5bae56a32a
not this line yet?
2020-12-07 01:40:26 -05:00
2a1b585bfe
Revert "Revert "Split ETB in to interface + implementation headers ( #2040 )""
...
This reverts commit 4f4bb957
2020-12-07 01:27:27 -05:00
bb3cb0ba22
Revert "Require redundant tps for ETB ( #2037 )"
...
This reverts commit 4f1085a8
2020-12-07 01:11:32 -05:00
4f4bb95770
Revert "Split ETB in to interface + implementation headers ( #2040 )"
...
This reverts commit d9a82c09
2020-12-07 01:11:19 -05:00
d9a82c09af
Split ETB in to interface + implementation headers ( #2040 )
...
* split etb interface
* mocks
* fix master while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:29:09 -05:00
4f1085a87a
Require redundant tps for ETB ( #2037 )
...
* mod sensor api
* require redundancy
* fix tests
* check that it fails
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:05:06 -05:00
efef2bfe4f
more ETB test coverage ( #2039 )
...
* test no pedal map
* test open loop
* open loop but not throttle
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:59:18 -05:00
67269aa637
maybe fix sensor init checks ( #2034 )
...
* enums
* don't collide
* auto_generated_enums
* check based on new enum val
* maybe this will make generate tool happy
* add a test
* fix test
* fix and add another test
* make clang happier
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:19:57 -05:00
b3d45b909f
Revert "switch rpm calculator to use timer class ( #2005 )"
...
This reverts most of a26ed3eb5a
2020-12-06 18:05:53 -05:00
a26ed3eb5a
switch rpm calculator to use timer class ( #2005 )
...
* add api
* rpm calculator
* fix fsio
* fix float
* remove wrong comment
* fix timer
* clang didn't like this
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 16:01:45 -05:00
c5e3657d45
don't duplicate sensor error logic ( #2032 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 15:00:30 -05:00
9ccda6bbe7
add isRedundant ( #2031 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 14:55:06 -05:00
29141055ab
one step back #2017
2020-12-06 08:50:10 -05:00
2d9be1077b
require TPS values to be different ( #2017 )
...
* require values to be different
* fix not
* oops
* missed another spot
* test negative cases too
* resets
* test no sensor case
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 00:41:49 -05:00
ffae0cd335
round rpm instead of truncating ( #2023 )
...
* round rpm instead of truncating
* efiround is expensive
* Revert "efiround is expensive"
This reverts commit e5690f89e1b1988aacf5ced1f024d576465a7cd6.
* round is better than rintf
* testing
* it works now?!
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 00:11:57 -05:00
e544e8150a
unit tests in clang ( #2012 )
...
* clang errors
* non-test-only
* debugging
* rules on mac
* makefile
* put back
* let's see if this way makes everybody happy
* no, it does nto
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-05 23:21:17 -05:00
8c5fe1bf23
unit tests in clang #2012
2020-12-05 00:22:10 -05:00
864bd7fa73
Dyno view proposal ( #1999 )
...
* DynoView creation
module implementation and unit_tests
* update acc algo
we only calcualte new acceleration value if speed has changed, not on every callback.
* added acceleration ts_channel
* fixed broken unit tests
* fixed accel sign
* review updates
* Update test_dynoview.cpp
fix unit_tests
* Update engine_controller.cpp
Fix .ram4 unused size
* Update test_dynoview.cpp
2020-12-04 20:28:48 -05:00
1a7b0196f9
docs
2020-12-04 16:10:58 -05:00
e138621202
all triggers should be documented way nicer #2001
2020-12-04 11:58:26 -05:00
f021c37cc1
DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT fix #2008
2020-12-03 23:12:30 -05:00
6fb745d29c
Launch Control refactoring ( #1992 )
...
* refactor
- called from periodicFastCallback
- removed defines
* Update rusefi.input
removed unused configurations.
added clutch inversion option
* Added new tests
fixed limiting only in case we have launch condition and rpm outside of window
* Update launch_control.cpp
Unintialized config update, now it is working fine with VSS and with clutch as well.
* small fixes
updated after review findings
* Fix breaking engine rev limiter
applyLaunchControlLimiting should not overwrite booleans to false!
* Delay timer in seconds
timer uses ms, so convert seconds to ms
2020-12-01 13:03:42 -05:00
f15efa7f15
dead engine config
2020-11-26 20:53:44 -05:00
a5ba9d54dc
fix etb unit test idle hardware ( #1991 )
...
* move check to etb
* give it a sensor to read
2020-11-26 19:21:42 -05:00
750070a496
fix etb wastegate percent output ( #1988 )
...
* wastegate etb should use percent
* percent_t
* fix test
2020-11-25 21:14:06 -05:00
492498f8d0
Boost tolerance ( #1986 )
...
* tolerate invalid closed loop config when in open loop mode
* fix test
2020-11-25 07:27:24 -05:00
90e5630e60
avoid float -> int64 conversion #1977
...
cherry picking...
2020-11-23 23:33:46 -05:00
55379463c0
remove ( #1985 )
2020-11-23 20:10:17 -05:00
747b3d2fa8
fix #1968 ( #1976 )
...
* tanf
* name
* comment, add test
2020-11-22 08:26:17 -05:00
fe93dfd8df
No latest gcov #1973
2020-11-19 21:57:18 -05:00
659b9c1973
No latest gcov #1973
2020-11-19 21:56:48 -05:00
9315b1e8de
No latest gcov #1973
2020-11-19 21:32:14 -05:00
7c793834ef
Launch control unit tests update ( #1972 )
...
* testable launch start
* extract base class
* add a test
* fix ts debug
* Launch control unit_tests
updated launch control for a better split
VSS mock for unit tests
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2020-11-19 21:14:38 -05:00
68c8d8c6a2
Starter is engaged on start-up in pull-up configuration #1969
...
usability & test improvement
2020-11-19 17:15:28 -05:00
ee51da64ad
Launch control testable ( #1967 )
...
* testable launch start
* extract base class
* add a test
* fix ts debug
2020-11-19 08:15:56 -05:00
f3b7a1d9da
Remove lockAnyContext, replace with CriticalSectionLocker ( #1938 )
...
* switch to CriticalSectionLocker
* that's just about all
* clean up last usage
* include hpp for sim
* need the cpp wrappers in the makefile too
* include dir
* include
2020-11-19 06:56:02 -05:00
47fbb92bff
Starter seems to be engaged forever fix #1965
2020-11-18 23:54:30 -05:00
7c2cb1d2ac
Starter seems to be engaged forever #1965
2020-11-18 23:06:44 -05:00
bec2e0b2e6
Starter seems to be engaged forever #1965
2020-11-18 22:56:05 -05:00
a9e0bffbbd
Starter seems to be engaged forever #1965
2020-11-18 22:47:40 -05:00
53f6f1e661
Starter seems to be engaged forever #1965
2020-11-18 22:42:41 -05:00
c52c6f45c9
Starter seems to be engaged forever #1965
2020-11-18 21:22:01 -05:00
7f688f7616
Starter seems to be engaged forever #1965
2020-11-18 20:53:03 -05:00
ee7e1880a2
Something something unit test ETB does not work #1966
2020-11-18 20:12:58 -05:00
e29911114a
Starter seems to be engaged forever #1965
2020-11-18 20:01:02 -05:00
35754d298a
Starter seems to be engaged forever #1965
2020-11-18 19:34:09 -05:00
5d3d85d644
put getTimeNowLowerNt in to mpu_util ( #1950 )
...
* put getTimeNowLowerNt in to mpu_util
* move GPTDEVICE to port_mpu_util
* and remove from efifeatures
2020-11-18 14:17:00 -05:00
5b0a178605
Fix crc again, for real this time ( #1948 )
...
* re enable
* changelog
* fix
* fix test
* put some tests back
2020-11-15 16:59:02 -05:00
e00a9b91c6
occasional tunerstudio CRC errors #1943
...
now with a bit of a unit test
2020-11-15 12:44:53 -05:00
43c5c7ff83
occasional tunerstudio CRC errors #1943
...
unit test progress
2020-11-15 12:36:07 -05:00
a42077bef8
occasional tunerstudio CRC errors #1943
...
now with a bit of a unit test
2020-11-15 12:27:47 -05:00
286fa10b15
occasional tunerstudio CRC errors #1943
...
getting ready for unit test
2020-11-15 11:55:26 -05:00
30a0082ed2
occasional tunerstudio CRC errors #1943
...
getting ready for unit test
2020-11-15 11:53:09 -05:00
0e3673e78c
remove idle thread; just call from periodicSlowCallback ( #1924 )
...
* remove thread
* remove ui
2020-11-11 21:47:19 -05:00
bb8650179c
consolidate EFI_UNIT_TEST and friends ( #1940 )
...
* restructure
* guard c++
* idle too
* status_loop.h
* consolidate definitions
* use 1/0 instead, check for existence
* missed a few
* dead define
* defs for bootloader
2020-11-11 20:34:39 -05:00
d992bab241
Move all DECLARE_ENGINE_PTR etc to one place ( #1937 )
...
* restructure
* guard c++
* idle too
* status_loop.h
2020-11-11 19:06:04 -05:00
02c4d630f6
compensate injector flow based on fuel pressure ( #1931 )
...
* injector compensation
* fix
* ui
* testability & comments
* hella testing
* debug channels
* enum value
* auto generated enums
* update comment
* oops too much
* update config fields
* handle failed pressure sensor
* build
* fix
* add some todos for the future
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-11-10 23:11:22 -05:00
111b017442
refactoring
2020-11-05 18:10:44 -05:00
cf3dc9c2c3
convert cranking defaults to mg ( #1921 )
...
* convert cranking defaults to mg
* fix tests
2020-11-03 14:12:26 -05:00
3e30865e6c
unused tach field ( #1918 )
2020-10-29 15:26:01 -04:00
09b41bb1bb
Everything in lambda! ( #1893 )
...
* lambda
* default configs, fix build
* config, gauge, UI
* more digits
* change menu text
* fix that while I'm here
* doesn't need extra word
* todo note
* tests
* last test
* missed a config
* update java
* store target lambda
* more java
* format
* hopefully enough java for CI to pass
2020-10-26 18:15:17 -04:00
a90792fa44
convert mass -> duration later in the pipeline ( #1906 )
...
* cranking duration to mass
* implement
* units
* patch types
* suppress warning
* fix output channels
* add note about how to set it
2020-10-26 07:23:13 -04:00
f37ed597c5
fix double deadtime ( #1904 )
...
* move global correction factor to fuel mass
* tests
* the fix
2020-10-25 00:12:05 -04:00
10c1ad7698
use fuel model ( #1901 )
...
* use fuel model
* spit'n'polish
2020-10-23 20:25:47 -04:00
06f92807cc
second PID config for wastegate ( #1889 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
* consume
* add cfg field
* ui maybe
* fix
* fix
* add wastegate config test
2020-10-19 08:04:27 -04:00
42bfad807b
Etb wastegate hookup ( #1888 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
2020-10-18 21:57:04 -04:00
44653da2e5
Etb function cfg: actually read config ( #1884 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-18 17:26:38 -04:00
bd7dcf1709
HW CI has failed 11 times since Oct 2 #1849
2020-10-16 13:54:12 -04:00
a8057cfc16
write SD header using new Writer class ( #1882 )
...
* write header
* hooray, free memory!
* fix test
* is there really this much free space...?
* no, there is not
2020-10-15 16:00:13 -04:00
2083b34cf9
simplify getTimeNowNt() ( #1876 )
...
* remove old impl
* add cpp wrapper to os_access
* clean up os_access
* remove touchTimeCounter
* new impl
* put comment about lock free impl
* include cpp wrappers for BL
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-10-15 08:57:13 -04:00
299a345c1c
etb function config 1 ( #1881 )
...
* this should all be safe...
* test fix
2020-10-14 22:02:09 -04:00
2a0205e3c4
switch to single precision constants ( #1880 )
...
* adjust builds
* fix test
2020-10-14 20:04:35 -04:00
605e2590f1
buffered writer - progress on #1463 ( #1875 )
...
* add buffered writer
* rename
2020-10-12 15:10:34 -04:00
07a905b1fe
revering functional part of
...
Etb function cfg, try again #1860
try again from #1831
2020-10-08 17:09:00 -04:00
1bce3aa4c0
Etb function cfg, try again ( #1860 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-08 14:12:03 -04:00
cb47cde068
switch from float to expected<float> ( #1862 )
2020-10-06 22:33:00 -04:00
8cff16e797
FSIO refactoring ( #1861 )
...
* better fsio tests
* condense operators
* minor parser cleanup too
* comments, too!
2020-10-06 21:54:49 -04:00
5925a5f4bd
const ref-ify trigger ( #1856 )
...
* const ref-ify
* tests
2020-10-05 14:22:59 -04:00
c885db32f0
use expected for event queue next event ( #1859 )
...
* use expected for event queue next event
* minor cleanup
* tests
2020-10-05 13:53:34 -04:00
367436454d
HW CI has failed 11 times since Oct 2 #1849
...
Revert "ETB function config (#1831 )"
This reverts commit af59c45a
2020-10-03 22:00:00 -04:00
af59c45adb
ETB function config ( #1831 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-02 20:51:02 -04:00
f1c04efefa
replace ETB index with function enum ( #1807 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
2020-09-28 16:33:07 -04:00
2d771018e8
unit test for start/stop hardware and pin repository #1811
2020-09-21 12:29:01 -04:00
eef4e800b5
nicer parameter name
2020-09-21 08:57:56 -04:00
77f15256b6
unit test for start/stop hardware and pin repository #1811
2020-09-21 08:57:37 -04:00
f8f3e74d99
unit test for start/stop hardware and pin repository #1811
2020-09-21 05:02:35 -04:00
c1699d91d0
fix closed loop fuel ( #1797 )
...
* fix
* add a test
* signature
2020-09-19 03:44:01 -04:00
1fc55da3ca
two throttles one thread ( #1806 )
...
* two throttles one thread
* look at all this RAM!
2020-09-18 13:47:49 -04:00
97cb9f45bd
logging simplification: switch bare functions to member functions: try the second ( #1794 )
...
* first pass
* first pass
* const means we don't have to check!
* static
* test fixup
* fix sniffer
2020-09-13 11:49:25 +03:00
256a4a2637
Revert "logging simplification: switch bare functions to member functions ( #1788 )"
...
This reverts commit d941bdc5
2020-09-12 04:36:24 -04:00
d941bdc502
logging simplification: switch bare functions to member functions ( #1788 )
...
* first pass
* first pass
* const means we don't have to check!
* static
* test fixup
2020-09-12 03:08:11 +03:00
337106cd24
DebounceButton A/C switch ( #1782 )
...
* change acSwitch name, add mode
* fix
* remove some adc stuff
* remove some adc stuff
* semicolon stupid
* left behind
* add readpinstate
* wrong var name
* add functions back
* fix name
* bool, not void, plus fix name
* move
* not sure what I broke
* try setMockValue
* namespace
* whoops missed one
* switch values because adc was set up for pullup
* try 5
* comment for now
* comment for now
* uncomment tests, add function to mock, add mock to efiReadPin
* fixes
* for F's sake
* if
* add defy
* pass params
* use ASSERT_TRUE/FALSE
* advance time
* remove ifdef from readPin
* try moving if
* move to separate func
* move extern
* move include
* try engine_test_helper
* am confuse
* move func to else
* include hal
* add efi prod check
* remove include
* try extern
* move include
* semicolon stupid
* move extern again
* include
* move mockPinStates
* size
* add if
* add comment
* clean on instantiation
2020-09-10 22:16:20 -04:00
eebded8caa
scale tables using type system ( #1776 )
...
* store scale in the type
* efi ratio
* boost control scaling
* fix boost tests
2020-09-10 18:44:10 -04:00
6d1acb40f8
Selectable AFR axis override ( #1771 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
* impl
* unhide option
* fix
* tests
2020-09-08 17:15:18 -04:00
ef0b2f7be0
Selectable VE axis override ( #1769 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
2020-09-07 10:15:42 -04:00
6e7d72170f
Move ve logic ( #1762 )
...
* move ve
* fix build
* fix rendering
* duh
* cleaning
* correct scaling
* put some back
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-09-06 19:06:32 -04:00
95798a5246
fix broken master, inject engine ptr to rpmcalculator ( #1759 )
...
* fix
* oops
2020-09-05 18:49:42 -04:00
675cce3854
less hacky testing implementation
2020-09-03 22:52:29 -04:00
ca21d5b4c2
refactoring
2020-09-03 19:29:15 -04:00
5fec6d0c04
move lambda in to sensor model ( #1736 )
...
* lambda sens
* fix init
* fix
* a test for good measure
* he's climbin in your windows, snatchin you ram up
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-09-01 16:22:31 -04:00
efdaef81af
this does not go as planned :(
2020-08-31 08:02:29 -04:00
24cf51e883
this does not go as planned :(
2020-08-31 07:54:45 -04:00
00572b3c30
dead
2020-08-29 09:39:52 -04:00
540eef5e0d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
3a2670d5de
VVT support for VAG trigger #883
2020-08-24 02:07:58 -04:00
7867e83e43
VVT support for VAG trigger #883
2020-08-24 02:01:50 -04:00
95bd50da94
VVT support for VAG trigger #883
2020-08-24 01:21:42 -04:00
adf899e338
Allow negative VVT position feedback #1713
2020-08-23 11:49:46 -04:00
5929164fb3
Add injector model class ( #1687 )
...
* stub injector model
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-17 05:22:25 -04:00
b961944790
tests
2020-08-10 22:11:25 -07:00
1f64754b57
consume
2020-08-10 21:41:03 -07:00
33d31d16f7
trigger and VSS hw integrated testing #1668
2020-08-08 12:03:24 -04:00
526e02af53
TS SD integration #1653
2020-08-06 22:05:26 -04:00
b4862138ac
testHysteresisSelf
2020-08-04 17:59:31 -04:00
0183f0f24a
these were testing nothing
2020-08-03 12:22:00 -07:00
9977668480
The Big Refactoring of 2019: folder structure #723
2020-08-02 20:55:27 -04:00
c3f26c93b5
The Big Refactoring of 2019: folder structure #723
2020-08-02 20:52:31 -04:00
8f4aecf7ca
The Big Refactoring of 2019: folder structure #723
2020-08-02 20:46:40 -04:00
795da6ea43
don't rely on periodicFastCallback
2020-07-31 22:09:23 -07:00
8b97b37a24
this test should have never called setTestBug299
2020-07-31 19:08:18 -07:00
c690eec898
relax a little
2020-07-31 19:02:48 -07:00
978fa20916
Merge remote-tracking branch 'upstream/master' into remove-plain-maf
2020-07-31 14:56:29 -07:00
4527b7694a
expose the problem
2020-07-31 14:41:29 -07:00
28225a078b
mock airmass
2020-07-31 12:44:22 -07:00
197fba8c64
remove getBaseTableFuel test
2020-07-31 12:43:56 -07:00
132ee12974
cleanup
2020-07-30 21:20:10 -07:00
196337a8de
NA6 progress
2020-07-29 22:48:41 -04:00
2253fe6eef
test cleanup
2020-07-28 14:42:02 -07:00
8b305acf68
fix tests
2020-07-28 14:27:34 -07:00
d57465a6d3
eth adjustments
2020-07-28 14:18:50 -07:00
53b864bdda
fixing
2020-07-28 12:11:56 -07:00
2289c465b5
fixes
2020-07-28 11:56:39 -07:00
50fc127555
put mock in enginetesthelper
2020-07-26 20:39:42 -07:00
42c6a641ad
add mock
2020-07-26 20:35:36 -07:00
7e86dbc249
Weird VAG: DC motor idle valve not ETB #1637
...
ok, that's the current reality
2020-07-26 12:30:50 -04:00
3857607fc2
Weird VAG: DC motor idle valve not ETB
...
#1637
Seattle we might have a problem!
2020-07-26 12:03:36 -04:00
d5739815b4
Weird VAG: DC motor idle valve not ETB #1637
2020-07-26 10:54:51 -04:00
ed14758c63
mocks
2020-07-26 03:18:26 -07:00
2b212fbaab
add tests for VW mode
2020-07-26 03:11:56 -07:00
66bd14ebad
tests & cleanup
2020-07-25 02:00:24 -07:00
34df0862b6
Merge pull request #1634 from mck1117/refactor-inj
...
move injector logic in to its own file
2020-07-24 22:47:39 -04:00
626f55a08a
refacto
2020-07-24 18:26:24 -07:00
cad0d47443
improve test
2020-07-23 01:24:02 -07:00
5e7ddc9f24
start refactor
2020-07-22 13:11:07 -07:00
c6d2a856dd
Merge pull request #1606 from mck1117/reset-overlap
...
reset overlap counter on fuel reschedule
2020-07-20 23:51:34 -04:00
27f346b0ff
make private
2020-07-20 18:50:48 -07:00
a6139c5c70
Merge remote-tracking branch 'upstream/master' into export-all-logicdata
2020-07-20 18:48:54 -07:00
b66b8f8542
test with fix
2020-07-20 18:47:08 -07:00
ea49647c1d
compensate for bug
2020-07-20 13:21:15 -07:00
66b9c3ebea
auto export all logicdata
2020-07-20 13:12:21 -07:00
rusefi
Matthew Kennedy
rusefillc
shadowm60
David Holdeman
Matthew Kennedy
rusefillc