Commit Graph

2899 Commits

Author SHA1 Message Date
rusefillc f6c5ac8ebb fix vBatt false-detection 2021-12-01 11:22:13 -05:00
Matthew Kennedy 565a94ea34 Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630)
* no working copy

* oops
2021-11-29 16:44:45 -05:00
rusefillc 3cf4be3aa9 why so many channels are hidden in debug ? #3614 2021-11-29 14:11:19 -05:00
rusefillc 9cfd30a2b4 why so many channels are hidden in debug ? #3614 2021-11-29 11:54:55 -05:00
rusefillc 194cd8ea11 why so many channels are hidden in debug ? #3614 2021-11-29 10:44:41 -05:00
rusefillc ffb35aeff7 why so many channels are hidden in debug ? #3614 2021-11-29 10:16:45 -05:00
rusefillc c64fb3f595 why so many channels are hidden in debug ? #3614 2021-11-29 01:02:40 -05:00
Matthew Kennedy aed334f9ac better VSS configuration (#3542)
* vss uses real values

* some defaults

* test and correct math

* km, not miles!

* comment

* tooltip

* that macro went away

* 100hz and default settings gives 9kph

* changelog

* order of operations safety

* make the test like the pwm test

* housekeeping

* this is why we need sensor automation

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-27 08:49:07 -05:00
rusefillc d791ef5581 skipspark script kills ECU fix #3611 2021-11-25 22:40:19 -05:00
GitHub build-firmware Action ca5ba2f8e8 Auto-generated configs and docs 2021-11-26 02:06:11 +00:00
Andrey e3920a3159 reliable 32/2 trigger shape 2021-11-25 20:45:58 -05:00
Matthew Kennedy dad52dd75a wall fuel tweaks (#3617) 2021-11-25 18:45:44 -05:00
Matthew Kennedy 6e4759389a AC is EngineModule (#3604)
* AC is engine module

* missed a spot with main relay while we're at it

* TS
2021-11-25 07:59:31 -05:00
Andrey 374b7223cd isCylinderCleanupEnabled would be nice by default 2021-11-24 23:32:55 -05:00
Andrey 695557f709 MAP phase sensing #3544 2021-11-24 22:36:36 -05:00
Andrey a42a52bb2e MAP phase sensing #3544 2021-11-24 22:35:56 -05:00
Matthew Kennedy 5752b4ba92 bye (#3609) 2021-11-24 22:03:17 -05:00
rusefillc 28c9d7555b live data for wastegate #3588 2021-11-24 12:59:57 -05:00
Matthew Kennedy 5274cffff3 main relay doesn't use fsio (#3580)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag

* main relay

* plumbing

* dead fsio stuff

* test it

* by 100%, we mean 99.98%
2021-11-24 07:47:51 -05:00
rusefillc 09ed871dad well Lua wants to be BIG 2021-11-23 16:40:04 -05:00
GitHub build-firmware Action 191b76f4dd Auto-generated configs and docs 2021-11-22 23:12:52 +00:00
Matthew Kennedy 9bd8a19564 oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
rusefillc 5d55b8538f unusedLogFormat 2021-11-22 13:37:06 -05:00
Matthew Kennedy e2a4504728 rpm calculator refactoring, gm 24x test (#3585)
* data

* stub test

* use getTimeSinceSyncPoint

* s

* s

* no

* test

* stray ;

* those were 1/10 what they were supposed to be

* actually check something

* dead log line?
2021-11-20 14:59:02 +03:00
Scott Smith 04fa1fd410 Fix potential buffer overrun in cyclic_buffer. (#3583)
This exposed a buffer overrun, so double the size of the buffer (to account for 720 degree engine
cycle vs 360 degree crank events).

Also use proper numeric limits when computing min/max.
Finally, add a lock around the call to cyclic_buffer that actually caused the contention.
2021-11-20 03:01:11 -05:00
Matthew Kennedy 569415930c detect more overflows with asan (#3582)
* overflow detector

* type list dynamic allocate

* fix the buffer length

* comment

* pr fb

* sanitize sim

* fix sim sanitizer bug

* didn't mean to turn off optimization for sim

* asan can do that, if you turn it on!

* cleaning
2021-11-20 01:38:39 -05:00
Scott Smith 07d30285fc Basic framework for high pressure fuel pump control (#3476)
* Basic framework for high pressure fuel pump control

* Many changes

Move calculations to fast callback
Move main object into Engine
Respond to pin changes without requiring a reboot

* Use EngineModule for HpfpController
Schedule pin off after executing pin on so we are sure it ends, even if the motor stops.
Test scheduling.
Less RAM use by only having one event and reordering fields.

* Make scheduling test actually useful - need non-0 activation angle.

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-11-19 23:06:51 -05:00
Matthew Kennedy e7956a53f6 fuel pump doesn't use fsio (#3576)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag
2021-11-19 22:23:12 -05:00
rusefillc c441d7dd89 debug mode for skipped count for 4 cylinders #3570 2021-11-19 07:02:21 -05:00
Matthew Kennedy a0a1b5e6a0 delimeter is not comma (#3533)
* delimeter is not comma

* do it in config txt

* use txt

* s

* string

* compat

* also, spelling is hard

* use new name

* use new name

* generate enough for happy console

* use an even less common character

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-19 12:01:45 +03:00
Scott Smith aba4e5167e Separate out scheduleOrQueue into it's own standalone scheduler. (#3573)
It's a large enough entity that it shouldn't be buried in ignition logic.
2021-11-18 14:27:21 -05:00
rusefillc 82ffcad01f proportional spark cut #3427 2021-11-17 23:35:26 -05:00
Scott Smith b3e0b28c75 Make the module API more concise. (#3571)
engineModules.get<FOO>(). becomes modules<FOO>()->

I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
Scott Smith 659cc68be1 Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith f9f13f0bad Create a base class EngineModule for that contains various useful callbacks. (#3548)
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith 80091498a6 Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith 19f7fa8f89 Make engine* and friends be const pointers in production. (#3564)
This allows the compiler to see through the pointer and make accesses faster.
It saves 1336 bytes of text.
2021-11-17 03:53:17 -05:00
Scott Smith dac2ae9b1d Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
rusefillc 774d96493e spelling 2021-11-16 16:46:54 -05:00
rusefillc 6fdb98e84f helping launch enter simulator 2021-11-16 16:45:14 -05:00
rusefillc ed1d24dbbe helping launch enter simulator 2021-11-16 16:31:35 -05:00
Andrey 1be12392c0 proportional spark cut #3427 2021-11-16 13:23:08 -05:00
Matthew Kennedy 7296593448 remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Scott Smith 2cfc4af998 Start the process of using a global engine ptr for unit tests. (#3551)
* Start the process of using a global engine ptr for unit tests.

Passing around the engine, config, and persistent state wasn't buying anything.  Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables.  Add a dummy check in
case some test tries to set them manually.

* Fix OSX build

* Adapt PR to recently added code.
2021-11-16 00:23:14 -05:00
Andrey b545743f7d Not all launch control options are used #3554 2021-11-15 21:13:01 -05:00
Andrey 349d224b5f technical debt: enableOverdwellProtection #3553
only documentation
2021-11-15 20:32:25 -05:00
Andrey 7b790d36f6 random refactoring: trigger central encapsulation 2021-11-15 20:22:05 -05:00
Andrey 4bc9343d0b refactoring launch 2021-11-15 20:09:03 -05:00
Andrey 837cdf2cfb refactoring launch 2021-11-15 19:55:04 -05:00
Andrey 0a956d96b4 refactoring launch 2021-11-15 19:55:04 -05:00
Andrey c8b733ea6e refactoring launch 2021-11-15 19:34:42 -05:00
Andrey c41dccb5ff refactoring launch 2021-11-15 19:24:00 -05:00
Andrey bc3befd0ac refactoring launch 2021-11-15 18:57:12 -05:00
Andrey bafd5e0e17 refactoring launch 2021-11-15 14:40:35 -05:00
Matthew Kennedy bd04dc8352 less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
GitHub build-firmware Action a29aa50cb0 Auto-generated configs and docs 2021-11-15 03:03:29 +00:00
rusefillc 8448b04078 MAP phase sensing #3544 2021-11-14 21:58:01 -05:00
rusefi 291f815b2d Something something Automatic Compression Release #3442 2021-11-14 15:04:10 -05:00
rusefi df4f122c0b Epic: Remove FSIO #2928 2021-11-14 14:14:43 -05:00
rusefillc 1a3fb4a0db Epic: Remove FSIO #2928 2021-11-14 11:04:51 -05:00
rusefillc 3327b0d4e7 Epic: Remove FSIO #2928 2021-11-14 10:57:19 -05:00
rusefillc 5f1aadf638 Epic: Remove FSIO #2928 2021-11-14 10:39:47 -05:00
rusefillc 0fc4096213 Epic: Remove FSIO #2928 2021-11-14 08:33:19 -05:00
rusefillc eab7f670a2 Epic: Remove FSIO #2928 2021-11-14 07:24:50 -05:00
rusefillc 29670184e2 script settings need names! 2021-11-13 22:47:46 -05:00
GitHub build-firmware Action 2762268d58 Auto-generated configs and docs 2021-11-14 03:02:10 +00:00
Matthew Kennedy 8edc91f657 mercedes two lobe trigger testing (#3543)
* mercedes

* config

* break;

* I did the gap ratio math wrong

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
rusefillc 4803a6def5 Something something Automatic Compression Release #3442 2021-11-13 04:24:53 -05:00
GitHub build-firmware Action 015a07576d Auto-generated configs and docs 2021-11-13 03:01:55 +00:00
rusefillc d96755ec15 Proteus Harley 2021-11-12 21:56:07 -05:00
GitHub build-firmware Action cf7231a8a0 Auto-generated configs and docs 2021-11-12 01:54:56 +00:00
Andrey 37adc7e713 Bench Test IAC Valve fails #3534
that's not even funny
2021-11-11 20:39:01 -05:00
Andrey 06f7098cae Bench Test IAC Valve fails #3534 2021-11-11 20:31:46 -05:00
Andrey 5136d0b994 Bench Test IAC Valve fails #3534 2021-11-11 20:28:01 -05:00
Andrey 1aca049c47 Something something Automatic Compression Release #3442 2021-11-11 20:16:46 -05:00
Andrey 9aa98cd523 refactoring: less hacky implementation 2021-11-11 20:16:46 -05:00
rusefillc 371f0ca72c Idle valve outputs not available in TS #3523 2021-11-10 20:40:42 -05:00
rusefi 69a53c565f pid demo progress 2021-11-08 17:31:33 -05:00
Andrey 757cd10c1f docs 2021-11-08 12:23:00 -05:00
rusefillc fd28e82f73 refactoring - magic constant bad 2021-11-07 00:03:16 -04:00
GitHub build-firmware Action 2ee8ecb287 Auto-generated configs and docs 2021-11-07 03:59:47 +00:00
rusefillc eb4ef563dd a bit of dead code 2021-11-06 23:39:56 -04:00
rusefillc 3f278e989b a bit of dead code 2021-11-06 21:19:56 -04:00
GitHub build-firmware Action 4dca92f21e Auto-generated configs and docs 2021-11-07 01:05:29 +00:00
rusefillc 31347d66be a bit of dead code 2021-11-06 21:01:01 -04:00
Andrey e3355ab2d3 Remove Miata MX5 NB1 trigger #3488 2021-11-06 20:24:41 -04:00
GitHub build-firmware Action cab19aeba0 Auto-generated configs and docs 2021-11-06 23:15:42 +00:00
rusefillc faa8abf673 a bit of dead code 2021-11-06 18:43:19 -04:00
GitHub build-firmware Action beb2083509 Auto-generated configs and docs 2021-11-06 22:37:34 +00:00
rusefillc 4045893437 PROTEUS_LUA_DEMO 2021-11-06 18:24:59 -04:00
GitHub build-firmware Action b117f260c1 Auto-generated configs and docs 2021-11-06 03:28:22 +00:00
Scott Smith e350b0b6b4 Configuration for HPFP control algorithm. (#3475) 2021-11-05 23:15:35 -04:00
Scott Smith e8633a8cb4 Move fuel density to a header file so it can be accessed by other components. (#3474) 2021-11-05 22:29:56 -04:00
Scott Smith 61fd669add Convert existing tables to use the simpler 3d table definition style in rusefi_config.txt (#3473)
This fixes #3465.
2021-11-05 21:55:33 -04:00
Scott Smith fcac26c032 Allow scaled_channel to have both multiplier and divisor (#3468)
Disallow scaled_channel for float.  I can't think of a reason to allow it, and it gets in the way
of rounding.

Add separate template param to setTable; let the compiler sort out whether assignment can happen
between TElement and VElement without forcing them to be the same at function call time.
2021-11-05 17:34:22 -04:00
GitHub build-firmware Action f3e6b44f89 Auto-generated configs and docs 2021-11-05 19:42:05 +00:00
Matthew Kennedy b41dbe2ed1 nissan MR18DE VVT cam pattern (#3466)
* refactoring nissan trigger

* comments

* plumbing

* b

* enums

* image

* image

* implement decoder

* reshuffle

* don't case unused

* dead trigger enums
2021-11-05 15:33:22 -04:00
rusefillc 2bd0633ecb minor todo 2021-11-05 10:01:58 -04:00
GitHub build-firmware Action 6f2744a5c9 Auto-generated configs and docs 2021-11-05 11:19:56 +00:00
Matthew Kennedy 6b85313b04 nissan 4yl crank pattern (#3462)
* refactoring nissan trigger

* comments

* plumbing

* b
2021-11-05 07:15:03 -04:00
rusefillc 31a2218339 more curves! also names for curves 2021-11-04 23:59:04 -04:00
rusefillc b9861159a1 more curves! also names for curves 2021-11-04 23:19:44 -04:00
rusefi 365a1e13a8 turboSpeedSensorMultiplier 2021-11-04 19:35:58 -04:00
racer-coder 55ac8d56b8 Fix the types in various fuel functions that actually refer to grams, not ms. (#3458) 2021-11-04 11:50:19 -04:00
rusefillc 88d7046382 most dead miata config 2021-11-04 09:56:05 -04:00
Matthew Kennedy cadaf2a801 extract engine phase function (#3456)
* extract getCurrentEnginePhase

* inject engine ref

* never invalid RPM, use 0 instead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00
Matthew Kennedy a2766e5d9b support autoscale on table axes (#3452)
* scale map Y axis

* allow different row/col types

* scaled channel detector

* interpolation

* looks like this actually works

* tests, no manual scaling

* comment
2021-11-03 19:53:26 -04:00
Matthew Kennedy 4717210859 autoscale fields in generated structs (#3444)
* add to grammar

* parser

* parser

* example consumer

* build config tool

* commit the right jar
2021-11-02 18:59:19 -04:00
rusefi 356a73e7a5 docs 2021-11-02 17:11:44 -04:00
Matthew Kennedy 1cee83a56c Knock retard (#3396)
* output gauge

* knock controller

* don't need that

* inject engine ref

* test knock

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-01 23:33:59 -04:00
rusefillc de0736492d better VVT default? 2021-10-31 15:25:43 -04:00
rusefillc 178f6fe9e8 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
fail faster!
2021-10-31 12:09:11 -04:00
rusefillc 960b68424b live data stuff goes up 2021-10-31 12:07:44 -04:00
GitHub build-firmware Action b632832407 Auto-generated configs and docs 2021-10-31 02:31:01 +00:00
Andrey fd34b2adee Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:24:43 -04:00
Andrey ef413188ee Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:21:36 -04:00
GitHub build-firmware Action 1a13dd7463 Auto-generated configs and docs 2021-10-31 02:08:31 +00:00
Andrey ac64f215f3 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:03:19 -04:00
Andrey f01c6fa6ae Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 21:45:52 -04:00
Andrey 12dfc7e869 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 21:45:37 -04:00
rusefillc a2f1cd2467 Override trigger gaps feature #2734 2021-10-30 10:45:32 -04:00
Andrey 14aac56c41 warning(CUSTOM_PID_DTERM, "PID: unexpected dTime") 2021-10-29 18:31:43 -04:00
rusefillc 558c639f82 Honda K & default VVT pid 2021-10-29 12:16:19 -04:00
rusefi 2d99e7b4b5 Honda K cam wheels #3405 2021-10-28 15:57:23 -04:00
Andrey 346e617d6a https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 13:49:44 -04:00
GitHub build-firmware Action 1e8feb2d1f Auto-generated configs and docs 2021-10-28 16:45:50 +00:00
Andrey 695ff0d391 https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 12:29:56 -04:00
GitHub build-firmware Action 642403db21 Auto-generated configs and docs 2021-10-28 16:17:08 +00:00
Andrey 3bf9a982d9 https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 12:12:45 -04:00
Andrey 5527f77589 Honda K cam wheels #3405 2021-10-28 10:36:41 -04:00
rusefi 032d6108ba secondary MRE 2021-10-27 19:54:45 -04:00
Andrey f526383aff UNUSED 2021-10-26 21:24:16 -04:00
GitHub build-firmware Action c53fc6823c Auto-generated configs and docs 2021-10-27 01:17:33 +00:00
Andrey 12ee912854 MRE_SECONDARY_CAN 2021-10-26 21:05:38 -04:00
rusefillc 996a39ba6e generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 11:05:45 -04:00
rusefillc e7084a78cb generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 10:59:24 -04:00
rusefillc 0301abaca3 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 10:57:02 -04:00
rusefi 1c0919d2a0 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 20:06:57 -04:00
Andrey 63472eb4d4 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 19:19:16 -04:00
Andrey 98fe894ce1 Honda K cam wheels #3405 2021-10-24 17:12:19 -04:00
Andrey 8431db7d34 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 17:06:59 -04:00
Andrey a67a4ced0d docs 2021-10-24 17:05:37 -04:00
GitHub build-firmware Action 27e6c5d682 Auto-generated configs and docs 2021-10-24 19:28:08 +00:00
rusefillc baca6a2289 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:18:23 -04:00
rusefillc bb16d4e081 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:17:37 -04:00
rusefillc 4d2796a82b generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:08:21 -04:00
rusefillc 9741b037f5 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:58:04 -04:00
GitHub build-firmware Action ad366764f1 Auto-generated configs and docs 2021-10-24 17:18:25 +00:00
rusefillc 23012085c9 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:10:38 -04:00
rusefillc ec609264f3 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:01:40 -04:00