Andrey
998652ac76
sensor_chart into unit tests
2022-11-06 11:28:25 -05:00
Andrey
a5136a0eae
trigger refactoring: instance RPM #4740
2022-11-06 11:05:57 -05:00
rusefillc
36d5b1fbb6
minor trigger refactoring
2022-11-06 00:59:29 -04:00
Matthew Kennedy
f4f5f69ee6
duplicate log field names ( #4730 )
...
* remove duplicate target lambda/afr
* names on fuel computer
* remove more copies
* sensor.java
* everybody loves hard dependencies on generated fields
* target afr gauge fix
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
Matthew Kennedy
1269428044
remove idle timing deadzone ( #4731 )
...
* remove idle timing deadzone
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
Andrey
ccca90cb55
Nissan defaults
2022-11-02 12:05:51 -04:00
rusefi
93f9e81e9e
huh, we can pole larger method here
2022-10-26 12:08:27 -04:00
rusefillc
a573b604d7
so much weird
2022-10-24 23:02:39 -04:00
Matthew Kennedy
24650f6460
implement "ford mode" injector correction ( #4686 )
...
* implement "ford mode"
* missed the enum value
2022-10-20 22:25:39 -04:00
Matthew Kennedy
f760ae11c1
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
GitHub build-unit-tests Action
7d5059b8ea
Trigger wheel definitions
2022-10-16 16:21:57 +00:00
GitHub build-unit-tests Action
8cf4eaa010
Trigger wheel definitions
2022-10-16 14:42:22 +00:00
rusefillc
d13a851c97
triggerImage: todo: support symmetrical crank
2022-10-16 10:33:38 -04:00
GitHub build-unit-tests Action
ebfedbc5da
Trigger wheel definitions
2022-10-16 14:31:28 +00:00
rusefillc
5fb9f7c2df
triggerImage: todo: support symmetrical crank
2022-10-16 02:59:57 -04:00
GitHub build-unit-tests Action
d2b87846fd
Trigger wheel definitions
2022-10-16 06:57:03 +00:00
rusefillc
d91211106c
triggerImage: todo: support symmetrical crank
2022-10-16 02:44:57 -04:00
Matthew Kennedy
1ae642e7a7
build tweaks for size ( #4661 )
...
* don't align on non-cached mcu
* lua decimal point
* no snprintf
* sort sections by alignment
* unit tests
2022-10-13 20:30:30 -04:00
GitHub build-unit-tests Action
e290f9296a
Trigger wheel definitions
2022-10-10 01:31:12 +00:00
Matthew Kennedy
aa881efe89
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
GitHub build-unit-tests Action
630347c5e7
Trigger wheel definitions
2022-10-06 02:10:48 +00:00
Matthew Kennedy
d6647025cc
2jz test ( #4638 )
2022-10-05 20:48:28 -04:00
Andrey
83afa58baf
Mark is asking for VIN number field #3967
2022-10-04 21:12:51 -04:00
Matthew Kennedy
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy
ec5d48fb5b
remove 898 ( #4634 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
Matthew Kennedy
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
b089825a4a
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
GitHub build-unit-tests Action
443ffbad90
Trigger wheel definitions
2022-09-25 13:23:24 +00:00
Matthew Kennedy
ae6c44634b
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
Matthew Kennedy
b45f84fe20
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
Andrey
612d52645a
Honda K cam wheels #3405
2022-09-25 00:26:42 -04:00
Andrey
9d27780974
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
Andrey
111220d38c
more inclusive configuration name
2022-09-24 23:49:41 -04:00
Andrey
cff779dd78
K progress
2022-09-24 23:18:57 -04:00
Andrey
782f4f32b8
progress
2022-09-24 23:07:55 -04:00
Andrey
a38d87b0e0
fancy default and reusing constant
2022-09-24 23:01:42 -04:00
Andrey
89f0dad5be
renaming stuff
2022-09-24 22:55:54 -04:00
Andrey
93e64a61a6
fancy
2022-09-24 22:54:58 -04:00
Andrey
33be12541b
K
2022-09-24 15:37:51 -04:00
Andrey
0eef498b3e
refactoring: extract constant
2022-09-24 15:33:01 -04:00
rusefillc
cab0177df0
insist on setBoardConfigOverrides fix #4614 ( #4615 )
...
* insist on setBoardConfigOverrides fix #4614
* insist on setBoardConfigOverrides fix #4614
* insist on setBoardConfigOverrides fix #4614
* insist on setBoardConfigOverrides fix #4614
* insist on setBoardConfigOverrides fix #4614
2022-09-24 07:35:19 -04:00
Matthew Kennedy
7139ddcda2
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
GitHub build-unit-tests Action
b656256a52
Trigger wheel definitions
2022-09-24 00:25:12 +00:00
rusefillc
c4699efe91
honda K enum rename
2022-09-23 20:13:14 -04:00
rusefillc
2f18168d47
K20
2022-09-23 20:13:14 -04:00
rusefillc
ed72758a5d
K20
2022-09-23 18:25:24 -04:00
Matthew Kennedy
dfe1b47b4d
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy
af7e4f6fe5
two modes trigger scheduler ( #4598 )
...
* two modes trigger scheduler
* asOld
* hpfp
2022-09-20 05:28:23 -04:00
rusefillc
60e703e079
B6
2022-09-17 23:49:24 -04:00
Andrey
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
6b0941b8ed
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
Andrey
954ddacd96
GM
2022-09-14 00:03:38 -04:00
Andrey
8ce57d5599
code formatting
2022-09-13 23:44:38 -04:00
Andrey G
55c1f53c75
dead code, reduce typedefs ( #4566 )
...
* Do lightweight checks first
* Dead getTimeIgnitionSeconds()
Dead since 81fffe87b7
* Get rid of efitime_t.
Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.
* Fix unit tests
* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G
91d4844e38
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
rusefillc
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
Andrey
cbb42b68d1
E38
2022-09-09 14:04:22 -04:00
Andrey
2199bfd7f7
E38
2022-09-09 01:15:55 -04:00
Matthew Kennedy
72299bd1ba
only report vvt position if we have full sync ( #4547 )
...
* only report vvt position if we have full sync
* comments
* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
Andrey
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
Andrey
7eb453bc54
os_access.h dead?
2022-09-07 16:00:13 -04:00
Andrey
07d895dfeb
B6
2022-09-06 15:12:43 -04:00
Matthew Kennedy
b305308ef6
add hysteresis to limp rpm, boost, injector duty ( #4541 )
...
* add hysteresis
* changelog
2022-09-05 20:56:32 -04:00
Andrey
4d65067345
wow Leiderman-Khlystov
2022-09-05 20:23:40 -04:00
Andrey
4c9df01b64
wow Leiderman-Khlystov
2022-09-05 20:02:33 -04:00
Andrey
4934d76d88
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
Andrey
b756456450
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:00:24 -04:00
Andrey
268a5c7964
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:44:06 -04:00
Andrey
c1b218b772
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
Andrey
feb386a54b
refactoring: moving field
2022-09-05 01:15:45 -04:00
Andrey
796e421857
wow Leiderman-Khlystov
2022-09-04 18:29:13 -04:00
rusefi
fc46ec182c
wow Leiderman-Khlystov
2022-09-04 15:58:46 -04:00
rusefi
51ee116fea
B6
2022-09-04 11:47:57 -04:00
rusefi
5c88f4c1f0
B6
2022-09-04 11:29:18 -04:00
Matthew Kennedy
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
Andrey
d329f8ae10
tear down Engine god object #4511
...
just trying different things
2022-09-03 07:44:24 -04:00
rusefillc
25f4ebbc01
moving state into specific class ( #4520 )
...
* moving state into specific class
* moving state into specific class
2022-09-02 14:38:03 -04:00
Andrey
9d8afea152
a bit of dead code
2022-09-01 11:47:56 -04:00
Andrey
b89217b596
reducing confusion between library header and rusefi main repo header
2022-09-01 11:35:35 -04:00
Andrey
7e340cceb3
refactoring: reducing outputChannels copy
2022-09-01 10:58:16 -04:00
Andrey
da66fa055c
refactoring: enum name clean-up
2022-09-01 00:23:33 -04:00
Andrey
fef406a5a6
english do you speak it
2022-08-31 22:56:38 -04:00
GitHub build-unit-tests Action
61769e954f
Trigger wheel definitions
2022-09-01 02:22:06 +00:00
Andrey
8500f4c313
B6 progress
2022-08-30 05:20:56 -04:00
Andrey
4e45046673
B6 progress
2022-08-30 04:38:20 -04:00
Andrey
027ed7742e
B6 progress
2022-08-30 04:07:48 -04:00
Matthew Kennedy
ee97e2a7d0
knock retard limit table ( #4498 )
...
* add max retard table
* ui
* s
* better naming
* s
* test can use base class
2022-08-30 01:57:37 -04:00
Matthew Kennedy
cbe70f8dec
idle always uses instant rpm ( #4499 )
...
* idle always uses instant rpm
* configs
* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy
553b549b95
idle coasting table is RPM, not clt ( #4487 )
...
* idle coasting table is RPM, not clt
* default
* autoscale
* changelog
2022-08-29 08:15:04 -04:00
GitHub build-unit-tests Action
23332db8f6
Trigger wheel definitions
2022-08-29 02:52:44 +00:00
GitHub build-unit-tests Action
3024a61ab5
Trigger wheel definitions
2022-08-29 02:23:56 +00:00
Matthew Kennedy
5a4e8b314a
B6 progress
2022-08-28 12:33:32 -04:00
Matthew Kennedy
b662e59707
remove some uses of EFI_ERROR_CODE ( #4496 )
...
* lua hooks
* findAngleMatch
* s
* s
2022-08-28 09:43:21 -04:00
Matthew Kennedy
ca60dc17bb
trim table for throttle #2 ( #4472 )
...
* add table and wire it up
* trim table ui
* initialization
* changelog
* add a test
2022-08-28 08:28:20 -04:00
Andrey
c6607a5a5e
B6 progress
2022-08-27 20:44:30 -04:00
Andrey
764fc833d7
B6 progress
2022-08-26 12:07:13 -04:00
Andrey
2ee07e643c
B6 progress
2022-08-26 00:30:46 -04:00
Andrey
678c0f1432
B6 progress
2022-08-26 00:24:38 -04:00
Andrey
2f3b1def90
B6 progress
2022-08-26 00:21:17 -04:00
Andrey
3477d4bd07
refactoring
2022-08-26 00:16:36 -04:00
Andrey
1b4bbb8772
refactoring
2022-08-26 00:14:52 -04:00
Andrey
97e8c978ce
B6 progress
2022-08-26 00:04:47 -04:00
rusefillc
055184e1ec
two bugs love to cancel each other
2022-08-25 23:55:42 -04:00
Matthew Kennedy
4d66dff87c
dfco delay ( #4482 )
...
* dfco delay
* config
* using a function that doesn't exist? who does that
* test new behavior
* clearer test
2022-08-25 21:26:17 -04:00
Andreika
c24712bed7
[DRAFT] Air by rpm taper ( #4486 )
...
* add rpm to getOpenLoop() and getRunningOpenLoop()
* implement airByRpmTaper
* unit-test for airByRpmTaper
2022-08-25 21:23:23 -04:00
Andrey
e480e9d561
B6 progress
2022-08-25 19:26:18 -04:00
Andrey
c266a9c542
B6 progress
2022-08-25 12:45:47 -04:00
Andrey
cc95f08fbc
B6 progress
2022-08-25 11:15:54 -04:00
Andrey
4844edc682
Lua code reuse
2022-08-25 10:45:26 -04:00
GitHub build-unit-tests Action
e2ade1d5ff
Trigger wheel definitions
2022-08-24 03:41:03 +00:00
rusefillc
5007084981
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
GitHub build-unit-tests Action
25bb66030f
Trigger wheel definitions
2022-08-22 23:49:31 +00:00
rusefi
26eda07424
Lua CAN bus index: let's fail if invalid value specified
2022-08-21 22:31:52 -04:00
Andrey
585f2ebeea
test coverage and some magic constant refactoring
2022-08-21 16:03:34 -04:00
Andrey
35a71f8960
test coverage and some magic constant refactoring
2022-08-21 15:22:22 -04:00
rusefi
25778f0890
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
rusefi
0f320448ff
refactoring: default argument value
2022-08-21 12:17:50 -04:00
Matthew Kennedy
3e4965ea27
fix inverted vvt ( #4464 )
...
* fix inverted mode
* unit tests are great
2022-08-20 20:12:32 -04:00
Matthew Kennedy
eebc810295
enable alwaysInstantRpm in some tests ( #4461 )
...
* test some with alwaysInstantRpm set
* more
2022-08-19 15:03:20 -04:00
Matthew Kennedy
423f69a842
allow logging multiple warnings at once ( #4414 )
...
* allow logging multiple warnings at once
* comment
* .Code
* Revert ".Code"
This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.
* add a better comparison operator instead of conversion
* dot code
* Revert "dot code"
This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.
* force gcc-10 maybe?
* Revert "force gcc-10 maybe?"
This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.
* vq
* dot code
* dead
* dot code
* return may be null
* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?
* move static vector
* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
rusefi
a4cd6e6a6b
random progress
2022-08-13 23:33:30 -04:00
rusefillc
8f6fb427eb
ECU to Mainline DynoLog Data Protocol #4319
2022-08-12 23:53:48 -04:00
Matthew Kennedy
76f5832db9
resolve VVT phase using every tooth, not just sync point ( #4434 )
...
* resolve VVT phase using every tooth, not just sync point
* fix tests
* comment
* changelog
2022-08-12 08:08:23 -04:00
rusefillc
b5c2b70e23
refactoring: better field name
2022-08-09 20:32:39 -04:00
Matthew Kennedy
c3d6bd7e59
Pt2001 module ( #4396 )
...
* pt2001 uses module
* read flag0
* c
* libfirmware
* makefiles
* are unit tests happy?
* bootloader
2022-08-08 08:53:08 -04:00
Matthew Kennedy
435fd9538b
Simpler thread controller ( #4327 )
...
* s
* Start -> start
* maybe tests are happy
* s
* s
2022-08-02 01:16:13 +03:00
GitHub build-unit-tests Action
55b3bd578e
Trigger wheel definitions
2022-07-31 14:26:12 +00:00
Matthew Kennedy
b6f1779781
implement sensor checker ( #4395 )
...
* implement sensor checker
* use default
* s
* fix
* properly report non-timeout errors
* it's not safe to read Value when invalid
* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
rusefillc
d320dd589c
it's impossible to receive AcceleratorPedal sensor via CAN/Lua #4369
2022-07-28 12:08:35 -04:00
Matthew Kennedy
923d2c2e44
unexpected contains information about why it failed ( #4393 )
...
* unexpected can contain information
* info printing
* sensors return appropriate error codes
* remove reliance on undefined behavior
* s
2022-07-28 10:04:28 +03:00
Matthew Kennedy
41318e0f9d
detect bad Lua sensor name when registering ( #4391 )
...
* format
* lua error on bad sensor
* comment
* name validation
* soft check before the hard check causes a fatal error
* s
2022-07-27 12:41:21 +03:00
Matthew Kennedy
4643dc3c79
Reenable sanitize ( #4384 )
...
* turn on sanitize, fix overrun
* allow sanitize override, disable it for shared lib
* probably fix android build
2022-07-27 09:22:22 +03:00
GitHub build-unit-tests Action
f7303a740a
Trigger wheel definitions
2022-07-23 07:52:13 +00:00
Andrey
7887b9d1e1
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:39:19 -04:00
Andrey
20a16bd53b
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:16:11 -04:00
rusefillc
f7f6f9d8eb
Revert "Reenable sanitize ( #4365 )"
...
This reverts commit d87be38401
.
2022-07-22 08:15:15 -04:00
Matthew Kennedy
d87be38401
Reenable sanitize ( #4365 )
...
* turn on sanitize, fix overrun
* allow sanitize override, disable it for shared lib
2022-07-22 08:19:54 +03:00
Matthew Kennedy
40f48212aa
libfirmware has interpolation tests ( #4362 )
...
* move interpolation tests
* what actually happens if sanitize is off?
* oh look there are real bugs to be caught by sanitizer
2022-07-21 15:41:42 -04:00
rusefillc
4987a0b93c
Launch control bug? "range" thing is confusing #4348
...
a typo and configurable behaviour without UI
2022-07-20 18:48:55 -04:00
Matthew Kennedy
848fbcf6ca
fragments ( #4357 )
2022-07-19 11:02:41 +03:00
Matthew Kennedy
e1254f84b9
remove idle offset ( #4355 )
...
* remove offset
* remove more completely
* changelog
2022-07-18 15:49:43 -04:00
Matthew Kennedy
acf18c7072
move math ( #4353 )
2022-07-17 00:16:22 -04:00
Matthew Kennedy
a0d8ae3f4f
use libfirmware for a few things ( #4351 )
...
* use libfirmware
* unit tests
* crc
* missed one
* bootloader
2022-07-16 02:22:51 -04:00
rusefillc
b7cfa4e702
launch control for autocross on micro rusefi #4341
2022-07-14 16:41:50 -04:00
rusefillc
55ffb45934
FSIO is dead
2022-07-14 07:52:58 -04:00
rusefillc
86270d51c3
RoverK - wow that's odd, but whatever
2022-07-12 03:09:42 -04:00
GitHub build-unit-tests Action
a4b04cdcf3
Trigger wheel definitions
2022-07-12 04:33:14 +00:00
rusefillc
b628c81d26
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-12 00:11:25 -04:00
rusefillc
2f0db8b7c4
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-11 04:21:17 -04:00
Matthew Kennedy
8bc01472b7
Add a timeout for Lua ETB adjustment ( #4331 )
...
* lua etb timeout
* mocks
* test
2022-07-10 05:46:28 +03:00
Matthew Kennedy
3c062e02bc
Lua hooks for gear detection ( #4328 )
...
* implement
* sim has vss
* write a test
* guard
2022-07-07 23:16:56 -04:00
Matthew Kennedy
aecacc6aa1
Rewrite tooth logger buffer management ( #4317 )
...
* s
* make it work
* put back enough maybe
* fix console composite log
* unit tests can just use a vector, why not
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-04 16:57:17 -04:00
Matthew Kennedy
0b10f7dca8
hellen board ID detect improvements ( #4307 )
...
* move call
* board detections work correctly
* improve detector
* s
* break instead of return
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-02 05:19:02 -04:00
Matthew Kennedy
3284282be7
rescale RPM values ( #4300 )
...
* rpm configs
* fix
* s
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-29 18:48:30 -04:00
rusefillc
1b28e292e2
logging of live data structs was: data points #3614
...
huh?
2022-06-29 02:42:03 -04:00
Matthew Kennedy
c0f290b922
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
Matthew Kennedy
fcd3d991ee
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
Matthew Kennedy
34ee344661
fix ( #4279 )
2022-06-23 21:35:05 -04:00
Matthew Kennedy
29420c76aa
wideband live data ( #4276 )
...
* wideband live data magic
* test build happy
* test even happier
2022-06-23 20:04:26 -04:00
Andrey
6ef7562666
VAG Lua progress
2022-06-23 16:02:09 -04:00
Andrey
e4cd9d567d
VAG Lua progress
2022-06-22 22:22:49 -04:00
Matthew Kennedy
11d58f8d5a
clt based rpm limit ( #4267 )
2022-06-22 16:49:24 -04:00
rusefillc
e793124f8d
bit math is hard :(
2022-06-20 21:51:21 -04:00
rusefillc
2ae59f6bd5
bit math is hard :(
2022-06-20 21:36:10 -04:00
GitHub build-unit-tests Action
1d04efa20d
Trigger wheel definitions
2022-06-20 15:54:57 +00:00
GitHub build-unit-tests Action
b5a523af57
Trigger wheel definitions
2022-06-20 12:39:12 +00:00
Matthew Kennedy
932f5e1f30
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit 32d46d1f09
.
* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"
This reverts commit d5e131b1d0
.
* remove synchronizedPhase
* only crank needs this
* changelog
* needsDisambiguation()
* test
* s
* bad merge
* put the timer back
* s
* s
* changelog
* test for new behavior
* correct parameter order
* spelling
* s
* s
* s
* tests merge happy
* bad merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
GitHub build-unit-tests Action
991b7e094e
Trigger wheel definitions
2022-06-02 01:35:22 +00:00
Matthew Kennedy
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
rusefillc
b7743f101f
helping build
2022-05-31 10:45:32 -04:00
rusefillc
22d9bf056a
heling build
2022-05-31 08:48:24 -04:00
GitHub build-unit-tests Action
5ee2236565
Trigger wheel definitions
2022-05-31 02:50:12 +00:00
Matthew Kennedy
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy
f945e6efc9
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy
66fffee321
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
GitHub build-unit-tests Action
da5be301a2
Trigger wheel definitions
2022-05-24 19:05:09 +00:00
rusefillc
6df7d90765
spaces in JAVA_HOME usability
2022-05-24 14:42:42 -04:00
Matthew Kennedy
6f45d0fd46
Fix trigger error indicator ( #4185 )
...
* test and fix
* more shards!
2022-05-19 09:43:42 -04:00
GitHub build-unit-tests Action
af0fa30015
Trigger wheel definitions
2022-05-18 03:24:52 +00:00
rusefillc
458b92e6d9
reduce flash footprint by smarter code generation #4163
2022-05-16 00:00:47 -04:00
rusefillc
8168cad4d7
Revert "Revert "reduce flash footprint by smarter code generation #4163""
...
This reverts commit ea11cc2351
.
2022-05-15 15:15:06 -04:00
rusefillc
ea11cc2351
Revert "reduce flash footprint by smarter code generation #4163"
...
This reverts commit f327897d6c
.
2022-05-15 15:14:04 -04:00
rusefillc
f327897d6c
reduce flash footprint by smarter code generation #4163
2022-05-15 12:05:38 -04:00
Andrey
146d887cdd
reduce flash footprint by smarter code generation #4163
2022-05-15 10:07:17 -04:00
Andrey
d38d8a7840
altering technical debt
2022-05-15 10:07:17 -04:00
rusefillc
500c443a15
Timestamp Error scheduleByTimestampNt too far #3395
...
improving error message
2022-05-14 21:24:19 -04:00
Matthew Kennedy
ae91b2aea8
don't rely on triggerStateListener to detect trigger errors ( #4164 )
...
* Write proper TriggerDecoder tests
* Improve logic around sync loss
* these tests I understand
* these I sort of understand....
* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
GitHub build-unit-tests Action
6b3d1446e0
Trigger wheel definitions
2022-05-11 10:54:37 +00:00
Matthew Kennedy
098b2c87c6
Proper decoder testing ( #4166 )
...
* Write proper TriggerDecoder tests
* patch test for un-patched decoder
2022-05-11 06:14:45 -04:00
Matthew Kennedy
d4509cab8a
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
rusefillc
2132cec3fc
Remove value copy from controller into outputChannels #4095
2022-05-09 06:12:17 -04:00
rusefillc
bd9639b91d
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
Matthew Kennedy
e13dad3a2a
support better wbo format ( #4000 )
...
* new format
* comment
* pr feedback
* heater duty
* extra
* comment
* test multi-accept logic
* s
* test new format
* this comment made no sense
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-07 02:19:51 -04:00
GitHub build-unit-tests Action
c73d9bdbf8
Trigger wheel definitions
2022-05-06 12:37:23 +00:00
Matthew Kennedy
b650bbe46c
Trigger gm 3 vs 5 ( #4140 )
...
* add parameter
* two modes
* add new mode to list
* format
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
Matthew Kennedy
58619b4115
Scaled channel ints ( #4129 )
...
* test that fails today
* Revert "int32 scaled_channel has float precision #4128"
This reverts commit 03d44b75ea
.
* fix the problem
* format
* x
* s
2022-05-02 15:20:02 -04:00