d90d6705cf
adjustment to #3722 ( #3723 )
...
* s
* behold, another bug a test caught
* test
* test generates usable trigger pattern so it works correctly
* comment
* don't need that
2021-12-31 01:21:21 -05:00
041a3e12a3
extract isSyncPoint function ( #3726 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* clean up noise from test case
* clarify and comment
2021-12-30 11:39:04 -05:00
b392a7120e
improved noFiringUntilVvtSync logic ( #3696 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* nissan MR too
2021-12-27 12:09:38 -05:00
71542ea6b9
live data this
2021-12-09 22:02:47 -05:00
b9f8409f59
correctly compute engine revolution number ( #3586 )
...
* add param
* first revolution is revolution 0, not revolution 1
* would you look at that, we sync one rev quicker!
* changelog
* rpm value
2021-11-21 09:01:27 +03:00
dac2ae9b1d
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
7296593448
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
bd04dc8352
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
9b40e68155
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
e3e5e57eac
instant rpm uses full engine cycle ( #3077 )
...
* instant rpm uses full engine cycle
* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
e8aef0dcd3
VVT position of first cam is off on first cycle fix #2987
2021-07-22 01:02:37 -04:00
c433c20a36
simplify quad vvt test #3018
...
better parameter name and explicit constraint clarification
2021-07-21 17:45:35 -04:00
206bf7adc8
reducing warnings
2021-07-13 14:50:10 -04:00
ab3a862f19
reducing code duplication
2021-07-06 00:09:35 -04:00
8f13e5711a
Nissan VVT trigger decoder #2887
2021-07-05 23:39:39 -04:00
32a813339d
Nissan
2021-07-05 18:37:53 -04:00
9ad5ec8044
refactoring: getShaftSynchronized
2021-07-03 10:37:03 -04:00
737ee444b8
rip the bandaid: find-replace most of scheduleMsg ( #2572 )
...
* biiiig find replace
* more trivial find replace
* pwm
* almost all of them
* few more
* gpio
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
3d89cc2093
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 15:17:01 -04:00
9c26a84be9
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 01:21:28 -04:00
d5bc14719e
trigger decoder timer ( #2427 )
...
* part 2
* stale comment
* include
* why was this a macro
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 16:35:58 -05:00
5bfee13c21
fix instant rpm ( #2180 )
...
* consumers
* impl
* instant rpm in idle timing
2021-01-14 20:45:55 -05:00
e112bbd07e
remove virtual calls from hot path ( #1857 )
...
* const ref-ify
* no virtual ❌
* even more const
* tests
* fix tests
2020-10-05 16:42:50 -04:00
060cfbd778
const ref-ify trigger ( #1856 )
...
* const ref-ify
* tests
2020-10-05 14:22:59 -04:00
ebc884e8d5
trigger decode cleanup and perf ( #1853 )
...
* trigger decode cleanup
* test config ptr patchup
* disable CDM by default
2020-10-04 19:29:26 -04:00
b19ffa7075
TriggerConfiguration getPrintPrefix
2020-08-29 17:25:42 -04:00
35702163ee
const
2020-08-26 17:37:15 -04:00
f268af5165
const
2020-08-26 17:30:13 -04:00
b64c9bd9d3
VVT support for VAG trigger #883
2020-08-25 13:14:46 -04:00
470a9f5a5a
VVT support for VAG trigger #883
2020-08-25 12:45:18 -04:00
7d53f5859d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
4e333dac1c
VVT support for VAG trigger #883
2020-08-24 02:07:58 -04:00
bdbee0d38b
VVT support for VAG trigger #883
2020-08-24 02:01:50 -04:00
0f9e8bf83e
VVT support for VAG trigger #883
2020-08-24 01:21:42 -04:00
24b0c85a9e
fix warnings ( #1282 )
...
* warnings
* don't need to template those
2020-04-12 09:39:14 -04:00
a2a5b40ced
Support disabling most/all features ( #1162 )
...
* this flag did nothing
* guard features properly
2020-02-26 18:16:35 -05:00
ae228dff0e
trigger refactoring
2020-01-26 14:20:55 -05:00
9bd796ab6b
trigger refactoring
2020-01-26 12:02:54 -05:00
98c6198f1d
reducing code duplication
2020-01-26 06:28:33 -05:00
23631b5970
trigger refactoring
2020-01-26 06:12:01 -05:00
d1a4b39a5a
refactoring: de-coupling trigger decoder and engine
2020-01-26 03:48:25 -05:00
dfa8d9ccc9
refactoring trigger
2020-01-26 03:33:45 -05:00
59c293b548
trigger refactoring
2020-01-25 11:22:25 -05:00
43eb2ef9d0
refactoring trigger
2020-01-24 13:42:09 -05:00
c7875876e5
refactoring - de-coupling trigger
2020-01-22 13:25:35 -05:00
f6ce9397db
refactoring
2020-01-22 01:22:44 -05:00
a89e20a647
refactoring
2020-01-22 00:40:26 -05:00
63e3e84e08
happy new year
2020-01-08 00:02:40 -05:00
cf0b13041f
random refactoring: hopefully not changing byte size of any variables but clarifying/fixing type between ticks, US and MS
2019-12-21 21:11:09 -05:00
bcec694eb1
just a trivial massive rename: TriggerState > TriggerWaveform
2019-12-08 01:09:39 -05:00
Matthew Kennedy
rusefillc
Scott Smith
Andrey