63524c3f34
fan/AC idle improvements ( #2818 )
...
* fan 2 open loop bump
* we had an AC target bump all this time?!
* format
* enable test
* I can't type
2021-06-15 17:30:35 -04:00
322f69474f
remove cranking dwell angle ( #2814 )
...
* config & impl
* settings
* engines & boards
* this test doesn't do anything interesting
2021-06-13 07:52:07 -04:00
0c0957f52a
apply open loop idle when in automatic mode ( #2745 )
...
* always apply open loop in closed loop
* simplify flags
* comment
* move
* comment
* missed one
* config for fan bump
* adjust miata defaults
* test fan/ac open loop
* idle CL tests
* test coasting
* test integration case
* fix merge
* put back reset logic for now
* s
* don't need that part
* I guess use OL as baseIdlePosition
* reset condition
2021-06-12 14:21:11 -04:00
41104dcca8
hard coded fan logic ( #2805 )
...
* remove fsio
* hard code impl
* test it
* enable fan with AC
* make commented stuff match
2021-06-11 06:25:12 -04:00
e3bf80b9d7
convert gpiochips to c++ ( #2761 )
...
* core
* basic header
* tests are happy
* tle6240
* tle8888
* 33972
* 33810
* tle8888_req_init
* unused warning
* warning
* unsigned
* 8888 debug
* fix
* don't qualify
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-10 04:11:01 -04:00
70c0db189d
warnings & assorted cleanup ( #2793 )
...
* lua hook
* validateBuffer
* tables
* simplify fsio table
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 14:30:25 -04:00
8466b29ade
Trigger wheel definitions
2021-06-02 16:43:30 +00:00
de00c7fef7
Bandaid for 2735 ( #2788 )
...
* bandaid
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-02 12:02:52 +03:00
cc0547217c
Cranking defaults ( #2787 )
...
* defaults
* more
* cranking fuel
* cranking timing
* cranking time digits
* ugh these tests shouldn't depend on defaults
2021-06-02 08:21:36 +03:00
f21fa3e652
idle fan/AC open loop bump ( #2785 )
...
* idle open loop ui section
* idle bump logic
* test fan/ac bump
2021-06-01 00:45:04 +03:00
1f3cbd67ad
iac coast table ( #2784 )
2021-06-01 00:43:58 +03:00
6fbdb3c2d0
make the implementation match what the UI claims ( #2779 )
2021-05-31 07:37:02 -04:00
1b607faeba
Idle test that fails ( #2781 )
...
* make member func
* failing test
2021-05-31 06:18:15 -04:00
f0c8b3e102
my status
2021-05-31 05:27:51 -04:00
6436dcf755
Trigger wheel definitions
2021-05-31 08:53:37 +00:00
f51dd36622
require redundant pedal ( #2758 )
...
* require redundant pedal
* return false
* I don't typing good
* tests
* tests
2021-05-30 19:19:57 -04:00
d71a40ae24
Trigger wheel definitions
2021-05-29 08:25:43 +00:00
82b62f5ac0
Trigger wheel definitions
2021-05-26 10:24:44 +00:00
de48ec71f0
Trigger wheel definitions
2021-05-26 09:43:53 +00:00
0d46d96e46
subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021
2021-05-26 05:22:13 -04:00
e4497358f5
Override trigger gaps feature #2734
2021-05-25 17:19:20 -04:00
9b7c9afb3b
Trigger: warning code on normal engine start up #669
2021-05-24 06:03:58 -04:00
575d2fda85
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-23 18:59:08 -04:00
27ada27639
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-23 18:49:48 -04:00
3ab4ee9ea5
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-21 11:07:59 -04:00
68ad12da53
convert a table to scaled_channel ( #2724 )
...
* scaled VE table
* use setTable
* efi::clear
* ratio -> struct
2021-05-20 20:00:32 -04:00
6bfaed64db
lua pwm hooks ( #2687 )
...
* pwm hook
* dedicated pins
* write hook
* UI
* more info
* zero based, clamp
* memory
* don't compile lua in bootloader at all
2021-05-20 19:01:17 -04:00
8b042ab9b1
rewrite table3d ( #2723 )
...
* post cranking factor limits
* sensible defaults
* but not for tests
* add pointer version of get bin
* test via map3d
* put that back for a minute
* new impl
* fix order
* rename and fix table orientation
* flip the table to the correct orientation
* dead cleanup, rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-05-20 22:31:16 +03:00
4b69e7d441
compile gpiochips as cpp ( #2702 )
...
* rename
* core
* structing
* more
* makefile
* structing
* 6240 compiles
* explicit cast instead of implicit narrowing
* 8888
* no extern C
* fix tests build
* extern "C"
* 33810
* 8860
* 33810
* linker
* unbreak master
* don't need that if compiling as C++
* bump config
* fix test
* tests
* unit tests bad merge
* build
* move subaru logic to cpp file
* cpp goodness
* hpp include
* this is probably the right thing to do
* simulator
2021-05-17 08:42:56 +03:00
bdf4766343
helping jenkins
2021-05-16 11:35:05 -04:00
a441ff17a3
Hw layer rearrangement ( #2707 )
...
* Fix unit_tests
* simulator: fix redifinition of TS_PRIMARY_SERIAL warning
2021-05-16 15:19:34 +03:00
9c352b4d99
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-15 16:21:24 -04:00
06bdf52b3c
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-15 05:27:33 -04:00
eecfcd9e0e
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-14 10:58:53 -04:00
0c03a1cb4a
const airmass ( #2694 )
2021-05-14 07:17:22 -04:00
9307ab6b1e
explicitly test PTC thermistors ( #2681 )
...
* test ptc
* allow hotter for air cooled people
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-05-10 18:15:09 -04:00
1aed5c6ae2
remove intermediate buffer ( #2668 )
...
* remove define
* goodbye intermediate logging buffer
* free ram! woo!
2021-05-10 08:01:24 -04:00
76f2f063d2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
1e887f5ecb
unit tests usability: overwriting an existing profile data with a different timestamp fix #2650
2021-05-07 22:33:26 -04:00
77c28c6969
Break out unit tests #2627
2021-05-07 22:14:22 -04:00
ab9d248254
Break out unit tests #2627
2021-05-07 17:45:26 -04:00
effcf3616b
Break out unit tests #2627
2021-05-07 17:43:24 -04:00
f458b6588a
Break out unit tests #2627
2021-05-07 17:18:18 -04:00
e0f8cfaca1
Break out unit tests #2627
2021-05-07 12:36:30 -04:00
37a3de07cf
remove stateChangeCallback from simplepwm ( #2644 )
...
* remove callback parameter from cj125
* remove from ext
* remove stateChangeCallback
* alt doesn't need that
* demorgan
* remove call
* bad cut/paste
* check the actual pin in the test
2021-05-07 09:38:41 -04:00
b7c9002d56
Break out unit tests #2627
2021-05-06 16:33:10 -04:00
ab11c2275f
docs
2021-05-06 10:43:25 -04:00
71b45bb196
explicit paths
2021-05-06 10:09:18 -04:00
c2a42cc823
explicit paths
2021-05-06 10:04:21 -04:00
65a8941286
more Lua hooks ( #2605 )
...
* more hooks
* zero index
* test table hook
* test works
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-29 22:22:04 -04:00
a470c1eec1
lua 5.4 ( #2590 )
...
* thread priority
* build
* makefile prep
* call startup
* lua 5.1
* mk
* 5.3
* mk
* I guess lua does something?
* extract hooks, builds for tests
* a bit of error handling
* guard
* bootloader makefile
* remove lua
* submodule
* submodule update
* builds with submodule
* disabled by default
* h7 chconf
* tweaks
* add a useful hook
* move luaconf
* perf trace lua
* test helpers
* lua unit tests
* include to satiate clang
2021-04-28 22:41:25 -04:00
5f0791f9fb
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
8cfb63455d
Logging remove 3 ( #2568 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
* vvt
* more
* idle
* missed one
* dynoview
* launch
* can
* console IO
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-20 14:09:41 -04:00
992c16b4af
logging cleanup 2: sensors, pid, etb, etc ( #2567 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 20:02:32 -04:00
babb43013f
rewrite text logging system ( #2439 )
...
* minor cleanup
* enable mailboxes
* priority
* implement new logger
* more cleaning
* signature
* remove debug
* put the assertion back in
* remove debugging
* spelling
* doy
* tweaks & comments
* cleaning
* size_t
* guard more
* test build now
* needs more ram until we can remove LogginWithSTorage
* hunt for memory
* bootloader
* unused
* stub simulator
* it would help to get the signature right
* geez kinetis only has 64k ram
* more guarding because kinetis
* that's now very legal and very cool
* templatify
* s
* force null terminate
* probably fix
* const
* write a test
* disable sensor chart for now
* hide SC ui
* oh nope that breaks many things
This reverts commit c3c1bb324fb484c3d9cc44b7715c234bc0392e1e.
* missed one
* reset after scheduleLogging
* we can't print out the full message because it contains commas which break parsing
* force terminate long buffers
* let's see how much memory we have to play with
* a lot, is the answer
* real thread name
* shrink this for now before its deleted
* turn that back on
* biiig comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 18:46:47 -04:00
55837e9a98
Trigger wheel definitions
2021-04-15 23:39:10 +00:00
9c1aa580f1
WOW major scheduling drama on NB2 running with Proteus #2533
2021-04-15 19:12:09 -04:00
82fe2f123d
Trigger wheel definitions
2021-04-09 17:12:18 +00:00
7063a5bde9
Trigger wheel definitions
2021-04-09 02:45:15 +00:00
8080f3bde7
helping us trace CUSTOM_INTEPOLATE_ERROR
2021-04-08 16:14:06 -04:00
c3270fb715
helping us trace CUSTOM_FSIO_STACK_SIZE
2021-04-08 15:15:12 -04:00
f34bca916d
CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534
2021-04-08 15:01:12 -04:00
9c26a84be9
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 01:21:28 -04:00
7782ebd7b4
Ford redundant ETB tps ( #2519 )
...
* ford tps
* configurable maximum
* initialization
* check consistency when in the low range
* print info
* default
* config field
* config parameter
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-05 15:57:03 -04:00
a9e822f790
'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528
2021-04-04 23:12:07 -04:00
b378fcdb88
engine sniffer into unit tests
2021-04-04 22:48:48 -04:00
549839b0de
engine sniffer into unit tests
2021-04-04 22:41:38 -04:00
112b4d1182
Hip9011 ( #2512 )
...
* hip9011: coexistance with other spi devices
* hip9011: rework so SPI transfer is invoked from thread
also use polling spi exchange to avoid cache problems
* hip9011: move calculations from ADC callback to thread
* hip9011: big cleanup
* hip9011: simplify spi communication
* No need to set knockBandCustom if it is not custom
HIP9011 calculates knockBand from cylinderBore same way
* hip9011: make unit test happy
* hip9011: fix unit test
* hip9011: remove duplicated initialization, reorder
* hip9011: just renames and data type adjustments
* hip9011: rename BAND() to HIP9011_BAND()
* hip9011: move some code from lookup.cpp to logic.cpp
* hip9011: move initEngineNoiseTable to engine_configuration.cpp
* hip9011: move lookup tables to hip9011_logic.c
* hip9011: remove empty files
* hip9011: additional checks
2021-03-30 10:56:25 -04:00
72dac58f9b
fix multi-serial-port insanity ( #2476 )
...
* carve out UART specific
* implement channel
* config cleanup
* use new config
* bootloader
* dead code
* s
* h7 inherits f7
* oops
* ok now it's right
* tests
* cleanup
* call setup
* put that in its own file
* cleanup
* format
* guard
* not needed
* improve guarding
* portable
* allow override of uart mode
* fixes for bootloader
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 09:06:36 -04:00
204aa33e9a
goodbye ignitionOffset ( #2503 )
...
* remove
* set the timing map to do what the offset used to do
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 08:00:09 -04:00
ce142907a0
replace print/printMsg with scheduleMsg ( #2497 )
...
* start cleaning
* disabled feature means don't print that it's disabled
* cli
* usages
* printMsg -> scheduleMsg
* this is alllll dead now
* no crlf please
* all hope is lost if you manage to hit this line
* tests
* tests
* ok we did actually need that part
* sim
* d
* kinetis
* it did ifdef, not if
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-26 17:23:26 -04:00
4e1d30f86d
plumbing for multiple vvt ( #2488 )
...
* plumb multiple vvt
* fix test
* s
* fix barra while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
fe2b1ddae3
Trigger wheel definitions
2021-03-22 18:33:55 +00:00
5e6746c3aa
Implement nonlinear fuel level sender ( #2473 )
...
* table function
* config fields
* sensor type
* switch consumers
* init the sensor
* ui
* 1mv resolution
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-19 08:39:08 -04:00
910f46267f
VVT uses closed loop controller framework ( #2453 )
...
* vvt uses framework
* builds
* rename, update headers
* s
* testable
* write some basic tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-14 19:31:46 -04:00
765895d913
Fuel pressure sensor checks ( #2449 )
...
* test for missing sensor
* test negative pressure delta checking logic
* test new hasSensor logic
2021-03-12 23:32:41 -05:00
dee68b13f7
Trigger wheel definitions
2021-03-13 03:00:16 +00:00
3651883bcf
test_timer
2021-03-12 00:43:48 -05:00
9f90387d09
vBatt -> SensorType::vBatt fix #2260
2021-03-11 23:07:18 -05:00
ff5bf3e3c3
error accumulator ( #2434 )
...
* error accumulator
* makefile
2021-03-08 07:40:46 -05:00
b70e39d425
update all compile scripts to use available cores rather than a hardcoded value ( #2425 )
...
* fix typos, spelling
* add two V8 firing orders
* use the available number of CPU cores, not just 4
* add new firing orders to config
* updating generated files to include new v8 firing orders
* reverting update of auto-generated files
* correct firing order labels for new firing orders
* update all compile scripts to use available cores rather than a hardcoded value
2021-03-06 12:55:46 -05:00
89d71e4379
Compute injection duration later in the pipeline ( #2175 )
...
* injector model, test
* new math
* inject fuel based on new math
* tests
* fix
* it should work like this
* format
* update TPS AE even when we're cutting fuel
* comment
* conversion factor
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-03 07:30:56 -05:00
cd548b4db2
hip9011 compilation fix, cosmetic clean-ups ( #2414 )
...
* Board subaru eg33: has HIP9011 knock sensor
* hip9011: lastExecutionCount does not exist any more
* hip9011: extranc commands to header, use logic math for bitfields
2021-02-28 15:42:57 -05:00
350a047ead
cleanup ( #2386 )
2021-02-23 16:57:14 -05:00
12a31e5132
start making tunerstudio more sane: part 2 ( #2381 )
...
* ts cleanup part 1
* move more stuff in to the class
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-19 20:48:21 -05:00
321fe48b27
rework FSIO LEelement ( #2374 )
...
* save
* firmware
* test parsing multiple things
* split tests
2021-02-17 23:32:44 -05:00
55facb6613
use DECLARE_ENGINE_PTR for Engine class ( #2365 )
...
* engine cleanup
* do the cleanup
* one last spot
* expand_engine noop for firmware
* simulator
2021-02-16 16:58:54 -05:00
dbebc353a2
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
6b848bf896
second bank vvt decoder unit test
2021-02-09 10:16:49 -05:00
8a237fa800
M62T vanos support #2243
2021-02-08 22:41:31 -05:00
8fa1a6530b
M62T vanos support #2243
2021-02-08 21:50:31 -05:00
aea4baecb4
M62T vanos support #2243
2021-02-08 21:07:43 -05:00
1012b61e02
M62T vanos support #2243
2021-02-08 20:38:38 -05:00
2ccb75a064
refactoring: naming consistency
2021-02-08 18:20:53 -05:00
4b8a92ccc9
M62T vanos support #2243
2021-02-08 18:08:26 -05:00
d05edd2a3d
M62T vanos support #2243
2021-02-08 16:16:26 -05:00
3390bcf0ce
refactoring: more structure
2021-02-08 15:59:40 -05:00
c0757a7d13
simplify MCU selection ( #2308 )
...
* set mcu type in hw_ports
* move f4 linker script
* move f7 linker script
* don't set default linker file in makefiles
* extra line
* prometheus actually didn't depend on anything special for f469
* dead line
* h7
* dead
2021-02-08 02:11:44 -05:00
983d75444e
baro in sensor model ( #2306 )
...
* baro in sensor model
* missed
* typo
* init baro
* needs an include there
2021-02-07 17:54:41 -06:00
3aee9b171f
Trigger wheel definitions
2021-02-07 06:11:28 +00:00
11e8a35c15
Trigger pattern request Škoda Favorit fix #2302
2021-02-06 20:53:30 -05:00
dfd2b6abc6
Trigger wheel definitions
2021-02-07 01:25:21 +00:00
8d9db6b5c1
put vbatt in sensor model ( #2261 )
...
* vbatt in sensor model
* sensor name
* vbatt
* s
* oy vei
* a little bit of cleanup
* memory apparently
* cj125 test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-03 07:55:40 -06:00
96648f96aa
Trigger wheel definitions
2021-02-02 16:21:55 +00:00
c743c98b3a
Trigger wheel definitions
2021-02-02 15:03:11 +00:00
1655209406
Trigger wheel definitions
2021-02-02 04:56:18 +00:00
11aa253ae9
vvt/cam events to pass index
2021-01-31 22:24:45 -05:00
e22a9e9d02
-g3 to -g ( #2256 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-31 14:13:55 -05:00
8e954c89cf
Trigger wheel definitions
2021-01-19 00:14:52 +00:00
0cc7cb8eb4
Revert "Save more space in the angle cache ( #2228 )"
...
This reverts commit 1800219e
2021-01-18 18:53:00 -05:00
bc39f7e8c2
Trigger wheel definitions
2021-01-18 23:42:56 +00:00
1800219e44
Save more space in the angle cache ( #2228 )
...
* store event angles in a scaled field
* tests
* comment
2021-01-18 18:31:06 -05:00
b047ec4f12
clean up some includes ( #2227 )
...
* cleanup
* make c happy
2021-01-16 09:45:45 -05:00
b32e9ecb4a
templated interpolate2d ( #2221 )
...
* template table2d
* assertions
* oops
* tests
* test bins too
* more assert
* format
* explicitly handle and test NaN
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-11 08:00:15 -05:00
0768eb75da
weird
2021-01-10 20:29:20 -05:00
3daa7d4d9a
Start support for multi-bank closed loop fueling ( #2184 )
...
* cfg
* cell
* N banks
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-10 08:10:49 -05:00
86d3746453
Idle timing uses phase logic, remove falloff ( #2169 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
* wonderful changelog
* now unused parameter
* put back deadzone
* ui
* test deadzone
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-07 08:06:36 -05:00
f962a7bd64
Gpio cleanup #2 ( #1530 )
...
* pin repository: PIN_USED size in now equal to brain_pin_e enum size
expect special values...
* smart gpios: register gpio chip to given base (no auto-allocation)
* drivers: gpio: core: add gpiochip_unregister()
* drivers: gpio: MC33810 intergation
* smart_gpio.cpp: cleanup ifdef mess, minor cleanups
* gpio: core: additional check for gpio ranges overlaps
* unit test: gpio chip: fixed and extended
2021-01-06 18:29:47 -05:00
56b4d87fcd
generate triggers.txt from parametric test ( #2186 )
...
* add new test
* comment
* remove old
* main cleanup
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 17:58:34 -05:00
8608df5450
flex fuel AFR interpolation ( #2190 )
...
* config
* implement flex
* secondary fuel default
* test
* test works
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 16:27:23 -05:00
cb1637411c
Trigger wheel definitions
2021-01-05 21:14:10 +00:00
71fe582ce5
Adc isAdcChannelValid helper ( #2188 )
...
* Guard define argument
* ADC: isAdcChannelValid
Check for both <= EFI_ADC_NONE and >= EFI_ADC_LAST_CHANNEL
Also check for value out of enum range (corrupted settings)
* Fix unit tests
2021-01-05 16:02:20 -05:00
30e8334349
Trigger wheel definitions
2021-01-04 05:38:14 +00:00
8f4e7db309
Trigger wheel definitions
2021-01-03 19:05:07 +00:00
add0dcd390
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
7c38714129
Revert "Idle timing PID uses phase logic ( #2156 )"
...
This reverts commit f1ee8b43
2020-12-31 12:22:54 -05:00
83266c904b
Put map in the sensor model ( #2161 )
...
* hook up map
* check for init
* switch some consumers
* don't do limp for now
* oops
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:43:49 -05:00
f1ee8b431e
Idle timing PID uses phase logic ( #2156 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 23:50:56 -05:00
924ca4f3a4
progress to fsio type safety ( #2137 )
...
* rename
* packed type safe fsio value
* comment
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-27 17:22:11 -05:00
5f84cf2a07
limp manager can disable etb ( #2143 )
...
* move rev limit to limp manager
* call fatal error
* include order
* fix bug
* tests
* limp can disable etb
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 21:47:27 -05:00
560061e251
Idle refactor open loop ( #2146 )
...
* impl
* typo
* tests
2020-12-26 19:34:42 -05:00
b0f7fbf28a
create limp manager ( #2142 )
...
* move rev limit to limp manager
* call fatal error
* include order
* fix bug
* tests
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 17:30:46 -05:00
93cc1e84c3
more testable idle logic ( #2140 )
...
* header
* test
* impl
2020-12-26 08:32:01 -05:00
90cdd2ee84
rename ( #2136 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-25 08:40:54 -05:00
76e19fc97f
fix tach test 2130 ( #2134 )
...
* fix
* comment
2020-12-24 21:20:24 -05:00
297adecbca
Restore testPulsePerRev #2130
2020-12-24 08:17:43 -05:00
fad3b07b8b
Purge e34 config ( #2127 )
...
* remove
* enums
* s
* func test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-24 07:31:25 -05:00
7617b115de
Partition configs by board type ( #2106 )
...
* remove old flag
* flags
* reorder switch
* oops
2020-12-22 21:54:40 -05:00
85f0621738
Purge rover v8 config ( #2116 )
...
* bye
* goodbye, rover v8
* that snuck in
* use a different config for that test
2020-12-22 10:05:54 -05:00
d3a24c568a
gpio unit tests ( #2099 )
...
* fix unregister api for gpio
* consumers
* guard with a critical section
* index
* guard less
* unregister under lock
* fix reinit
* dead flag
* fix most tests
* initialize properly
* initialize properly
* assertions in tests
* fix message
* move gpio mocking
* test gpios
* we must lock earlier to be truly safe
* this was using huge memory
* devirtualize
* test deinit
2020-12-18 17:19:02 -05:00
30fd52d82d
Fix gpio reinit race condition ( #2098 )
...
* fix unregister api for gpio
* consumers
* guard with a critical section
* index
* guard less
* unregister under lock
* fix reinit
* dead flag
* fix most tests
* initialize properly
* initialize properly
* assertions in tests
* fix message
* we must lock earlier to be truly safe
* this was using huge memory
* devirtualize
2020-12-18 17:18:12 -05:00
f5a5a54683
naming consistency
2020-12-18 09:01:18 -05:00
d3cbed60af
move target computation ( #2091 )
2020-12-17 17:46:51 -05:00
34edf34bf4
only build in config for the correct board ( #2088 )
...
* only build in config for the correct board
* undo
* undo
* undo
* only touch proteus config
* include configs in tests
2020-12-17 17:12:24 -05:00
d7acabc19e
Trigger wheel definitions
2020-12-14 00:34:22 +00:00
3cda7e1c1e
Trigger wheel definitions
2020-12-13 21:52:33 +00:00
0465acc0ab
Trigger wheel definitions
2020-12-13 04:53:28 +00:00
abf683e775
test ( #2071 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-12 23:40:05 -05:00
ba3065a998
random initial
2020-12-12 21:59:56 -05:00
456759067d
Trigger action ( #2070 )
...
* push triggers.txt
* tricky whitespace
* remove from gitignore
* add
* echo output for debug
* change path
2020-12-12 21:36:41 -05:00
26a205f72b
clang warnings again ( #2055 )
...
* s
* changelog
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-11 13:59:28 -05:00
47db5d0d99
clang warnings again #2055
2020-12-11 10:33:00 -05:00
719e341eeb
start fuel pump as soon as trigger events happen ( #2038 )
...
* switch pump fsio logic
* value collision
* fuel pump in tests
* mock time since trigger
* test fp
* init pin in test
* fix gpio outputs in tests
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-10 01:23:24 -05:00
ce2e7d3cbe
fix mock pins array ( #2050 )
...
* fix
* fix probably
2020-12-10 00:10:58 -05:00
ba1ba1452d
second lambda (x-series CAN only, for now) ( #2048 )
...
* add sensor
* second sensor
* switch sensor name
* gobblin up your memory
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-09 20:26:23 -05:00
4072db3052
trigger lifecycle
2020-12-09 12:19:25 -05:00
d7c56f78a9
require redundant TPS for ETB ( #2041 )
...
* Require redundant tps for ETB (#2037 )
* mod sensor api
* require redundancy
* fix tests
* check that it fails
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
* add a test that fails but should not
* fix the bug
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-08 06:24:20 -05:00
13ac8fe744
not this line yet?
2020-12-07 01:40:26 -05:00
412e2b1d40
Revert "Revert "Split ETB in to interface + implementation headers ( #2040 )""
...
This reverts commit dae0b606
2020-12-07 01:27:27 -05:00
e38c6d3660
Revert "Require redundant tps for ETB ( #2037 )"
...
This reverts commit c08d0b5e
2020-12-07 01:11:32 -05:00
dae0b606cb
Revert "Split ETB in to interface + implementation headers ( #2040 )"
...
This reverts commit 53cbeedb
2020-12-07 01:11:19 -05:00
53cbeedb99
Split ETB in to interface + implementation headers ( #2040 )
...
* split etb interface
* mocks
* fix master while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:29:09 -05:00
c08d0b5ed8
Require redundant tps for ETB ( #2037 )
...
* mod sensor api
* require redundancy
* fix tests
* check that it fails
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:05:06 -05:00
ab8248427c
more ETB test coverage ( #2039 )
...
* test no pedal map
* test open loop
* open loop but not throttle
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:59:18 -05:00
cd2d568b74
maybe fix sensor init checks ( #2034 )
...
* enums
* don't collide
* auto_generated_enums
* check based on new enum val
* maybe this will make generate tool happy
* add a test
* fix test
* fix and add another test
* make clang happier
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:19:57 -05:00
8d6255b1e2
Revert "switch rpm calculator to use timer class ( #2005 )"
...
This reverts most of 622021e799
2020-12-06 18:05:53 -05:00
622021e799
switch rpm calculator to use timer class ( #2005 )
...
* add api
* rpm calculator
* fix fsio
* fix float
* remove wrong comment
* fix timer
* clang didn't like this
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 16:01:45 -05:00
69f754bfbd
don't duplicate sensor error logic ( #2032 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 15:00:30 -05:00
7dad3356e9
add isRedundant ( #2031 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 14:55:06 -05:00
63e328603f
one step back #2017
2020-12-06 08:50:10 -05:00
fbcfb4534a
require TPS values to be different ( #2017 )
...
* require values to be different
* fix not
* oops
* missed another spot
* test negative cases too
* resets
* test no sensor case
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 00:41:49 -05:00
a806053d52
round rpm instead of truncating ( #2023 )
...
* round rpm instead of truncating
* efiround is expensive
* Revert "efiround is expensive"
This reverts commit e5690f89e1b1988aacf5ced1f024d576465a7cd6.
* round is better than rintf
* testing
* it works now?!
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 00:11:57 -05:00
9f9e9f99d1
unit tests in clang ( #2012 )
...
* clang errors
* non-test-only
* debugging
* rules on mac
* makefile
* put back
* let's see if this way makes everybody happy
* no, it does nto
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-05 23:21:17 -05:00
8540343d48
unit tests in clang #2012
2020-12-05 00:22:10 -05:00
45205e7da7
Dyno view proposal ( #1999 )
...
* DynoView creation
module implementation and unit_tests
* update acc algo
we only calcualte new acceleration value if speed has changed, not on every callback.
* added acceleration ts_channel
* fixed broken unit tests
* fixed accel sign
* review updates
* Update test_dynoview.cpp
fix unit_tests
* Update engine_controller.cpp
Fix .ram4 unused size
* Update test_dynoview.cpp
2020-12-04 20:28:48 -05:00
dae7499c65
docs
2020-12-04 16:10:58 -05:00
59e4e3187b
all triggers should be documented way nicer #2001
2020-12-04 11:58:26 -05:00
c6d49e9621
DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT fix #2008
2020-12-03 23:12:30 -05:00
b014023560
Launch Control refactoring ( #1992 )
...
* refactor
- called from periodicFastCallback
- removed defines
* Update rusefi.input
removed unused configurations.
added clutch inversion option
* Added new tests
fixed limiting only in case we have launch condition and rpm outside of window
* Update launch_control.cpp
Unintialized config update, now it is working fine with VSS and with clutch as well.
* small fixes
updated after review findings
* Fix breaking engine rev limiter
applyLaunchControlLimiting should not overwrite booleans to false!
* Delay timer in seconds
timer uses ms, so convert seconds to ms
2020-12-01 13:03:42 -05:00
701f0b2e20
dead engine config
2020-11-26 20:53:44 -05:00
cf1c99b36c
fix etb unit test idle hardware ( #1991 )
...
* move check to etb
* give it a sensor to read
2020-11-26 19:21:42 -05:00
92e36e66b5
fix etb wastegate percent output ( #1988 )
...
* wastegate etb should use percent
* percent_t
* fix test
2020-11-25 21:14:06 -05:00
ae53889d10
Boost tolerance ( #1986 )
...
* tolerate invalid closed loop config when in open loop mode
* fix test
2020-11-25 07:27:24 -05:00
315bfe6531
avoid float -> int64 conversion #1977
...
cherry picking...
2020-11-23 23:33:46 -05:00
be71d06dfc
remove ( #1985 )
2020-11-23 20:10:17 -05:00
8eaae30bca
fix #1968 ( #1976 )
...
* tanf
* name
* comment, add test
2020-11-22 08:26:17 -05:00
9edcd372ec
No latest gcov #1973
2020-11-19 21:57:18 -05:00
a671d14b36
No latest gcov #1973
2020-11-19 21:56:48 -05:00
827115f0c2
No latest gcov #1973
2020-11-19 21:32:14 -05:00
e69d103461
Launch control unit tests update ( #1972 )
...
* testable launch start
* extract base class
* add a test
* fix ts debug
* Launch control unit_tests
updated launch control for a better split
VSS mock for unit tests
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2020-11-19 21:14:38 -05:00
f3c9d67d8b
Starter is engaged on start-up in pull-up configuration #1969
...
usability & test improvement
2020-11-19 17:15:28 -05:00
359a6ddc47
Launch control testable ( #1967 )
...
* testable launch start
* extract base class
* add a test
* fix ts debug
2020-11-19 08:15:56 -05:00
2792828dce
Remove lockAnyContext, replace with CriticalSectionLocker ( #1938 )
...
* switch to CriticalSectionLocker
* that's just about all
* clean up last usage
* include hpp for sim
* need the cpp wrappers in the makefile too
* include dir
* include
2020-11-19 06:56:02 -05:00
dbdfd87c6d
Starter seems to be engaged forever fix #1965
2020-11-18 23:54:30 -05:00
2c4f048e0d
Starter seems to be engaged forever #1965
2020-11-18 23:06:44 -05:00
acb65fe307
Starter seems to be engaged forever #1965
2020-11-18 22:56:05 -05:00
2d3ddcde9d
Starter seems to be engaged forever #1965
2020-11-18 22:47:40 -05:00
b6dac8dac2
Starter seems to be engaged forever #1965
2020-11-18 22:42:41 -05:00
b41df605b4
Starter seems to be engaged forever #1965
2020-11-18 21:22:01 -05:00
a73b2c9298
Starter seems to be engaged forever #1965
2020-11-18 20:53:03 -05:00
ab75be8742
Something something unit test ETB does not work #1966
2020-11-18 20:12:58 -05:00
2af3cdf70e
Starter seems to be engaged forever #1965
2020-11-18 20:01:02 -05:00
344423e9ab
Starter seems to be engaged forever #1965
2020-11-18 19:34:09 -05:00
786aaf2e3c
put getTimeNowLowerNt in to mpu_util ( #1950 )
...
* put getTimeNowLowerNt in to mpu_util
* move GPTDEVICE to port_mpu_util
* and remove from efifeatures
2020-11-18 14:17:00 -05:00
80edfe64ce
Fix crc again, for real this time ( #1948 )
...
* re enable
* changelog
* fix
* fix test
* put some tests back
2020-11-15 16:59:02 -05:00
9262c58ea1
occasional tunerstudio CRC errors #1943
...
now with a bit of a unit test
2020-11-15 12:44:53 -05:00
1eb0f8808f
occasional tunerstudio CRC errors #1943
...
unit test progress
2020-11-15 12:36:07 -05:00
05e7792ad4
occasional tunerstudio CRC errors #1943
...
now with a bit of a unit test
2020-11-15 12:27:47 -05:00
53bcd448cf
occasional tunerstudio CRC errors #1943
...
getting ready for unit test
2020-11-15 11:55:26 -05:00
952e019b01
occasional tunerstudio CRC errors #1943
...
getting ready for unit test
2020-11-15 11:53:09 -05:00
605269c358
remove idle thread; just call from periodicSlowCallback ( #1924 )
...
* remove thread
* remove ui
2020-11-11 21:47:19 -05:00
6b0c533d2c
consolidate EFI_UNIT_TEST and friends ( #1940 )
...
* restructure
* guard c++
* idle too
* status_loop.h
* consolidate definitions
* use 1/0 instead, check for existence
* missed a few
* dead define
* defs for bootloader
2020-11-11 20:34:39 -05:00
74d2af9c6c
Move all DECLARE_ENGINE_PTR etc to one place ( #1937 )
...
* restructure
* guard c++
* idle too
* status_loop.h
2020-11-11 19:06:04 -05:00
0fa06e2e2a
compensate injector flow based on fuel pressure ( #1931 )
...
* injector compensation
* fix
* ui
* testability & comments
* hella testing
* debug channels
* enum value
* auto generated enums
* update comment
* oops too much
* update config fields
* handle failed pressure sensor
* build
* fix
* add some todos for the future
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-11-10 23:11:22 -05:00
14fffa5136
refactoring
2020-11-05 18:10:44 -05:00
789926a61d
convert cranking defaults to mg ( #1921 )
...
* convert cranking defaults to mg
* fix tests
2020-11-03 14:12:26 -05:00
bcabb51222
unused tach field ( #1918 )
2020-10-29 15:26:01 -04:00
b8c2041467
Everything in lambda! ( #1893 )
...
* lambda
* default configs, fix build
* config, gauge, UI
* more digits
* change menu text
* fix that while I'm here
* doesn't need extra word
* todo note
* tests
* last test
* missed a config
* update java
* store target lambda
* more java
* format
* hopefully enough java for CI to pass
2020-10-26 18:15:17 -04:00
6abc80e74c
convert mass -> duration later in the pipeline ( #1906 )
...
* cranking duration to mass
* implement
* units
* patch types
* suppress warning
* fix output channels
* add note about how to set it
2020-10-26 07:23:13 -04:00
5189e0b1d9
fix double deadtime ( #1904 )
...
* move global correction factor to fuel mass
* tests
* the fix
2020-10-25 00:12:05 -04:00
5296de1493
use fuel model ( #1901 )
...
* use fuel model
* spit'n'polish
2020-10-23 20:25:47 -04:00
4d1c331eca
second PID config for wastegate ( #1889 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
* consume
* add cfg field
* ui maybe
* fix
* fix
* add wastegate config test
2020-10-19 08:04:27 -04:00
5337d9f723
Etb wastegate hookup ( #1888 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
2020-10-18 21:57:04 -04:00
2c23085715
Etb function cfg: actually read config ( #1884 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-18 17:26:38 -04:00
54c3d0f15c
HW CI has failed 11 times since Oct 2 #1849
2020-10-16 13:54:12 -04:00
02c47eeec8
write SD header using new Writer class ( #1882 )
...
* write header
* hooray, free memory!
* fix test
* is there really this much free space...?
* no, there is not
2020-10-15 16:00:13 -04:00
94bd5921c5
simplify getTimeNowNt() ( #1876 )
...
* remove old impl
* add cpp wrapper to os_access
* clean up os_access
* remove touchTimeCounter
* new impl
* put comment about lock free impl
* include cpp wrappers for BL
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-10-15 08:57:13 -04:00
abfa17216b
etb function config 1 ( #1881 )
...
* this should all be safe...
* test fix
2020-10-14 22:02:09 -04:00
554304dac3
switch to single precision constants ( #1880 )
...
* adjust builds
* fix test
2020-10-14 20:04:35 -04:00
c5291888d0
buffered writer - progress on #1463 ( #1875 )
...
* add buffered writer
* rename
2020-10-12 15:10:34 -04:00
53c001d541
revering functional part of
...
Etb function cfg, try again #1860
try again from #1831
2020-10-08 17:09:00 -04:00
cca175c6ea
Etb function cfg, try again ( #1860 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-08 14:12:03 -04:00
22a55ce7e6
switch from float to expected<float> ( #1862 )
2020-10-06 22:33:00 -04:00
7b333e60ea
FSIO refactoring ( #1861 )
...
* better fsio tests
* condense operators
* minor parser cleanup too
* comments, too!
2020-10-06 21:54:49 -04:00
060cfbd778
const ref-ify trigger ( #1856 )
...
* const ref-ify
* tests
2020-10-05 14:22:59 -04:00
540fca8cc9
use expected for event queue next event ( #1859 )
...
* use expected for event queue next event
* minor cleanup
* tests
2020-10-05 13:53:34 -04:00
aee984d0c2
HW CI has failed 11 times since Oct 2 #1849
...
Revert "ETB function config (#1831 )"
This reverts commit fd7dae8a
2020-10-03 22:00:00 -04:00
fd7dae8ab8
ETB function config ( #1831 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-02 20:51:02 -04:00
b79c0fefe5
replace ETB index with function enum ( #1807 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
2020-09-28 16:33:07 -04:00
3b9d339db0
unit test for start/stop hardware and pin repository #1811
2020-09-21 12:29:01 -04:00
f92d894d14
nicer parameter name
2020-09-21 08:57:56 -04:00
0b301fb454
unit test for start/stop hardware and pin repository #1811
2020-09-21 08:57:37 -04:00
96d3af18f4
unit test for start/stop hardware and pin repository #1811
2020-09-21 05:02:35 -04:00
4a1b1b6bad
fix closed loop fuel ( #1797 )
...
* fix
* add a test
* signature
2020-09-19 03:44:01 -04:00
85304392dd
two throttles one thread ( #1806 )
...
* two throttles one thread
* look at all this RAM!
2020-09-18 13:47:49 -04:00
36234961c1
logging simplification: switch bare functions to member functions: try the second ( #1794 )
...
* first pass
* first pass
* const means we don't have to check!
* static
* test fixup
* fix sniffer
2020-09-13 11:49:25 +03:00
ead14bd1ca
Revert "logging simplification: switch bare functions to member functions ( #1788 )"
...
This reverts commit 39280fb2
2020-09-12 04:36:24 -04:00
39280fb2c6
logging simplification: switch bare functions to member functions ( #1788 )
...
* first pass
* first pass
* const means we don't have to check!
* static
* test fixup
2020-09-12 03:08:11 +03:00
e8e2cf2cfd
DebounceButton A/C switch ( #1782 )
...
* change acSwitch name, add mode
* fix
* remove some adc stuff
* remove some adc stuff
* semicolon stupid
* left behind
* add readpinstate
* wrong var name
* add functions back
* fix name
* bool, not void, plus fix name
* move
* not sure what I broke
* try setMockValue
* namespace
* whoops missed one
* switch values because adc was set up for pullup
* try 5
* comment for now
* comment for now
* uncomment tests, add function to mock, add mock to efiReadPin
* fixes
* for F's sake
* if
* add defy
* pass params
* use ASSERT_TRUE/FALSE
* advance time
* remove ifdef from readPin
* try moving if
* move to separate func
* move extern
* move include
* try engine_test_helper
* am confuse
* move func to else
* include hal
* add efi prod check
* remove include
* try extern
* move include
* semicolon stupid
* move extern again
* include
* move mockPinStates
* size
* add if
* add comment
* clean on instantiation
2020-09-10 22:16:20 -04:00
8079e5f292
scale tables using type system ( #1776 )
...
* store scale in the type
* efi ratio
* boost control scaling
* fix boost tests
2020-09-10 18:44:10 -04:00
eb2bc3201c
Selectable AFR axis override ( #1771 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
* impl
* unhide option
* fix
* tests
2020-09-08 17:15:18 -04:00
8adfef930f
Selectable VE axis override ( #1769 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
2020-09-07 10:15:42 -04:00
a3db817f6e
Move ve logic ( #1762 )
...
* move ve
* fix build
* fix rendering
* duh
* cleaning
* correct scaling
* put some back
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-09-06 19:06:32 -04:00
fc02c2bdf4
fix broken master, inject engine ptr to rpmcalculator ( #1759 )
...
* fix
* oops
2020-09-05 18:49:42 -04:00
be49f46057
less hacky testing implementation
2020-09-03 22:52:29 -04:00
c476cd3b95
refactoring
2020-09-03 19:29:15 -04:00
bad69c812e
move lambda in to sensor model ( #1736 )
...
* lambda sens
* fix init
* fix
* a test for good measure
* he's climbin in your windows, snatchin you ram up
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-09-01 16:22:31 -04:00
286768477c
this does not go as planned :(
2020-08-31 08:02:29 -04:00
81db997be8
this does not go as planned :(
2020-08-31 07:54:45 -04:00
24f12d2993
dead
2020-08-29 09:39:52 -04:00
7d53f5859d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
4e333dac1c
VVT support for VAG trigger #883
2020-08-24 02:07:58 -04:00
bdbee0d38b
VVT support for VAG trigger #883
2020-08-24 02:01:50 -04:00
0f9e8bf83e
VVT support for VAG trigger #883
2020-08-24 01:21:42 -04:00
d0705f14ee
Allow negative VVT position feedback #1713
2020-08-23 11:49:46 -04:00
f5036a9f84
Add injector model class ( #1687 )
...
* stub injector model
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-17 05:22:25 -04:00
581fe1808f
tests
2020-08-10 22:11:25 -07:00
4ac3ded498
consume
2020-08-10 21:41:03 -07:00
ae606a6380
trigger and VSS hw integrated testing #1668
2020-08-08 12:03:24 -04:00
0ebe7ba059
TS SD integration #1653
2020-08-06 22:05:26 -04:00
63acb583c3
testHysteresisSelf
2020-08-04 17:59:31 -04:00
ca8083f4d1
these were testing nothing
2020-08-03 12:22:00 -07:00
81a6a30ed5
The Big Refactoring of 2019: folder structure #723
2020-08-02 20:55:27 -04:00
85758dea6e
The Big Refactoring of 2019: folder structure #723
2020-08-02 20:52:31 -04:00
9a33e922af
The Big Refactoring of 2019: folder structure #723
2020-08-02 20:46:40 -04:00
2572809535
don't rely on periodicFastCallback
2020-07-31 22:09:23 -07:00
1f85c023a8
this test should have never called setTestBug299
2020-07-31 19:08:18 -07:00
fb48a3487d
relax a little
2020-07-31 19:02:48 -07:00
7009c82993
Merge remote-tracking branch 'upstream/master' into remove-plain-maf
2020-07-31 14:56:29 -07:00
2eca162a8a
expose the problem
2020-07-31 14:41:29 -07:00
f502be0d8b
mock airmass
2020-07-31 12:44:22 -07:00
40047327c5
remove getBaseTableFuel test
2020-07-31 12:43:56 -07:00
eabdd9f458
cleanup
2020-07-30 21:20:10 -07:00
6b2c1d4d59
NA6 progress
2020-07-29 22:48:41 -04:00
40c2fb8047
test cleanup
2020-07-28 14:42:02 -07:00
eea3f2cf36
fix tests
2020-07-28 14:27:34 -07:00
a3c0942e1a
eth adjustments
2020-07-28 14:18:50 -07:00
a29de6950b
fixing
2020-07-28 12:11:56 -07:00
c00621756d
fixes
2020-07-28 11:56:39 -07:00
7a479fa44f
put mock in enginetesthelper
2020-07-26 20:39:42 -07:00
061ae726ec
add mock
2020-07-26 20:35:36 -07:00
dfd646cbf5
Weird VAG: DC motor idle valve not ETB #1637
...
ok, that's the current reality
2020-07-26 12:30:50 -04:00
07df0c78a8
Weird VAG: DC motor idle valve not ETB
...
#1637
Seattle we might have a problem!
2020-07-26 12:03:36 -04:00
0302be40ed
Weird VAG: DC motor idle valve not ETB #1637
2020-07-26 10:54:51 -04:00
985ddef559
mocks
2020-07-26 03:18:26 -07:00
7bf98384bf
add tests for VW mode
2020-07-26 03:11:56 -07:00
0828146ccc
tests & cleanup
2020-07-25 02:00:24 -07:00
07ce0ae1b2
Merge pull request #1634 from mck1117/refactor-inj
...
move injector logic in to its own file
2020-07-24 22:47:39 -04:00
d19e2b2499
refacto
2020-07-24 18:26:24 -07:00
aeb5c8e8d6
improve test
2020-07-23 01:24:02 -07:00
7940b84778
start refactor
2020-07-22 13:11:07 -07:00
2e58d92fdb
Merge pull request #1606 from mck1117/reset-overlap
...
reset overlap counter on fuel reschedule
2020-07-20 23:51:34 -04:00
c0ea3f19b7
make private
2020-07-20 18:50:48 -07:00
faf9279402
Merge remote-tracking branch 'upstream/master' into export-all-logicdata
2020-07-20 18:48:54 -07:00
b40114f34f
test with fix
2020-07-20 18:47:08 -07:00
572c347ad7
compensate for bug
2020-07-20 13:21:15 -07:00
5c4e22fd16
auto export all logicdata
2020-07-20 13:12:21 -07:00
57de48ad59
impruv
2020-07-20 12:40:23 -07:00
c1a1f384bb
Merge remote-tracking branch 'origin/master'
2020-07-20 14:25:47 -04:00
a6706b7d26
unit test framework improvements for smoother event execution
2020-07-20 14:25:32 -04:00
7d3876148b
Merge pull request #1622 from mck1117/encapsulate-wwae
...
put wall wetting inside InjectionEvent
2020-07-20 14:19:57 -04:00
bac27ea8ea
Merge remote-tracking branch 'upstream/master' into test-1592
2020-07-20 10:54:18 -07:00
097ca21626
better unit test logging
2020-07-20 13:38:33 -04:00
117e98b753
unit test framework improvements for smoother event execution
2020-07-20 12:45:26 -04:00
c4885dcc0e
unit test framework improvements for smoother event execution
2020-07-20 11:16:51 -04:00
8282bb127d
test
2020-07-20 03:29:43 -07:00
b38c2e3863
put wall wetting inside
2020-07-20 00:04:05 -07:00
e2c8e97aa0
logicdata into unit tests
2020-07-20 00:36:10 -04:00
5b75acdaf5
logicdata into unit tests
2020-07-19 22:41:34 -04:00
f940f1458f
filename parameter
2020-07-19 21:30:49 -04:00
ac7166fce1
OMG it works!
2020-07-19 21:27:28 -04:00
ef3de11be0
first bugfixes
2020-07-19 20:47:58 -04:00
e0bf2eb909
fix ( #1620 )
2020-07-19 18:05:31 -04:00
80ac91662e
let's add .logicdata for unit tests
2020-07-19 17:42:11 -04:00
4535730652
let's add .logicdata for unit tests
2020-07-19 16:13:55 -04:00
e2c62b8ab3
better unit test logging
2020-07-19 15:47:21 -04:00
1ae3334980
better unit test logging
2020-07-19 14:26:28 -04:00
5245cb1978
unit tests: order of tests multispark/sensor tests should not matter #1616
...
TODO
2020-07-19 14:10:55 -04:00
09684963a1
would this work?
2020-07-19 13:59:55 -04:00
9c22ca7202
Injectors #1 and #5 stick open #1592
...
two bytes of progress
2020-07-19 13:54:47 -04:00
e9c5d5be7e
would this work?
2020-07-19 13:50:43 -04:00
8c520758d6
would this work?
2020-07-19 13:45:42 -04:00
934300465a
would this work?
2020-07-19 13:33:02 -04:00
eaff13ea1f
Injectors #1 and #5 stick open #1592
...
two bytes of progress
2020-07-19 13:32:17 -04:00
18efd1609b
one step backwards to help build?
2020-07-19 13:26:46 -04:00
5406a60e49
Injectors #1 and #5 stick open #1592
...
starting somewhere
2020-07-19 13:13:25 -04:00
ec29fd9ca0
better folder structure
2020-07-19 12:57:05 -04:00
a79153bbea
correct batch fuel cylinder pairing ( #1595 )
...
* correct batch fuel cylinder pairing
* param
* only change behavior on two wire batch
* Add tests for two wire batch & sequential
* improve testing a little bit
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-13 14:46:55 -04:00
93f85b0b93
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 18:25:48 -04:00
2b32bc8c16
PidIndustrial does not limit iTerm fix #1599
2020-07-11 15:30:40 -04:00
2a45055289
PidIndustrial does not limit iTerm #1599
...
confirming issue with a unit test
2020-07-11 15:19:27 -04:00
a2078e9cfe
Switch to Bash ( #1585 )
...
* switch firmware to bash
* switch unit_testts to bash
* switch jenkins to bash
2020-07-09 10:27:20 -04:00
d4d5a699f0
Use github actions to build and upload bundles ( #1583 )
...
* add env var to skip upload
* remove checking from compile.bat
* working on push.yaml
* finish sorting
* progress
* rename push to builds
* rename push to builds
* Add skip upload env var
* fix pull_request name
* fixed typo and changed name
* fixed indentation and runs-on
* try different env var setup
* add nucleos and switch to underscore
* add quotes
* remove boards that were commented
* remove boards that were commented
* fix project board name
* fixed variable name
* add ini-file and console-settings
* try installing gcc-multilib first
* Install g++-multilib as well
* remove unnecessary export
* fixed exit numbers
* change to different env setup
* add simulator and console compilation to board bundles
* changed OS and added linux simulator build
* add checkout and missing colon
* add gcc-multilib installes
* Install mingw
* fixed install
* remove mingw from linux sim and call compile directly
* change directory
* moved envs to command
* debug ls
* debug ls
* set ftp vars
* add makefile debug info
* removed batchecks
* redirect stdout to easier see orrs
* change name
* remove redirect, add file inpection
* Add conditional project name
* Try software upgrade
* missing char
* update ine files
* try quotes
* add escapes
* add quotes
* add escapes and quotes
* remove quotes and escapes
* remove software upgrade
* ignore test 2
* update apt
* like this then
* forgot import
* fix case
* remove RUSEFI_SKIP_UPLOAD and check RUSEFI_FTP_SERVER instead
* break workflow back apart
* upload simulator artifact
* fixed operator
* update apt
* change paths
* Update build-firmware.yaml
* move update bundle to artifacts
* fix var name
* Install ncftp
* set env vars conditionally
* remove check so zips are created
* try things the github way and copy to primary
* re-enable test
* missing space
2020-07-08 11:10:24 -04:00
8bcd46291f
migrate amazing idle from FSIO to less opaque TS #1581
2020-07-08 01:12:08 -04:00
bd39351055
idle_min through FSIO not working as intended #1553
2020-07-04 22:01:12 -04:00
c1752327da
FATAL error: lsize mismatch 336/3342 #884
2020-07-04 09:39:16 -04:00
49d98e3ed0
FATAL error: lsize mismatch 336/3342 #884
2020-07-03 21:38:56 -04:00
8b84243dae
Gen config refactor 2 ( #1560 )
...
* gen_config refactor, part II
* short board defines
* oops
* comment & undef
* define QUOTE
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2020-07-02 12:33:31 -04:00
21c35874a5
idle_min through FSIO not working as intended #1553
2020-07-01 20:45:37 -04:00
8a7220d989
Convert jenkins build_extra_bundles scripts to sh ( #1554 )
...
* Add checkout
* remove empty with statement
* Actually we do need push depth
* convert build_working_folder
* convert prepare_bundle
* fixed extension
* fixed closing bracket
* fixed comparison and assignments
* no comment
* convert compile_and_upload and clean
* convert build_simulator
* Finish converting build_working_folder
* convert build_java_console
* Add hashbangs
* remove findcyg instruction
* changed paths
* remove call
* add path
* fixed script names
* add prams
* fix cd
* convert clean_env_variables
* convert common_make.sh
* Added linux hex2dfu binary
* add file extension to linux hex2dfu
* add file extension to linux hex2dfu
* remove spurious paren
* fixed board name
* convert compile-frankenso-na6
* convert compile-frankenso-pal
* add hashbang
* convert compile-kinetis
* convert compile-mre-f4
* convert compile-mre-f4-hardware-QC-special-build
* convert compile-mre-f4-slave
* convert compile-mre-f7
* convert compile-mre-f7-test
* switch to underscores
* converting boards to sh
* convert prometheus
* convert proteus
* fixed path
* switch to underscores
* chmod and add extension
* add quotes
* Add check for Windows
* Add chmod
* fix script name
* fix error checking
* quote vars
* remove checking from batch shims
* fix typo
* change error checking to support nix style error codes
* switch to 1 retval
* cd back to firmware
* Add escapes
* change from cd to rel path
* add p flags to mkdir
Co-authored-by: David Holdeman <David Holdeman>
2020-07-01 14:09:01 -04:00
acafff9390
Merge remote-tracking branch 'origin/master'
2020-06-18 23:14:47 -04:00
1fd0182d07
convert unit_tests/compile ( #1517 )
2020-06-18 23:14:05 -04:00
7f3ce36065
1 byte issue in TuneReadWriteTest #1512
2020-06-18 22:51:07 -04:00
f80f3aa6d6
Remove run_gcov ( #1513 )
...
* remove run_gcov and call ci_gcov from run_clean_gcov
* explicitly call bash
2020-06-18 17:44:57 -04:00
aba153b814
simplify cranking corrections ( #1510 )
2020-06-18 08:54:02 -04:00
531f1c63c7
fuel math simplifications ( #1485 )
...
* simplify
* fix
* tweak
* cleaning
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-17 17:15:04 -04:00
546344c78a
nope, unit tests did not just fix themselves
2020-06-17 08:42:37 -04:00
c46a6e5c0e
only setup etb if primary sensor configured instead of proxy ( #1489 )
...
* only setup etb if primary sensor configured instead of proxy
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-16 21:38:09 -04:00
96e9ab5712
Moved secrets check to before running coverage ( #1501 )
2020-06-16 18:55:18 -04:00
5a90d73ec0
docs
2020-06-16 18:25:41 -04:00
74664a3e2c
Move gcov to Github Actions ( #1500 )
...
* Add gcov generation
* Install missing software
* Change working directory
* typo
* Added echo statements
* Enquote args
* add test for args
* add error message
* replace return with exit
* added extra line returns
2020-06-16 17:39:50 -04:00
160d8d7462
Trigger decoding issues (60-2) #1488
...
unit test refactoring
2020-06-15 00:11:02 -04:00
db29a3523a
Fix gppwm properly ( #1487 )
...
* directly control output in onoff mode
* test fixing
2020-06-11 20:43:26 -04:00
2525a9a22c
Factor out airmass logic ( #1483 )
...
* refactor
* extract more airmass
* rename, fix tests
2020-06-06 07:25:19 -04:00
9ecb0a4e55
refactor ( #1481 )
2020-06-03 21:12:12 -04:00
c95ed26d89
Remove old thermistor implementation ( #1458 )
...
* remove test clt/iat
* remove warning since this code is nearly dead
* remove old therm impl
* tests & live doc
* not quite right
2020-05-28 17:51:33 -04:00
38cb254de3
remove maf2map mode ( #1474 )
...
* remove
* remove fully
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-28 14:06:18 -04:00
0ccde6f937
Makefile clean-up
2020-05-25 13:42:55 -04:00
45e03262d0
Redundant accelerator pedal ( #1470 )
...
* add second boudns
* init logic
* test changes
* reconfigure correctly
* rams
2020-05-23 19:48:32 -04:00
a2313a853c
switch some firmware warnings to errors ( #1465 )
...
* warnings as errors
* throw instead of exit
* test massaging
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
bb6cd1326c
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:54:40 -04:00
f47f5089ba
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:49:56 -04:00
93a3379fce
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:42:09 -04:00
60bfb2d789
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:38:55 -04:00
b1bafea05b
Merge remote-tracking branch 'origin/master'
2020-05-20 03:17:13 -04:00
c5bba14da5
remove test clt/iat ( #1457 )
...
* remove test clt/iat
* remove warning since this code is nearly dead
2020-05-20 03:16:01 -04:00
9790dbbcb0
docs
2020-05-20 03:12:23 -04:00
ce2beafb5f
Redundant tps ( #1427 )
...
* add redundant sensor
* add tests
* add configure, info printing
* tests
* tests
* partial hookup
* fix
* fix
* bad makefile merge
* use second TPS config
* update test
* update test
* sensor names
* set second pin by default
* fix auto cal
* auto cal both sensors
* add reconfigure of secondary sensors
* gobblin' up your ram
* slow down write a little bit
* put split in debug gauge
* s
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-18 14:32:00 -04:00
e6e48ce66c
binary logging ( #1443 )
...
* field support
* tests
* makefiles
* test data too
* missing include dir
* write correct thing
* fix one test
* fix test
* omnomnomnom ram
* format
* use defined names
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-17 15:56:37 -04:00
8253f5b931
better VVT progress
2020-05-15 21:33:25 -04:00
2878461d25
VVT_INACTIVE
2020-05-14 23:31:01 -04:00
7a41df6153
Fix 100% duty injection ( #1431 )
...
* skip turn-off for high duty
* mock executor injection
* test
* switch to hard cut
* test no longer relevant
2020-05-14 07:44:32 -04:00
2db29c7824
34-2 3 cam Toyota wheel progress
2020-05-10 18:03:11 -04:00
b6f6d28ed4
removing some unneeded flexibility
2020-05-10 02:06:15 -04:00
bfe3b2c5fb
34-2 3 cam Toyota wheel progress
2020-05-10 01:21:54 -04:00
e4cfc39b68
docs & clean-up
2020-05-10 00:59:32 -04:00
424a86be7b
short term fuel trim: part 2 ( #1405 )
...
* add tooltip
* add other direction to deadband
* add impl
* test partitioning
* makefile
* wrong comment
* fix include
2020-05-07 08:52:32 -04:00
55159cae44
short term fuel trim: part 1 ( #1402 )
...
* add cell
* add stft cell tests
* add bit
* minimally generate
* config defaults
2020-05-06 21:00:40 -04:00
6f3736f246
Rewrite boost control in new closed loop framework ( #1342 )
...
* rewrite boost
* test
* fix build
* tests
* open loop test
* test closed loop
* fix names
* typo
* tests
* mock boost setOutput
* needs more virtual
* fix boost logic
* switch to TPS based open loop
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-06 08:40:42 -04:00
573d6d2d55
pull out std air charge math ( #1397 )
2020-05-05 08:01:40 -04:00
9353ef7d51
better state messages
2020-05-01 18:52:06 -04:00
fefafd61b8
TPS Auto Calibration with ETB ( #1382 )
...
* switch to thread
* actually use default frequency define
* crank ADC too
* make space in RAM
* remove TS field
* this should work for test
* auto cal
* wire up bench testing
* s
* fix
* rearrange a bit
* inject
* remove unused bit
* mock repair
* guard for ECUs without ETB
2020-04-28 19:31:41 -04:00
dee2568fd5
Minor ETB improvements ( #1381 )
...
* fix pid reset and pedal failure
* pause control later
* test pauseEtbControl
* update tooltip + field name
* update test
2020-04-28 16:52:40 -04:00
7e067eb0b5
Move ETB control to a thread ( #1374 )
...
* switch to thread
* actually use default frequency define
* crank ADC too
* make space in RAM
* remove TS field
* this should work for test
* fix dt
* re-resize ram
2020-04-28 07:22:31 -04:00
d84f194ab7
fixing build
2020-04-26 20:40:06 -04:00
738e53442d
General purpose PWM: implementation & tests ( #1366 )
...
* config
* significant digits
* renumber enum, no need for a "none"
* ui
* impl base
* error handle MAP
* init & update
* don't need arg
* don't lie about sensor
* fix test build
* test stub
* initialize
* null check
* fix clamping
* test output
* types & enums
* don't need param
* test getOutput
* fix
* output pin instead of brain pin
* default config
2020-04-26 14:06:28 -04:00
c9ca028c9c
etb CL test ( #1361 )
2020-04-24 17:54:03 -04:00
b1741bdd6e
Improve ETB idle control ( #1319 )
...
* compress idle pos
* fix tests for new behavior
2020-04-20 17:29:03 -04:00
ce08650f65
Inject idle to ETB ( #1335 )
...
* inject idle position
* pointer
* etb idle tests
* extract mocks
* ops
* test negative case too
* don't convert for etb
* guard
2020-04-20 16:26:35 -04:00
3418356b6b
ETB: inject pedal map ( #1334 )
...
* add clampf
* more tests
* public
* missed a mock
* fix output duty clamping
* do it that way
* more
* ah ha!
* test negative too
* clamp pedal
* inject pedal map
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 14:34:45 -04:00
d17afd3a63
ETB testing: output, position clamping ( #1333 )
...
* add clampf
* more tests
* public
* missed a mock
* fix output duty clamping
* do it that way
* more
* ah ha!
* test negative too
* clamp pedal
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 13:52:20 -04:00
bb24782bc2
rewrite etb tests with gmock ( #1330 )
2020-04-19 20:32:41 -04:00
830f03c003
Closed loop controller base & ETB testing ( #1322 )
...
* closed loop controller base
* etb tps test
* closed loop controller tests
* test support
* update gtest
* fix for change
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 17:18:47 -04:00
2f773c314a
TT_RENIX_66_2_2_2
2020-04-19 14:54:02 -04:00
c1a4bd857b
TT_HONDA_K_12_1
2020-04-19 14:23:01 -04:00
f54db83d67
Improve unexpected ( #1323 )
...
* use type instead of value
* fix remaining initializer-list users
* impruv
* last consumer?
* consumer
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 08:37:43 -04:00
363f6d5110
add expected helper class ( #1321 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 01:53:04 -04:00
192a96838f
consistency
2020-04-18 22:46:22 -04:00
89be50fd70
Renix 44-2-2
2020-04-18 22:20:17 -04:00
942403cec2
Fuel/ign correctino on new temp sensors ( #1318 )
...
* corrections
* test
* adv map
* tests
* cleanup
* lcd
* fsio
* unneeded
* more math
* last consumer
* cleanup
* fix kinetis
2020-04-18 18:45:30 -04:00
2535d123b8
CLT consumer: fsio ( #1302 )
...
* idle
* CLT test prep
* idle target
* header
* air interpolate
* ancient comment
* fuel cut
* fuel cut, idle tests
* cleanup
* fsio test help
2020-04-15 16:20:45 -04:00
83592f0dff
New clt consumers part 1 ( #1301 )
...
* idle
* CLT test prep
* idle target
* header
* air interpolate
* ancient comment
* fuel cut
* fuel cut, idle tests
* cleanup
2020-04-15 09:48:17 -04:00
3f4518c324
fixing master
2020-04-14 12:55:39 -04:00
33eb9fd2ec
new attempt at better simulator
2020-04-13 13:12:55 -04:00
afc5f6c99b
fix maf ( #1287 )
2020-04-12 15:52:29 -04:00
24b0c85a9e
fix warnings ( #1282 )
...
* warnings
* don't need to template those
2020-04-12 09:39:14 -04:00
3abd181f6f
CLT/IAT/Aux in the new sensor world ( #1269 )
...
* hook up clt
* init test
* probably fix test
* aux temp
* relax checking
* more significant figures
* remove old aux temp
* hand generate
* claim RAM
* move to ccm
* subscribe
* info printing
* warnings
* raise high voltage failure threshold
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-07 16:07:09 -04:00
c1ab5ca585
smart gpio clean-up
2020-04-06 14:13:29 -04:00
01c87a87ee
Deadband helper & tests ( #1267 )
...
* deadband
* header
* comment
2020-04-06 09:16:26 -04:00
f161a6990a
fix ( #1268 )
2020-04-06 09:00:26 -04:00
95ef31da67
Goodbye, old TPS ( #1266 )
...
* clear out tps
* boost control
* aux valves
* launch, aux valves
* unused field
2020-04-05 19:33:33 -04:00
44bb09d1a4
yet more tps consumers ( #1258 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
* engine load
* ve lookup
* unused
* oops we needed that
* oops needed that too
* mocking
* test mocks
* oops
* helps to use the right sensor
* and cylinder cleanup
* fuel math
* typo
* old tests
* kill dead stuff
* cleanup
* more
* fix
* test
* s
* fix signature
* fix test
* comment
* priming pulse
* remove mock tps
* remove more dead
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-05 09:11:25 -04:00
43d38a6691
TPS Initialization Testing ( #1264 )
...
* test support
* stub for tests
* plumbing so we can test this
* add test
* comments
2020-04-05 09:10:08 -04:00
606a7fff0d
More TPS consumers: VE lookup ( #1256 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
* engine load
* ve lookup
* unused
* oops we needed that
* oops needed that too
* mocking
* test mocks
* oops
* helps to use the right sensor
* and cylinder cleanup
* fuel math
* typo
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-04 08:41:09 -04:00
9a21262cf8
TPS consumers: idle and ignition and obd2 and lcd ( #1254 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-03 19:59:08 -04:00
d16ff88e30
run ETB on new TPS ( #1248 )
...
* run ETB on new TPS
* why did we include all those...?
* init tps for etb test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 21:33:49 -04:00
baa2547da1
E30 M3 Tach output solution #907 ( #1203 )
...
* Update tachometer.cpp
Initial implementation of E30 M3 Tach output solution #907 , unit_test plus debugging next
* tacho unit tests
First successfull unit test for tachometer
* RAM adjustment so it would link
* refactoring tacho, broken!
* starting to make some progress...still fails after a few seconds
* Rework with SW PWM
* Update after code review
* unit_test update
* First working unit_test
* Update .gitignore
* Update engine_controller.cpp
* Update engine_controller.cpp
* Update tachometer.h
* Update test_tacho.cpp
Co-authored-by: rusefi <rusefi@users.noreply.github.com>
2020-04-02 15:20:04 -04:00
cee565f2b1
Add redundant sensor ( #1249 )
...
* add redundant sensor
* add tests
* add configure, info printing
* tests
* tests
* casing
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:55:21 -04:00
7e4f4ca97e
Replace hasPedalPositionSensor ( #1245 )
...
* remove
* add Sensor::hasSensor
* consume in etb
* remove unused state
* don't use it there either
* format
* fix up tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:04:12 -04:00
b40d4d588d
code style
2020-04-01 21:32:21 -04:00
8235d8d765
Fully switch acc pedal to new sensors ( #1212 )
...
* proxy sensor
* header
* idle
* can
* settings
* remove old mocking
* remove old impl
* etb
* oops, gotta actually register it
* fix test
* structured bindings ftw!
* driver intent for stepper
* tear out old
* oops too much
2020-04-01 20:21:03 -04:00
cd41449459
Debuggability in the new sensor world ( #1238 )
...
* rename to avoid conflict
* fix efilib
* add sensor printing
* makefile
* that check was already there
* const
* const
* fix tests
* formatting
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-30 18:29:42 -04:00
b7033bbde9
Finally rename injector_central to bench_test ( #1229 )
...
* bench test rename
* rename consumers
* good lord what are all of these externs doing
* fix tests
2020-03-26 08:03:55 -04:00
b7b67a2a7f
Multispark implementation ( #1192 )
...
* multispark prototype
* only multispark if not cut
* typo
* do some reasonableish math
* consume cfg
* todo
* bad merge
* move math out of engine2.cpp
* engine state config
* consume generated
* use new
* hand generate
* doc, debugging
* debug channel names
* don't depend on rpmcalc
* safer, fix math
* tests
* default multispark config
* remove todo
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-26 01:49:36 -04:00
aa28127211
random code inspired by Ola
2020-03-24 19:50:04 -04:00
42834ba5ec
launch control #203
...
somewhat questionable code
2020-03-23 23:20:54 -04:00
41443520b8
48 pin documentation
2020-03-21 10:41:25 -04:00
fa8036e4b6
fix ( #1202 )
...
* fix test
* shrink memory
2020-03-19 20:02:49 -04:00
0e8acf6514
CLT stops working when using 2-0 custom trigger wheel #1171
2020-03-06 01:31:04 -05:00
6d8eedf9ca
Split out EtbHardware ( #1168 )
...
* start tear out motor
* fix
* nuke reconfig
* guard for test
* test fixing
* format, condense headers
* fix todos
* undo todo
* format
2020-03-03 17:56:50 -05:00
6db8978667
Add single flag for omitting PnP configs ( #1157 )
...
* switch to single enable flag
* engine_configuration.cpp
2020-02-24 19:08:02 -05:00
923daaa3a1
ETB: expand automated testing #115
2020-02-22 23:18:02 -05:00
2eec300251
miata vvt trigger decoding is broken #1145
2020-02-14 13:02:27 -05:00
67e6812dbb
Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas'
2020-02-14 10:51:26 -05:00
f69bbba6a4
Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas'
2020-02-14 10:50:50 -05:00
eaf28b161b
miata vvt trigger decoding is broken #1145
2020-02-14 10:49:22 -05:00
b4d2ce0ecd
miata vvt trigger decoding is broken #1145
2020-02-14 09:33:29 -05:00
fc33789da7
miata vvt trigger decoding is broken #1145
2020-02-14 00:37:36 -05:00
910a4d6706
cam/vvt decoder
2020-02-05 01:49:33 -05:00
7e86765370
cam/vvt decoder test progress
2020-02-05 01:08:39 -05:00
734963343d
Rescale TPS ( #1112 )
...
* fake adc ticks
* consumers
* fix test 1
* fix tests
2020-02-01 16:41:07 -05:00
3f08833de2
this test is even better now!
2020-01-31 13:45:15 -05:00
f4d36f32fa
VVT refactoring & assertions for VVT test
2020-01-31 01:49:10 -05:00
a124e0b934
date & VVT test progress
2020-01-31 01:23:01 -05:00
5bb778381a
lovely tiny bug which mostly affects NB2 with an impossible one tooth crank trigger wheel
2020-01-30 01:47:34 -05:00
9bd819a18d
extracting class & codes clean-up
2020-01-28 00:16:33 -05:00
ae228dff0e
trigger refactoring
2020-01-26 14:20:55 -05:00
98c6198f1d
reducing code duplication
2020-01-26 06:28:33 -05:00
dfa8d9ccc9
refactoring trigger
2020-01-26 03:33:45 -05:00
a89e20a647
refactoring
2020-01-22 00:40:26 -05:00
a222ecdfe1
happy new year unification
2020-01-13 21:57:43 -05:00
abe1b8c1f3
refactoring: no need to specify parameter manually
2020-01-12 10:43:02 -05:00
0256b0358e
Add timeout + raw value access for sensors ( #1098 )
...
* timeout
* inject stamp
* allow getting raw value
* plumb timeout
* fix tests
2020-01-12 03:25:23 -05:00
67a3796086
better method names
2020-01-10 23:17:58 -05:00
e2841e689d
Require tooth reference time for scheduleByAngle ( #1091 )
...
* injection
* injectors
* add edge timestamp to ShaftPositionListener
* scheduleByAngle require edgeTimestamp
* schedule with nt not us
* oops, these were missing from this branch
2020-01-09 23:45:13 +03:00
cb1039fe23
Inject timestamps in to hwHandleShaftSignal ( #1090 )
...
* injection
* injectors
2020-01-09 21:19:11 +03:00
63e3e84e08
happy new year
2020-01-08 00:02:40 -05:00
3d8c4f4179
Strongly typed action constructor ( #1087 )
...
* strong typing
* maybe we needed that one
2020-01-07 18:10:31 -05:00
6703705a33
Pass action_s instead of callback/param ( #1084 )
...
* change action
* consumers
* fix test
* didn't mean to add those
* simplify
* fix simulator
* fix sim for real
* oy
* maybe this time the simulator will actually be fixed, for real
* don't rely on undefined behavior
2020-01-07 00:41:18 -05:00
4605c64a07
that's not a worth a file
2019-12-24 00:03:53 -05:00
bf5767ccd8
dead code
2019-12-23 23:42:50 -05:00
ae615376ea
refactoring
2019-12-23 23:32:43 -05:00
c629b21ab4
adding simplicity
2019-12-23 23:25:08 -05:00
67e1f06d36
simplicity?
2019-12-23 22:50:04 -05:00
de480fe05e
adding simplicity
2019-12-23 22:30:58 -05:00
2b4b119962
Add new sensor function types ( #1065 )
...
* add functions
* add tests
* add chain tests
* float suffix
2019-12-17 09:06:29 -05:00
95d2875672
this stuff is pretty dead
2019-12-15 21:59:25 -05:00
c12ccb654c
fixing build is my most favourite time!
2019-12-13 18:37:11 -05:00
19ce8b7044
and finally a unit test, like it shoud be!
2019-12-13 14:55:20 -05:00
27f617686b
progress towards ETB controller mocking
2019-12-13 13:52:34 -05:00
f47a1a16d1
getting rid of boardConfiguration / binary compatible change
2019-12-11 17:48:55 -05:00
9f5535721e
clean-up
2019-12-10 01:03:02 -05:00
52c15a7d9b
dual-ETB progress
2019-12-10 00:07:46 -05:00
bcec694eb1
just a trivial massive rename: TriggerState > TriggerWaveform
2019-12-08 01:09:39 -05:00
a5ee6b13d5
Refactor Trigger System #635
...
injecting callback via parameters instead of nasty "bool isInitializingTrigger" field
2019-12-06 01:57:11 -05:00
edabed50f5
Refactor Trigger System #635
...
injecting callback via parameters via magic and potentially broken field manipulation
2019-12-06 01:05:19 -05:00
561986d3e4
The Big Refactoring of 2019: folder structure #723
2019-12-04 01:11:10 -05:00
431a21943b
The Big Refactoring of 2019: folder structure #723
2019-12-03 23:52:44 -05:00
5a299fcd9c
refactoring - updating name according to new reality
2019-12-03 14:39:11 -05:00
5c40bb4628
#490
2019-12-03 00:29:12 -05:00
ccd056d331
EngineTestHelper progress
2019-12-03 00:20:47 -05:00
4861bc24a9
missing override ( #1039 )
2019-12-02 23:52:35 -05:00
079598a87e
reducing complexity
2019-12-02 23:29:06 -05:00
bce4ce71fd
misc clean-up
2019-12-02 13:53:31 -05:00
8326be1d4a
shared GCC settings between projects
2019-12-02 13:53:08 -05:00
d8a10139c2
misc clean-up
2019-12-02 10:18:13 -05:00
5ac023d987
misc clean-up
2019-12-02 10:03:50 -05:00
f9c387b42e
cj125 unit test progress!
2019-12-02 01:52:54 -05:00
7220735530
Starter relay + Hardcoded 'FSIO' + simulator fix ( #1032 )
...
* Starter Relay: gui + built-in FSIO impl.
* Hardcoded 'FSIO' replacement for RAM-limited boards
* fix simulator
2019-11-25 20:08:01 -05:00
e8051c1807
more correct variable names
2019-11-23 23:49:39 -05:00
18bb121cbe
aux valves unit test
2019-11-23 22:55:21 -05:00
07c7219f51
header cleanup
2019-11-23 21:41:17 -05:00
af3118fd42
making progres on angle-based scheduling
2019-11-23 20:36:40 -05:00
f15986b9aa
refactoring
2019-11-23 18:38:16 -05:00
79ada84b56
'triggerEventAngle' not really needed
2019-11-23 17:44:44 -05:00
a31057ec17
explicit list field to simplify code navigation
2019-11-23 17:04:51 -05:00
0a7535fb1f
Use templated array references ( #1027 )
...
* update defs
* consumers, use default params
* setArrayValues in tests
* floats
* test fixing
2019-11-22 23:27:24 -05:00
4cebc85cbf
refactoring
2019-11-20 01:35:08 -05:00
95e8f4227b
making F4 and else happier with perf_trace, also maybe missing 'break'?
2019-11-19 20:36:47 -05:00
f68241bc35
development into unit tests, makefile cleanup
2019-11-19 20:05:12 -05:00
f3c4c8d822
v12
2019-11-18 23:54:08 -05:00
e4d31bafb7
v12 done right
2019-11-17 09:32:12 -05:00
e783f71d53
code formatting
2019-11-17 09:03:20 -05:00
41bdf469b2
#pragma once
2019-11-15 00:00:13 -05:00
9f6549b719
32 bit vs 64 bit compiler challenge for floats in unit tests
2019-11-10 13:57:27 -05:00
add26866f5
Industrial PID Controller ( #1002 )
...
* Implement Industrial PID controller
* Test-Use PidIndustrial in alternator
* Meaningful unit-tests for PidIndustrial
2019-11-10 13:04:27 -05:00
c734cb0fa4
Missing dwell altogether in some corner cases fix #796
2019-11-06 00:31:24 -05:00
4910d37387
Missing dwell altogether in some corner cases #796
...
getting closer!
2019-11-06 00:01:08 -05:00
ef23be6893
Kinetis & TLE8888 compatibility & fixes... ( #991 )
...
* TLE8888: More compatibility & postTunerStudioState
* activeConfiguration & EFI_ACTIVE_CONFIGURATION_IN_FLASH fix
* Kinetis: jump_to_bootloader() impl.
* Kinetis: UART baudrate safety check
* Kinetis: OMG!..
2019-10-31 16:06:34 -04:00
0fcf3bfa4e
refactoring: reducing code duplication
2019-10-21 23:47:40 -04:00
6f3bfcb099
fix wwae ( #980 )
2019-10-17 00:06:54 -04:00
cf20fe4b47
I guess we can simply change the magic number
2019-10-16 23:02:37 -04:00
a7ea155633
preparing for #973
2019-10-16 22:10:38 -04:00
2c24b1b7f7
preparing for #973
...
wall wetting was not covered by any unit test?!
2019-10-16 16:46:34 -04:00
5513e0174b
Coil duty cycle ignores dwell #977
2019-10-15 05:30:38 -04:00
6b2451873a
Coil duty cycle ignores dwell #977
...
test-driven is the way to go
2019-10-15 05:16:30 -04:00
6f8b82e8ed
preparing for #974
...
code comments & refactoring
2019-10-14 18:32:16 -04:00
730aaca3ea
preparing for #974
...
code comments & refactoring
2019-10-14 16:04:28 -04:00
791c1423b0
preparing for #974
...
code comments & refactoring
2019-10-14 09:09:08 -04:00
41919a4fbd
preparing for #974
...
code comments & refactoring
2019-10-14 06:18:08 -04:00
584398d593
sweet unit test hack
2019-10-13 09:59:43 -04:00
c938b0d374
preparation for #961
...
more unified access to pre-calculated value
2019-10-13 09:59:06 -04:00
f776513a5a
preparation for #961
...
macro as a syntax sugar for method invocation
2019-10-10 07:28:52 -04:00
c5f12fbcd9
I got carried away, but DEAD CODE?!
2019-10-08 03:14:21 -04:00
875fb3d1bc
something is over-complicated here? looks like two classes should become one?
2019-10-08 02:56:19 -04:00
415de92543
something is over-complicated here? looks like two classes should become one?
2019-10-08 02:35:21 -04:00
5d6a329c80
wow, dead field
2019-10-08 02:17:32 -04:00
54fe92e534
really not clear what is the best place for these classes
2019-10-08 02:13:52 -04:00
15ae9b1580
fancy C++ s/NULL/nullptr/
2019-10-08 01:26:35 -04:00
7e1e7629ee
refactoring: better field name(s)
2019-10-08 01:03:57 -04:00
46e1ff671a
refactoring: better field name
2019-10-08 00:54:19 -04:00
c9821588e9
One cylinder, 4 stroke, only crank sensor needs special wasted_mode spark control #968
...
just a unit test for now
2019-10-07 23:12:29 -04:00
95d3368b0f
refactoring: all events are now validated in relation to current timestamp
2019-10-07 23:02:47 -04:00
63375dc24c
refactoring
2019-10-07 21:54:03 -04:00
b68ed9f8cb
docs & refactoring
2019-10-07 21:23:38 -04:00
40853e1a3f
fix gm 24x decoder ( #963 )
...
* fix gm
* fix
* fix default config, tests
2019-10-05 08:27:30 -04:00
9b1dc07ae1
Simplify thermistor config ( #962 )
...
* simplify thermistor config
* fix test
2019-10-02 21:00:10 -04:00
52e95a5d68
pid limits / etb limits
2019-09-29 14:56:18 -04:00
eb59a41724
extracting pid test to separate file
2019-09-29 14:36:41 -04:00
b68ed85491
Fix sensor mock spill, again ( #957 )
...
* actually reset
* add test
* doh
2019-09-27 21:40:36 -04:00
Matthew Kennedy
GitHub build-unit-tests Action
rusefillc
Andrey
Andrey G
slowriot
rusefi
David Holdeman
shadowm60
Matthew Kennedy
rusefillc
andreika-git
David Holdeman
rusEfi