Andrey
bbd855d62b
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 04:45:40 -04:00
rusefillc
46e6e621da
reduce chance of invalid CAM setting fix #3105
2021-08-03 22:15:40 -04:00
Matthew Kennedy
4e6b61234f
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy
e3e5e57eac
instant rpm uses full engine cycle ( #3077 )
...
* instant rpm uses full engine cycle
* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
Matthew Kennedy
d3ec2b21d1
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
rusefillc
bc9f85ff31
safer NB2 progress ( #3041 )
...
* safer NB2 progress
* one step back
2021-07-23 16:43:24 -04:00
Andrey
e8aef0dcd3
VVT position of first cam is off on first cycle fix #2987
2021-07-22 01:02:37 -04:00
Andrey
2a07c3df27
Nissan VVT trigger decoder #2887
2021-07-21 23:08:56 -04:00
Matthew Kennedy
3cbd983c93
adjust nb2 vvt sync ( #3019 )
...
* test existing implementation
* nb2 vvt pattern sync
* update test
2021-07-21 20:07:28 -04:00
Andrey
c433c20a36
simplify quad vvt test #3018
...
better parameter name and explicit constraint clarification
2021-07-21 17:45:35 -04:00
Matthew Kennedy
2a4dfd0bf8
Fix prepareEventAngles for symmetrical crank triggers ( #2982 )
...
* fix and make code legible
* update test to check every tooth
* symmetrical crank
* simplify findTriggerPosition
* make getAngle intelligable
2021-07-17 23:27:20 -04:00
Andrey
c9360448cc
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 17:47:32 -04:00
rusefillc
a35e2cbb18
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 02:03:55 -04:00
Andrey
39364ced59
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 01:10:13 -04:00
Andrey
8a9999c87f
refactoring
2021-07-17 00:56:50 -04:00
Andrey
46098135d9
refactoring
2021-07-17 00:53:51 -04:00
Andrey
1a2389b034
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:46:39 -04:00
Andrey
d76132c206
refactoring
2021-07-17 00:46:39 -04:00
Andrey
f69690a36a
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:27:56 -04:00
Matthew Kennedy
e3849b95d5
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
Andrey
64d95dd5aa
trigger signal debug pins - logic level output #2959
2021-07-16 17:18:03 -04:00
Andrey
cbbfce2123
trigger signal debug pins - logic level output #2959
2021-07-16 16:42:26 -04:00
rusefi
c5399a4632
FATAL on NB2 tune jim stim input signal fix #2965
2021-07-14 21:18:05 -04:00
Andrey
d93cece1dc
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:05:53 -04:00
Andrey
47f285c50c
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:03:00 -04:00
Andrey
8814476f8b
trigger signal debug pins - logic level output #2959
2021-07-13 20:33:27 -04:00
Andrey
564c380851
trigger signal debug pins - logic level output #2959
2021-07-13 20:15:55 -04:00
Andrey
b3f33a1249
trigger signal debug pins - logic level output #2959
2021-07-13 18:16:32 -04:00
rusefillc
206bf7adc8
reducing warnings
2021-07-13 14:50:10 -04:00
Matthew Kennedy
ff9c14c239
fix vvt indication ( #2926 )
...
* wrap logic
* rename gauges
* names and ranges
* binary log
* we actually don't need that warning
* values auto wrap
* values auto wrap
* bye warnings
* comparison
2021-07-12 16:29:07 -04:00
Andrey
ab3a862f19
reducing code duplication
2021-07-06 00:09:35 -04:00
Andrey
3759028a32
unit tests pass on Linux fail on Windows fix #2902
...
reducing code duplication
2021-07-05 23:51:13 -04:00
Andrey
8f13e5711a
Nissan VVT trigger decoder #2887
2021-07-05 23:39:39 -04:00
Andrey
bb181ac8fd
Nissan VVT trigger decoder #2887
...
another bug - improper handling of three-times-symmetrical
2021-07-05 23:15:44 -04:00
Andrey
5416dd9906
refactoring - reusing magic constant
2021-07-05 23:07:36 -04:00
Andrey
eceaa1f377
Nissan VVT trigger decoder #2887
...
that looks like one bug
2021-07-05 22:44:20 -04:00
Andrey
7ec3ef4b28
Nissan VVT trigger decoder #2887
...
that's all very strange
2021-07-05 22:17:26 -04:00
Andrey
59e33b3577
restore testQuadCam #2911
2021-07-05 21:04:09 -04:00
rusefi
de750354a2
Nissan progress!!!
2021-07-05 20:29:49 -04:00
Andrey
f8d5e3f51b
Nissan
2021-07-05 18:43:39 -04:00
rusefillc
e223ff4d9e
Nissan
2021-07-05 18:38:34 -04:00
rusefillc
32a813339d
Nissan
2021-07-05 18:37:53 -04:00
Andrey
4c19e22237
Nissan VVT trigger decoder #2887
...
one step back
2021-07-03 12:42:07 -04:00
Andrey
fb7639f347
Nissan VVT trigger decoder #2887
2021-07-03 12:26:31 -04:00
Andrey
e34b04bd46
Nissan VVT trigger decoder #2887
2021-07-03 12:02:00 -04:00
Andrey
2ad22a262b
Nissan VVT trigger decoder #2887
2021-07-03 11:08:22 -04:00
Andrey
9ad5ec8044
refactoring: getShaftSynchronized
2021-07-03 10:37:03 -04:00
Andrey
26fdfb1ab6
Nissan VVT trigger decoder #2887
2021-07-03 10:15:41 -04:00
Andrey
f3ffecbc2b
Nissan VVT trigger decoder #2887
2021-07-03 09:43:27 -04:00
Andrey
cd4842f2b8
Nissan VVT trigger decoder #2887
2021-07-02 20:28:15 -04:00
Andrey
9339f0169d
Nissan progress
2021-07-02 20:12:31 -04:00
Andrey
2911e128d9
Nissan progress
2021-07-02 19:57:26 -04:00
Andrey
7b21e5cf29
wow we have weird code!
2021-07-02 19:49:00 -04:00
Andrey
4e18c2a0ae
todo: vvt
2021-07-02 19:06:07 -04:00
Andrey
1fe9389ede
Nissan VVT trigger decoder #2887
2021-07-01 23:53:53 -04:00
Andrey
11def6d9e3
Nissan VVT trigger decoder #2887
2021-07-01 22:27:43 -04:00
Andrey
fd3aa4ec18
Nissan VVT trigger decoder #2887
2021-07-01 21:48:47 -04:00
Matthew Kennedy
9ae1ada582
Stricter miata sync ( #2891 )
...
* strict mazda trigger shape
* this is an even better gap
* sync point moved so things are different now
* fix
* update instantrpm in test
* s
* s
* this is safer
* test
* tests
* instant rpm
* cleanup
2021-07-01 21:29:04 -04:00
Matthew Kennedy
20937455a0
Fix pre sync timestamp copy ( #2892 )
...
* fix tests
* fix pre sync copy
* this fixes the issue
2021-07-01 18:58:28 -04:00
Andrey
6c7d2700b3
Nissan VVT trigger decoder #2887
2021-07-01 17:28:52 -04:00
Matthew Kennedy
ee6f49e65f
Consolidate hwHandleShaftSignal ( #2875 )
...
* consolidate trigger input
* merge functions
* comment
* dead
* hw vs. not hw
* stray comma
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 10:06:22 -04:00
Andrey
eefba195d0
VW warnings on cranking #2861
...
same resilience for some other triggers
2021-06-27 13:29:09 -04:00
Andrey
8185eb2de3
refactoring maybe making code reuse more possible in the future
2021-06-27 13:00:01 -04:00
Andrey
967f423391
VW warnings on cranking #2861
2021-06-27 12:31:18 -04:00
Andrey
0668bf899e
so many wonderful discoveries
2021-06-27 00:54:38 -04:00
Andrey
083a2e12f9
depressing code comment
2021-06-26 23:01:47 -04:00
Andrey
738b03b63e
refactoring - crankDivider etc etc
2021-06-26 22:42:53 -04:00
Andrey
4627707e1c
refactoring - explicit read method
2021-06-26 22:17:07 -04:00
Andrey
25afc6e67c
refactoring - explicit read method
2021-06-26 22:11:42 -04:00
Andrey
1003056f85
refactoring - explicit read method
2021-06-26 22:07:45 -04:00
Matthew Kennedy
95f9e949a5
fix trigger changed logic ( #2860 )
...
* reenable
* fix
* longer interval between updates
* only deinit hard trigger outputs if necessary
* init logic
* init order
* warning
* guard
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-25 19:38:42 -04:00
rusefillc
f262be8c99
Minor change of Miata NA trigger shape #2855 #669 ( #2856 )
...
* Minor change of Miata NA trigger shape #2855 #669
* Minor change of Miata NA trigger shape #2855 #669
2021-06-25 14:12:18 -04:00
Andrey
bb5500dbb3
Trigger: warning code on normal engine start up #669
...
better TDC unit test approach?
2021-06-25 13:19:16 -04:00
Andrey
8d4b9c4535
Trigger: warning code on normal engine start up #669
...
making more code unit-testable
2021-06-25 12:50:19 -04:00
Andrey
1b968fbcbc
helping build?
2021-06-25 12:28:55 -04:00
Andrey
da2e7101aa
refactoring
2021-06-25 12:01:59 -04:00
Andrey
bd29dedbca
Trigger: warning code on normal engine start up #669
...
making more code unit-testable
2021-06-25 11:50:23 -04:00
Andrey
742935567b
Trigger: warning code on normal engine start up #669
...
making more code unit-testable
2021-06-25 11:30:06 -04:00
Andrey
57094f43cc
refactoring: reducing code duplication
2021-06-25 10:55:46 -04:00
Andrey
f567c764ab
giving unit tests a chance to use tdcMarkCallback
2021-06-25 01:31:53 -04:00
Andrey
1269e7f4ea
Minor change of Miata NA trigger shape #2855 #669
2021-06-24 22:21:30 -04:00
Andrey
4f499dfa82
OMG dead code?!
2021-06-24 22:01:57 -04:00
Andrey
7e0d83d54b
looks like this parameter is very well used now?
2021-06-21 02:12:14 -04:00
Andrey G
64a1c8678a
trigger: subaru 7+6: update cranck angles, add comments ( #2789 )
2021-06-02 19:19:52 +03:00
Andrey G
078b65edd9
Subaru svx ( #2777 )
...
* Revert "hiding 3rd channel for now"
This reverts commit 00c5c786c7
.
* trigger subaru SVX: disable cranck #2 channel
* Board subaru-eg33: fix D10 pin defined twice
* Board subaru-eg33: renumber ignition ouput according cylinder order
* board subaru eg33: use common_make.sh to get dfu files
* board subaru-eg33: update default configuration
2021-05-31 04:25:57 -04:00
Andrey
90177d4db4
SVX
2021-05-30 19:59:13 -04:00
Andrey
00c5c786c7
hiding 3rd channel for now
2021-05-29 04:09:12 -04:00
rusefillc
68d2fdb6ce
https://rusefi.com/forum/viewtopic.php?f=16&t=2027
2021-05-27 05:50:59 -04:00
Andrey
1b0b81ab9d
subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021
2021-05-26 06:07:31 -04:00
Andrey
d993c6522b
subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021
2021-05-26 05:29:41 -04:00
Andrey
0db488b3ef
subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021
2021-05-26 04:46:17 -04:00
Andrey
e4497358f5
Override trigger gaps feature #2734
2021-05-25 17:19:20 -04:00
rusefillc
9a65cb6f7f
Subaru 7+6 trigger refactoring, not changing gap ratio much
2021-05-25 16:31:37 -04:00
Andrey
9865b04bf7
Override trigger gaps feature #2734
2021-05-23 20:52:18 -04:00
Andrey
f74946e790
Override trigger gaps feature #2734
2021-05-23 20:06:19 -04:00
Andrey
765d229efb
Override trigger gaps feature #2734
2021-05-23 19:58:03 -04:00
Andrey
62ecef3e3f
Override trigger gaps feature #2734
2021-05-23 19:51:00 -04:00
David Holdeman
68da5c279e
Doxygen titles ( #2728 )
...
* move addRow call
* undo submo bump
* add header titles
2021-05-22 22:10:58 +03:00
rusefillc
fa4f936869
docs
2021-05-02 23:46:30 -04:00
rusefillc
de72978255
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2021-04-30 01:05:23 -04:00
rusefillc
99059ef846
https://rusefi.com/forum/viewtopic.php?f=16&t=1996
2021-04-25 09:34:40 -04:00
rusefillc
87e0b28cc4
https://rusefi.com/forum/viewtopic.php?f=16&t=1996
2021-04-25 09:18:35 -04:00
rusefillc
060b8b9c87
https://rusefi.com/forum/viewtopic.php?f=2&t=1993
2021-04-24 22:54:50 -04:00
rusefi
7300bbe750
improving QC process
2021-04-23 00:45:36 -04:00
rusefi
be0f2210c5
improving QC process
2021-04-22 21:23:20 -04:00
Matthew Kennedy
b6fc9befc8
finish it off: remove scheduleMsg ( #2575 )
...
* finish it off
* one more logger ptr
* fwd decl
* Revert "one more logger ptr"
This reverts commit a21fb0087ddc748978d716db2710800cf26e437b.
* unused
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 15:33:40 -04:00
Matthew Kennedy
5f0791f9fb
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
Matthew Kennedy
737ee444b8
rip the bandaid: find-replace most of scheduleMsg ( #2572 )
...
* biiiig find replace
* more trivial find replace
* pwm
* almost all of them
* few more
* gpio
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
rusefillc
9c1aa580f1
WOW major scheduling drama on NB2 running with Proteus #2533
2021-04-15 19:12:09 -04:00
rusefillc
f0c98325be
WOW major scheduling drama on NB2 running with Proteus #2533
...
totally same numbers for NB1 just simpler code
2021-04-15 18:44:37 -04:00
rusefillc
6bc7a0e134
WOW major scheduling drama on NB2 running with Proteus #2533
...
removing weird comments
2021-04-15 18:22:23 -04:00
rusefillc
28afbd648b
dead code - same value set by 's->initialize'
2021-04-13 01:11:03 -04:00
rusefillc
80adaadd7a
Kawasaki KX450F trigger wheel #2538
2021-04-13 00:24:52 -04:00
rusefillc
448dafb5f2
https://rusefi.com/forum/viewtopic.php?p=40383
2021-04-11 18:20:35 -04:00
rusefillc
2547283f45
Kawasaki KX450F trigger wheel #2538
2021-04-09 12:44:28 -04:00
rusefillc
06ada8562b
Kawasaki KX450F trigger wheel #2538
2021-04-08 22:16:14 -04:00
rusefillc
ffe845ab1a
CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534
2021-04-08 14:39:26 -04:00
rusefi
3d89cc2093
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 15:17:01 -04:00
rusefillc
c886394947
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 12:16:23 -04:00
rusefillc
9c26a84be9
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 01:21:28 -04:00
rusefillc
a9e822f790
'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528
2021-04-04 23:12:07 -04:00
rusefillc
f8aa71bf63
refactoring
2021-04-04 23:03:51 -04:00
rusefillc
181db048fe
todo?
2021-04-04 22:05:55 -04:00
Andrey G
5fda278503
hip9011: get callback from spark on each cylinder ( #2499 )
...
* hip9011: get callback from spark on each cylinder
* hip9011: cleanup unused
2021-03-27 14:12:49 -04:00
Matthew Kennedy
4e1d30f86d
plumbing for multiple vvt ( #2488 )
...
* plumb multiple vvt
* fix test
* s
* fix barra while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
Matthew Kennedy
db7856523c
barra vvt cam pattern ( #2483 )
...
* barra vvt cam pattern
* two tooth sync
* I think this needs to be here too
2021-03-22 07:48:29 -04:00
Andrey G
aa05ff195d
Hip9011 and cleanups ( #2477 )
...
* hip9011: move hipCs out of EnginePins to hip9011 driver
* hip9011: cleanup debug output, save few RAM bytes
* Supress few signed vs unsigned warnings
2021-03-20 08:40:36 -04:00
Matthew Kennedy
925a6ca086
harden against various no-boot scenarios ( #2468 )
...
* zero length trigger
* validate config
* validate cylinder count
* wrong type on cylinder count
* invalid comment
* invalid SPI
2021-03-17 09:24:13 -04:00
Matthew Kennedy
c168c748ea
dead code, warnings ( #2461 )
2021-03-15 10:23:19 -04:00
Matthew Kennedy
ce3878949c
stop trigger emulator PWM when disabled ( #2443 )
...
* simplify trig emulator
* spelling is hard
* fix various builds
* spelling again
* add command/button for external stimulation
* enable hw stim for HW-in-loop test
* s
* I does spelling good
* clear flag when disabled
* generate enough for console build
* don't disable that
* this test needs external stimulation enabled
* import
* ui improvements
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-11 08:38:52 -05:00
rusefillc
c954803292
TDC Trigger Position #2428
...
any single-tooth primary trigger should automatically run with "useOnlyPrimaryForSync = true;"
2021-03-08 00:00:48 -05:00
rusefillc
1b1bd0065d
removing dead code - initialize() sets 'true' already
2021-03-07 23:37:54 -05:00
Matthew Kennedy
d5bc14719e
trigger decoder timer ( #2427 )
...
* part 2
* stale comment
* include
* why was this a macro
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 16:35:58 -05:00
Matthew Kennedy
abdce83190
virtual zero timer ( #2426 )
...
* virtual zero timer
* it would help to call the correct function
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 15:32:41 -05:00
rusefillc
654a739e6b
M62T vanos support #2243
2021-02-08 22:21:02 -05:00
rusefillc
dc79ee1511
M62T vanos support #2243
2021-02-08 22:07:14 -05:00
rusefillc
8fa1a6530b
M62T vanos support #2243
2021-02-08 21:50:31 -05:00
rusefi
d39b285834
M62T vanos support #2243
2021-02-08 21:28:57 -05:00
rusefi
1012b61e02
M62T vanos support #2243
2021-02-08 20:38:38 -05:00
rusefi
2ccb75a064
refactoring: naming consistency
2021-02-08 18:20:53 -05:00
rusefillc
11e8a35c15
Trigger pattern request Škoda Favorit fix #2302
2021-02-06 20:53:30 -05:00
rusefillc
4dc9c013c9
Trigger pattern request Škoda Favorit #2302
2021-02-06 20:12:58 -05:00
Matthew Kennedy
9b5fa40d16
add option to disable ETB if engine not spinning ( #2280 )
...
* config/ui
* trigger central mods
* implement
2021-02-05 17:19:57 -06:00
rusefillc
2bfac97f93
GM/Daewoo 60/2/2/2 Trigger Pattern #2264
2021-02-02 11:06:32 -05:00
rusefillc
0f49d48a42
GM/Daewoo 60/2/2/2 Trigger Pattern #2264
2021-02-02 09:50:20 -05:00
rusefillc
782ae69cc3
GM/Daewoo 60/2/2/2 Trigger Pattern #2264
2021-02-01 23:44:14 -05:00
rusefillc
6043d6d8f2
GM/Daewoo 60/2/2/2 Trigger Pattern #2264
2021-02-01 23:18:11 -05:00
rusefillc
ce62edb56b
GM/Daewoo 60/2/2/2 Trigger Pattern #2264
2021-02-01 22:49:49 -05:00
rusefillc
7fb7cc6679
extracting runtime state from trigger central
2021-01-31 22:41:17 -05:00
rusefillc
11aa253ae9
vvt/cam events to pass index
2021-01-31 22:24:45 -05:00