clang warnings again #2055

firmware/controllers/algo/engine.h

@@ -52,8 +52,8 @@ class AirmassModelBase;
 #define CYCLE_ALTERNATION 2
 
 class IEtbController;
-class IFuelComputer;
-class IInjectorModel;
+struct IFuelComputer;
+struct IInjectorModel;
 
 class PrimaryTriggerConfiguration final : public TriggerConfiguration {
 public:

firmware/controllers/sensors/sensor.h

@@ -55,7 +55,7 @@
 using SensorResult = expected<float>;
 
 // Fwd declare - nobody outside of Sensor.cpp needs to see inside this type
-struct SensorRegistryEntry;
+class SensorRegistryEntry;
 class Logging;
 
 class Sensor {

firmware/util/os_util.c

@@ -41,20 +41,3 @@ void chVTSetAny(virtual_timer_t *vtp, systime_t time, vtfunc_t vtfunc, void *par
 }
 
 #endif /* EFI_UNIT_TEST */
-
-/**
- * See also getRemainingStack()
- */
-int getMaxUsedStack(uint8_t *ptr, int size) {
-	/**
-	 * maximum used stack size total stack buffer size minus position of first modified byte
-	 */
-#if ! EFI_UNIT_TEST
-	for (int i = 0; i < size; i++) {
-		if (ptr[i] != CH_DBG_STACK_FILL_VALUE) {
-			return size - i;
-		}
-	}
-#endif /* EFI_UNIT_TEST */
-	return 0;
-}

firmware/util/os_util.h

@@ -10,11 +10,6 @@
 
 #include "global.h"
 
-/**
- * @return for a given stack memory region returns how much stack was ever used
- */
-int getMaxUsedStack(uint8_t *ptr, int size);
-
 #if !EFI_UNIT_TEST
 
 #include "histogram.h"