rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HW CI is flaky :( #2063 

more detailed error messages
This commit is contained in:
rusefillc 2020-12-17 20:22:04 -05:00
parent df5b21ceb5
commit ca0f3ba240
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
firmware/controllers/system/efi_gpio.cpp
View File

@ -473,7 +473,11 @@ void OutputPin::initPin(const char *msg, brain_pin_e brainPin, const pin_output_
return;
if (*outputMode > OM_OPENDRAIN_INVERTED) {
firmwareError(CUSTOM_INVALID_MODE_SETTING, "%s invalid pin_output_mode_e", msg);
firmwareError(CUSTOM_INVALID_MODE_SETTING, "%s invalid pin_output_mode_e %d %s",
msg,
*outputMode,
hwPortname(brainPin)
);
return;
}
iomode_t mode = (*outputMode == OM_DEFAULT || *outputMode == OM_INVERTED) ?

8
firmware/hw_layer/pin_repository.cpp
View File

@ -21,6 +21,8 @@
static LoggingWithStorage logger("pin repos");
EXTERN_CONFIG;
static PinRepository pinRepository;
static int brainPin_to_index(brain_pin_e brainPin)
@ -264,7 +266,11 @@ bool brain_pin_markUsed(brain_pin_e brainPin, const char *msg) {
* connected, so the warning is never displayed on the console and that's quite a problem!
*/
// warning(OBD_PCM_Processor_Fault, "brain pin %d req by %s used by %s", brainPin, msg, getBrainUsedPin(index));
firmwareError(CUSTOM_ERR_PIN_ALREADY_USED_1, "Pin \"%s\" required by \"%s\" but is used by \"%s\"", hwPortname(brainPin), msg, getBrainUsedPin(index));
firmwareError(CUSTOM_ERR_PIN_ALREADY_USED_1, "Pin \"%s\" required by \"%s\" but is used by \"%s\" %s",
hwPortname(brainPin),
msg,
getBrainUsedPin(index),
getEngine_type_e(engineConfiguration->engineType));
return true;
}