rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Starter seems to be engaged forever #1965

This commit is contained in:
rusefillc 2020-11-18 20:01:02 -05:00
parent f0d93428e4
commit e29911114a
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
firmware/controllers/actuators/idle_thread.cpp
View File

@ -50,10 +50,6 @@ static Logging *logger;
EXTERN_ENGINE; EXTERN_ENGINE;
#if EFI_UNIT_TEST
Engine *unitTestEngine;
#endif
// todo: move all static vars to engine->engineState.idle? // todo: move all static vars to engine->engineState.idle?
static bool shouldResetPid = false; static bool shouldResetPid = false;
@ -74,7 +70,6 @@ class PidWithOverrides : public PidIndustrial {
public: public:
float getOffset() const override { float getOffset() const override {
#if EFI_UNIT_TEST #if EFI_UNIT_TEST
Engine *engine = unitTestEngine;
EXPAND_Engine; EXPAND_Engine;
#endif #endif
float result = parameters->offset; float result = parameters->offset;
@ -88,7 +83,6 @@ public:
float getMinValue() const override { float getMinValue() const override {
#if EFI_UNIT_TEST #if EFI_UNIT_TEST
Engine *engine = unitTestEngine;
EXPAND_Engine; EXPAND_Engine;
#endif #endif
float result = parameters->minValue; float result = parameters->minValue;

4
unit_tests/tests/test_idle_controller.cpp
View File

@ -19,13 +19,9 @@
extern IdleController idleControllerInstance; extern IdleController idleControllerInstance;
extern int timeNowUs; extern int timeNowUs;
extern Engine *unitTestEngine;
TEST(idle, fsioPidParameters) { TEST(idle, fsioPidParameters) {
WITH_ENGINE_TEST_HELPER(MIATA_NA6_MAP); WITH_ENGINE_TEST_HELPER(MIATA_NA6_MAP);
unitTestEngine = engine;
engineConfiguration->idleRpmPid.offset = 40; engineConfiguration->idleRpmPid.offset = 40;
engineConfiguration->acIdleExtraOffset = 10; engineConfiguration->acIdleExtraOffset = 10;