rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
17,767 Commits 1 Branch 0 Tags 1.2 GiB
Commit Graph

1781 Commits

Author SHA1 Message Date
Matthew Kennedy 0932fcf94c
Improve NA/NB miata sync parameters (#3730) 
* NA sync parameters

* NB vvt pattern too

* zach's car says tighten the gap

* look at that, we sync one cycle sooner!
 2022-01-01 21:39:04 -05:00
Matthew Kennedy 338c14c3a8
cylinder ignition trim (#3709) 
* cylinder ignition trim

* changelog

* changelog

* test

* move UI
 2022-01-01 15:47:47 -05:00
Matthew Kennedy ab3e3ac83f
hook up fuel trims (#3715) 
* hook up fuel trims

* pass all the params

* store per-cylinder fuel mass directly

* main trigger callback only touches per-cylinder, no banks!

* test test test test

* move UI to happy land

* changelog
 2022-01-01 02:19:59 -05:00
Matthew Kennedy d5c4b79b1a
Nb2 crank sync special case (#3727) 
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* custom nb decoder

* test only resyncs once!

* good job valgrind, you found a bug!
 2021-12-31 15:47:25 -05:00
rusefillc f715210b39 GDI Epic #1448 
live view
 2021-12-31 15:28:24 -05:00
Matthew Kennedy b3de217c1b
adjustment to #3722 (#3723) 
* s

* behold, another bug a test caught

* test

* test generates usable trigger pattern so it works correctly

* comment

* don't need that
 2021-12-31 01:21:21 -05:00
Matthew Kennedy 4981eb43d0
extract isSyncPoint function (#3726) 
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* clean up noise from test case

* clarify and comment
 2021-12-30 11:39:04 -05:00
rusefillc 4bc9c39044 E65 2021-12-29 00:50:17 -05:00
Andrey ae5dbd63a4 extract method 2021-12-27 21:09:41 -05:00
Andrey 7322fc345e E65 2021-12-26 14:48:00 -05:00
rusefillc 6665c4fb34 docs 2021-12-26 13:41:10 -05:00
rusefillc b337fed520 live data 2021-12-26 13:00:17 -05:00
rusefillc 561a466cdb E65 2021-12-24 17:35:27 -05:00
Andrey af1259c176 E65 2021-12-24 16:58:12 -05:00
Andrey 97b3212e56 E65 2021-12-24 16:56:17 -05:00
Andrey 1f40be01b9 E65 2021-12-24 16:53:24 -05:00
Andrey 19a8685644 refactoring 2021-12-24 16:51:31 -05:00
Matthew Kennedy a4871c703c
Autoscale all the things! (#3713) 
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio

* throttle, boost, gppwm

* scale ignition and VE

* tests
 2021-12-22 08:09:41 -05:00
Matthew Kennedy dff6d9b2f1
Map3D accepts any scaled_channel type (#3712) 
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio
 2021-12-21 18:52:46 -05:00
Andrey 6b91bacd59 Map3D needs some changes to allow autoscale RPM bin #3707 2021-12-21 16:04:16 -05:00
Matthew Kennedy b6a8bed429
tables support non-integer-scaled scaled_channel (#3708) 
* support dividers

* float

* format
 2021-12-21 00:59:07 -05:00
Matthew Kennedy 3a4a0ba18d
simplify some table lookups (#3692) 
* simplify

* expand interpolation test
 2021-12-20 08:14:30 -05:00
Matthew Kennedy 0810198185
clean up timing table defaults (#3705) 
* less crazy configs

* cleanup

* make that test happy
 2021-12-20 08:02:38 -05:00
rusefillc 47cde8801c 2 byte table axis #3045 2021-12-20 02:07:03 -05:00
Andrey 76768d6ac4 2 byte table axis #3045 
fixing build
 2021-12-20 01:50:23 -05:00
Andrey 76088f686f are we missing something? 2021-12-19 23:57:36 -05:00
rusefillc 66f82a0cdb 2 byte table axis #3045 2021-12-19 22:43:10 -05:00
Matthew Kennedy cddb9484a9
make macos happy (#3699) 
* s

* explicitly include it because that's a good idea.
 2021-12-19 09:58:49 -05:00
Andrey 951cea4471 ISO-TP accounting for new buffer size 2021-12-19 01:10:13 -05:00
rusefillc 907499416b is that all it needs? 2021-12-19 00:54:20 -05:00
Andrey d7e25028a0 PCAN sandbox - error requestOutputChannels fix #3698 2021-12-19 00:29:30 -05:00
Andrey 1dbcaaa6a4 TS via TCP connector and ISO-TP via PCAN #3667 2021-12-18 21:46:49 -05:00
GitHub build-unit-tests Action 01a89a5e2f Trigger wheel definitions 2021-12-17 03:17:55 +00:00
rusefillc 4292c2fb1d MAP phase sensing fix #3544 
removing dead implementation
 2021-12-16 21:28:27 -05:00
rusefillc 06ccf524dd MAP phase sensing #3544 
removing dead implementation
 2021-12-16 21:13:55 -05:00
Andrey 8d7452e5d1 Lua to read tsOutputs #3376 
unit test fix
 2021-12-15 09:23:06 -05:00
rusefillc ced403f7ee Lua to read tsOutputs #3376 
let's break master!
 2021-12-15 08:56:59 -05:00
rusefillc 5bdf25c3f8 Lua to read tsOutputs #3376 2021-12-14 23:16:05 -05:00
GitHub build-unit-tests Action 8ee2f49966 Trigger wheel definitions 2021-12-15 02:30:21 +00:00
Matthew Kennedy 256df56fa7
Honda K 12+1 decoder adjustment (#3694) 
* adjust trigger

* real cranking

* mk
 2021-12-14 21:10:01 -05:00
GitHub build-unit-tests Action 47a55eaa91 Trigger wheel definitions 2021-12-14 00:05:57 +00:00
Matthew Kennedy 6de8364895
maybe more working MAP sampling (#3689) 
* what if we do this

* cleanup

* s

* test
 2021-12-11 03:01:28 -04:00
Andrey 9ae24735f8 MAP phase sensing #3544 2021-12-10 17:28:03 -05:00
Andreika 6be915f7af
can_isotp fix? (#3678) 
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
 2021-12-08 18:12:51 -05:00
Matthew Kennedy 4148ee76bf
smarter priming logic (#3674) 
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* config & UI

* dead config

* implementation

* look, the test caught a bug

* keep the watchdog happy

* bad merge

* changelog

* easier to read the test

* test naming
 2021-12-08 16:20:19 -05:00
rusefillc f1855a41ae docs 2021-12-08 16:05:57 -05:00
Andreika 72cefd42de
CAN ISO-TP progress (+unit-tests fix) (#3677) 
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
 2021-12-08 15:11:19 -05:00
rusefillc 3a33e59b86 rusEFI console ISO-TP via PCAN #3667 2021-12-08 12:01:28 -05:00
rusefillc f104e4cc2f rusEFI console ISO-TP via PCAN #3667 2021-12-08 11:55:34 -05:00
Matthew Kennedy 2050580a16
prime upon ignition voltage, not on power on (#3662) 
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* test

* dead adjacent line of code
 2021-12-08 07:26:49 -05:00
Matthew Kennedy 91ec135cf8
ignition controller detects rising edge on voltage (#3636) 
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test
 2021-12-07 21:28:04 -05:00
Andrey 50038167d8 MAP phase sensing #3544 
new implementation seems complete?
 2021-12-07 21:08:25 -05:00
Andrey e72d57438a MAP phase sensing #3544 
new implementation
 2021-12-07 20:00:04 -05:00
Andrey 73fb5a2ef8 docs 2021-12-07 19:59:43 -05:00
Andrey 8b246a8d92 refactoring 2021-12-07 17:00:42 -05:00
Andrey 6e49d66385 MAP phase sensing #3544 
look new unit test!
 2021-12-07 16:58:10 -05:00
Matthew Kennedy 3a95e86112
calculate per-cylinder ignition timing (#3652) 
* simplify cylinder phasing

* per cylinder timing

* s

* s

* s

* why was there a divide by 2?
 2021-12-06 21:19:37 -05:00
rusefillc 2f45ed205c MAP phase sensing #3544 
option to look for high and low peaks
 2021-12-05 14:25:26 -05:00
rusefillc 0c91e77749 MAP phase sensing #3544 
taking a step back to happy place
 2021-12-04 18:21:10 -05:00
rusefillc 5f4b224b5f tune via CAN #3361 
CAN testability
 2021-12-04 01:01:48 -05:00
rusefillc 37183a0640 header style 2021-12-04 01:01:48 -05:00
Andrei c6fa50d196 CAN update 2021-12-03 21:44:15 -05:00
rusefillc c80a37503e trigger_adc helping simulator 2021-12-01 14:17:16 -05:00
rusefillc aaf732f738 trigger_adc unit tests 2021-12-01 13:35:44 -05:00
Andrei 1047fed77c trigger_adc unit-test data files 2021-12-01 12:28:48 -05:00
rusefillc 79e43384a5 proteus to have enlarged Lua 2021-11-30 21:37:17 -05:00
Matthew Kennedy a37c9bca9e
Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630) 
* no working copy

* oops
 2021-11-29 16:44:45 -05:00
rusefillc 0c4e64fb2d Epic: Remove FSIO #2928 2021-11-28 17:54:26 -05:00
Matthew Kennedy d5363b814a
better VSS configuration (#3542) 
* vss uses real values

* some defaults

* test and correct math

* km, not miles!

* comment

* tooltip

* that macro went away

* 100hz and default settings gives 9kph

* changelog

* order of operations safety

* make the test like the pwm test

* housekeeping

* this is why we need sensor automation

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2021-11-27 08:49:07 -05:00
GitHub build-unit-tests Action 7ea34947d5 Trigger wheel definitions 2021-11-26 02:09:34 +00:00
GitHub build-unit-tests Action 8d1231a588 Trigger wheel definitions 2021-11-25 23:54:51 +00:00
Andrey e2fa1af527 MAP phase sensing #3544 2021-11-24 22:36:36 -05:00
Andrey 58c0fb4539 MAP phase sensing #3544 2021-11-24 21:53:32 -05:00
Andrey 259e8744cb MAP phase sensing #3544 2021-11-24 21:53:16 -05:00
Matthew Kennedy 81fffe87b7
main relay doesn't use fsio (#3580) 
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag

* main relay

* plumbing

* dead fsio stuff

* test it

* by 100%, we mean 99.98%
 2021-11-24 07:47:51 -05:00
rusefillc c75291f415 live data for wastegate #3588 
i want to persist state so no 'const' sorry
 2021-11-23 15:52:43 -05:00
rusefillc 50ccf1fbea harley 2021-11-22 19:16:57 -05:00
Matthew Kennedy 3334a6963c
oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
rusefillc 42da5746f4 j1850 SAE crc8 Lua 2021-11-22 14:19:19 -05:00
rusefillc da68ff5ad6 j1850 SAE crc8 2021-11-22 14:03:52 -05:00
Scott Smith ba4a00d3bb
Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData (#3519) 
* Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData

Most all the users were Multi* anyways, so just improve that:
1. Allow up to 8 waveforms to share one byte per timestamp.  It could be better but this is simple
   and gets most of the benefit.
2. Use a wrapper structure to handle reserving space for the arrays.  Makes the interface simpler
   and more rigid.  Also saves 4 bytes per Multi*.  Downside is access is now via -> and *,
   not . and (nothing).

Saves 224 bytes of BSS, 1832 bytes of RAM4/CCM, 952 bytes of TEXT, and 103 bytes of RODATA

* Instantiate a base_t to make debugging easier.
Also fixes crash on real firmware by using &m_base instead - LTO optimization issue?

* No magical templated StaticAlloc thingy.  Just virtual functions.
 2021-11-21 04:56:07 -05:00
Matthew Kennedy 9a28e8d938
correctly compute engine revolution number (#3586) 
* add param

* first revolution is revolution 0, not revolution 1

* would you look at that, we sync one rev quicker!

* changelog

* rpm value
 2021-11-21 09:01:27 +03:00
Matthew Kennedy a342bee57e
rpm calculator refactoring, gm 24x test (#3585) 
* data

* stub test

* use getTimeSinceSyncPoint

* s

* s

* no

* test

* stray ;

* those were 1/10 what they were supposed to be

* actually check something

* dead log line?
 2021-11-20 14:59:02 +03:00
rusefillc bdc6340df7 only c++ because lua does some things asan doesn't like, but don't actually cause overruns. 2021-11-20 03:04:52 -05:00
Matthew Kennedy 754e832a7f
don't do things that don't work in clang (#3584) 
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2021-11-20 02:40:41 -05:00
Matthew Kennedy bb57a4b084
detect more overflows with asan (#3582) 
* overflow detector

* type list dynamic allocate

* fix the buffer length

* comment

* pr fb

* sanitize sim

* fix sim sanitizer bug

* didn't mean to turn off optimization for sim

* asan can do that, if you turn it on!

* cleaning
 2021-11-20 01:38:39 -05:00
rusefillc fcc2b780e9 On -fpermissive in Windows in unit tests fix #3581 2021-11-20 00:26:52 -05:00
rusefillc f1900b4887 On -fpermissive in Windows in unit tests #3581 2021-11-20 00:23:27 -05:00
rusefillc e54d3b9e06 On -fpermissive in Windows in unit tests #3581 2021-11-20 00:16:03 -05:00
Scott Smith 5bc1949aef
Basic framework for high pressure fuel pump control (#3476) 
* Basic framework for high pressure fuel pump control

* Many changes

Move calculations to fast callback
Move main object into Engine
Respond to pin changes without requiring a reboot

* Use EngineModule for HpfpController
Schedule pin off after executing pin on so we are sure it ends, even if the motor stops.
Test scheduling.
Less RAM use by only having one event and reordering fields.

* Make scheduling test actually useful - need non-0 activation angle.

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
 2021-11-19 23:06:51 -05:00
Matthew Kennedy d40ca0f581
fuel pump doesn't use fsio (#3576) 
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag
 2021-11-19 22:23:12 -05:00
Matthew Kennedy cdd27abb09
turn on c++ 20 (#3579) 
* set flags

* emit initializers

* jar
 2021-11-19 22:19:34 -05:00
Scott Smith 18c27a6e9c
Separate out scheduleOrQueue into it's own standalone scheduler. (#3573) 
It's a large enough entity that it shouldn't be buried in ignition logic.
 2021-11-18 14:27:21 -05:00
Scott Smith 98040ad9af
Make the module API more concise. (#3571) 
engineModules.get<FOO>(). becomes modules<FOO>()->

I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
 2021-11-17 21:50:00 -05:00
Scott Smith 69d36dad6e
Final cleanup of ENGINE macros (#3567) 
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
 2021-11-17 13:45:10 -05:00
Scott Smith 988aacdd91
Create a base class EngineModule for that contains various useful callbacks. (#3548) 
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
 2021-11-17 20:13:19 +03:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565) 
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
 2021-11-17 03:54:21 -05:00
Scott Smith 8dbdeb7773
Remove a bunch of macros from engine_ptr.h (#3562) 2021-11-17 10:01:39 +03:00
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560) 
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
 2021-11-16 16:52:11 -05:00
rusefillc 17d4646dce spelling 2021-11-16 16:46:54 -05:00