b628c81d26
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-12 00:11:25 -04:00
1b28e292e2
logging of live data structs was: data points #3614
...
huh?
2022-06-29 02:42:03 -04:00
c0f290b922
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
fcd3d991ee
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
932f5e1f30
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit 32d46d1f09d5e131b1d0
2022-06-09 17:21:22 -04:00
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
b7743f101f
helping build
2022-05-31 10:45:32 -04:00
22d9bf056a
heling build
2022-05-31 08:48:24 -04:00
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
f945e6efc9
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
6f45d0fd46
Fix trigger error indicator ( #4185 )
...
* test and fix
* more shards!
2022-05-19 09:43:42 -04:00
d38d8a7840
altering technical debt
2022-05-15 10:07:17 -04:00
ae91b2aea8
don't rely on triggerStateListener to detect trigger errors ( #4164 )
...
* Write proper TriggerDecoder tests
* Improve logic around sync loss
* these tests I understand
* these I sort of understand....
* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
098b2c87c6
Proper decoder testing ( #4166 )
...
* Write proper TriggerDecoder tests
* patch test for un-patched decoder
2022-05-11 06:14:45 -04:00
d4509cab8a
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
bd9639b91d
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
b650bbe46c
Trigger gm 3 vs 5 ( #4140 )
...
* add parameter
* two modes
* add new mode to list
* format
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
e4a0979dc2
Brain pin is enum class ( #4108 )
...
* change most usages to Gpio::
* board configs
* engine configs etc
* isBrainPinValid, smart gpio
* generator
* generator
* generator
* connector yamls
* kinetis enums
* cypress txt
* kinetis config
* frankenso
* config generator
* actually do it for the others
* disable skips for pr ci
* fix tle8888
* misc
* weird cast from int
* needs this operator too
* this can be an unsigned subtract
* happy tests
* s
* kinetis isConfigurationChanged weirdness
* missed J/K
* cypress efifeatures
* build script mistake (!)
* mistake in smart gpio
* debounce
* eg33
* kinetis, so needy
* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
ddd85e701e
Remove value copy from controller into outputChannels #4095
2022-04-23 20:38:48 -04:00
71275e841b
m_hasSynchronizedSymmetrical handling improvements #4099 ( #4101 )
2022-04-23 19:45:29 -04:00
4492bc760a
m_hasSynchronizedSymmetrical handling improvements #4099
2022-04-23 19:03:59 -04:00
7b64aa5880
m_hasSynchronizedSymmetrical handling improvements #4099
2022-04-23 18:46:12 -04:00
14e37e3cf4
FasterEngineSpinUp should be enabled by default fix #4094
2022-04-23 09:51:47 -04:00
3c7eb93fe1
steps towards ignition live data
2022-04-13 16:48:25 -04:00
093de78ff3
Proper cam speed labels in triggers #4021
2022-04-03 17:56:47 -04:00
e631988b22
Proper cam speed labels in triggers #4021
2022-04-03 12:22:47 -04:00
204ac3961b
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
WOW it works?!
2022-04-03 02:30:43 -04:00
cc9a1136c4
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 02:21:37 -04:00
b0be8c4b66
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
progress: this way test is less fake!
2022-04-03 02:13:56 -04:00
5840a61f55
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:02:13 -04:00
95d36b37e3
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 00:34:18 -04:00
6b5747d4c8
refactoring: method rename
2022-04-02 21:01:29 -04:00
086739d20a
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 19:08:22 -04:00
174a3f33bd
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-01 22:05:25 -04:00
b1de262520
toothed previous time #4019
2022-03-21 20:41:09 -04:00
1b334656e1
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-03-19 19:59:36 -04:00
5811f691d9
things are happy without gtest ( #3999 )
...
* things are happy without gtest
* this is not a static lib
2022-03-14 15:00:02 -04:00
3076027887
spelling
2022-03-14 13:11:10 -04:00
06437f304f
dead StartupFuelPumping ( #3883 )
...
* dead
* test
* dead config too
2022-02-03 08:01:21 -05:00
28f39fe71c
test organization ( #3882 )
...
* organize actuators
* this test can be useful
* don't name things misc
* fewer tests called misc
* fewer tests called "big" (?)
* unnecessary
2022-02-02 16:36:35 -05:00
33df88d3f7
fixing NOISY_RPM handling via Sensor framework
2022-01-21 00:21:45 -05:00
9313bcca92
migrating to SensorType::Rpm API
2022-01-20 23:19:48 -05:00
e37ab73f1d
migrating to SensorType::Rpm API
2022-01-20 22:58:12 -05:00
e55eb28086
migrating to SensorType::Rpm API
2022-01-20 22:42:13 -05:00
c7a62bcdb3
migrating to SensorType::Rpm API
2022-01-20 22:04:45 -05:00
0932fcf94c
Improve NA/NB miata sync parameters ( #3730 )
...
* NA sync parameters
* NB vvt pattern too
* zach's car says tighten the gap
* look at that, we sync one cycle sooner!
2022-01-01 21:39:04 -05:00
d5c4b79b1a
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
b3de217c1b
adjustment to #3722 ( #3723 )
...
* s
* behold, another bug a test caught
* test
* test generates usable trigger pattern so it works correctly
* comment
* don't need that
2021-12-31 01:21:21 -05:00
4981eb43d0
extract isSyncPoint function ( #3726 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* clean up noise from test case
* clarify and comment
2021-12-30 11:39:04 -05:00
rusefillc
Matthew Kennedy
Andrey
rusefillc