Commit Graph

1225 Commits

Author SHA1 Message Date
rusefi 22453f8392 nicer enum name 2019-11-03 21:19:13 -05:00
rusefi 5c46ad25a7 review feedback 2019-11-03 10:36:35 -05:00
rusefi 47eaea3da3 scramblr reports sync issues on NB1 fix #990 2019-10-30 21:01:23 -04:00
rusefi 74e0c20235 flipping NB1 trigger definition 2019-10-29 21:19:00 -04:00
rusefi 8cf19d3d12 refactoring & verbose trigger to simulator 2019-10-29 21:12:44 -04:00
rusefi fe77766b2b bugfix around verboseTriggerSynchDetails - 64 bits on stack was causing broken messages 2019-10-29 18:20:55 -04:00
rusefi 88348ebd09 refactoring: reducing code duplication 2019-10-21 23:47:40 -04:00
Matthew Kennedy 10a6d6eb8b fix wwae (#980) 2019-10-17 00:06:54 -04:00
rusefi 5f9fdfe9a6 Revert "Revert "Performance improvement: call GetBaseFuel less (#979)""
This reverts commit 7eb9947fd4.
2019-10-16 23:02:24 -04:00
rusefi 7eb9947fd4 Revert "Performance improvement: call GetBaseFuel less (#979)"
This reverts commit 95e51f13
2019-10-16 22:29:19 -04:00
Matthew Kennedy 95e51f1399 Performance improvement: call GetBaseFuel less (#979)
* Remove extra calls to getInjectionDuration

* increase callback frequency
2019-10-16 22:13:10 -04:00
Matthew Kennedy 4db3fa46cd fix #977 (#978) 2019-10-15 05:24:33 -04:00
Matthew Kennedy d6e065f99e Merge remote-tracking branch 'upstream/master' into perf-tracing 2019-10-14 23:45:39 -07:00
Matthew Kennedy d76670d946 trace all the things 2019-10-14 23:34:12 -07:00
rusefi 12137fc7cd preparing for #974
code comments & refactoring
2019-10-14 06:18:08 -04:00
Matthew Kennedy f52bdecb80 profile all the things 2019-10-13 13:14:08 -07:00
rusefi 5cb90d0e1b preparation for #961
more unified access to pre-calculated value
2019-10-13 09:59:06 -04:00
Matthew Kennedy 763b17fb50 experiment 2019-10-11 17:43:21 -07:00
Matthew Kennedy 29804cbc8a move tsOutputChannels to header (#970) 2019-10-08 21:02:51 -04:00
rusefi 4574aaccce I got carried away, but DEAD CODE?! 2019-10-08 03:14:21 -04:00
rusefi 2acdbf308b something is over-complicated here? looks like two classes should become one? 2019-10-08 02:56:19 -04:00
rusefi a65c8c9295 something is over-complicated here? looks like two classes should become one? 2019-10-08 02:35:21 -04:00
rusefi 4e26bd2fd2 refactoring 2019-10-08 02:01:41 -04:00
rusefi ade7ad158a typo & better field name 2019-10-08 01:36:03 -04:00
rusefi 42dc9e3662 fancy C++ s/NULL/nullptr/ 2019-10-08 01:26:35 -04:00
rusefi 1ab488e4b4 refactoring: better field name(s) 2019-10-08 01:03:57 -04:00
rusefi ca67249522 refactoring: better field name 2019-10-08 00:54:19 -04:00
rusefi 8424723024 refactoring: better variable names 2019-10-08 00:42:47 -04:00
rusefi 0d31cdddea refactoring: better parameter name 2019-10-08 00:30:20 -04:00
rusefi 53231f7b49 refactoring: smarter C++ initialization 2019-10-08 00:27:49 -04:00
Matthew Kennedy d1da567b85 fix gm 24x decoder (#963)
* fix gm

* fix

* fix default config, tests
2019-10-05 08:27:30 -04:00
rusefi 533087f475 ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 09:56:06 -04:00
rusEfi d5ef749761 s/NULL/nullptr/ 2019-09-22 08:22:35 -04:00
rusefi c59d8164c6 unit tests progress 2019-09-19 21:41:52 -04:00
rusefi db018723f7 refactoring: better field name 2019-09-09 19:39:13 -04:00
rusefi 8d1d88bf73 instant RPM for idle control #925
refactoring
2019-09-09 14:41:26 -04:00
rusefi 612a4ab3b3 MRE NB2 2019-09-03 23:35:49 -04:00
rusefi f32b29f318 Live Data: trigger current gap 2019-09-03 19:30:51 -04:00
rusEfi 1b8219432c Live Data for hw VVT signals 2019-09-02 21:02:08 -04:00
rusEfi c2980a36a9 Live Data VVT counter 2019-09-02 14:47:05 -04:00
rusefi 7842c7305f Live Data progress 2019-09-01 00:45:36 -04:00
rusefi 4858124edb unified names for generated headers 2019-08-31 23:12:39 -04:00
rusefi 2804b31e7e cranking fuel live data #911 2019-08-26 23:41:04 -04:00
rusefi 9161703598 reducing unit test noise 2019-08-25 02:01:09 -04:00
rusefi e5e0ce0b94 minor test code fix & refactoring 2019-08-25 01:35:36 -04:00
rusefi 8a4d3f9896 reducing unit test noise 2019-08-25 01:15:18 -04:00
rusEfi 1c0d38abef new feature: check engine light to blink on trigger synchronization 2019-08-18 15:53:38 -04:00
rusEfi 7a7dbb8c30 refactoring: engine sniffer magic constants 2019-08-18 15:04:02 -04:00
rusefi e0acec2a63 WTF is wrong with MRE_miata_na6 config? operationMode complexity #898
fatal error is the best I can come up with quickly
2019-08-08 22:57:22 -04:00
rusefi 539cd8b1c7 current toolchain does not work great with current rusEfi code, two methods with same name are hard for full text search :( 2019-08-08 22:33:52 -04:00
rusefi 643cc24931 WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
more refactoring
2019-08-08 00:32:31 -04:00
rusefi f25b1e5f2f WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
more refactoring
2019-08-08 00:30:32 -04:00
rusefi 51110b33ad WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
refactoring to begin with, zero logic change
2019-08-08 00:19:09 -04:00
rusefi 676035f950 refactoring: extracting method to facilitate debugging 2019-08-07 22:02:08 -04:00
rusefi 7a00ccd2ce better trigger state debug field logging 2019-08-07 20:13:30 -04:00
rusEfi ba56a79ad5 proper HW type message logic 2019-08-06 23:56:35 -04:00
rusEfi d5451a7b4f NA6 & trigger 2019-08-06 22:17:18 -04:00
rusefi 0306255013 CBR600 trigger progress 2019-07-23 19:22:40 -04:00
rusefi d01485d484 trigger error message makes trigger very unhappy #888
quick dirty temporary solution
2019-07-22 17:38:52 -04:00
rusefi e5b953db84 trigger counters to formula, docs & improvements 2019-07-20 14:56:56 -04:00
rusefi 56a6cdd329 gcc 2019 q3 fails integration testing #886
investigation
2019-07-14 15:22:02 -04:00
rusefi 3256af5510 gcc 2019 q3 fails integration testing #886
nicer messages
2019-07-14 13:15:48 -04:00
rusefi 7ac957e108 gcc 2019 q3 fails integration testing #886
nicer messages
2019-07-14 12:25:54 -04:00
rusefi a3de5fc276 Annotations in C++ code to produce formulas in rusEfi console #807
refactoring wall wetting
2019-07-12 22:34:38 -04:00
rusefi 07f41c8f2a refactoring 2019-07-12 21:31:58 -04:00
rusefi 1282a22134 support multiple VVT sensors #885 2019-07-12 21:13:24 -04:00
rusefi 04bc1128df support multiple VVT sensors #885
new fields & packing configuration. bumping configuration version
2019-07-12 14:24:45 -04:00
Matthew Kennedy e0db83e027 Template-ize bin/value length for interpolation (#878)
* update consumers

* tests

* whitespace

* format
2019-07-09 21:16:36 +03:00
rusefi d0d546e500 EFI_TOOTH_LOGGER 2019-07-07 15:22:46 -04:00
Matthew Kennedy d708f3e038 Implement TS tooth logger (#873)
* FW changes

* config changes

* whitespace

* comment

* simplify
2019-07-06 20:48:58 -04:00
rusefi cdac02429c refactoring: better file name 2019-07-06 20:15:49 -04:00
rusefi fecf83e4d2 order of includes consistency 2019-07-05 20:03:32 -04:00
rusefi 05fac9e869 Refactoring: OS access should be explicit #867 2019-07-05 19:00:44 -04:00
rusefi 83ad64eade Refactoring: OS access should be explicit #867 2019-07-04 03:57:21 -04:00
rusefi b81c60cf3e Refactoring: OS access should be explicit #867 2019-07-03 21:48:04 -04:00
rusefi b24064d231 NB2 magic clarification 2019-07-01 12:48:08 -04:00
rusefi ded41e5efe Annotations in C++ code to produce formulas in rusEfi console #807 2019-06-30 09:38:51 -04:00
rusefi 23fe25268a https://rusefi.com/forum/viewtopic.php?f=10&t=442&p=33587#p33584
better support for pretty noisy trigger (?)
2019-06-25 20:51:29 -04:00
rusefi 50bf018fe9 https://rusefi.com/forum/viewtopic.php?f=10&t=442&p=33585#p33575 2019-06-25 18:20:01 -04:00
rusefi a82c7e30db verbose trigger sync: better field name & check box to engine sniffer 2019-06-25 02:25:26 -04:00
Matthew Kennedy 95003e9a7b const, explicit, and override (#831)
* const, explicit, and override

* more const

* more const

* missed a spot
2019-06-08 09:51:36 -04:00
rusefi 5f642ac254 unit tests should not have global context, including mock values 2019-05-27 15:56:12 -04:00
rusefi 1c36b89141 nicer pin names for messages while same short names for engine sniffer 2019-05-15 04:26:41 -04:00
rusefi 266f8b5176 Multiple sync pattern for faster cranking #679 2019-05-14 19:24:18 -04:00
rusefi 812c61903a BUG: phase sensor validation attending - detect missing CAM signal fix #659 2019-05-11 00:21:37 -04:00
rusefi ff1d10dd2e BUG: phase sensor validation attending - detect missing CAM signal #659
preparation
2019-05-10 23:52:55 -04:00
rusefi 04afb87610 Trigger: warning code on normal engine start up #669
avoiding CUSTOM_OBD_SKIPPED_FUEL fot triggers without synchronizaiton
2019-05-10 22:55:08 -04:00
rusefi a2c4b1bde1 typo 2019-05-10 22:43:03 -04:00
rusefi c6198e34ec BUG: phase sensor validation attending - detect missing CAM signal #659
refactoring and unit test first phase
2019-05-10 21:56:33 -04:00
rusefi 4e61505620 refactoring unit test 2019-05-10 21:29:17 -04:00
rusefi 22ec5da4bc Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778 2019-05-07 21:39:11 -04:00
rusefi d7fd0ce6c1 refactoring: better method name 2019-05-07 19:32:08 -04:00
rusefi d647772b98 Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778
metric progress
2019-05-07 19:16:01 -04:00
rusefi 1220a1a1fb Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778
first steps of scheduling metric
2019-05-07 17:22:26 -04:00
rusefi 5f70acab9f Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778
only renaming methods
2019-05-07 17:10:47 -04:00
rusefi 61231fb1af Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778
refactoring only
2019-05-07 16:45:29 -04:00
rusefi 1350a94715 Saab CDM knock signal integration #647 2019-05-05 18:53:34 -04:00
rusefi f534fd0e67 console usability: engine sniffer jitter fix #780 2019-05-02 18:42:59 -04:00
rusefi 1ec5baf57a refactoring: better method name 2019-05-02 18:05:33 -04:00
rusefi edb4e37505 docs 2019-05-02 17:52:48 -04:00
rusefi f04732830f PID - fix dTime usages #776 2019-04-25 21:31:33 -04:00
rusefi 49841f1adb The Big Refactoring of 2019: configuration version should not be a global variable #656 2019-04-15 21:02:42 -04:00
rusefi 3afc72a458 PWM parameter validation fix #594 2019-04-15 20:47:06 -04:00
rusefi 7be441a1bc random cleanup 2019-04-14 13:52:27 -04:00
rusefi 541c445a2d defined(__DOXYGEN__) ? #748 2019-04-12 22:07:03 -04:00
rusefi e3b74f0f3e smarter PWM API - need to pass arbitrary pointer 2019-04-12 20:15:18 -04:00
rusefi 22ad223d75 smarter PWM API - need to pass arbitrary pointer 2019-04-12 20:11:27 -04:00
rusefi 1dffb21e89 smarter PWM API - need to pass arbitrary pointer 2019-04-12 20:06:09 -04:00
rusefi be9651cb95 The Big Refactoring of 2019: folder structure #723 2019-03-31 17:44:34 -04:00
rusefi ebe58122c6 The Big Refactoring of 2019: folder structure #723 2019-03-31 16:56:13 -04:00
rusefi bd2b992918 unifying_file_naming 2019-03-29 09:11:13 -04:00
andreika-git 4b5ed3e0e1 Tps-accel. fractional mode (#715)
* Add new config settings for tps_accel_fractional_mode

* Add new variables for the fractional algo

* Add resetFractionValues() method

* Call onEngineCycleTps() and fix onEngineCycle()

* Implement the fractional algo

* More debug outputs for tps-enrich

* Nice & juicy unit-test!
2019-03-28 22:47:20 -04:00
rusefi a6fe81d07f docs 2019-03-23 08:55:33 -04:00
rusefi 653a735eab refactoring: no logic changes, just nicer variable and method names 2019-03-12 18:54:46 -04:00
dron0gus c9edbf4225 Cleanup fixes (#700)
* Kill some more warnings

* pin_repository: add markUnused, allow use from plain C

* ehiGpio.cpp: add forgotten GPIOG port
2019-03-08 07:01:15 -05:00
rusefi 84c1b3581d refactoring trigger simulation 2019-03-04 01:10:31 -05:00
rusefi 8decc09edf reducing code duplication 2019-03-04 00:40:22 -05:00
rusefi a9e3399a74 refactoring: removing unused variables 2019-03-04 00:21:02 -05:00
rusefi 46bdbf82d1 refactoring: reducing code duplication 2019-02-23 12:33:49 -05:00
dron0gus 76fa11d5e2 warning cleanup (#693)
* Kill annoing warnings about unused vars

* Kill annoing signed vs unsigned warnings

* Make ALWAYS_INLINE macro realy inlining

* Incorrect attribute placement.

While correct attribute placement cause ram4 overflow.
Move to correct place (to avoid gcc-2018-q4 errors) and comment
out.

* Silence -Wcast-function-type warnings

Cast to intermediate "void *" to lose compiler knowledge about the original
type and pass the warning. This is a workaround.
2019-02-21 05:44:45 -05:00
rusefi 16da833501 Refactor Trigger System #635
reducing global state magic
2019-02-03 02:47:20 -05:00
rusefi 3127b6fd24 Refactor Trigger System #635
reducing global state magic
2019-02-03 02:33:33 -05:00
rusefi 5d735c4d6e Refactor Trigger System #635
better field names
2019-02-03 01:49:41 -05:00
rusefi 27da8ce328 Refactor Trigger System #635 2019-02-03 01:34:20 -05:00
rusefi 4187f4b081 Refactor Trigger System #635 2019-02-03 01:27:47 -05:00
rusefi 935a9fa706 Refactor Trigger System #635 2019-02-03 01:19:16 -05:00
rusefi d247c13283 Refactor Trigger System #635 2019-02-03 01:04:24 -05:00
rusefi 2f2fcc11e0 Refactor Trigger System #635 2019-02-03 00:40:25 -05:00
rusefi 9ed58a5ba0 better conditional compilation 2019-01-31 18:30:40 -05:00
rusefi da4fb3a19f better conditional compilation 2019-01-31 17:55:23 -05:00
rusefi 9a3441f11b #657 pulling global access down 2019-01-28 00:44:30 -05:00
rusefi 1b74b722d2 refactoring: 'const' modifier 2019-01-24 23:44:29 -05:00
rusefi 14199080b1
Trigger rabbit hole (#682)
fix #681

* this did not work right

* progress: spinning is detected sooner now

* and now things are much better?

* and now reducing RAM usage
2019-01-24 21:12:55 -05:00
rusefi f2c321d37b got deeper into the rabbit hole and now I am confused about something else 2019-01-24 00:19:01 -05:00
rusefi 90a7e61767 trigger refactoring: extracting methods to improve readability 2019-01-23 22:31:16 -05:00
rusefi 72c6ebd239 trigger refactoring: extracting methods to improve readability 2019-01-23 22:06:42 -05:00
rusefi 87930e3b49 trigger code minor clean-up 2019-01-23 21:43:27 -05:00
rusefi f7a2cc9e63 state validation progress 2019-01-22 23:15:33 -05:00
rusefi 1d15885448 C++11 and unique method name 2019-01-22 19:07:36 -05:00
rusefi 53b5c08c0a refactoring around GET_RPM 2019-01-21 21:48:58 -05:00
rusefi 7a20bda66f refactoring around GET_RPM 2019-01-21 20:33:21 -05:00
rusefi 2756ff57eb refactoring: reducing header tree hell 2019-01-21 00:10:09 -05:00
rusefi ee8297c94d refactoring: reducing header tree hell 2019-01-20 23:30:40 -05:00
rusefi 28bde6f084 better method name and docs related to improved craking logic 2019-01-20 11:33:40 -05:00
rusefi 78f4a68d3a #674 fix? 2019-01-19 19:45:35 -05:00
rusefi 8539ba3271 The Big Refactoring of 2019: configuration version should not be a global variable #656 2019-01-15 21:51:09 -05:00
rusefi 662831cde9 The Big Refactoring of 2019: configuration version should not be a global variable #656 2019-01-15 21:18:44 -05:00
rusefi 0ffa05a911 learning C++ 2019-01-15 20:24:36 -05:00
rusefi a2e8744200 The Big Refactoring of 2019: configuration version should not be a global variable #656
making a global not global
2019-01-14 12:21:26 -05:00
rusefi 01095219ba docs 2019-01-14 11:36:46 -05:00
andreika-git 775775e4fd fix! (#673) 2019-01-14 11:33:58 -05:00
rusefi 2bbc5feef4 minor improvement 2019-01-14 00:21:08 -05:00
rusefi 4ed5072f13 enjoying C++11 2019-01-14 00:20:50 -05:00
rusefi 4b29af6e96 something is not right here :( 2019-01-14 00:01:35 -05:00
rusefi d1430b1b3d enjoying C++11 2019-01-13 23:55:10 -05:00
rusefi c7f5581382 enjoying C++11 2019-01-13 23:20:19 -05:00
rusefi c459020fdd minor clean-up 2019-01-13 23:05:03 -05:00
rusefi 6bb8da7b39 Question: something strange trigger errors #662 2019-01-11 09:24:24 -05:00
rusefi cbd2d69731 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657 2019-01-09 22:57:33 -05:00
rusefi 57993ff1b4 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657 2019-01-09 22:16:30 -05:00
rusefi 2f0804022b The Big Refactoring of 2019: configuration version should not be a global variable #656 2019-01-09 21:08:04 -05:00
rusefi 68d172a8f1 The Big Refactoring of 2019: scheduler should not be global #655 2019-01-09 09:37:16 -05:00
rusefi 970d120a41 The Big Refactoring of 2019: scheduler should not be global #655 2019-01-09 08:50:51 -05:00
rusefi 5ffcc396eb The Big Refactoring of 2019: scheduler should not be global #655 2019-01-09 07:57:43 -05:00
rusefi 2f01f8759c The Big Refactoring of 2019: scheduler should not be global #655 2019-01-09 00:53:54 -05:00
rusefi 5b74163136 refactoring around "stopEngine" logic 2019-01-05 23:33:04 -05:00
rusefi 0c6f361181 refacoting: making code more consistent 2019-01-05 00:57:09 -05:00
rusefi 19c410387d making either Matt or compiler or both happier 2019-01-05 00:11:17 -05:00
rusefi 3db5ad5e5b #396 2019-01-04 21:33:50 -05:00
rusefi 6360719ed0 #635 2019-01-01 14:05:11 -05:00
Fabien Poussin 72fe39ff32 Workarounds for GCC 8 (#637) 2018-12-27 09:40:40 -05:00
rusefi f0344fd16c #625 big step - no more engine dependency from TriggerShape 2018-12-25 22:47:29 -05:00
rusefi 72f87ce425 #625 2018-12-25 21:18:14 -05:00
rusefi 2585e4cad7 #625 2018-12-25 21:05:06 -05:00
rusefi d51fa71085 #625 2018-12-25 20:56:54 -05:00
rusefi 22734e8f39 #635 2018-12-25 20:09:35 -05:00
rusefi 23de7a6d8a #635 2018-12-25 19:42:27 -05:00
rusefi 7e64c16df5 #625 2018-12-25 19:18:37 -05:00
rusefi c6c53a02fd #625 progress 2018-12-25 19:13:28 -05:00
rusefi 76b2dd9aec #635 2018-12-25 17:31:21 -05:00
rusefi 62b5e87393 #635 2018-12-25 12:27:34 -05:00
rusefi 57ebbb1a0b #635 2018-12-25 11:51:49 -05:00
rusefi 5b25174cc3 #635 2018-12-25 10:33:28 -05:00
rusefi daed49dd12 #635 2018-12-25 10:20:13 -05:00
rusefi a4efd47ba1 #635 better names 2018-12-25 10:13:00 -05:00
rusefi 881fad4e59 #635 refactoring: better name 2018-12-25 08:27:52 -05:00
rusefi b15845754d #635 2018-12-24 23:33:21 -05:00
rusefi 48a972bc76 #635 2018-12-24 23:27:06 -05:00
rusefi 3a7f719d5c #635 2018-12-24 23:23:45 -05:00
rusefi 7e3a7b5c79 #635 2018-12-24 23:16:33 -05:00
rusefi 5ccc3bbef5 refactoring trigger system 2018-12-24 22:57:36 -05:00
rusefi 2df38cdd91 refactoring 2018-12-24 22:40:48 -05:00
rusefi a549009c99 more CPU stats code 2018-12-24 00:31:26 -05:00
rusefi 8c3934a7b3 code style and some refactoring 2018-12-08 16:59:16 -05:00
rusefi a6d83e1cc2 moving code to proper file 2018-12-08 16:38:44 -05:00
rusefi 3efedc9c95 better state validation 2018-12-08 16:31:46 -05:00
rusefi 5d86f610d5 docs 2018-11-22 12:18:00 -05:00
rusefi dbff41a8e6 docs 2018-11-22 12:13:21 -05:00
rusefi 2fa2213227 more docs related to trigger process 2018-11-22 10:25:02 -05:00
rusefi c77ab926c2 Mazda Z5 trigger integration 2018-11-22 10:01:48 -05:00