Commit Graph

1573 Commits

Author SHA1 Message Date
Andrey f2cb242090 simplify quad vvt test #3018
better parameter name and explicit constraint clarification
2021-07-21 17:45:35 -04:00
Matthew Kennedy 5f3464b204
Fix prepareEventAngles for symmetrical crank triggers (#2982)
* fix and make code legible

* update test to check every tooth

* symmetrical crank

* simplify findTriggerPosition

* make getAngle intelligable
2021-07-17 23:27:20 -04:00
Andrey 9345e5d2e0 NB2 trigger shape does not seem to match JimStim #2980
only first steps of unit test
2021-07-17 17:47:32 -04:00
rusefillc 6da3310d97 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 02:03:55 -04:00
Andrey 180d7bc899 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 01:10:13 -04:00
Andrey ffe2fe3271 refactoring 2021-07-17 00:56:50 -04:00
Andrey d583c91a7a refactoring 2021-07-17 00:53:51 -04:00
Andrey d16d6dd58d kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 00:46:39 -04:00
Andrey f54b3cd1b2 refactoring 2021-07-17 00:46:39 -04:00
Andrey df558303d3 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 00:27:56 -04:00
Matthew Kennedy 2ce7777865
don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
Andrey f87d1c425e trigger signal debug pins - logic level output #2959 2021-07-16 17:18:03 -04:00
Andrey ee91af5c73 trigger signal debug pins - logic level output #2959 2021-07-16 16:42:26 -04:00
rusefi 92dee23061 FATAL on NB2 tune jim stim input signal fix #2965 2021-07-14 21:18:05 -04:00
Andrey 2442d8f2d8 FATAL on NB2 tune jim stim input signal #2965 2021-07-14 16:05:53 -04:00
Andrey e1c41ff798 FATAL on NB2 tune jim stim input signal #2965 2021-07-14 16:03:00 -04:00
Andrey bb9835fe58 trigger signal debug pins - logic level output #2959 2021-07-13 20:33:27 -04:00
Andrey 994230be65 trigger signal debug pins - logic level output #2959 2021-07-13 20:15:55 -04:00
Andrey f028c4d727 trigger signal debug pins - logic level output #2959 2021-07-13 18:16:32 -04:00
rusefillc 090725d273 reducing warnings 2021-07-13 14:50:10 -04:00
Matthew Kennedy aef0732509
fix vvt indication (#2926)
* wrap logic

* rename gauges

* names and ranges

* binary log

* we actually don't need that warning

* values auto wrap

* values auto wrap

* bye warnings

* comparison
2021-07-12 16:29:07 -04:00
Andrey f92bf80e3f reducing code duplication 2021-07-06 00:09:35 -04:00
Andrey 8e30c513da unit tests pass on Linux fail on Windows fix #2902
reducing code duplication
2021-07-05 23:51:13 -04:00
Andrey 9fb7e39864 Nissan VVT trigger decoder #2887 2021-07-05 23:39:39 -04:00
Andrey 70424ac7b5 Nissan VVT trigger decoder #2887
another bug - improper handling of three-times-symmetrical
2021-07-05 23:15:44 -04:00
Andrey 293bf45763 refactoring - reusing magic constant 2021-07-05 23:07:36 -04:00
Andrey cf2e2a6451 Nissan VVT trigger decoder #2887
that looks like one bug
2021-07-05 22:44:20 -04:00
Andrey 1b174bd4b3 Nissan VVT trigger decoder #2887
that's all very strange
2021-07-05 22:17:26 -04:00
Andrey 064c1612e3 restore testQuadCam #2911 2021-07-05 21:04:09 -04:00
rusefi de63a5cd17 Nissan progress!!! 2021-07-05 20:29:49 -04:00
Andrey c2fafbb695 Nissan 2021-07-05 18:43:39 -04:00
rusefillc f498524611 Nissan 2021-07-05 18:38:34 -04:00
rusefillc 9814264bdf Nissan 2021-07-05 18:37:53 -04:00
Andrey 3853e7721a Nissan VVT trigger decoder #2887
one step back
2021-07-03 12:42:07 -04:00
Andrey 2737045eab Nissan VVT trigger decoder #2887 2021-07-03 12:26:31 -04:00
Andrey 0cf095a943 Nissan VVT trigger decoder #2887 2021-07-03 12:02:00 -04:00
Andrey 23e7022e55 Nissan VVT trigger decoder #2887 2021-07-03 11:08:22 -04:00
Andrey f5e937fe2b refactoring: getShaftSynchronized 2021-07-03 10:37:03 -04:00
Andrey 152eea43b1 Nissan VVT trigger decoder #2887 2021-07-03 10:15:41 -04:00
Andrey 36165bed44 Nissan VVT trigger decoder #2887 2021-07-03 09:43:27 -04:00
Andrey e5a1b68eb2 Nissan VVT trigger decoder #2887 2021-07-02 20:28:15 -04:00
Andrey 0af1e8ee59 Nissan progress 2021-07-02 20:12:31 -04:00
Andrey 1660a5b3fd Nissan progress 2021-07-02 19:57:26 -04:00
Andrey 00ea760979 wow we have weird code! 2021-07-02 19:49:00 -04:00
Andrey 9cc82f5068 todo: vvt 2021-07-02 19:06:07 -04:00
Andrey ab8bb3a5cb Nissan VVT trigger decoder #2887 2021-07-01 23:53:53 -04:00
Andrey ae7937402c Nissan VVT trigger decoder #2887 2021-07-01 22:27:43 -04:00
Andrey fccd13247b Nissan VVT trigger decoder #2887 2021-07-01 21:48:47 -04:00
Matthew Kennedy 025c32de00
Stricter miata sync (#2891)
* strict mazda trigger shape

* this is an even better gap

* sync point moved so things are different now

* fix

* update instantrpm in test

* s

* s

* this is safer

* test

* tests

* instant rpm

* cleanup
2021-07-01 21:29:04 -04:00
Matthew Kennedy 8569f028d6
Fix pre sync timestamp copy (#2892)
* fix tests

* fix pre sync copy

* this fixes the issue
2021-07-01 18:58:28 -04:00
Andrey 50e25605b8 Nissan VVT trigger decoder #2887 2021-07-01 17:28:52 -04:00
Matthew Kennedy 5c60973dd8
Consolidate hwHandleShaftSignal (#2875)
* consolidate trigger input

* merge functions

* comment

* dead

* hw vs. not hw

* stray comma

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 10:06:22 -04:00
Andrey 41060a1235 VW warnings on cranking #2861
same resilience for some other triggers
2021-06-27 13:29:09 -04:00
Andrey 21c06e1514 refactoring maybe making code reuse more possible in the future 2021-06-27 13:00:01 -04:00
Andrey 2e252022aa VW warnings on cranking #2861 2021-06-27 12:31:18 -04:00
Andrey 82439b3ffd so many wonderful discoveries 2021-06-27 00:54:38 -04:00
Andrey 4463ca1fdb depressing code comment 2021-06-26 23:01:47 -04:00
Andrey 5adb42f939 refactoring - crankDivider etc etc 2021-06-26 22:42:53 -04:00
Andrey eaff083377 refactoring - explicit read method 2021-06-26 22:17:07 -04:00
Andrey 1822426d0c refactoring - explicit read method 2021-06-26 22:11:42 -04:00
Andrey a5eeb19c4d refactoring - explicit read method 2021-06-26 22:07:45 -04:00
Matthew Kennedy ce4eb2b55d
fix trigger changed logic (#2860)
* reenable

* fix

* longer interval between updates

* only deinit hard trigger outputs if necessary

* init logic

* init order

* warning

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-25 19:38:42 -04:00
rusefillc 0af5de0934
Minor change of Miata NA trigger shape #2855 #669 (#2856)
* Minor change of Miata NA trigger shape #2855 #669

* Minor change of Miata NA trigger shape #2855 #669
2021-06-25 14:12:18 -04:00
Andrey 942eb46471 Trigger: warning code on normal engine start up #669
better TDC unit test approach?
2021-06-25 13:19:16 -04:00
Andrey c40f801e6d Trigger: warning code on normal engine start up #669
making more code unit-testable
2021-06-25 12:50:19 -04:00
Andrey 12067584e9 helping build? 2021-06-25 12:28:55 -04:00
Andrey 5e87b326f2 refactoring 2021-06-25 12:01:59 -04:00
Andrey 266e50f4ca Trigger: warning code on normal engine start up #669
making more code unit-testable
2021-06-25 11:50:23 -04:00
Andrey 66b091a5a5 Trigger: warning code on normal engine start up #669
making more code unit-testable
2021-06-25 11:30:06 -04:00
Andrey 0c97b4bc83 refactoring: reducing code duplication 2021-06-25 10:55:46 -04:00
Andrey 71fdfe6756 giving unit tests a chance to use tdcMarkCallback 2021-06-25 01:31:53 -04:00
Andrey 3092164e48 Minor change of Miata NA trigger shape #2855 #669 2021-06-24 22:21:30 -04:00
Andrey 03f18cd0c8 OMG dead code?! 2021-06-24 22:01:57 -04:00
Andrey c13bb8dbe1 looks like this parameter is very well used now? 2021-06-21 02:12:14 -04:00
Andrey G e561836c58
trigger: subaru 7+6: update cranck angles, add comments (#2789) 2021-06-02 19:19:52 +03:00
Andrey G 8ee700bf76
Subaru svx (#2777)
* Revert "hiding 3rd channel for now"

This reverts commit 50682816ac.

* trigger subaru SVX: disable cranck #2 channel

* Board subaru-eg33: fix D10 pin defined twice

* Board subaru-eg33: renumber ignition ouput according cylinder order

* board subaru eg33: use common_make.sh to get dfu files

* board subaru-eg33: update default configuration
2021-05-31 04:25:57 -04:00
Andrey 39bc62ff2e SVX 2021-05-30 19:59:13 -04:00
Andrey 50682816ac hiding 3rd channel for now 2021-05-29 04:09:12 -04:00
rusefillc 157732d5aa https://rusefi.com/forum/viewtopic.php?f=16&t=2027 2021-05-27 05:50:59 -04:00
Andrey 4216080e49 subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 06:07:31 -04:00
Andrey 9f6ed75582 subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 05:29:41 -04:00
Andrey 2581a53e0d subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 04:46:17 -04:00
Andrey 0ad11168e8 Override trigger gaps feature #2734 2021-05-25 17:19:20 -04:00
rusefillc cc861e1862 Subaru 7+6 trigger refactoring, not changing gap ratio much 2021-05-25 16:31:37 -04:00
Andrey cd5653ff84 Override trigger gaps feature #2734 2021-05-23 20:52:18 -04:00
Andrey bd48753682 Override trigger gaps feature #2734 2021-05-23 20:06:19 -04:00
Andrey cbb6ca0c7c Override trigger gaps feature #2734 2021-05-23 19:58:03 -04:00
Andrey 17f07b6b0e Override trigger gaps feature #2734 2021-05-23 19:51:00 -04:00
David Holdeman 6d4060d824
Doxygen titles (#2728)
* move addRow call

* undo submo bump

* add header titles
2021-05-22 22:10:58 +03:00
rusefillc be931e41d5 docs 2021-05-02 23:46:30 -04:00
rusefillc 2575c8beeb Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2021-04-30 01:05:23 -04:00
rusefillc 10858ae371 https://rusefi.com/forum/viewtopic.php?f=16&t=1996 2021-04-25 09:34:40 -04:00
rusefillc 02d4cde3c4 https://rusefi.com/forum/viewtopic.php?f=16&t=1996 2021-04-25 09:18:35 -04:00
rusefillc ac2d0b99cd https://rusefi.com/forum/viewtopic.php?f=2&t=1993 2021-04-24 22:54:50 -04:00
rusefi 3c9f7174ba improving QC process 2021-04-23 00:45:36 -04:00
rusefi 3e44135947 improving QC process 2021-04-22 21:23:20 -04:00
Matthew Kennedy a70f113b77
finish it off: remove scheduleMsg (#2575)
* finish it off

* one more logger ptr

* fwd decl

* Revert "one more logger ptr"

This reverts commit a21fb0087ddc748978d716db2710800cf26e437b.

* unused

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 15:33:40 -04:00
Matthew Kennedy c26987b96b
Destroy all shared logger (#2574)
* most of shared logger

* a few more

* one more

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
Matthew Kennedy ad71016862
rip the bandaid: find-replace most of scheduleMsg (#2572)
* biiiig find replace

* more trivial find replace

* pwm

* almost all of them

* few more

* gpio

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
rusefillc 2b6345070f WOW major scheduling drama on NB2 running with Proteus #2533 2021-04-15 19:12:09 -04:00
rusefillc 2b8ec15071 WOW major scheduling drama on NB2 running with Proteus #2533
totally same numbers for NB1 just simpler code
2021-04-15 18:44:37 -04:00
rusefillc 3c6c4595c2 WOW major scheduling drama on NB2 running with Proteus #2533
removing weird comments
2021-04-15 18:22:23 -04:00
rusefillc 79e0d6ebd4 dead code - same value set by 's->initialize' 2021-04-13 01:11:03 -04:00
rusefillc 01344ec851 Kawasaki KX450F trigger wheel #2538 2021-04-13 00:24:52 -04:00
rusefillc 027a9efdc8 https://rusefi.com/forum/viewtopic.php?p=40383 2021-04-11 18:20:35 -04:00
rusefillc debd15991e Kawasaki KX450F trigger wheel #2538 2021-04-09 12:44:28 -04:00
rusefillc 2032e5fdb8 Kawasaki KX450F trigger wheel #2538 2021-04-08 22:16:14 -04:00
rusefillc 6c89cdf637 CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534 2021-04-08 14:39:26 -04:00
rusefi 3f914bf3ed trigger and VVT duty cycle integration into limp manager #2523 2021-04-07 15:17:01 -04:00
rusefillc 40c50adf88 trigger and VVT duty cycle integration into limp manager #2523 2021-04-07 12:16:23 -04:00
rusefillc e02f09495b trigger and VVT duty cycle integration into limp manager #2523 2021-04-07 01:21:28 -04:00
rusefillc 9753b6e020 'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528 2021-04-04 23:12:07 -04:00
rusefillc f3c46f2720 refactoring 2021-04-04 23:03:51 -04:00
rusefillc 488f6fed47 todo? 2021-04-04 22:05:55 -04:00
Andrey G bbe3291ccd
hip9011: get callback from spark on each cylinder (#2499)
* hip9011: get callback from spark on each cylinder

* hip9011: cleanup unused
2021-03-27 14:12:49 -04:00
Matthew Kennedy 1c473934b9
plumbing for multiple vvt (#2488)
* plumb multiple vvt

* fix test

* s

* fix barra while we're at it

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
Matthew Kennedy 5e88376e2c
barra vvt cam pattern (#2483)
* barra vvt cam pattern

* two tooth sync

* I think this needs to be here too
2021-03-22 07:48:29 -04:00
Andrey G 89b631a794
Hip9011 and cleanups (#2477)
* hip9011: move hipCs out of EnginePins to hip9011 driver

* hip9011: cleanup debug output, save few RAM bytes

* Supress few signed vs unsigned warnings
2021-03-20 08:40:36 -04:00
Matthew Kennedy be70524ced
harden against various no-boot scenarios (#2468)
* zero length trigger

* validate config

* validate cylinder count

* wrong type on cylinder count

* invalid comment

* invalid SPI
2021-03-17 09:24:13 -04:00
Matthew Kennedy 3072d54717
dead code, warnings (#2461) 2021-03-15 10:23:19 -04:00
Matthew Kennedy e0763c6994
stop trigger emulator PWM when disabled (#2443)
* simplify trig emulator

* spelling is hard

* fix various builds

* spelling again

* add command/button for external stimulation

* enable hw stim for HW-in-loop test

* s

* I does spelling good

* clear flag when disabled

* generate enough for console build

* don't disable that

* this test needs external stimulation enabled

* import

* ui improvements

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-11 08:38:52 -05:00
rusefillc 4e35176e81 TDC Trigger Position #2428
any single-tooth primary trigger should automatically run with "useOnlyPrimaryForSync = true;"
2021-03-08 00:00:48 -05:00
rusefillc e4bd0f6815 removing dead code - initialize() sets 'true' already 2021-03-07 23:37:54 -05:00
Matthew Kennedy 57b79ab6bb
trigger decoder timer (#2427)
* part 2

* stale comment

* include

* why was this a macro

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 16:35:58 -05:00
Matthew Kennedy 5a4c24f9a5
virtual zero timer (#2426)
* virtual zero timer

* it would help to call the correct function

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 15:32:41 -05:00
rusefillc ce78123eb0 M62T vanos support #2243 2021-02-08 22:21:02 -05:00
rusefillc 081357ca5e M62T vanos support #2243 2021-02-08 22:07:14 -05:00
rusefillc 2d99e77c95 M62T vanos support #2243 2021-02-08 21:50:31 -05:00
rusefi 0d6dfbb501 M62T vanos support #2243 2021-02-08 21:28:57 -05:00
rusefi 6793b5d8fc M62T vanos support #2243 2021-02-08 20:38:38 -05:00
rusefi 6b10de5616 refactoring: naming consistency 2021-02-08 18:20:53 -05:00
rusefillc 953990d10b Trigger pattern request Škoda Favorit fix #2302 2021-02-06 20:53:30 -05:00
rusefillc d95ba6b443 Trigger pattern request Škoda Favorit #2302 2021-02-06 20:12:58 -05:00
Matthew Kennedy 870857df36
add option to disable ETB if engine not spinning (#2280)
* config/ui

* trigger central mods

* implement
2021-02-05 17:19:57 -06:00
rusefillc 29db28f077 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-02 11:06:32 -05:00
rusefillc 8ff61e9e68 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-02 09:50:20 -05:00
rusefillc 7eb5816c33 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 23:44:14 -05:00
rusefillc 11f9bf16f6 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 23:18:11 -05:00
rusefillc 9a2cc6b3c9 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 22:49:49 -05:00
rusefillc 4bb9762e2e extracting runtime state from trigger central 2021-01-31 22:41:17 -05:00
rusefillc 869e4cfc49 vvt/cam events to pass index 2021-01-31 22:24:45 -05:00
rusefillc dc80e4e6cb M62T vanos support #2243 2021-01-26 22:54:25 -05:00
rusefillc e219638f60 M62T vanos support #2243 2021-01-26 21:43:23 -05:00
rusefillc b6f5e5f34d M62T vanos support #2243 2021-01-26 21:16:47 -05:00
rusefi 10e980e293 Revert "Save more space in the angle cache (#2228)"
This reverts commit c7ca1b2e
2021-01-18 18:53:00 -05:00
Matthew Kennedy c7ca1b2ef4
Save more space in the angle cache (#2228)
* store event angles in a scaled field

* tests

* comment
2021-01-18 18:31:06 -05:00
Andrey G baea67eccf
Simplify Makefile, unify board.mk files (#2229)
* Proper way to add lis302 driver

* Proper way to add license directory to includes

* Makefile: simplify

All ChibiOS stuff is accumulated in ALLCSRC, ALLINC and so on.

* board.mk: append sources and includes to ALLSRC, ALLCPPSRC, ALLINC

* Cypress: fix CANv2 includence into build
2021-01-17 09:32:06 -05:00
Matthew Kennedy 6a1b9db952
save 1440 bytes (#2226) 2021-01-16 21:22:30 -05:00
Matthew Kennedy 60f70a3721
clean up some includes (#2227)
* cleanup

* make c happy
2021-01-16 09:45:45 -05:00
Matthew Kennedy bdacda558c
fix instant rpm (#2180)
* consumers

* impl

* instant rpm in idle timing
2021-01-14 20:45:55 -05:00