Commit Graph

86 Commits

Author SHA1 Message Date
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy 145316c497
less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
rusefillc d84cf5eea8 splitting accelerations 2021-10-16 20:16:40 -04:00
Matthew Kennedy 86683afca2
trailing spark scheduling (#2932)
* enable bit

* implement trailing sparks

* test trailing spark

* it helps to call the correct function

* add pins

* gobblin ram
2021-07-09 08:37:46 -04:00
Matthew Kennedy 2eb0b2a631
Unified cyl count macro (#2914)
* update test framework

* eh

* hey look it's fewer warnings

* unwind

* fix

* config

* configs

* logic

* even java had some

* console needs help
2021-07-06 20:14:08 -04:00
Matthew Kennedy 13f3d1e291
Fix multi bank fueling (#2661)
* add cylinder number

* changelog

* wording
2021-05-09 09:37:07 -04:00
Matthew Kennedy a5266cd6ef
part of 2217 which may fix it alone (#2220) 2021-01-11 08:01:54 -05:00
Matthew Kennedy 988d9b138c
detect which cylinder knocked (#1732)
* s

* science

* set pin mode

* turn stuff off so it fits

* filtering maybe

* filtering actually works

* generate filter parameters internally

* shorter window

* guard behind enable flag

* use checked in filter

* add biquad reset

* tracing

* const

* exec order

* do it from a thread

* smaller buffer, comment

* configure with header

* only for proteus

* oops

* unused

* not needed

* guards

* pin config

* don't need that include

* precook filter steady state

* define sample rate

* multi cylinder knock

* TS

* only sense when running
2020-08-31 21:05:33 -04:00
Matthew Kennedy 7a85161a4a initialization 2020-07-29 02:22:54 -07:00
Matthew Kennedy 626f55a08a refacto 2020-07-24 18:26:24 -07:00
Matthew Kennedy 8b0d6a26cf Merge remote-tracking branch 'upstream/master' into reset-overlap 2020-07-20 13:27:51 -07:00
Matthew Kennedy 46b7567195 put wall wetting inside 2020-07-20 00:04:05 -07:00
Matthew Kennedy b3261f25f3 add reset 2020-07-14 23:54:41 -07:00
Matthew Kennedy a5d4d06868
Multispark implementation (#1192)
* multispark prototype

* only multispark if not cut

* typo

* do some reasonableish math

* consume cfg

* todo

* bad merge

* move math out of engine2.cpp

* engine state config

* consume generated

* use new

* hand generate

* doc, debugging

* debug channel names

* don't depend on rpmcalc

* safer, fix math

* tests

* default multispark config

* remove todo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-26 01:49:36 -04:00
rusefi bb217b01dd happy new year unification 2020-01-13 21:57:43 -05:00
rusefi eb305f0265 #490 2019-12-03 00:29:12 -05:00
rusefi 1c96d9541e refactoring 2019-12-02 23:08:18 -05:00
rusefi 1cb2f92142 more correct variable names 2019-11-23 23:49:39 -05:00
rusefi af60a46229 making progres on angle-based scheduling 2019-11-23 20:36:40 -05:00
rusefi 1bb3f2698c making progres on angle-based scheduling 2019-11-23 19:47:53 -05:00
rusefi aa4967383a explicit list field to simplify code navigation 2019-11-23 17:04:51 -05:00
rusefi 4574aaccce I got carried away, but DEAD CODE?! 2019-10-08 03:14:21 -04:00
rusefi 2acdbf308b something is over-complicated here? looks like two classes should become one? 2019-10-08 02:56:19 -04:00
rusefi a65c8c9295 something is over-complicated here? looks like two classes should become one? 2019-10-08 02:35:21 -04:00
rusefi fbbf8995e4 wow, dead field 2019-10-08 02:17:32 -04:00
rusefi 2b59940161 really not clear what is the best place for these classes 2019-10-08 02:13:52 -04:00
rusefi 4e26bd2fd2 refactoring 2019-10-08 02:01:41 -04:00
rusefi cd1e87ff41 docs & refactoring 2019-10-08 01:49:42 -04:00
rusefi ade7ad158a typo & better field name 2019-10-08 01:36:03 -04:00
rusefi 42dc9e3662 fancy C++ s/NULL/nullptr/ 2019-10-08 01:26:35 -04:00
rusefi 53231f7b49 refactoring: smarter C++ initialization 2019-10-08 00:27:49 -04:00
rusefi 83ad64eade Refactoring: OS access should be explicit #867 2019-07-04 03:57:21 -04:00
rusefi b81c60cf3e Refactoring: OS access should be explicit #867 2019-07-03 21:48:04 -04:00
rusefi 22ec5da4bc Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778 2019-05-07 21:39:11 -04:00
rusefi 1220a1a1fb Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778
first steps of scheduling metric
2019-05-07 17:22:26 -04:00
rusefi 541c445a2d defined(__DOXYGEN__) ? #748 2019-04-12 22:07:03 -04:00
rusefi ee8297c94d refactoring: reducing header tree hell 2019-01-20 23:30:40 -05:00
rusefi 31db253e12 docs 2017-03-11 22:22:10 -05:00
rusefi 9c2a9de2f6 #366 2017-03-05 14:33:35 -05:00
rusEfi 55e89f0f31 auto-sync 2017-01-03 06:05:22 -05:00
rusEfi 39fd428e0d auto-sync 2016-12-18 22:03:00 -05:00
rusEfi dd7b864492 auto-sync 2016-11-30 22:06:43 -05:00
rusEfi f399233038 auto-sync 2016-11-30 21:06:24 -05:00
rusEfi 0fe292a6ac auto-sync 2016-11-30 19:01:43 -05:00
rusEfi 90989a6579 auto-sync 2016-11-30 18:02:19 -05:00
rusEfi 6f827f5a4f auto-sync 2016-11-28 16:01:48 -05:00
rusEfi c5a51fe752 auto-sync 2016-11-28 14:01:52 -05:00
rusEfi f9fe1ff8a4 auto-sync 2016-11-28 13:02:24 -05:00
rusEfi 28289a2d77 auto-sync 2016-11-28 12:03:02 -05:00