rusefillc
b628c81d26
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-12 00:11:25 -04:00
rusefillc
2f0db8b7c4
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-11 04:21:17 -04:00
Matthew Kennedy
8bc01472b7
Add a timeout for Lua ETB adjustment ( #4331 )
...
* lua etb timeout
* mocks
* test
2022-07-10 05:46:28 +03:00
Matthew Kennedy
3c062e02bc
Lua hooks for gear detection ( #4328 )
...
* implement
* sim has vss
* write a test
* guard
2022-07-07 23:16:56 -04:00
Matthew Kennedy
aecacc6aa1
Rewrite tooth logger buffer management ( #4317 )
...
* s
* make it work
* put back enough maybe
* fix console composite log
* unit tests can just use a vector, why not
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-04 16:57:17 -04:00
Matthew Kennedy
0b10f7dca8
hellen board ID detect improvements ( #4307 )
...
* move call
* board detections work correctly
* improve detector
* s
* break instead of return
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-02 05:19:02 -04:00
Matthew Kennedy
3284282be7
rescale RPM values ( #4300 )
...
* rpm configs
* fix
* s
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-29 18:48:30 -04:00
rusefillc
1b28e292e2
logging of live data structs was: data points #3614
...
huh?
2022-06-29 02:42:03 -04:00
Matthew Kennedy
c0f290b922
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
Matthew Kennedy
fcd3d991ee
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
Matthew Kennedy
34ee344661
fix ( #4279 )
2022-06-23 21:35:05 -04:00
Matthew Kennedy
29420c76aa
wideband live data ( #4276 )
...
* wideband live data magic
* test build happy
* test even happier
2022-06-23 20:04:26 -04:00
Andrey
6ef7562666
VAG Lua progress
2022-06-23 16:02:09 -04:00
Andrey
e4cd9d567d
VAG Lua progress
2022-06-22 22:22:49 -04:00
Matthew Kennedy
11d58f8d5a
clt based rpm limit ( #4267 )
2022-06-22 16:49:24 -04:00
rusefillc
e793124f8d
bit math is hard :(
2022-06-20 21:51:21 -04:00
rusefillc
2ae59f6bd5
bit math is hard :(
2022-06-20 21:36:10 -04:00
GitHub build-unit-tests Action
1d04efa20d
Trigger wheel definitions
2022-06-20 15:54:57 +00:00
GitHub build-unit-tests Action
b5a523af57
Trigger wheel definitions
2022-06-20 12:39:12 +00:00
Matthew Kennedy
932f5e1f30
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit 32d46d1f09
.
* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"
This reverts commit d5e131b1d0
.
* remove synchronizedPhase
* only crank needs this
* changelog
* needsDisambiguation()
* test
* s
* bad merge
* put the timer back
* s
* s
* changelog
* test for new behavior
* correct parameter order
* spelling
* s
* s
* s
* tests merge happy
* bad merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
GitHub build-unit-tests Action
991b7e094e
Trigger wheel definitions
2022-06-02 01:35:22 +00:00
Matthew Kennedy
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
rusefillc
b7743f101f
helping build
2022-05-31 10:45:32 -04:00
rusefillc
22d9bf056a
heling build
2022-05-31 08:48:24 -04:00
GitHub build-unit-tests Action
5ee2236565
Trigger wheel definitions
2022-05-31 02:50:12 +00:00
Matthew Kennedy
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy
f945e6efc9
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy
66fffee321
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
GitHub build-unit-tests Action
da5be301a2
Trigger wheel definitions
2022-05-24 19:05:09 +00:00
rusefillc
6df7d90765
spaces in JAVA_HOME usability
2022-05-24 14:42:42 -04:00
Matthew Kennedy
6f45d0fd46
Fix trigger error indicator ( #4185 )
...
* test and fix
* more shards!
2022-05-19 09:43:42 -04:00
GitHub build-unit-tests Action
af0fa30015
Trigger wheel definitions
2022-05-18 03:24:52 +00:00
rusefillc
458b92e6d9
reduce flash footprint by smarter code generation #4163
2022-05-16 00:00:47 -04:00
rusefillc
8168cad4d7
Revert "Revert "reduce flash footprint by smarter code generation #4163""
...
This reverts commit ea11cc2351
.
2022-05-15 15:15:06 -04:00
rusefillc
ea11cc2351
Revert "reduce flash footprint by smarter code generation #4163"
...
This reverts commit f327897d6c
.
2022-05-15 15:14:04 -04:00
rusefillc
f327897d6c
reduce flash footprint by smarter code generation #4163
2022-05-15 12:05:38 -04:00
Andrey
146d887cdd
reduce flash footprint by smarter code generation #4163
2022-05-15 10:07:17 -04:00
Andrey
d38d8a7840
altering technical debt
2022-05-15 10:07:17 -04:00
rusefillc
500c443a15
Timestamp Error scheduleByTimestampNt too far #3395
...
improving error message
2022-05-14 21:24:19 -04:00
Matthew Kennedy
ae91b2aea8
don't rely on triggerStateListener to detect trigger errors ( #4164 )
...
* Write proper TriggerDecoder tests
* Improve logic around sync loss
* these tests I understand
* these I sort of understand....
* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
GitHub build-unit-tests Action
6b3d1446e0
Trigger wheel definitions
2022-05-11 10:54:37 +00:00
Matthew Kennedy
098b2c87c6
Proper decoder testing ( #4166 )
...
* Write proper TriggerDecoder tests
* patch test for un-patched decoder
2022-05-11 06:14:45 -04:00
Matthew Kennedy
d4509cab8a
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
rusefillc
2132cec3fc
Remove value copy from controller into outputChannels #4095
2022-05-09 06:12:17 -04:00
rusefillc
bd9639b91d
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
Matthew Kennedy
e13dad3a2a
support better wbo format ( #4000 )
...
* new format
* comment
* pr feedback
* heater duty
* extra
* comment
* test multi-accept logic
* s
* test new format
* this comment made no sense
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-07 02:19:51 -04:00
GitHub build-unit-tests Action
c73d9bdbf8
Trigger wheel definitions
2022-05-06 12:37:23 +00:00
Matthew Kennedy
b650bbe46c
Trigger gm 3 vs 5 ( #4140 )
...
* add parameter
* two modes
* add new mode to list
* format
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
Matthew Kennedy
58619b4115
Scaled channel ints ( #4129 )
...
* test that fails today
* Revert "int32 scaled_channel has float precision #4128"
This reverts commit 03d44b75ea
.
* fix the problem
* format
* x
* s
2022-05-02 15:20:02 -04:00
Andrey
3c3ce36753
helping build
2022-05-02 06:30:06 -04:00
rusefillc
9b9b67f932
helping build
2022-05-02 05:57:53 -04:00
Andrey
e62877964a
Move curves out of engineConfiguration in order to reduce RAM usage #4127
2022-05-01 23:43:43 -04:00
rusefillc
d24bff2d23
Technical debt: ENUM_32_BITS #3874
2022-05-01 08:48:54 -04:00
rusefillc
107685f069
this seems mostly dead?
2022-04-30 13:43:09 -04:00
rusefillc
571211501e
2 byte pin index #4097 ( #4102 )
...
* 2 byte pin index #4097
* 2 byte pin index #4097
good time to defragment configuration
* 2 byte pin index #4097
new fancy way
* 2 byte pin index #4097
smart comment
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-04-29 19:35:31 -04:00
Matthew Kennedy
e4a0979dc2
Brain pin is enum class ( #4108 )
...
* change most usages to Gpio::
* board configs
* engine configs etc
* isBrainPinValid, smart gpio
* generator
* generator
* generator
* connector yamls
* kinetis enums
* cypress txt
* kinetis config
* frankenso
* config generator
* actually do it for the others
* disable skips for pr ci
* fix tle8888
* misc
* weird cast from int
* needs this operator too
* this can be an unsigned subtract
* happy tests
* s
* kinetis isConfigurationChanged weirdness
* missed J/K
* cypress efifeatures
* build script mistake (!)
* mistake in smart gpio
* debounce
* eg33
* kinetis, so needy
* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Matthew Kennedy
38213bbc00
more missing autoscale ( #4112 )
...
* autoscale m_config->timeConstant
* min/max afr
* more
* dwell voltage
* closed loop fuel
* knock
* map estimate
* applyNonlinearBelowPulse
* fix
* add a test while we're at it for un-covered code
* test fallback MAP since we touched that
* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
Matthew Kennedy
c3fb211d6b
fix vss/iss filter parameter validation ( #4114 )
...
* fix filter parameter validation
* use values that don't get clipped
2022-04-27 22:29:51 -04:00
rusefillc
ddd85e701e
Remove value copy from controller into outputChannels #4095
2022-04-23 20:38:48 -04:00
rusefillc
71275e841b
m_hasSynchronizedSymmetrical handling improvements #4099 ( #4101 )
2022-04-23 19:45:29 -04:00
Andrey
4492bc760a
m_hasSynchronizedSymmetrical handling improvements #4099
2022-04-23 19:03:59 -04:00
Andrey
7b64aa5880
m_hasSynchronizedSymmetrical handling improvements #4099
2022-04-23 18:46:12 -04:00
rusefillc
14e37e3cf4
FasterEngineSpinUp should be enabled by default fix #4094
2022-04-23 09:51:47 -04:00
Matthew Kennedy
16de438ab8
knock threshold table fix ( #4077 )
...
* fix knock threshold table
* defaults
* knock controller is engine module
* testable
* test builds
* knock tests work
* s
* format
* everyone loves changelogs
2022-04-18 08:03:16 -04:00
Matthew Kennedy
6aef4f10d0
fragment refactoring ( #4072 )
...
* fragment refactoring
* jar
* jar?
2022-04-16 09:24:45 -04:00
rusefi
141804f490
steps towards better commands encapsulation
2022-04-14 01:44:35 -04:00
rusefillc
44ed81fce0
logging of live data structs was: data points #3614
...
handling request past end of fragments
2022-04-13 23:31:32 -04:00
rusefillc
53d31ee0ea
logging of live data structs was: data points #3614
...
support for null fragments
2022-04-13 20:46:55 -04:00
rusefillc
3c7eb93fe1
steps towards ignition live data
2022-04-13 16:48:25 -04:00
Matthew Kennedy
baef88d1c7
make the vss fliter parameter work again ( #4056 )
...
* vss has adjustable filter
* tooltip and validate
* s
2022-04-09 09:00:19 -04:00
Matthew Kennedy
bd2b5a3dba
gear detection validation ( #4053 )
...
* gear detection validation
* test validation because why not
2022-04-09 08:59:07 -04:00
Matthew Kennedy
f0b810a81c
Gear detection implementation ( #4052 )
...
* gear detect improvements
* ui
* ui for gear ratios
* ui
* output channel
* output channels etc
* implement gear detection
* name
* s
* status loop
* missing function
* ui tweaking
* s
2022-04-07 09:21:11 -04:00
Matthew Kennedy
ad368b2031
Gear detection improvements ( #4047 )
...
* gear detect improvements
* ui
* ui for gear ratios
* ui
2022-04-06 16:15:58 -04:00
rusefillc
b005a049e2
JNI for test coverage #3965
2022-04-04 22:33:30 -04:00
Andrey
8053aeb9cf
Extra Idle Air if Throttle is Pressed behavior #3940
...
only live data
2022-04-03 20:30:09 -04:00
GitHub build-unit-tests Action
ec3fc18a2d
Trigger wheel definitions
2022-04-03 22:10:40 +00:00
Andrey
093de78ff3
Proper cam speed labels in triggers #4021
2022-04-03 17:56:47 -04:00
GitHub build-unit-tests Action
dcd1419c59
Trigger wheel definitions
2022-04-03 16:42:45 +00:00
rusefillc
e631988b22
Proper cam speed labels in triggers #4021
2022-04-03 12:22:47 -04:00
Matthew Kennedy
289122c0b7
fix 4032 ( #4034 )
...
* fix 4032
* board defaults should not set these things
2022-04-03 06:58:25 -04:00
Andrey
204ac3961b
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
WOW it works?!
2022-04-03 02:30:43 -04:00
Andrey
cc9a1136c4
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 02:21:37 -04:00
Andrey
b0be8c4b66
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
progress: this way test is less fake!
2022-04-03 02:13:56 -04:00
Andrey
5840a61f55
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:02:13 -04:00
Andrey
95d36b37e3
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 00:34:18 -04:00
rusefillc
6b5747d4c8
refactoring: method rename
2022-04-02 21:01:29 -04:00
GitHub build-unit-tests Action
61897aa3ee
Trigger wheel definitions
2022-04-02 23:28:57 +00:00
rusefillc
086739d20a
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 19:08:22 -04:00
GitHub build-unit-tests Action
0c0b5f582a
Trigger wheel definitions
2022-04-02 19:26:13 +00:00
rusefillc
174a3f33bd
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-01 22:05:25 -04:00
GitHub build-unit-tests Action
d2c694c0b2
Trigger wheel definitions
2022-03-24 00:18:03 +00:00
GitHub build-unit-tests Action
be283b96d2
Trigger wheel definitions
2022-03-22 10:45:51 +00:00
rusefillc
b1de262520
toothed previous time #4019
2022-03-21 20:41:09 -04:00
GitHub build-unit-tests Action
cb952a702c
Trigger wheel definitions
2022-03-21 00:24:31 +00:00
GitHub build-unit-tests Action
3a40347835
Trigger wheel definitions
2022-03-20 02:22:26 +00:00
GitHub build-unit-tests Action
f3e377bb27
Trigger wheel definitions
2022-03-20 00:11:47 +00:00
Andrey
1b334656e1
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-03-19 19:59:36 -04:00
GitHub build-unit-tests Action
f3b2cefe27
Trigger wheel definitions
2022-03-19 23:45:58 +00:00
GitHub build-unit-tests Action
b62eb9dbb8
Trigger wheel definitions
2022-03-19 21:05:36 +00:00
GitHub build-unit-tests Action
e3bb929c6d
Trigger wheel definitions
2022-03-19 20:14:32 +00:00
GitHub build-unit-tests Action
e35bf1edaf
Trigger wheel definitions
2022-03-19 16:35:49 +00:00
rusefillc
697f675daf
JNI for test coverage #3965
2022-03-19 11:55:44 -04:00
Matthew Kennedy
4e57daf6d7
test AEM X-Series wideband protocol ( #4002 )
...
* break out acceptFrame, test CanListener
* test AEM xseries protocol
* tweaks
* tweaks
* maybe everyone compiles happily now
2022-03-15 15:52:50 -04:00
rusefillc
cbd6879ddf
JNI for test coverage #3965
2022-03-15 13:57:40 -04:00
rusefillc
6c8f130ff9
JNI for test coverage #3965
2022-03-15 13:05:24 -04:00
rusefillc
2181430101
JNI for test coverage #3965
2022-03-15 11:09:54 -04:00
rusefillc
05e8f7f6d4
gtest in library is hard ( #3998 )
...
* Revert "Revert "JNI for test coverage #3965""
This reverts commit 7566328816
.
* JNI for test coverage #3965
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-03-14 22:15:21 -04:00
GitHub build-unit-tests Action
330e4065fe
Trigger wheel definitions
2022-03-15 00:55:36 +00:00
Matthew Kennedy
a0f114a9a2
break out acceptFrame, test CanListener ( #4001 )
2022-03-14 19:09:01 -04:00
Matthew Kennedy
5811f691d9
things are happy without gtest ( #3999 )
...
* things are happy without gtest
* this is not a static lib
2022-03-14 15:00:02 -04:00
rusefillc
3076027887
spelling
2022-03-14 13:11:10 -04:00
rusefillc
983688a9fa
JNI for test coverage #3965
2022-03-14 00:10:01 -04:00
rusefillc
8733841c79
JNI for test coverage #3965
2022-03-13 21:36:25 -04:00
rusefillc
6aa62190ee
JNI for test coverage #3965
2022-03-13 21:04:04 -04:00
rusefillc
9d0f1fe64a
Jni engine ( #3995 )
...
* JNI for test coverage #3965
* JNI for test coverage #3965
* JNI for test coverage #3965
2022-03-13 20:03:49 -04:00
rusefillc
20cf22665e
JNI for test coverage #3965
2022-03-13 00:25:10 -05:00
rusefillc
19c034db51
JNI for test coverage #3965
2022-03-13 00:06:26 -05:00
rusefillc
6dca5bfcc4
JNI for test coverage #3965
2022-03-13 00:01:16 -05:00
rusefillc
44b5383a71
JNI for test coverage #3965
2022-03-12 23:47:38 -05:00
Matthew Kennedy
0937de1b84
flash storage uses 32 bit CRC ( #3984 )
...
* better flash logic and warning message
* comment
* s
* ssssss
* simplify logic
* use 32 bit crc
* s
* don't test things that don't exist
2022-03-08 23:17:35 -05:00
rusefillc
9b99fc306c
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:37:08 -05:00
rusefillc
56bb2e2c70
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:34:39 -05:00
rusefillc
e688dd10d1
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:30:36 -05:00
rusefillc
be368ad2d2
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:29:28 -05:00
rusefillc
825a8d38ee
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:27:04 -05:00
rusefillc
a036dcda87
JNI for test coverage #3965
2022-03-01 00:13:39 -05:00
rusefillc
82686cfb9f
JNI for test coverage #3965
2022-02-28 12:54:33 -05:00
rusefillc
2eda9310b2
JNI for test coverage #3965
2022-02-26 21:52:52 -05:00
rusefillc
af39ca9eba
JNI for test coverage #3965
...
hello darwin
2022-02-26 21:02:34 -05:00
rusefillc
6cbb602c08
JNI for test coverage #3965
2022-02-26 21:02:34 -05:00
rusefillc
2955f66f66
JNI for test coverage #3965
2022-02-26 21:02:34 -05:00
rusefillc
1a6c0c57c8
JNI for test coverage #3965
2022-02-26 18:12:34 -05:00
rusefillc
865cd1bc54
JNI for test coverage #3965
2022-02-26 18:12:34 -05:00
Andrey G
067055095f
cli registry: rework this hell, add FFF and FFFFF ( #3964 )
...
* cli registry: rework this hell, add FFF and FFFFF
* kinetis: no nodefaultlib
* revert back token helpers
* cli_registery: argument parser: do not eat qoutes
* Unit test for FFF
* cli_registry: remove debug
2022-02-26 16:58:10 -05:00
rusefillc
c94bbcc34f
one step back: helping master
2022-02-26 13:52:39 -05:00
rusefillc
540c68d7ce
dead code: THUMB really does not apply here
2022-02-26 13:48:51 -05:00
rusefillc
95b1d6cc5b
JNI for test coverage #3965
2022-02-26 13:10:57 -05:00
rusefillc
ef3b23312e
refactoring
2022-02-26 13:03:22 -05:00
rusefillc
abca5dca2f
JNI for test coverage #3965
2022-02-26 12:51:50 -05:00
rusefillc
0130933dd7
BMW 6HP gatewy #3954
2022-02-22 23:13:32 -05:00
rusefillc
970d63568f
Revert "lua: TDD of enabling base lib"
...
This reverts commit d8b3712817
.
2022-02-22 20:50:38 -05:00
rusefillc
d8b3712817
lua: TDD of enabling base lib
2022-02-22 16:25:41 -05:00
rusefillc
38d7f12b30
BMW 6HP gatewy #3954
2022-02-22 15:35:50 -05:00
rusefillc
dc824f0c42
N73
2022-02-21 11:29:46 -05:00
rusefillc
70ea61c091
N73
2022-02-19 20:46:04 -05:00
Matthew Kennedy
f1897ba7aa
less dependence on that logger ( #3884 )
...
* less dependence on that logger
* comma
* refactor a bit, make it clear what this thing actually *does*
* static
* shrink the buffer a bit and make names useful
* dead util that's just subtraction lol
2022-02-09 06:53:16 -05:00
Matthew Kennedy
d8073e8b27
remove mock adc ( #3888 )
...
* remove mock adc
* do these do /anything/?
2022-02-03 20:43:34 -05:00
Andreika
2beca221a3
hellen_board_id + hellen-common.mk ( #3885 )
...
* Hellen_board_id
* move EXTI init before config load
* add NT2USF()
* Hellen_board_id unit-tests
* hellen-common.mk
* fix for older macos compiler
2022-02-03 11:24:31 -05:00
Matthew Kennedy
06437f304f
dead StartupFuelPumping ( #3883 )
...
* dead
* test
* dead config too
2022-02-03 08:01:21 -05:00