Andrey
3748bf5ad0
proportional spark cut #3427
2021-11-16 05:56:15 -05:00
Matthew Kennedy
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
Scott Smith
344c9073e2
Start the process of using a global engine ptr for unit tests. ( #3551 )
...
* Start the process of using a global engine ptr for unit tests.
Passing around the engine, config, and persistent state wasn't buying anything. Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables. Add a dummy check in
case some test tries to set them manually.
* Fix OSX build
* Adapt PR to recently added code.
2021-11-16 00:23:14 -05:00
Andrey
655b77dc3f
random refactoring: trigger central encapsulation
2021-11-15 20:22:05 -05:00
Andrey
928c673695
refactoring launch
2021-11-15 20:09:03 -05:00
Andrey
05fa6071dd
refactoring launch
2021-11-15 19:55:04 -05:00
Andrey
4002c92dcc
refactoring launch
2021-11-15 18:57:12 -05:00
Andrey
34015eceee
refactoring launch
2021-11-15 14:40:35 -05:00
Matthew Kennedy
cb032fb1ea
(void) -> () ( #3550 )
...
* static functions with (void)
* more
* Revert "more"
This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy
145316c497
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
rusefillc
22c872d8d8
Epic: Remove FSIO #2928
2021-11-14 10:57:19 -05:00
rusefillc
6210eaacf7
script settings need names!
2021-11-13 23:10:38 -05:00
Andrey
cd57e1fdb6
Something something Automatic Compression Release #3442
2021-11-11 20:16:46 -05:00
Andrey
6436a2b9a4
dead line
2021-11-11 20:16:46 -05:00
Scott Smith
158f719d95
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
Scott Smith
f9e36f5ea4
Configuration for HPFP control algorithm. ( #3475 )
2021-11-05 23:15:35 -04:00
rusefillc
85984928ca
more curves! also names for curves
2021-11-04 23:19:44 -04:00
Matthew Kennedy
59e9d05fc7
extract engine phase function ( #3456 )
...
* extract getCurrentEnginePhase
* inject engine ref
* never invalid RPM, use 0 instead
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00
Matthew Kennedy
75a2b5ef02
Knock retard ( #3396 )
...
* output gauge
* knock controller
* don't need that
* inject engine ref
* test knock
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-01 23:33:59 -04:00
rusefillc
61e2b3d5db
Remove engine load acceleration enrichment fix #3357
2021-10-16 21:24:05 -04:00
Matthew Kennedy
9797d25b7c
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
Matthew Kennedy
9806373dac
dead map ( #3316 )
2021-10-04 18:33:10 -04:00
Matthew Kennedy
db12cdbe19
put MAP in the sensor model ( #3292 )
...
* map averaging in sensor model
* deadly, deadly code!
* mpxh
* Revert "deadly, deadly code!"
This reverts commit 346fe25267966a313145a809792dced84be348cf.
* comments
* sensor types
* last sensor
* channel init
* correct spot
* deinit properly
* simplify
* fix
* mocks
* map init test
* showInfo
* comment
* singleton identity function
* sensor info print
* multiple cylinder averaging buffer
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-10-04 17:18:08 -04:00
Matthew Kennedy
f6d492121e
shrink multi cylinder map average buffer ( #3315 )
...
* halve
* add tooltip, rename UI
2021-10-04 07:50:17 -04:00
rusefillc
b4884498cb
OBD error renames
2021-10-03 01:30:42 -04:00
Andrey
fdab6c303c
overdwell protection #3071
2021-10-02 01:33:26 -04:00
rusefillc
77ebc71f9a
overdwell protection #3071 ( #3294 )
2021-10-02 01:17:53 -04:00
Matthew Kennedy
0a550a70b1
overdwell protection ( #3220 )
...
* cancel event
* looks like it works...
* some tests are happy
* add enable bit
* undo test changes
* Revert "add enable bit"
This reverts commit 000afadd3fc560867302557afe26f76cd9fc4ed6.
* enable bit in engine
* only turn off for one test
* Revert "undo test changes"
This reverts commit 106db49e291b5a531a94de6ac177c6584d5337f6.
2021-10-02 01:10:24 -04:00
Andrey
2a2722c3cc
SPARK_EXTREME_LOGGING
2021-10-01 23:50:32 -04:00
Matthew Kennedy
90e5fba5db
dead code in map avg ( #3290 )
...
* dead code in map avg
* while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-30 23:05:58 -04:00
Matthew Kennedy
4b6a67f8f0
bye frequency map ( #3285 )
...
* bye freq map
* map.cpp
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-30 00:20:21 -04:00
rusefillc
a6fbb98193
Complete fuel cut, maybe by wall wetting? Warning on decel (?) CUSTOM_OBD_SKIPPED_FUEL = 9010 fix #3225
2021-09-27 22:04:03 -04:00
rusefillc
bca1b11146
"Injector Duty cycle cut"
2021-09-26 20:59:32 -04:00
Matthew Kennedy
34c98c1485
weak link stub ( #3258 )
2021-09-22 14:33:25 -04:00
Matthew Kennedy
8cd132b8a8
dead knock code ( #3255 )
...
* more unification
* hip stub
* comment
* guard
* channel idx
* include
* hip
* move in to engine
* hip9011
* dead stuff
* dead
* fsio
* lcd
* more dead
2021-09-21 20:40:20 -04:00
Matthew Kennedy
5de27e0b92
more knock sense unification ( #3250 )
...
* more unification
* hip stub
* comment
* guard
* channel idx
* include
* hip
* move in to engine
* hip9011
2021-09-21 17:39:21 -04:00
Matthew Kennedy
bf98546314
share some knock logic ( #3246 )
...
* knocky knock
* only if TS
* typo
* merge
2021-09-20 16:10:34 -04:00
rusefillc
ff6edb9790
refactoring: just a better constant name
2021-09-08 20:32:50 -04:00
rusefillc
0159e8e32b
Smart ECU: misfire detection #936
2021-09-06 15:29:36 -04:00
rusefillc
059a82bcb2
Smart ECU: misfire detection #936
2021-09-06 11:10:11 -04:00
rusefillc
a555b7a00f
Smart ECU: misfire detection #936
2021-09-06 10:35:26 -04:00
Matthew Kennedy
87e4e7e4cf
simpler way for limp manager to handle engine stop ( #3194 )
...
* simpler
* why would we lie about spinning?
2021-08-25 11:29:20 +03:00
rusefillc
cc9b8ffa98
Implement auto knock threshold sampling #3033
2021-08-10 06:42:39 -04:00
Matthew Kennedy
5ff7235040
don't "validate instant RPM" ( #3095 )
...
* don't "validate instant RPM"
* test actually tests the right thing
* test mode transition
2021-08-04 08:17:14 +03:00
Matthew Kennedy
25414ebdad
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy
0d983855b9
instant rpm uses full engine cycle ( #3077 )
...
* instant rpm uses full engine cycle
* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
Matthew Kennedy
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
Matthew Kennedy
2368e90ae7
dead ( #3016 )
2021-07-23 08:31:23 -04:00
Andrey
8b5dde5a8f
trailing spark outputs fix #2931
2021-07-22 00:01:54 -04:00
Matthew Kennedy
76924be3d1
not setValue ( #3026 )
2021-07-21 23:36:46 -04:00