Apply suggestions from code review

Co-authored-by: str4d <jack@electriccoin.co>
This commit is contained in:
Kris Nuttycombe 2021-12-03 14:23:42 -07:00
parent a6420858f4
commit fd300e0061
2 changed files with 4 additions and 4 deletions

View File

@ -21,7 +21,7 @@ pub enum Fvk {
/// A pruned version of the extended public key for the BIP 44 account corresponding to the /// A pruned version of the extended public key for the BIP 44 account corresponding to the
/// transparent address subtree from which transparent addresses are derived. This /// transparent address subtree from which transparent addresses are derived. This
/// includes just the chain code (32 bytes) and the public key (33 bytes) and excludes /// includes just the chain code (32 bytes) and the compressed public key (33 bytes), and excludes
/// the depth of in the derivation tree, the parent key fingerprint, and the child key /// the depth of in the derivation tree, the parent key fingerprint, and the child key
/// number (which would reveal the wallet account number for which this UFVK was generated). /// number (which would reveal the wallet account number for which this UFVK was generated).
/// ///
@ -31,7 +31,7 @@ pub enum Fvk {
/// include transparent receivers. To achieve this, we treat the last hardened node in /// include transparent receivers. To achieve this, we treat the last hardened node in
/// the BIP 44 derivation path as the "transparent viewing key"; all addresses derived /// the BIP 44 derivation path as the "transparent viewing key"; all addresses derived
/// from this node use non-hardened derivation, and can thus be derived just from this /// from this node use non-hardened derivation, and can thus be derived just from this
/// extended public key. /// pruned extended public key.
P2pkh([u8; 65]), P2pkh([u8; 65]),
Unknown { Unknown {

View File

@ -26,7 +26,7 @@ pub enum Ivk {
/// A pruned version of the extended public key for the BIP 44 account corresponding to the /// A pruned version of the extended public key for the BIP 44 account corresponding to the
/// transparent address subtree from which transparent addresses are derived, /// transparent address subtree from which transparent addresses are derived,
/// at the external `change` BIP 44 path, i.e. `m/44'/133'/<account_id>'/0`. This /// at the external `change` BIP 44 path, i.e. `m/44'/133'/<account_id>'/0`. This
/// includes just the chain code (32 bytes) and the public key (33 bytes) and excludes /// includes just the chain code (32 bytes) and the compressed public key (33 bytes), and excludes
/// the depth of in the derivation tree, the parent key fingerprint, and the child key /// the depth of in the derivation tree, the parent key fingerprint, and the child key
/// number (which would reveal the wallet account number for which this UFVK was generated). /// number (which would reveal the wallet account number for which this UFVK was generated).
/// ///
@ -36,7 +36,7 @@ pub enum Ivk {
/// include transparent receivers. To achieve this, we treat the last hardened node in /// include transparent receivers. To achieve this, we treat the last hardened node in
/// the BIP 44 derivation path as the "transparent viewing key"; all addresses derived /// the BIP 44 derivation path as the "transparent viewing key"; all addresses derived
/// from this node use non-hardened derivation, and can thus be derived just from this /// from this node use non-hardened derivation, and can thus be derived just from this
/// extended public key. /// pruned extended public key.
P2pkh([u8; 65]), P2pkh([u8; 65]),
Unknown { Unknown {