9319dd4c3e
Implement XNOR using `assert_eq!`
...
Because of course that is simpler than building it from XOR.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-03 00:12:55 +00:00
fa75c9587c
zcash_address: Avoid an unnecessary allocation while parsing a UA
2022-02-03 00:02:03 +00:00
4a30679491
f4jumble: Return `Error` from allocating functions
2022-02-03 00:02:03 +00:00
682d5235c2
Merge pull request #501 from nuttycom/fix_beta_lints
...
Fix Clippy beta linting complaints.
2022-02-02 23:31:33 +00:00
a304c3953b
Fix Clippy beta linting complaints.
2022-02-02 16:02:45 -07:00
e63979e80a
Merge pull request #504 from nuttycom/merge_non_consensus_changes
...
Merge all non-consensus changes staged for NU5 to `master`.
2022-02-02 22:25:30 +00:00
60d9124453
Merge branch 'non-consensus-changes-on-branchid-37519621' into 'master'
2022-02-02 14:38:09 -07:00
4f4a25252f
Merge pull request #341 from nuttycom/autoshield-poc-daa
...
Add auto-shielding to the data access API
2022-02-02 14:26:05 -07:00
3699a6df97
Fix typos.
2022-02-02 14:00:05 -07:00
cdd899dda1
Fix documentation.
...
Co-authored-by: str4d <jack@electriccoin.co>
2022-02-02 12:53:59 -07:00
488d13fde3
Do not delete sent note data in rewind.
2022-02-02 12:48:22 -07:00
1507d1de0a
Fix incorrect construction of transparent OVKs.
2022-02-02 10:33:44 -07:00
b4ff3f368e
Add test vectors for transparent OVKs.
2022-02-02 10:33:44 -07:00
6b189f18ff
Correct the changelog relating to `store_decrypted_tx`
2022-02-02 10:33:44 -07:00
632b9ee22f
Merge pull request #494 from zcash/internal-key-tvs
...
Internal key test vectors
2022-02-02 10:33:44 -07:00
0c80399fe1
zcash_primitives::zip32::tests: Use internal test vectors.
2022-02-02 10:33:44 -07:00
cf4c982483
zcash_primitives::zip32: Include test vectors for internal key components.
2022-02-02 10:33:44 -07:00
9c2d485c80
Address comments from code review.
...
Co-authored-by: str4d <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-02 10:33:41 -07:00
2dd0348792
Remove the `nullifiers` argument from `store_decrypted_tx`
...
This value can be obtained internally within the implementation
of `store_decrypted_tx` and does not need to be part of the
public API.
2022-02-02 10:32:35 -07:00
41810e5be9
Merge remote-tracking branch 'upstream/non-consensus-changes-on-branchid-37519621' into autoshield-poc-daa
2022-02-02 10:32:35 -07:00
3d51c53d68
Address comments from code review.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-02 10:32:33 -07:00
8916a16f38
Replace ripemd160 dependency with ripemd
2022-02-02 10:30:43 -07:00
d0e1f98429
Use extension traits for transparent-related data api functionality.
2022-02-02 10:30:43 -07:00
5a75c210f0
Fix order of note deletion relative to transactions being un-mined in rewind.
2022-02-02 10:30:07 -07:00
e8e5d94ea6
Mark functions that will be made crate-private as deprecated
2022-02-02 10:29:19 -07:00
d7fe28ac3f
zcash_primitives: Update ZIP 244 with coinbase fix
...
This corresponds to the ZIP 244 changes in zcash/zips#587 .
Closes zcash/librustzcash#485 .
2022-02-01 15:57:39 +00:00
f28f0b7476
Merge branch 'non-consensus-changes-on-branchid-37519621'
2022-02-01 15:57:13 +00:00
d52171768f
Merge pull request #496 from nuttycom/beta_lints
...
Use clippy beta instead of nightly
2022-02-01 15:55:47 +00:00
9940d275fb
Use clippy beta instead of nightly
2022-02-01 08:26:05 -07:00
9711fa227f
Merge pull request #495 from zcash/pin-protobuf
...
Restrict cargo to `protobuf >=2.20,<2.26`
2022-02-01 08:25:28 -07:00
e9ecb19143
Restrict cargo to `protobuf >=2.20,<2.26`
...
`protobuf 2.26.0` bumped its MSRV to 1.52.1, which is incompatible with
our current MSRV.
2022-02-01 14:26:47 +00:00
b3fbf2410d
Allow use of internal deprecated pubkey_to_address method.
2022-01-27 21:21:18 -07:00
2f1d3da26d
Update changelogs.
2022-01-27 16:25:01 -07:00
4057b066bd
ExtendedFullViewingKey::chain_code should not be public.
2022-01-27 16:18:26 -07:00
6e11f2d11a
Validate ZIP 321 request by roundtrip through the URI format.
...
Co-authored-by: str4d <jack@electriccoin.co>
2022-01-27 16:08:04 -07:00
544c4ed6bb
Remove unused zcash_address dependency.
2022-01-27 16:08:04 -07:00
a1e693d15f
Remove the Wif type; it should not be used.
...
We should attempt to avoid passing spending keys back and forth
across the FFI entirely, but in any case this is no longer the
correct type to use at this boundary; we should use the encoding
of the transparent component of a unified spending key instead.
2022-01-27 16:08:04 -07:00
3a20176092
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
2022-01-27 15:00:37 -07:00
132df78a31
Add serialization and deserialization for AccountPubKey
2022-01-27 08:52:12 -07:00
6fcdfda69e
Derive OVKs from transparent account-level key, not child keys.
...
This also renames a number of legacy key types to better reflect
their intended use.
2022-01-26 13:36:27 -07:00
47fc12704b
Fix doctest compilation.
2022-01-25 10:01:48 -07:00
0b43535203
Move OutgoingViewingKey to zcash_primitives::keys
2022-01-25 08:53:51 -07:00
f58d191439
Move transparent account keys to zcash_primitives.
2022-01-25 08:53:51 -07:00
72c2e54a7b
Add explicit serialize and deserialize methods to ExternalPubKey
...
The serialization defined by HDWallet for the fields of ExtendedPubKey
is in the opposite field order from what is defined in ZIP 316.
2022-01-24 16:25:06 -07:00
8b0c1c4ab2
transparent::ExternalPubKey: impl TryFrom for &[u8; 65].
2022-01-24 14:41:40 +08:00
4068075ffd
Merge remote-tracking branch 'upstream/non-consensus-changes-on-branchid-37519621' into autoshield-poc-daa
2022-01-22 23:10:47 -07:00
cec128b8c7
Merge pull request #480 from zcash/transparent-ovk
...
[ZIP 316] Transparent internal and external ovk
2022-01-22 23:03:12 -07:00
4dac37ffde
Ensure that transparent input functionality is correctly feature-flagged.
2022-01-22 22:33:22 -07:00
a7ea5f0bc1
Implement TryFrom<&[u8] for ExternalPubKey.
2022-01-22 22:29:45 -07:00
6f776aacc3
zcash_primitives::zip316::transparent: Parse Ufvk from zcash_address.
2022-01-22 22:29:45 -07:00
str4d
Kris Nuttycombe
therealyingtong
Kris Nuttycombe