Commit Graph

3930 Commits

Author SHA1 Message Date
Daira-Emma Hopwood 3582f84686 Allow `ChangeValue::output_pool` to reference the transparent pool by
changing its type from `ShieldedProtocol` to `PoolType`.

Also fix compilation errors when the "orchard" feature is used without
the "transparent-inputs" feature.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-18 21:03:22 +01:00
Daira-Emma Hopwood 1d9fede906 Cosmetic fixes to changelog.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-18 21:03:22 +01:00
str4d dd3a55713f
Merge pull request #1429 from zcash/zcs-db-docs
zcash_client_sqlite: Start documenting the table structures
2024-06-18 20:50:07 +01:00
str4d 444de3bdfa
Merge pull request #1428 from AArnott/patch-1
Drop orchard unstable flag from VS Code settings
2024-06-18 20:26:52 +01:00
Jack Grigg cf1922cdee zcash_client_sqlite: Move pinned views to `wallet::db` module 2024-06-18 19:21:03 +00:00
Jack Grigg 39bf4caa20 zcash_client_sqlite: Initial pass at documenting table structures
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2024-06-18 16:48:05 +00:00
Jack Grigg 3599c6afe7 zcash_client_sqlite: Move pinned indices to `wallet::db` module 2024-06-18 14:24:33 +00:00
Jack Grigg 9c98a649ee zcash_client_sqlite: Move pinned table structures to `wallet::db` module 2024-06-18 14:24:33 +00:00
Andrew Arnott bb06f84f65
Drop orchard unstable flag from VS Code settings
This setting is no longer required, and its presence greatly increases build and test times while using VS Code extensions for rust because inconsistent settings are used, defeating the rust build cache.
2024-06-18 08:14:39 -06:00
Kris Nuttycombe 87e23081d0
Merge pull request #1421 from zcash/dep-bip32
Migrate from `hdwallet` to `bip32`
2024-06-17 17:04:14 -06:00
str4d 03fc64cfd0
Merge pull request #1396 from nuttycom/test/block_spanning_shards
`zcash_client_sqlite` Fix error related to commitment tree frontier insertions.
2024-06-17 19:29:44 +01:00
Kris Nuttycombe 3e090dca66 Apply suggestions from code review
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-17 11:40:47 -06:00
Jack Grigg f54ee4abde Migrate from `hdwallet` to `bip32`
As part of this, we migrate to `secp256k1 0.27`. This version does not
bump `secp256k1-sys`, so remains compatible with the `libsecp256k1`
revision used in `zcashd`.

The `zcash_primitives::legacy::keys::AccountPrivKey` encoding also
changes to preserve the transparent extended key metadata. Previously
the type was documented as such, but only encoded the private key and
chain code; the new encoding now matches the documentation. As a side
effect, the unstable encoding of `zcash_keys::keys::UnifiedSpendingKey`
also changes.

Closes zcash/librustzcash#1407.
Closes zcash/librustzcash#1408.
2024-06-15 00:04:37 +00:00
dependabot[bot] 40166fa7e1
build(deps): bump codecov/codecov-action from 4.3.0 to 4.5.0
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.5.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v4.3.0...v4.5.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-14 05:58:50 +00:00
Kris Nuttycombe 3bc74b254b zcash_client_sqlite: Improve documentation for test setup functions. 2024-06-13 18:43:55 -06:00
Kris Nuttycombe e3956c3251 zcash_client_sqlite: Fix clippy complaint. 2024-06-13 18:09:52 -06:00
Kris Nuttycombe ecea9ca196 zcash_client_sqlite: Fix shardtree error caused by pruning after frontier insertion.
Fixes #1398
2024-06-13 18:09:46 -06:00
Kris Nuttycombe de66c5b154 zcash_client_sqlite: Add test to reproduce incomplete penultimate subtree error. 2024-06-13 18:09:39 -06:00
Kris Nuttycombe 3db515e347 zcash_client_sqlite: Allow multi-output fake blocks to send to multiple keys. 2024-06-12 16:36:20 -06:00
Kris Nuttycombe c88cd17929 zcash_client_sqlite: Add multiple output capability to fake compact block construction.
Many important test scenarios for note commitment tree structure require
the use of blocks that contain multiple notes.
2024-06-12 16:34:37 -06:00
Daira-Emma Hopwood 5a2a670ffc
Merge pull request #1406 from zcash/msrv-1.70
Bump general MSRV to 1.70
2024-06-12 18:00:14 +01:00
Daira-Emma Hopwood db7ae25d7e Allow compiling with "orchard" and without "transparent-inputs".
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-12 14:51:29 +01:00
Daira-Emma Hopwood 4cd96f30a1 Fix clippy lints exposed by the MSRV bump to 1.70.0.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-12 14:51:29 +01:00
Jack Grigg aea38c991e pprof 0.13 2024-06-12 11:51:19 +00:00
Jack Grigg 0f4b7463d8 Remove `time` pin now that its MSRV is compatible with ours 2024-06-12 11:20:40 +00:00
Jack Grigg 56c9b92df7 `cargo update proc-macro2` as it has audits 2024-06-12 11:15:05 +00:00
Jack Grigg 7165541896 cargo vet prune 2024-06-12 11:01:43 +00:00
Jack Grigg bffe6a4a10 Bump MSRV to 1.70 2024-06-12 10:58:17 +00:00
str4d 0c03e0673c
Merge pull request #1405 from daira/fix-audits
Add and prune audits
2024-06-12 11:53:28 +01:00
Daira-Emma Hopwood cfc1cb3738 Add and prune audits.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-04 12:19:40 +01:00
str4d 976a4d2d5c
Merge pull request #1392 from zcash/cargo-update-2024-05
Dependency updates
2024-05-24 16:56:53 +01:00
str4d 851e20347f
Fix changelogs to reflect actual MSRVs 2024-05-24 15:46:40 +01:00
str4d 4cf777ffdd
Merge pull request #1399 from zcash/fix-sapling-flags
Disable `sapling-crypto` default features by default
2024-05-24 02:06:17 +01:00
Jack Grigg f136535196 Merge branch 'main' into fix-sapling-flags 2024-05-23 20:41:29 +00:00
Jack Grigg 8b2188a0f3 zcash_primitives 0.15.1 2024-05-23 20:35:18 +00:00
Jack Grigg 7ca695ea3c Disable `sapling-crypto` default features by default
The only default-enabled feature flag in `sapling-crypto` is the
`multicore` feature flag, which we re-export in each crate that includes
proof creation. We need to disable it as a default feature of our
dependency in order to enable it to be correctly disabled when a user of
e.g. `zcash_primitives` disables its default features.
2024-05-23 20:32:29 +00:00
Daira-Emma Hopwood 39a6b2b4f8 Add audits and bump some exemptions.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-05-20 13:35:27 +01:00
Daira-Emma Hopwood aa77be8830 Update dependencies (including to avoid a vulnerability warning for atty), bump MSRV to 1.66,
and fix new clippy lints for MSRV 1.66.

* tonic 0.10 -> 0.11
* tonic-build 0.10 -> 0.11
* cargo update
* cargo update -p home@0.5.9 --precise 0.5.5
* cargo update -p prost-build@0.12.4 --precise 0.12.3
* cargo update -p prost-types@0.12.4 --precise 0.12.3
* cargo update -p prost@0.12.4 --precise 0.12.3
* cargo update -p prost-derive@0.12.5 --precise 0.12.3
* cargo update -p half@2.4.1 --precise 2.2.1

(The precise updates avoid a further MSRV bump to 1.70.)

Remaining duplicates are currently unavoidable.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-05-20 13:35:27 +01:00
str4d 0b350c1646
Merge pull request #1391 from zcash/remove-zip339-module
Remove zcash_primitives::zip339 module
2024-05-16 20:57:31 +01:00
Daira-Emma Hopwood 031b416b75 Update `Cargo.lock`.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-05-16 00:16:54 +01:00
Daira-Emma Hopwood 6961819576 Document the removal of `zcash_primitives::zip339` in the CHANGELOG.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-05-14 10:19:59 +01:00
Daira-Emma Hopwood bb6c3a6a1a Revert "ZIP 339 support."
This reverts commit d1443e5049.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-05-14 10:12:50 +01:00
Kris Nuttycombe c3eace4982
Merge pull request #1383 from jimmycathy/main
chore: remove repetitive words
2024-05-07 09:06:02 -06:00
jimmycathy 3510384f10 chore: remove repetitive words
Signed-off-by: jimmycathy <clonecode@outlook.com>
2024-05-04 20:54:15 +08:00
Kris Nuttycombe 9375c1b7ed
Merge pull request #1378 from zcash/ci-codecov-4
CI: Migrate to `codecov/codecov-action@v4.3.0`
2024-04-29 09:48:27 -06:00
Jack Grigg 7bd1cd1a2b CI: Migrate to `codecov/codecov-action@v4.3.0` 2024-04-29 15:15:05 +00:00
Daira-Emma Hopwood de24462993
Merge pull request #1376 from zcash/fix-audit-aggregation-workflow
CI: Add explicit token to GitHub CLI usage
2024-04-27 10:03:07 +01:00
Jack Grigg e4c51c30f6 CI: Add explicit token to GitHub CLI usage 2024-04-26 20:08:20 +00:00
str4d 081be32443
Merge pull request #1375 from zcash/trigger-audit-aggregation
CI: Add workflow to automatically trigger audit aggregation
2024-04-26 21:05:51 +01:00
Jack Grigg c2ed829ec5 CI: Add workflow to automatically trigger audit aggregation 2024-04-26 19:15:33 +00:00