Merge pull request #92 from zcash/fix-lints

Fix lints

src/builder.rs

@@ -135,12 +135,7 @@ impl ActionInfo {
         let alpha = pallas::Scalar::random(&mut rng);
         let rk = ak.randomize(&alpha);
 
-        let note = Note::new(
-            self.output.recipient,
-            self.output.value,
-            nf_old.clone(),
-            rng,
-        );
+        let note = Note::new(self.output.recipient, self.output.value, nf_old, rng);
         let cm_new = note.commitment();
 
         // TODO: Note encryption
@@ -542,7 +537,7 @@ pub mod testing {
             recipient_amounts in vec(
                 arb_address().prop_flat_map(move |a| {
                     arb_positive_note_value(MAX_NOTE_VALUE / n_recipients as u64)
-                        .prop_map(move |v| (a.clone(), v))
+                        .prop_map(move |v| (a, v))
                 }),
                 n_recipients as usize
             ),

src/bundle.rs

@@ -112,7 +112,7 @@ impl<T> Action<T> {
         Instance {
             anchor,
             cv_net: self.cv_net.clone(),
-            nf_old: self.nf.clone(),
+            nf_old: self.nf,
             rk: self.rk.clone(),
             cmx: self.cmx.clone(),
             enable_spend: flags.spends_enabled,

src/circuit.rs

@@ -197,7 +197,7 @@ mod tests {
                 let alpha = pallas::Scalar::random(&mut rng);
                 let rk = ak.randomize(&alpha);
 
-                let (_, _, output_note) = Note::dummy(&mut rng, Some(nf_old.clone()));
+                let (_, _, output_note) = Note::dummy(&mut rng, Some(nf_old));
                 let cmx = output_note.commitment().into();
 
                 let value = spent_note.value() - output_note.value();

src/keys.rs

@@ -421,7 +421,7 @@ impl DiversifiedTransmissionKey {
     }
 
     /// $repr_P(self)$
-    pub(crate) fn to_bytes(&self) -> [u8; 32] {
+    pub(crate) fn to_bytes(self) -> [u8; 32] {
         self.0.to_bytes()
     }
 }

src/note/nullifier.rs

@@ -37,7 +37,7 @@ impl Nullifier {
     }
 
     /// Serialize the nullifier to its canonical byte representation.
-    pub fn to_bytes(&self) -> [u8; 32] {
+    pub fn to_bytes(self) -> [u8; 32] {
         self.0.to_bytes()
     }