[#1427] Do not concatenate memos

- Closes #1427
- Changelog update
This commit is contained in:
Honza Rychnovský 2024-05-02 12:37:50 +02:00 committed by GitHub
parent 09febc6ff1
commit 448177c2d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 6 deletions

View File

@ -16,6 +16,10 @@ directly impact users rather than highlighting other key architectural updates.*
### Changed
- We've improved the visibility logic of the little loader that is part of the Balances widget
### Removed
- Concatenation of the messages on a multi-messages transaction has been removed and will be addressed using a new
design
## [1.0 (638)] - 2024-04-26
### Fixed

View File

@ -729,10 +729,6 @@ private fun HistoryItemMessagePart(
onAction: (TrxItemAction) -> Unit,
modifier: Modifier = Modifier,
) {
// TODO [#1315]: Proper more messages in transaction displaying
// TODO [#1315]: https://github.com/Electric-Coin-Company/zashi-android/issues/1315
val composedMessage = messages.joinToString(separator = "\n\n")
val textStyle: TextStyle
val textColor: Color
if (state.isFailed()) {
@ -758,8 +754,11 @@ private fun HistoryItemMessagePart(
.fillMaxWidth()
.border(width = 1.dp, color = ZcashTheme.colors.textFieldFrame)
) {
// TODO [#1315]: Proper more messages in transaction displaying
// TODO [#1315]: Note we display the first one only for now
// TODO [#1315]: https://github.com/Electric-Coin-Company/zashi-android/issues/1315
Text(
text = composedMessage,
text = messages[0],
style = textStyle,
color = textColor,
modifier = Modifier.padding(all = ZcashTheme.dimens.spacingMid)
@ -776,7 +775,7 @@ private fun HistoryItemMessagePart(
modifier =
Modifier
.clip(RoundedCornerShape(ZcashTheme.dimens.regularRippleEffectCorner))
.clickable { onAction(TrxItemAction.MessageClick(composedMessage)) }
.clickable { onAction(TrxItemAction.MessageClick(messages[0])) }
.padding(all = ZcashTheme.dimens.spacingTiny)
)
}