[#1356] Do not report caught exceptions
- Although GlobalCrashReporter is built primarily as an interface for the locale exceptions reporting using LocalCrashReporter, the FirebaseCrashReporter inherits its reportCaughtException API and provides the ability to report a caught exception to remote crashyltics service. This commit disables this API for FirebaseCrashReporter. - Closes #1356
This commit is contained in:
parent
81508f6466
commit
895d692588
|
@ -69,7 +69,12 @@ private class FirebaseCrashReporterImpl(
|
||||||
) : CrashReporter {
|
) : CrashReporter {
|
||||||
@AnyThread
|
@AnyThread
|
||||||
override fun reportCaughtException(exception: Throwable) {
|
override fun reportCaughtException(exception: Throwable) {
|
||||||
firebaseCrashlytics.recordException(exception)
|
error(
|
||||||
|
"Although most of the sensitive model objects implement custom [toString] methods to redact information" +
|
||||||
|
" if they were to be logged (which includes exceptions), we're encouraged to disable caught exception" +
|
||||||
|
" reporting to the remote Crashlytics service due to its security risk. Use the the local variant of" +
|
||||||
|
" the reporter to report caught exception - [LocalCrashReporter]."
|
||||||
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
override fun enable() {
|
override fun enable() {
|
||||||
|
|
Loading…
Reference in New Issue