zec
/
secant-android-wallet
mirror of https://github.com/zcash/secant-android-wallet.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #257 from zcash/256-fix-signing 

[#256] Fix release signing config
This commit is contained in:
Francisco Gindre 2022-03-04 14:39:20 -03:00 committed by GitHub
parent d410d62f64 93347c3116
commit aec6967b3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
app/build.gradle.kts
View File

@ -52,30 +52,19 @@ android {
} }
} }
buildTypes { val releaseKeystorePath = project.property("ZCASH_RELEASE_KEYSTORE_PATH").toString()
getByName("release").apply { val releaseKeystorePassword = project.property("ZCASH_RELEASE_KEYSTORE_PASSWORD").toString()
isMinifyEnabled = project.property("IS_MINIFY_ENABLED").toString().toBoolean() val releaseKeyAlias = project.property("ZCASH_RELEASE_KEY_ALIAS").toString()
isShrinkResources = project.property("IS_MINIFY_ENABLED").toString().toBoolean() val releaseKeyAliasPassword =
proguardFiles( project.property("ZCASH_RELEASE_KEY_ALIAS_PASSWORD").toString()
getDefaultProguardFile("proguard-android-optimize.txt"), val isReleaseSigningConfigured = listOf(
"proguard-project.txt" releaseKeystorePath,
) releaseKeystorePassword,
} releaseKeyAlias,
} releaseKeyAliasPassword
).all { !it.isNullOrBlank() }
signingConfigs { signingConfigs {
val releaseKeystorePath = project.property("ZCASH_RELEASE_KEYSTORE_PATH").toString()
val releaseKeystorePassword = project.property("ZCASH_RELEASE_KEYSTORE_PASSWORD").toString()
val releaseKeyAlias = project.property("ZCASH_RELEASE_KEY_ALIAS").toString()
val releaseKeyAliasPassword =
project.property("ZCASH_RELEASE_KEY_ALIAS_PASSWORD").toString()
val isReleaseSigningConfigured = listOf(
releaseKeystorePath,
releaseKeystorePassword,
releaseKeyAlias,
releaseKeyAliasPassword
).all { !it.isNullOrBlank() }
if (isReleaseSigningConfigured) { if (isReleaseSigningConfigured) {
// If this block doesn't execute, the output will be unsigned // If this block doesn't execute, the output will be unsigned
create("release").apply { create("release").apply {
@ -87,6 +76,20 @@ android {
} }
} }
buildTypes {
getByName("release").apply {
isMinifyEnabled = project.property("IS_MINIFY_ENABLED").toString().toBoolean()
isShrinkResources = project.property("IS_MINIFY_ENABLED").toString().toBoolean()
proguardFiles(
getDefaultProguardFile("proguard-android-optimize.txt"),
"proguard-project.txt"
)
if (isReleaseSigningConfigured) {
signingConfig = signingConfigs.getByName("release")
}
}
}
// TODO [#6]: Figure out how to move this into the build-conventions // TODO [#6]: Figure out how to move this into the build-conventions
kotlinOptions { kotlinOptions {
jvmTarget = libs.versions.java.get() jvmTarget = libs.versions.java.get()