Commit Graph

161 Commits

Author SHA1 Message Date
Francisco Gindre 33e855df13 Issue #173 - build 0.0.1-15 2022-02-24 20:31:46 -03:00
Francisco Gindre 3b2dd7c43a
Merge pull request #170 from LukasKorba/163_validation_feedback
Requested changes done
2022-02-24 13:57:17 -03:00
Lukas Korba 465d4feded Test fixes 2022-02-24 17:26:06 +01:00
Francisco Gindre 4f08c8cd92
Merge pull request #169 from LukasKorba/138_onbordingUI_enhancements
138 onbording UI enhancements
2022-02-24 11:22:09 -03:00
Lukas Korba 6528309245 synopsis -> paragraph
The name of the function has been changed so it reflects the style being used
2022-02-24 14:30:00 +01:00
Lukas Korba 598eac0eed Requested changes
All PR comments have been fixed in this commit
2022-02-24 14:14:50 +01:00
Lukas Korba 18d880e2ea requested changes
All comments have been resolved
2022-02-23 20:29:29 +01:00
Lukas Korba 74cb622372 Merge branch '138_onbordingUI_enhancements' of https://github.com/LukasKorba/secant-ios-wallet into 138_onbordingUI_enhancements 2022-02-23 18:58:17 +01:00
Lukas Korba cc2479722e removed extra spaces 2022-02-23 18:57:32 +01:00
Lukas Korba 9323e32f6a
Update secant/UIComponents/CircularFrame/CircularFrameBadge.swift
agreed

Co-authored-by: dh-ecc <90868897+dh-ecc@users.noreply.github.com>
2022-02-23 18:57:08 +01:00
Lukas Korba ae2521d408
Update secant/UIComponents/CircularFrame/CircularFrameBadge.swift
agreed

Co-authored-by: dh-ecc <90868897+dh-ecc@users.noreply.github.com>
2022-02-23 18:56:53 +01:00
Lukas Korba e618cc48e5 Generator moved
I decided to also follow the Pastboard dependency and get rid of the specific file just for the generator.
2022-02-23 18:51:18 +01:00
Lukas Korba b7fccb3c28 TCA way
The syntax convention for the feedback generator was re-implemented to follow TCA and secant wallet principles.
2022-02-23 18:39:39 +01:00
Lukas Korba 3e0addd99e Response to comments
All updates and fixes related to the comments
2022-02-23 18:32:54 +01:00
Lukas Korba c8e54550fc Requested changes done
The failed color (red) updated. The haptic feedback (.error) now occurs when the chips are not at the right indices.
2022-02-23 17:49:17 +01:00
Lukas Korba 64146e2ac5 Merge branch '138_onbordingUI_enhancements' of https://github.com/LukasKorba/secant-ios-wallet into 138_onbordingUI_enhancements 2022-02-23 15:09:48 +01:00
Lukas Korba 277c8b33fd First batch of UI updates
The focus was on neumorphic buttons that work for both light and dark as well as state of the button (pressed)

Device specific enhancements

Colors and texts updated. Device specific paddings, margins and sizes enhanced

Dark appearance

Tweaks for the dark version of the onboarding UI

Update of the comments

Button UI updates

Colors updated, pressed button simulated and present in the DesignGuide.swift

Optimised Button's Layout

Onboarding footer was using the same settings for 3 buttons.
2022-02-23 15:08:54 +01:00
Lukas Korba 1e12d472f8
Merge branch 'zcash:main' into 138_onbordingUI_enhancements 2022-02-23 15:05:30 +01:00
Lukas Korba 9df95ebc29 Optimised Button's Layout
Onboarding footer was using the same settings for 3 buttons.
2022-02-23 15:04:36 +01:00
Francisco Gindre 8c12556236
Merge pull request #164 from rex4539/typos
Fix typos
2022-02-22 17:58:01 -03:00
Lukas Korba 8931433f8e Button UI updates
Colors updated, pressed button simulated and present in the DesignGuide.swift
2022-02-22 15:44:29 +01:00
Lukas Korba e1c1ec62e7 Update of the comments 2022-02-22 15:10:53 +01:00
Lukas Korba bbf5498fe2 Dark appearance
Tweaks for the dark version of the onboarding UI
2022-02-22 15:02:16 +01:00
Lukas Korba 54d9dd2fd9 Device specific enhancements
Colors and texts updated. Device specific paddings, margins and sizes enhanced
2022-02-22 13:50:50 +01:00
Lukas Korba 81ccc2b283 First batch of UI updates
The focus was on neumorphic buttons that work for both light and dark as well as state of the button (pressed)
2022-02-21 21:17:49 +01:00
Francisco Gindre 23126eb97b
Merge pull request #168 from LukasKorba/158
Installation of Swiftlint & Swiftgen added
2022-02-21 10:59:59 -03:00
Lukas Korba 04946c9f0a Installation of Swiftlint & Swiftgen added
Installations done via homebrew endup on a different path compared to Intel machines. A section describing how to handle both Swiftlint & Swiftgen on Apple Silicon added
2022-02-21 14:55:06 +01:00
Dimitris Apostolou b2eb4b228e
Fix typos 2022-02-18 23:39:04 +02:00
Francisco Gindre 9e6d3a7525
Merge pull request #160 from LukasKorba/159
Enhancement of the clamping the index for the seed
2022-02-18 13:45:28 -03:00
Lukas Korba c6b84d48f6 Update of the func signature 2022-02-18 15:33:40 +01:00
Lukas Korba ad92c8be26
Update secant/Util/Clamped.swift
Co-authored-by: Adam <adam@olemae.com>
2022-02-18 15:26:42 +01:00
Francisco Gindre 3e1a8f59eb
Merge pull request #162 from zcash/feature/welcome-screen
Issue #61 - Zcash Logo and welcome screen
2022-02-18 11:10:12 -03:00
Francisco Gindre b42cc56906 Issue #61 - Zcash Logo and welcome screen
Text shadows

font adjustments

Naïvely integrate to navigation

bump build

fix lint warning

PR Suggestions
2022-02-18 11:06:17 -03:00
Francisco Gindre 58175b5dcb
Merge pull request #134 from zcash/feature/recovery-phrase-validation
Recovery Phrase Validation.
2022-02-18 10:36:50 -03:00
Francisco Gindre b75def9cc1 Issue #44: Recovery Phrase Validation flow + tests
Rename struct to RecoveryPhraseValidationState. Add docs

WordGrid + tests

Make Word Groups Droppable and Blue word chips draggable

cleanup

Rename Stores and adopt aliases and default pattern for reducers

Fix drop not working

FIX: apply background to header. Spacing

Fix compilation errors. Add validation demo to AppView

Fix: the empty chips are rendered once, because they are not uniquely identifiable

Add the Validation screen to the App Home

make mutating functions static

fix project warnings

Fix Tests

Fixed .complete test

refactoring the Enum. first step

Move given() to RecoveryPhraseValidationState and fix tests

Add canary test for computed property of State

Move RecoveryPhraseValidationStep to a nested type of RecoveryPhraseValidationState

rename RecoveryPhraseValidationState.RecoveryPhraseValidationStep to RecoveryPhraseValidationState.Step

Move static functions from RecoveryPhraseValidationStep to RecoveryPhraseValidationState

Move creational factory methods together to the same extension

Remove unused functions

remove associated values from Step enum

Fix: Avoid Drop being disable between chips

0.0.1-10

add navigation bar to phrase validation demo

Reduce spacing between groups. Code cleanup

Remove RecoveryPhraseValidationStep.swift
Move remaining code to proper places

PR Fixes. Move .initial factory method to test target. Rename given() to apply(chip:group:) and make it a member function

Cleanup. Remove .validate, .invalid and .valid states. Figure word chips out of the state.

Fix randomIndices()

Tie view's title to state

Connect Header to State

BlueChip is now ColoredChip.

Success Screen

fix project

Connect Success Screen to successful validation

Add Red color to backgrounds

Validation Failed Screen

Connect SuccessValidation Screen to home

hide back button on Success view

Connect Phrase Display to validation

0.0.1-11

Fix word grid background colors

View Modifier to add scrollview when the content is being scaled up by DynamicType

Adjust UI spacing and padding to designs

Add Placeholder states for SwiftUI Previews

Flatten EnumeratedChip Hierarchy

Flatten EnumeratedChip view hierarchy

Fix: LazyVGrid can't take GeometryReader on its items' bodies

Fix: Colored Chip does not adjust

Fix: Vertical separation between wordgroups is too tall.

Fix: Accesibility fixes for Validation Failed screen

Rename ValidationFailedView

Accessibility Pass on Validation success screen

 FIX: Colored chips too big when scaled up

Fix: ValidationFailedScreen does not scroll well when scaled up

Fix Empty chip shadow color for dark color scheme

Fix: chip grid background does not bleed out to bottom of the screen

build 12

Fix: pre success/failure screen step shrinks the screen because word grid is missing

Resolved PR comments

Fixes to resolve PR conversations

Fixes to resolve PR conversations

Fix PhraseChip preview

Make ScrollableWhenScaledUp modifier fileprivate

Remove comments and clean up code

Fix Swiftlint issues

Renamed RecoveryPhraseStepFulfillment to ValidationWord

Rename pickWordsFromMissingIndices

PR fixes

PR suggestions

PR suggestions

Move words(fromMissingIndices:size) to RecoveryPhrase

Make ScrollableWhenScaled struct fileprivate

PR Suggestions Part two

PR Suggestion changes

remove unused

PR suggestions

suggested rename

PR suggestions

remove apply(chip:into) move that to Reducer

Formatting changes

more formatting changes

Fix: iPhone 13 Pro Max displays 4 columns instead of three

Fix: Recovery Phrase puzzle shows incorrect number of columns and margin alignment on bigger devices

Add test to catch state not changing as intended

Phrase validation reducer refactor + tests

make step computed property a bool

make isComplete a single line

PR Suggestions

Rename ValidationSuccededView.swift

Fix Bug: valid phrase should contemplate that the phrase is complete first

PR Suggestion

refactor and add Unit Tests for resultingPhrase, isComplete, isValid
2022-02-18 10:26:11 -03:00
Lukas Korba 895a43376d Optimised version of Clamped 2022-02-18 07:17:10 +01:00
Lukas Korba 44a9d4ffad Modification of Clamped property
So it's no longer out of the bounds. This was the case when initialised property has never been modified = set was never called
2022-02-18 07:06:32 +01:00
Lukas Korba c564215328 Enhancement of the clamping the index for the seed 2022-02-17 14:42:16 +01:00
Francisco Gindre 212d130bfb
Merge pull request #144 from zcash/app-icons
Update App Icons
2022-01-11 18:44:39 -03:00
Francisco Gindre 9e19f3e167 Optimized PNGs with ImageOptim (34% filesize optimization) 2022-01-11 17:30:03 -03:00
Francisco Gindre 7aa559dc9a Update App Icons 2022-01-11 17:05:04 -03:00
Francisco Gindre 80bbdc8cda
Merge pull request #135 from dh-ecc/nav-add-history-link
Add link to history from `Home`
2021-12-15 11:30:48 -03:00
Daniel Haight c37e9a2ade [Refactor] remove unused code
No significant code changes, just consolidating helper methods
and removing unused code.
2021-12-14 22:38:30 +00:00
Daniel Haight cd3c98cce4 Add button to show history placeholder from 2021-12-14 22:25:59 +00:00
Francisco Gindre 249f4306bb 0.0.1-9 2021-12-14 17:18:20 -03:00
Francisco Gindre ebeeca2e42
Merge pull request #130 from dh-ecc/nav-add-placeholders
Add placeholder features for app and link up navigation
2021-12-14 15:08:19 -03:00
Daniel Haight b2320c057a [lint] fix swiftlint warnings 2021-12-14 02:50:55 +00:00
Daniel Haight 8425dd94b1 Delete router style placeholders 2021-12-14 02:50:55 +00:00
Daniel Haight 8ec6494044 Add `.reset` action to `Home`
This is here for convenience while we are in the "placeholder" stages,
to give a way to navigate to the "App" screen from Home
2021-12-14 02:50:55 +00:00
Daniel Haight c035bed146 Use App feature view for app scene 2021-12-14 02:50:55 +00:00