Apply suggestions from code review

Co-authored-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
Kris Nuttycombe 2021-02-09 08:06:00 -07:00 committed by GitHub
parent 62331bbbb6
commit cdb7144519
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions

View File

@ -279,8 +279,8 @@ The personalization field of this hash is set to::
T.4a.ii: sapling_spends_noncompact_digest T.4a.ii: sapling_spends_noncompact_digest
......................................... .........................................
A BLAKE2b-256 hash of the non-nullifier information for all Sapling shielded spends A BLAKE2b-256 hash of the non-nullifier information for all Sapling shielded spends
belonging to the transaction, excluding zkproof data and spend authorization belonging to the transaction, excluding both zkproof data and spend authorization
signature. For each spend, the following elements are included in the hash:: signature(s). For each spend, the following elements are included in the hash::
T.4a.ii.1: cv (field encoding bytes) T.4a.ii.1: cv (field encoding bytes)
T.4a.ii.2: anchor (field encoding bytes) T.4a.ii.2: anchor (field encoding bytes)
@ -547,22 +547,22 @@ A BLAKE2b-256 hash of the field encoding of the Sapling ``zkproof`` and
``spend_auth_sig`` values of each Sapling spend description belonging ``spend_auth_sig`` values of each Sapling spend description belonging
to the transaction, followed by the field encoding of the to the transaction, followed by the field encoding of the
``zkproof`` field of each Sapling output belonging to the transaction, ``zkproof`` field of each Sapling output belonging to the transaction,
followed by the field encoding of the binding signature :: followed by the field encoding of the binding signature::
A.3a: spend_zkproofs_sigs (see subsection A.3a) A.3a: spend_zkproofs_and_sigs (see subsection A.3a)
A.3b: output_zkproofs (field encoding bytes) A.3b: output_zkproofs (field encoding bytes)
A.3c: binding_sig (field encoding bytes) A.3c: binding_sig (field encoding bytes)
The personalization field of this hash is set to:: The personalization field of this hash is set to::
"ZTxAuthSapliHash" "ZTxAuthSapliHash"
A.3a: spend_zkproofs_sigs A.3a: spend_zkproofs_and_sigs
''''''''''''''''''''''''' '''''''''''''''''''''''''''''
For each ``SpendDescription`` belonging to the transaction, the following For each ``SpendDescription`` belonging to the transaction, the following
elements are added to the ``A.3`` hash:: elements are added to the ``A.3`` hash::
A.3a.i: zkproof ([u8; 192]) A.3a.i: zkproof (field encoding bytes)
A.3a.ii: spend_auth_sig (field encoding bytes) A.3a.ii: spend_auth_sig (field encoding bytes)