Commit Graph

2399 Commits

Author SHA1 Message Date
Daira Hopwood 15d59f11c4 Add note about non-uniformity of Orchard ivk.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-19 00:12:37 +01:00
Daira Hopwood 119abe37c3 ExtractP(\ZeroP) should be 0, and ExtractP^\bot(\bot) should be \bot.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-19 00:12:37 +01:00
Daira Hopwood 1df0f60deb Add support for link checking to protocol/links_and_dests.py and protocol/Makefile.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-19 00:12:37 +01:00
Daira Hopwood 65ebb2266d Fix some URLs in references.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-19 00:12:37 +01:00
teor 572338f01a Add action descriptions to the Note Commitments section intro 2021-04-13 09:45:33 -04:00
Deirdre Connolly 20053e286c
Merge pull request #486 from teor2345/patch-11
Typo: Decription -> Description
2021-04-13 09:42:24 -04:00
teor 151e8c9661
Typo: Decription -> Description 2021-04-12 11:07:03 +10:00
Daira Hopwood fb9c5514bd Add stubs for ZIP numbers 314, 315, 316, 322, and 323.
Remove stub for ZIP 22 which has been renumbered to 323.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-07 10:12:11 +01:00
Daira Hopwood 761485e6c6 Regenerate PDFs. 2021-04-05 23:09:13 +01:00
Daira Hopwood e23cc72ac6 Work around bug in `release` target of protocol/Makefile.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-05 23:03:52 +01:00
Daira Hopwood 88c338b9e1 Specify that a unified payment address MUST contain at least one shielded payment address.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-05 22:12:29 +01:00
Daira Hopwood 18fbfdefe5 Correct ZKSpend.Verify to ZKOutput.Verify in \crossref{outputdesc}. fixes #481
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-05 22:00:53 +01:00
Daira Hopwood cc9c41a598 More clarifications to \theoremref{thmsinsemillacr}.
Co-authored-by: Taylor Hornby <taylor@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-05 21:51:59 +01:00
Daira Hopwood 1f041f955a Add links_and_dests.py.
This can be used to print outgoing links and targets in the PDF, and detect a subset of errors.
It depends on the PyPDF2 library (pip3 install PyPDF2).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-05 21:51:05 +01:00
Daira Hopwood 4f50d5e515 Make sure that Change History entries are URL destinations. fixes #462
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-05 21:51:00 +01:00
Daira Hopwood 46fefcaf56 Update all references to https URLs (and the year of the Unicode Standard to 2020).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-05 21:44:19 +01:00
Daira Hopwood e4cc1f7f82 Say that Canopy activated.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-05 20:30:33 +01:00
Daira Hopwood db3b2f72d4 Remove link to the "GNU Kind Communication Guidelines" given Richard Stallman's involvement
(see https://rms-open-letter.github.io/appendix), and that document's stance on pronouns.

In particular, although the document has changed since the open letter's reference to it, its
current version says that gender-neutral pronouns "don't conflict with any possible gender
identity". That is incorrect, and not compatible with our CoC. Always use a person's stated
pronouns if they are known; use gender-neutral pronouns only when the correct ones are unknown
or when not referring to a specific person.

Besides the pronoun issue and the association with RMS, a universal exhortation to "assume good
faith" is verging on tone-policing when applied to marginalized communities. In any case,
ZIP 0 is not about that topic and the link is out-of-place.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-04 15:20:45 +01:00
Daira Hopwood 404248cb92 Regenerate PDFs. 2021-04-01 02:19:32 +01:00
Daira Hopwood a0d048ed1e Update Change History entry date.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 417076e50d Make a note in \crossref{inbandrationale} of the divergence of ivk from a uniform scalar.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 1eec1f9832 Remove anchorSapling field when there are no Spends.
This corresponds to e0b08fd576 in ZIP 225.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 49f3b206f5 Fix type error in kdfinput for KDF^{Sapling,Orchard} (`ephemeralKey` is already a byte sequence).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 41580ec06d Cosmetics in Sapling Output statement.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood c367a22098 Explicitly note that the end of the ZIP 212 grace period precedes NU5 activation.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 3a312dc5a9 Expand the set of ZIPs associated with NU5 in \crossref{networkupgrades}, and reference the Orchard and halo2 books there.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 6c3099843d Add a caveat about reuse of rivk between PRF^expand and Commit^ivk.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 3826d43930 Correct the set of inputs to PRF^expand used for ZIP 32 and Orchard in \crossref{abstractprfs}.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood de0bc97bb2 Cosmetics (page breaking).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood bb985e039a Section \crossref{concreteorchardkdf} should be in the NU5 colour (slate blue).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Deirdre Connolly ec6c10fc5c Add a note to the Sending Notes (Orchard) section about using a dummy note for ρ.
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 6c8f9fb478 Update the Sprout key component diagram in \crossref{addressesandkeys} to remove magenta highlighting.Remove magenta highlighting
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood e1f105eaa1 Add note about use of big-endian order in the encoding of BLS12-381 points.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 3a55af9b1f Cosmetics and indexing.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 7bfdce2d6a Write caution about linkage between the abstract and concrete protocols in \crossref{cautionlinkage}.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 1097313feb Fix errors in the Sinsemilla proofs:
* SinsemillaHash is defined in terms of SinsemillaHashToPoint, which also takes the D argument.
* correct errors due to 1-based indexing.
* the argument for exceptional cases got the scalars and range of j wrong.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood cce172ace8 Cosmetics (page breaking).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood f45b6b5d66 Add Action Statement ref to flags note
This change makes it clearer that the note spend and creation
rules are implemented as part of the proof.

Co-authored-by: teor <teor@riseup.net>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
teor ecb2ccd3f4 Copy outCiphertext description to the encoding tables 2021-04-01 02:11:35 +01:00
Daira Hopwood 0eca13f809
Merge pull request #479 from nuttycom/zip_225-sapling_anchors
Remove anchorSapling field when there are no spends.
2021-04-01 00:59:47 +01:00
Daira Hopwood 89596379ff ZIP 225: Cosmetics (trailing spaces).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 00:58:37 +01:00
Kris Nuttycombe e0b08fd576 ZIP 225: Remove anchorSapling field when there are no spends.
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 00:58:23 +01:00
Daira Hopwood 1bed047c0e ZIP 221: cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-31 13:40:26 +01:00
Daira Hopwood c9f9d0b36b ZIP 221: fix rst formatting.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-31 13:37:49 +01:00
Daira Hopwood 31e8b03491 ZIP 244: update link to protocol spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 20:19:33 +01:00
Daira Hopwood b0c65971d7
Merge pull request #467 from nuttycom/zip_225-ncc_fixes
Fixes for ZIP 225 issues identified by the NCC audit.
2021-03-30 20:10:43 +01:00
Kris Nuttycombe 0dd2982ec3 Update generated HTML. 2021-03-30 11:13:28 -06:00
Kris Nuttycombe 6ecba03a2a Fix vSpendAuthSigsOrchard field name. 2021-03-30 10:57:24 -06:00
Kris Nuttycombe f7461d62e5
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 10:45:49 -06:00
Kris Nuttycombe e936a21a6b
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 09:40:13 -06:00