zec
/
zips
mirror of https://github.com/zcash/zips.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
2,598 Commits 41 Branches 258 Tags 832 MiB
Commit Graph

44 Commits

Author SHA1 Message Date
Daira Hopwood 604c40a5c0 ZIP 244: add a note that the empty authorization data tree cannot occur. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-06-15 15:24:09 +01:00
Kris Nuttycombe f0c438de9b Clarify contruction of `hashAuthDataRoot`. 
This changes the specification of hashAuthDataRoot to state that leaves
of the Merkle tree used to construct hashAuthDataRoot should have the
null hash value, while empty internal nodes should be hashes of empty
leaves. It also defines an all-FFs placeholder value to be used for
pre-v5 transactions in this tree.

Co-authored-by: Kris Nuttycom <nuttycom@electriccoin.co>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-06-15 15:14:44 +01:00
Kris Nuttycombe 9ccd44743f
Apply suggestions from code review 
Make the specification of the cases in which empty hashes are produced more
explicit, and less dependent upon how these rules are scoped.

Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-05-18 08:16:00 -06:00
Kris Nuttycombe 12fa6ffa8e Remove trailing whitespace. 2021-05-18 08:05:07 -06:00
Kris Nuttycombe 8d21457112 Add a note about the signedness of `value` 2021-05-18 07:53:40 -06:00
Kris Nuttycombe becbec175c Fix rendering of txin_sig_digest 2021-05-11 08:16:33 -06:00
Kris Nuttycombe d023ef8220
Update zip-0244.rst 
Co-authored-by: str4d <jack@electriccoin.co>
 2021-05-10 17:42:51 -06:00
Kris Nuttycombe 622179e574
Apply suggestions from code review 
Co-authored-by: teor <teor@riseup.net>
 2021-05-10 14:14:39 -06:00
Kris Nuttycombe f22a6d4151 Clarify hashes over authorizing data. 2021-05-06 16:06:03 -06:00
Kris Nuttycombe eea56aa173 The roots of empty transaction hash subtrees are now uniformly committed to with empty hashes. 2021-05-06 15:49:50 -06:00
Daira Hopwood 21d3c13d4f Update references to the protocol spec for all NU5-related ZIPs. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-04-23 22:33:56 +01:00
Kris Nuttycombe 827637cc17 Correct the description of the outputs_digest hash. 2021-04-23 08:20:20 -06:00
Deirdre Connolly 4c081eaa54 Make a note that the post-memo 'suffix' is the AEAD tag 2021-04-20 18:08:59 -04:00
teor ef5f47ca08
ZIP-244: Clarify sapling shared anchor hashing (#490) 
* ZIP-244: Clarify sapling shared anchor hashing

Unlike the orchard shared anchor, the sapling v5 transaction shared anchor
is hashed into *each* spend.

* Uppercase Sapling and Spend

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
 2021-04-20 18:08:12 -04:00
Daira Hopwood 31e8b03491 ZIP 244: update link to protocol spec. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-03-30 20:19:33 +01:00
Daira Hopwood b0c65971d7
Merge pull request #467 from nuttycom/zip_225-ncc_fixes 
Fixes for ZIP 225 issues identified by the NCC audit.
 2021-03-30 20:10:43 +01:00
Kris Nuttycombe f7461d62e5
Apply suggestions from code review 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-03-30 10:45:49 -06:00
teor 96efd54702
Be explicit about hashBlockCommitments activation 2021-03-29 14:14:12 +10:00
Kris Nuttycombe 4b2af700ef Add non-requirement for non-malleable transaction IDs for v4 transactions. 2021-03-26 16:37:30 -06:00
Kris Nuttycombe f202b83a9d Remove Sprout commitments from ZIP 244; include flagsOrchard in txid. 2021-03-26 16:37:30 -06:00
Daira Hopwood 5df826f0f6 ZIP 244: formatting fix. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-03-07 19:34:11 +00:00
Kris Nuttycombe 62dca39483 Separate Sapling effecting data from authorizing data in the transaction format. 
This change restructures the wire format of Sapling spend and output
descriptions to segregate authorizing data from the data describing the
effects of the transaction in a similar fashion as has been done for
Orchard. The result is now symmetric between Sapling and Orchard, and
also simplifies slightly the description of the computation of the
authorizing data commitment in ZIP 244.
 2021-03-01 10:55:11 -07:00
Kris Nuttycombe 267bced55a Draft of ZIP 225 2021-02-28 12:32:29 -07:00
Daira Hopwood 4b5ce259d1 Move ZIP 244 to Proposed and ZIP 245 to Draft. 
Also fix an rst syntax error in ZIP 245.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-15 20:52:40 +00:00
Kris Nuttycombe 566be18f40 Rename signature digests to clarify differences wrt txid digests. 2021-02-15 09:59:01 -07:00
Kris Nuttycombe a779c1043d
Apply suggestions from code review 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-15 09:52:53 -07:00
Kris Nuttycombe cdb7144519
Apply suggestions from code review 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-09 08:06:00 -07:00
Kris Nuttycombe 62331bbbb6 Add decoupling of wire format from consensus rules to motivation. 2021-02-08 11:19:14 -07:00
Kris Nuttycombe a424153462 Clarify rationale for personalization changes. 
Also clarify terminology around signature hash flags vs. types.
 2021-02-04 10:59:51 -07:00
Kris Nuttycombe 4b8a78c51b Specify exclusion of spend authorization sigs from txid. 2021-02-02 14:11:09 -07:00
Kris Nuttycombe 90e83ad754
Note number of underscores in hash personalization strings. 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-02 13:22:02 -07:00
Kris Nuttycombe 4da60ce58b Fix authorizing commitment to include spend_auth_sigs 2021-02-02 13:06:43 -07:00
Kris Nuttycombe 3bc233bafb Clean up HTML rendering of the RST. 2021-01-26 15:29:24 -07:00
Kris Nuttycombe e3729e8e7c Fix rst rendering errors. 2021-01-26 15:06:30 -07:00
Kris Nuttycombe 7558c6995d Add signature digest algorithm for TZEs. 2021-01-26 14:32:26 -07:00
Kris Nuttycombe 7fbe3780d9
Apply suggestions from code review 
Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
 2021-01-26 08:47:57 -07:00
Kris Nuttycombe c693ab88bd Fix outputs digest in signature hash. 2021-01-21 17:23:09 -07:00
Kris Nuttycombe 56dd669368 Add block commitment hash changes. 2021-01-21 12:52:53 -07:00
Kris Nuttycombe c689a58731 Include signature hash & auth commitment sections. 2021-01-20 17:28:39 -07:00
Kris Nuttycombe becda9c543 Add alternatives section to record zkproofs discussion. 2021-01-19 15:37:36 -07:00
Kris Nuttycombe 08faa9f8f8 Fix reference links. 2021-01-13 16:59:24 -07:00
Kris Nuttycombe e1558317bb
Apply suggestions from code review 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-01-13 16:57:38 -07:00
Kris Nuttycombe 05f86c7cc5 Use ZIP 244 for nonmalleability, ZIP 245 for TZE-related digests. 2021-01-13 16:27:19 -07:00
Daira Hopwood 917c85380c Add placeholder ZIPs for reserved numbers. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2020-09-14 15:53:54 +01:00