Kris Nuttycombe
058b1a6a17
Revert "Merge pull request #759 from nuttycom/zip-316/ua-expiry"
...
This reverts commit 7064e8229a
, reversing
changes made to 82f98ec91b
.
Revision 1 will be amended to include a change to the Human-Readable
Part of UA/UVK encodings in order to ensure that MUST-understand
metadata cannot be ignored by existing wallets.
2024-01-24 18:48:31 -07:00
Daira Emma Hopwood
b0de22d1e2
ZIP 316, Revision 1: Clarify relation of "MUST-understand" typecodes to derivation.
...
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2024-01-18 19:43:16 +00:00
Kris Nuttycombe
e05c7faa30
ZIP 316, Revision 1: Clarify constraints with respect to expiry times.
2024-01-18 19:40:11 +00:00
Kris Nuttycombe
5b92bcd076
ZIP 316, Revision 1: Apply suggestions from code review
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2024-01-18 19:40:11 +00:00
Kris Nuttycombe
099ef4397f
ZIP 316, Revision 1: Clarify that address expiration metadata is optional.
2024-01-18 19:40:11 +00:00
Kris Nuttycombe
34ac94b73c
ZIP 316, Revision 1: Address Expiration Metadata
...
This change adds metadata that allows a user to specify either an expiry
height or an expiry time (or both) for their addresses, and specifies
how wallets should interpret expiry metadata.
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2024-01-18 19:40:11 +00:00
Kris Nuttycombe
d4d34ed6ff
ZIP 316, Revision 1: MUST-understand metadata items
...
Reserve a range of metadata typecodes that unified container parsers
must understand; if a parser does not understand a typecode in the
specified range, then it must treat the entire unified address as
unsupported.
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2024-01-18 19:40:11 +00:00
Daira Emma Hopwood
2eb0ed8ef0
Updates to reference BCP 14 rather than RFC 2119. fixes #729
...
Also change two "should"s in ZIP 224 to "SHOULD"s.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-28 15:34:22 +01:00
Daira Emma Hopwood
932b81d59d
dk is already a byte sequence.
2023-08-22 20:30:42 +01:00
Andrew Arnott
61654491ce
Fix ZIP-316 bug in expected `dk` length
...
The `dk` value is 256 bits long. It's the *diversifier* that is only 88 bits long. The incoming viewing key requires the diversifier key -- not the diversifier.
This change also reflects the de facto standard in implementations up to this point, including YWallet and the [zcash_address crate](https://docs.rs/zcash_address/latest/src/zcash_address/kind/unified/ivk.rs.html ).
2023-07-31 07:21:04 -06:00
Jack Grigg
2fd1866298
Make existing inline rationale sections collapsible
2023-07-20 16:41:26 +01:00
Daira Emma Hopwood
815db1ca09
ZIP 316: cosmetics and minor rewording.
...
Also add definitions of Unified String Encoding and Unified QR Encoding.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-21 13:16:14 +00:00
Daira Emma Hopwood
158b32dabc
ZIP 316: update Owners and Credits.
...
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-21 13:11:12 +00:00
Daira Hopwood
418bf7fcab
ZIP 316: add MAY to keywords.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-03-21 13:11:12 +00:00
Daira Emma Hopwood
8ea921667d
Daira Hopwood -> Daira Emma Hopwood.
...
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:13:07 +00:00
Daira Hopwood
54359a8809
Update the status of all NU5 ZIPs to Final.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-06-22 22:21:35 +01:00
Daira Hopwood
e4ed372840
ZIP 316: specify that at least the first 20 characters of a UA/UVK MUST be shown.
...
fixes #571
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-04-28 21:09:04 +01:00
Daira Hopwood
ae1180f6d3
ZIP 316: make the limitation on total size of encodings more explicit.
...
fixes #570
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-04-18 22:25:47 +01:00
Daira Hopwood
81af218ef3
ZIP 316: further clarify which OVK is to be used when the sending Account is undetermined.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-02-07 14:51:53 +00:00
Daira Hopwood
8b8b3f7c5d
ZIP 316: UAs can be used in Payment Requests without any change to ZIP 321.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:52 +00:00
Daira Hopwood
c562b100f8
ZIP 316: add "Usage of Outgoing Viewing Keys" section.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:52 +00:00
Daira Hopwood
ca302f40ef
ZIPs 32 and 316: update and correct protocol spec references.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:52 +00:00
Daira Hopwood
d27d2fd836
ZIP 316: Clarify that UAs/UVKs MUST contain at least one shielded item. This is stronger than
...
the former requirement that a UA/UVK MUST NOT contain only P2SH or P2PKH items, due to the
existence of Typecodes that are not currently defined.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:51 +00:00
Daira Hopwood
4683507160
ZIP 316: add Deriving Internal Keys section, and minor cleanups.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:51 +00:00
Daira Hopwood
7b70d343b7
ZIP 316: link to the section of the protocol spec describing QR encoding.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:51 +00:00
Daira Hopwood
ee70cc53c3
ZIP 316: update Acknowledgements.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-28 15:30:44 +00:00
Daira Hopwood
1d75ed6548
ZIP 316: more changes to include UVKs and Metadata Items where applicable.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-28 15:30:15 +00:00
Daira Hopwood
2d5159361e
ZIP 316: add rationale for unlinkable address derivation, with a caveat about Metadata Items.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-28 13:39:01 +00:00
Daira Hopwood
b7e69cc10a
ZIP 316: add rationale for requiring ordering by Typecode.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-28 13:39:01 +00:00
Daira Hopwood
e8df7fbb65
ZIP 316: unrecognized metadata items should be dropped when deriving UFVK -> UIVK and UIVK -> UA.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-28 13:14:17 +00:00
Daira Hopwood
06b945bfe7
ZIP 316: change ordering of items.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-22 19:08:13 +00:00
Daira Hopwood
22840e1fc5
ZIP 316: clarify usage of Metadata Items and experiments.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-22 19:07:46 +00:00
Daira Hopwood
1a59063e81
ZIP 316: correct the rationale for the minimum size of the Bech32m-decoded byte sequence.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-22 19:07:19 +00:00
Daira Hopwood
4a23875519
ZIP 316: Clarify derivation of P2PKH IVK from FVK.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 23:46:09 +00:00
Deirdre Connolly
96c5ad3f69
ZIP 316: Clarify position of Transparent IVKs in the key tree.
...
Co-authored-by: Kris Nuttycombe <kris.nuttycombe@gmail.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 23:34:12 +00:00
Deirdre Connolly
110fe1a84e
ZIP 316: Update wording for Transparent P2PKH Receiver derivation.
...
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 23:32:02 +00:00
Daira Hopwood
d325f0b3b4
ZIP 316: Fix link.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:29:03 +00:00
Daira Hopwood
0e83a55a05
ZIP 316: Clarify requirements for HD-derived items and remove redundancy.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood
208d9b39c1
ZIP 316: Update Sapling and transparent viewing key encodings.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Jack Grigg
026977744c
ZIP 316: Fix bug in transparent constraint on diversifier index
...
The largest valid integer for any BIP 32 path element with a defined
hardening state (in this case, non-hardened) is 2^32 - 1 (being the
31-bit integer with all bits set to 1). The range of valid diversifier
indices for transparent-including UAs is defined as end-inclusive in
the ZIP, but used the end-exclusive bound 2^32.
2021-12-08 00:27:08 +00:00
Jack Grigg
78b7d8489f
ZIP 32: Revert all refinements
...
The hardened change path approach is being dropped. ZIP 316 will include
separate amendments (to be made later) that derive change addresses
within each protocol's key tree, instead of at the spend authorization
level.
2021-12-08 00:27:08 +00:00
Daira Hopwood
9a4df93e97
Cosmetics.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood
5c402793c3
Corrections for Orchard Viewing Keys.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood
880bf02301
Don't use UFVK or UIVK when referring to Viewing Key components.
...
(A UFVK or UIVK is properly only the whole thing.)
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood
b85a249a59
ZIP 316: clarify how P2PKH addresses are derived.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood
4d0477ce5f
ZIPs 32 and 316: refine how UIVK components are derived for Orchard and Transparent P2PKH.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood
d4cddc0615
ZIP 316: correct wording that assumed zero padding (i.e. had not been updated for inclusion of HRP).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-21 11:16:13 +01:00
Daira Hopwood
96277a1a14
ZIP 316: Expand "Message Authentication Code", and a wording improvement.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-17 15:30:56 +01:00
Daira Hopwood
39998c226c
ZIP 316: Clarify wording for UFVK or UIVK Encoding, and the reason why P2SH UFVK/UIVKs are not supported.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-17 14:41:27 +01:00
Daira Hopwood
0e057c3c8c
ZIP 316: Clarify that the experimental Typecodes are for use before proposing a ZIP.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-17 14:33:50 +01:00