Commit Graph

2382 Commits

Author SHA1 Message Date
Daira Hopwood db3b2f72d4 Remove link to the "GNU Kind Communication Guidelines" given Richard Stallman's involvement
(see https://rms-open-letter.github.io/appendix), and that document's stance on pronouns.

In particular, although the document has changed since the open letter's reference to it, its
current version says that gender-neutral pronouns "don't conflict with any possible gender
identity". That is incorrect, and not compatible with our CoC. Always use a person's stated
pronouns if they are known; use gender-neutral pronouns only when the correct ones are unknown
or when not referring to a specific person.

Besides the pronoun issue and the association with RMS, a universal exhortation to "assume good
faith" is verging on tone-policing when applied to marginalized communities. In any case,
ZIP 0 is not about that topic and the link is out-of-place.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-04 15:20:45 +01:00
Daira Hopwood 404248cb92 Regenerate PDFs. 2021-04-01 02:19:32 +01:00
Daira Hopwood a0d048ed1e Update Change History entry date.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 417076e50d Make a note in \crossref{inbandrationale} of the divergence of ivk from a uniform scalar.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 1eec1f9832 Remove anchorSapling field when there are no Spends.
This corresponds to e0b08fd576 in ZIP 225.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 49f3b206f5 Fix type error in kdfinput for KDF^{Sapling,Orchard} (`ephemeralKey` is already a byte sequence).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 41580ec06d Cosmetics in Sapling Output statement.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood c367a22098 Explicitly note that the end of the ZIP 212 grace period precedes NU5 activation.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 3a312dc5a9 Expand the set of ZIPs associated with NU5 in \crossref{networkupgrades}, and reference the Orchard and halo2 books there.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 6c3099843d Add a caveat about reuse of rivk between PRF^expand and Commit^ivk.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 3826d43930 Correct the set of inputs to PRF^expand used for ZIP 32 and Orchard in \crossref{abstractprfs}.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood de0bc97bb2 Cosmetics (page breaking).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood bb985e039a Section \crossref{concreteorchardkdf} should be in the NU5 colour (slate blue).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Deirdre Connolly ec6c10fc5c Add a note to the Sending Notes (Orchard) section about using a dummy note for ρ.
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 6c8f9fb478 Update the Sprout key component diagram in \crossref{addressesandkeys} to remove magenta highlighting.Remove magenta highlighting
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood e1f105eaa1 Add note about use of big-endian order in the encoding of BLS12-381 points.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 3a55af9b1f Cosmetics and indexing.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 7bfdce2d6a Write caution about linkage between the abstract and concrete protocols in \crossref{cautionlinkage}.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 1097313feb Fix errors in the Sinsemilla proofs:
* SinsemillaHash is defined in terms of SinsemillaHashToPoint, which also takes the D argument.
* correct errors due to 1-based indexing.
* the argument for exceptional cases got the scalars and range of j wrong.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood cce172ace8 Cosmetics (page breaking).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood f45b6b5d66 Add Action Statement ref to flags note
This change makes it clearer that the note spend and creation
rules are implemented as part of the proof.

Co-authored-by: teor <teor@riseup.net>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
teor ecb2ccd3f4 Copy outCiphertext description to the encoding tables 2021-04-01 02:11:35 +01:00
Daira Hopwood 0eca13f809
Merge pull request #479 from nuttycom/zip_225-sapling_anchors
Remove anchorSapling field when there are no spends.
2021-04-01 00:59:47 +01:00
Daira Hopwood 89596379ff ZIP 225: Cosmetics (trailing spaces).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 00:58:37 +01:00
Kris Nuttycombe e0b08fd576 ZIP 225: Remove anchorSapling field when there are no spends.
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 00:58:23 +01:00
Daira Hopwood 1bed047c0e ZIP 221: cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-31 13:40:26 +01:00
Daira Hopwood c9f9d0b36b ZIP 221: fix rst formatting.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-31 13:37:49 +01:00
Daira Hopwood 31e8b03491 ZIP 244: update link to protocol spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 20:19:33 +01:00
Daira Hopwood b0c65971d7
Merge pull request #467 from nuttycom/zip_225-ncc_fixes
Fixes for ZIP 225 issues identified by the NCC audit.
2021-03-30 20:10:43 +01:00
Kris Nuttycombe 0dd2982ec3 Update generated HTML. 2021-03-30 11:13:28 -06:00
Kris Nuttycombe 6ecba03a2a Fix vSpendAuthSigsOrchard field name. 2021-03-30 10:57:24 -06:00
Kris Nuttycombe f7461d62e5
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 10:45:49 -06:00
Kris Nuttycombe e936a21a6b
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 09:40:13 -06:00
Kris Nuttycombe 02fd26fc1f Make ordering of Orchard txid hash fields consistent with field order.
Also fixes a few conflicting/incorrect digest references and
removes some spurious duplication.

Co-authored by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 08:28:09 -06:00
Daira Hopwood 64484cb945
Merge pull request #477 from daira/nu5-update-zip221
ZIP 221 and 252 updates for NU5
2021-03-30 14:59:42 +01:00
Deirdre Connolly 0d67dcf681 Update zip-0221.rst
Co-authored-by: Deidre Connolly <deirde@zfnd.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 14:58:30 +01:00
Daira Hopwood 5c6ab07f15 ZIP 252: mention amended ZIP 221, and the halo2 book.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-29 23:19:55 +01:00
Daira Hopwood 37479f7a11 ZIP 221: NU5 updates.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-29 23:19:13 +01:00
Daira Hopwood b16cf169e4 ZIP 221: renamed fields.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-29 23:18:45 +01:00
Daira Hopwood 306c575b87 ZIP 244: regenerate HTML.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-29 16:52:29 +01:00
Daira Hopwood 17818f0b32
Merge pull request #474 from teor2345/patch-8
[ZIP 244]: Be explicit about immediate hashBlockCommitments activation
2021-03-29 16:51:55 +01:00
teor 96efd54702
Be explicit about hashBlockCommitments activation 2021-03-29 14:14:12 +10:00
Kris Nuttycombe 4b2af700ef Add non-requirement for non-malleable transaction IDs for v4 transactions. 2021-03-26 16:37:30 -06:00
Kris Nuttycombe f202b83a9d Remove Sprout commitments from ZIP 244; include flagsOrchard in txid. 2021-03-26 16:37:30 -06:00
Kris Nuttycombe e4bc6ad354 Fixes for ZIP 225 issues identified by the NCC audit. 2021-03-26 16:37:29 -06:00
Daira Hopwood b0180c76f8 ZIP 216: fix section numbers.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 20:03:19 +00:00
Daira Hopwood d713d35f54 ZIP 216: fix references to the NU5 protocol spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 20:00:44 +00:00
Daira Hopwood 0f427feb5b Regenerate PDFs. 2021-03-26 19:45:47 +00:00
Daira Hopwood f66887cdee Fix an off-by-one error.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 19:40:57 +00:00
Daira Hopwood 3898e2f571 Regenerate PDFs. 2021-03-26 19:38:49 +00:00