https://github.com/rust-lang/rust-clippy/issues/8771
error: this type has already been used as a bound predicate
--> impl/src/generics.rs:60:61
|
60 | pub fn insert(&mut self, ty: impl ToTokens, bound: impl ToTokens) {
| ^^^^^^^^
|
= note: `-D clippy::type-repetition-in-bounds` implied by `-D clippy::pedantic`
= help: consider combining the bounds: `impl ToTokens: ToTokens + ToTokens`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds
error: this trait bound is already specified in the where clause
--> impl/src/generics.rs:60:39
|
60 | pub fn insert(&mut self, ty: impl ToTokens, bound: impl ToTokens) {
| ^^^^^^^^
|
= note: `-D clippy::trait-duplication-in-bounds` implied by `-D clippy::pedantic`
= help: consider removing this trait bound
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trait_duplication_in_bounds
error: methods called `from_*` usually take no `self`
--> impl/src/prop.rs:5:30
|
5 | pub(crate) fn from_field(&self) -> Option<&Field> {
| ^^^^^
|
= note: `-D clippy::wrong-self-convention` implied by `-D clippy::all`
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
error: methods called `from_*` usually take no `self`
--> impl/src/prop.rs:51:30
|
51 | pub(crate) fn from_field(&self) -> Option<&Field> {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
error: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
--> tests/test_expr.rs:18:30
|
18 | #[error("#error {}", (.0).iter().copied().collect::<Vec<_>>().join(" "))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()`
error: casting `bool` to `usize` is more cleanly stated with `usize::from(_)`
--> impl/src/valid.rs:183:31
|
183 | if fields.len() > 1 + has_backtrace as usize {
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `usize::from(has_backtrace)`
|
= note: `-D clippy::cast-lossless` implied by `-D clippy::pedantic`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
The old version available by default in the GitHub Actions image fails
with:
thread 'main' panicked at 'package cache lock is not currently held, Cargo forgot to call `acquire_package_cache_lock` before we got to this stack frame', /usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-0.57.0/src/cargo/util/config/mod.rs:1542:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
David Tolnay
Danny McClanahan