Update some comments in zebra-network
Add ticket numbers, and update based on design decisions and new code.
This commit is contained in:
parent
68e2942f83
commit
0f0fb93b5c
|
@ -192,9 +192,9 @@ where
|
||||||
let (tcp_stream, addr) = req;
|
let (tcp_stream, addr) = req;
|
||||||
|
|
||||||
let connector_span = span!(Level::INFO, "connector", addr = ?addr);
|
let connector_span = span!(Level::INFO, "connector", addr = ?addr);
|
||||||
// set parent: None for the peer connection span, as it should exist
|
// set the peer connection span's parent to the global span, as it
|
||||||
// independently of its creation source (inbound connection, crawler,
|
// should exist independently of its creation source (inbound
|
||||||
// initial peer, ...)
|
// connection, crawler, initial peer, ...)
|
||||||
let connection_span = span!(parent: &self.parent_span, Level::INFO, "peer", addr = ?addr);
|
let connection_span = span!(parent: &self.parent_span, Level::INFO, "peer", addr = ?addr);
|
||||||
|
|
||||||
// Clone these upfront, so they can be moved into the future.
|
// Clone these upfront, so they can be moved into the future.
|
||||||
|
@ -315,12 +315,13 @@ where
|
||||||
// auto currentEpoch = CurrentEpoch(GetHeight(), consensusParams);
|
// auto currentEpoch = CurrentEpoch(GetHeight(), consensusParams);
|
||||||
// if (pfrom->nVersion < consensusParams.vUpgrades[currentEpoch].nProtocolVersion)
|
// if (pfrom->nVersion < consensusParams.vUpgrades[currentEpoch].nProtocolVersion)
|
||||||
//
|
//
|
||||||
// For approximately 1.5 days before a network upgrade, we also need to:
|
// For approximately 1.5 days before a network upgrade, zcashd also:
|
||||||
// - avoid old peers, and
|
// - avoids old peers, and
|
||||||
// - prefer updated peers.
|
// - prefers updated peers.
|
||||||
// For example, we could reject old peers with probability 0.5.
|
// We haven't decided if we need this behaviour in Zebra yet (see #706).
|
||||||
|
//
|
||||||
|
// At the network upgrade, we also need to disconnect from old peers (see #1334).
|
||||||
//
|
//
|
||||||
// At the network upgrade, we also need to disconnect from old peers.
|
|
||||||
// TODO: replace min_for_upgrade(network, MIN_NETWORK_UPGRADE) with
|
// TODO: replace min_for_upgrade(network, MIN_NETWORK_UPGRADE) with
|
||||||
// current_min(network, height) where network is the
|
// current_min(network, height) where network is the
|
||||||
// configured network, and height is the best tip's block
|
// configured network, and height is the best tip's block
|
||||||
|
|
Loading…
Reference in New Issue