zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: Improve an acceptance test failure message 

If the tests conflict with a local zebrad, zcashd, or other tests, they
need to be run with a custom config, or in an isolated environment.
This commit is contained in:
teor 2020-08-20 20:39:10 +10:00
parent b8e8d4f548
commit 1e0e4914a0
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
zebrad/tests/acceptance.rs
View File

@ -299,8 +299,15 @@ fn valid_generated_config() -> Result<()> {
output.stdout_contains(r"Starting zebrad")?;
// Make sure the command was killed
assert!(output.was_killed());
// If the test child has a cache or port conflict with another test, or a
// running zebrad or zcashd, then it will panic. But the acceptance tests
// expect it to run until it is killed.
//
// If these conflicts cause test failures:
// - run the tests in an isolated environment,
// - run zebrad on a custom cache path and port,
// - run zcashd on a custom port.
assert!(output.was_killed(), "Expected zebrad with generated config to succeed. Are there other acceptance test, zebrad, or zcashd processes running?");
// Run seed using temp dir and kill it at 1 second
let mut child = get_child(