Qualify std::sync::Mutex in the unit tests (#2304)

Also add a missing zebra_test::init().
This commit is contained in:
teor 2021-06-15 23:01:56 +10:00 committed by GitHub
parent 3f7410d073
commit 3932661a93
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 6 deletions

View File

@ -1,6 +1,6 @@
use std::{
env,
sync::{Arc, Mutex},
sync::Arc,
time::{Duration, Instant},
};
@ -69,7 +69,7 @@ proptest! {
// Since the address book is empty, there won't be any available peers
let address_book = AddressBook::new(&Config::default(), Span::none());
let mut candidate_set = CandidateSet::new(Arc::new(Mutex::new(address_book)), peer_service);
let mut candidate_set = CandidateSet::new(Arc::new(std::sync::Mutex::new(address_book)), peer_service);
// Make sure that the rate-limit is never triggered, even after multiple calls
for _ in 0..next_peer_attempts {
@ -106,7 +106,7 @@ proptest! {
let mut address_book = AddressBook::new(&Config::default(), Span::none());
address_book.extend(peers);
let mut candidate_set = CandidateSet::new(Arc::new(Mutex::new(address_book)), peer_service);
let mut candidate_set = CandidateSet::new(Arc::new(std::sync::Mutex::new(address_book)), peer_service);
let checks = async move {
// Check rate limiting for initial peers

View File

@ -3,7 +3,7 @@ use std::{
convert::TryInto,
iter,
net::{IpAddr, SocketAddr},
sync::{Arc, Mutex},
sync::Arc,
time::Duration as StdDuration,
};
@ -139,12 +139,15 @@ fn candidate_set_updates_are_rate_limited() {
// How many times should `update` be called in each rate limit interval
const POLL_FREQUENCY_FACTOR: u32 = 3;
zebra_test::init();
let runtime = Runtime::new().expect("Failed to create Tokio runtime");
let _guard = runtime.enter();
let address_book = AddressBook::new(&Config::default(), Span::none());
let (peer_service, call_count) = mock_peer_service();
let mut candidate_set = CandidateSet::new(Arc::new(Mutex::new(address_book)), peer_service);
let mut candidate_set =
CandidateSet::new(Arc::new(std::sync::Mutex::new(address_book)), peer_service);
runtime.block_on(async move {
time::pause();
@ -178,7 +181,8 @@ fn candidate_set_update_after_update_initial_is_rate_limited() {
let address_book = AddressBook::new(&Config::default(), Span::none());
let (peer_service, call_count) = mock_peer_service();
let mut candidate_set = CandidateSet::new(Arc::new(Mutex::new(address_book)), peer_service);
let mut candidate_set =
CandidateSet::new(Arc::new(std::sync::Mutex::new(address_book)), peer_service);
runtime.block_on(async move {
time::pause();