zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Disable RPC port conflict tests on Windows and macOS (#5072)

This commit is contained in:
teor 2022-09-06 02:07:27 +10:00 committed by GitHub
parent ceff590c12
commit 524e9ab123
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zebra-rpc/src/server/tests/vectors.rs
View File

@ -142,8 +142,12 @@ fn rpc_server_spawn_unallocated_port(parallel_cpu_threads: bool) {
} }
/// Test if the RPC server will panic correctly when there is a port conflict. /// Test if the RPC server will panic correctly when there is a port conflict.
///
/// This test is sometimes unreliable on Windows, and hangs on macOS.
/// We believe this is a CI infrastructure issue, not a platform-specific issue.
#[test] #[test]
#[should_panic(expected = "Unable to start RPC server")] #[should_panic(expected = "Unable to start RPC server")]
#[cfg(not(any(target_os = "windows", target_os = "macos")))]
fn rpc_server_spawn_port_conflict() { fn rpc_server_spawn_port_conflict() {
let _init_guard = zebra_test::init(); let _init_guard = zebra_test::init();
@ -234,7 +238,11 @@ fn rpc_server_spawn_port_conflict() {
/// ///
/// If this test fails, that's great! /// If this test fails, that's great!
/// We can make parallel the default, and remove the warnings in the config docs. /// We can make parallel the default, and remove the warnings in the config docs.
///
/// This test is sometimes unreliable on Windows, and hangs on macOS.
/// We believe this is a CI infrastructure issue, not a platform-specific issue.
#[test] #[test]
#[cfg(not(any(target_os = "windows", target_os = "macos")))]
fn rpc_server_spawn_port_conflict_parallel_auto() { fn rpc_server_spawn_port_conflict_parallel_auto() {
let _init_guard = zebra_test::init(); let _init_guard = zebra_test::init();