zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Adds a comment about avoiding duplicate ncts and avoids spawning rayon scope if there are no notes

This commit is contained in:
Arya 2024-04-24 13:36:44 -04:00
parent 19e407158a
commit 661b3fdfed
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
zebra-chain/src/parallel/tree.rs
View File

@ -79,8 +79,19 @@ impl NoteCommitmentTrees {
let mut sapling_result = None;
let mut orchard_result = None;
// Note: Only updating the note commitment trees when there are more notes that
// need to be appended to the tree prevents unnecessarily duplicating note commitment
// tree data in the non-finalized state.
let has_sprout_notes = !sprout_note_commitments.is_empty();
let has_sapling_notes = !sapling_note_commitments.is_empty();
let has_orchard_notes = !orchard_note_commitments.is_empty();
if !(has_sprout_notes || has_sapling_notes || has_orchard_notes) {
return Ok(());
}
rayon::in_place_scope_fifo(|scope| {
if !sprout_note_commitments.is_empty() {
if has_sprout_notes {
scope.spawn_fifo(|_scope| {
sprout_result = Some(Self::update_sprout_note_commitment_tree(
sprout,
@ -89,7 +100,7 @@ impl NoteCommitmentTrees {
});
}
if !sapling_note_commitments.is_empty() {
if has_sapling_notes {
scope.spawn_fifo(|_scope| {
sapling_result = Some(Self::update_sapling_note_commitment_tree(
sapling,
@ -98,7 +109,7 @@ impl NoteCommitmentTrees {
});
}
if !orchard_note_commitments.is_empty() {
if has_orchard_notes {
scope.spawn_fifo(|_scope| {
orchard_result = Some(Self::update_orchard_note_commitment_tree(
orchard,