orchard: ValueCommit ops implementation tests

This commit is contained in:
Deirdre Connolly 2021-04-04 20:59:46 -04:00 committed by Deirdre Connolly
parent db8f9cb81a
commit 81038e0fcb
1 changed files with 60 additions and 125 deletions

View File

@ -332,12 +332,14 @@ impl ValueCommitment {
} }
} }
// #[cfg(test)] #[cfg(test)]
// mod tests { mod tests {
// use std::ops::Neg; use std::ops::Neg;
// use super::*; use group::Group;
use super::*;
// #[test] // #[test]
// fn sinsemilla_hash_to_point_test_vectors() { // fn sinsemilla_hash_to_point_test_vectors() {
@ -353,140 +355,73 @@ impl ValueCommitment {
// } // }
// } // }
// TODO: these test vectors for ops are from Jubjub, replace with Pallas ones #[test]
fn add() {
zebra_test::init();
// #[test] let identity = ValueCommitment(pallas::Affine::identity());
// fn add() {
// zebra_test::init();
// let identity = ValueCommitment(pallas::Affine::identity()); let g = ValueCommitment(pallas::Affine::generator());
// let g = ValueCommitment(pallas::Affine::from_raw_unchecked( assert_eq!(identity + g, g);
// pallas::Base::from_raw([ }
// 0xe4b3_d35d_f1a7_adfe,
// 0xcaf5_5d1b_29bf_81af,
// 0x8b0f_03dd_d60a_8187,
// 0x62ed_cbb8_bf37_87c8,
// ]),
// pallas::Base::from_raw([
// 0x0000_0000_0000_000b,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// ]),
// ));
// assert_eq!(identity + g, g); #[test]
// } fn add_assign() {
zebra_test::init();
// #[test] let mut identity = ValueCommitment(pallas::Affine::identity());
// fn add_assign() {
// zebra_test::init();
// let mut identity = ValueCommitment(pallas::Affine::identity()); let g = ValueCommitment(pallas::Affine::generator());
// let g = ValueCommitment(pallas::Affine::from_raw_unchecked( identity += g;
// pallas::Base::from_raw([ let new_g = identity;
// 0xe4b3_d35d_f1a7_adfe,
// 0xcaf5_5d1b_29bf_81af,
// 0x8b0f_03dd_d60a_8187,
// 0x62ed_cbb8_bf37_87c8,
// ]),
// pallas::Base::from_raw([
// 0x0000_0000_0000_000b,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// ]),
// ));
// identity += g; assert_eq!(new_g, g);
// let new_g = identity; }
// assert_eq!(new_g, g); #[test]
// } fn sub() {
zebra_test::init();
// #[test] let g_point = pallas::Affine::generator();
// fn sub() {
// zebra_test::init();
// let g_point = pallas::Affine::from_raw_unchecked( let identity = ValueCommitment(pallas::Affine::identity());
// pallas::Base::from_raw([
// 0xe4b3_d35d_f1a7_adfe,
// 0xcaf5_5d1b_29bf_81af,
// 0x8b0f_03dd_d60a_8187,
// 0x62ed_cbb8_bf37_87c8,
// ]),
// pallas::Base::from_raw([
// 0x0000_0000_0000_000b,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// ]),
// );
// let identity = ValueCommitment(pallas::Affine::identity()); let g = ValueCommitment(g_point);
// let g = ValueCommitment(g_point); assert_eq!(identity - g, ValueCommitment(g_point.neg()));
}
// assert_eq!(identity - g, ValueCommitment(g_point.neg())); #[test]
// } fn sub_assign() {
zebra_test::init();
// #[test] let g_point = pallas::Affine::generator();
// fn sub_assign() {
// zebra_test::init();
// let g_point = pallas::Affine::from_raw_unchecked( let mut identity = ValueCommitment(pallas::Affine::identity());
// pallas::Base::from_raw([
// 0xe4b3_d35d_f1a7_adfe,
// 0xcaf5_5d1b_29bf_81af,
// 0x8b0f_03dd_d60a_8187,
// 0x62ed_cbb8_bf37_87c8,
// ]),
// pallas::Base::from_raw([
// 0x0000_0000_0000_000b,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// ]),
// );
// let mut identity = ValueCommitment(pallas::Affine::identity()); let g = ValueCommitment(g_point);
// let g = ValueCommitment(g_point); identity -= g;
let new_g = identity;
// identity -= g; assert_eq!(new_g, ValueCommitment(g_point.neg()));
// let new_g = identity; }
// assert_eq!(new_g, ValueCommitment(g_point.neg())); #[test]
// } fn sum() {
zebra_test::init();
// #[test] let g_point = pallas::Affine::generator();
// fn sum() {
// zebra_test::init();
// let g_point = pallas::Affine::from_raw_unchecked( let g = ValueCommitment(g_point);
// pallas::Base::from_raw([ let other_g = ValueCommitment(g_point);
// 0xe4b3_d35d_f1a7_adfe,
// 0xcaf5_5d1b_29bf_81af,
// 0x8b0f_03dd_d60a_8187,
// 0x62ed_cbb8_bf37_87c8,
// ]),
// pallas::Base::from_raw([
// 0x0000_0000_0000_000b,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// 0x0000_0000_0000_0000,
// ]),
// );
// let g = ValueCommitment(g_point); let sum: ValueCommitment = vec![g, other_g].into_iter().sum();
// let other_g = ValueCommitment(g_point);
// let sum: ValueCommitment = vec![g, other_g].into_iter().sum(); let doubled_g = ValueCommitment(g_point.to_curve().double().into());
// let doubled_g = ValueCommitment(g_point.into().double().into()); assert_eq!(sum, doubled_g);
}
// assert_eq!(sum, doubled_g); }
// }
// }