fix(beta-toolchain): Warnings (#8404)

* fix beta imports and other warnings

* clippy lints beta

* move attributes to after docs

Co-authored-by: Marek <mail@marek.onl>

* move some code to test module

* implement display instead of direct tostring for LongPollId

Co-authored-by: Arya <aryasolhi@gmail.com>

* fix typo

---------

Co-authored-by: Marek <mail@marek.onl>
Co-authored-by: Arya <aryasolhi@gmail.com>

zebra-chain/src/block/arbitrary.rs

@@ -1,22 +1,13 @@
 //! Randomised property testing for [`Block`]s.
 
-use std::{collections::HashMap, sync::Arc};
+use proptest::prelude::*;
-
-use proptest::{
-    arbitrary::{any, Arbitrary},
-    prelude::*,
-};
 
 use crate::{
     amount::NonNegative,
     block,
     fmt::{HexDebug, SummaryDebug},
     history_tree::HistoryTree,
-    parameters::{
+    parameters::{NetworkUpgrade::*, GENESIS_PREVIOUS_BLOCK_HASH},
-        Network,
-        NetworkUpgrade::{self, *},
-        GENESIS_PREVIOUS_BLOCK_HASH,
-    },
     serialization,
     transaction::arbitrary::MAX_ARBITRARY_ITEMS,
     transparent::{

zebra-chain/src/block/tests/prop.rs

@@ -2,21 +2,19 @@
 
 use std::{env, io::ErrorKind};
 
-use proptest::{arbitrary::any, prelude::*, test_runner::Config};
+use proptest::{prelude::*, test_runner::Config};
 
 use hex::{FromHex, ToHex};
 
 use zebra_test::prelude::*;
 
 use crate::{
-    parameters::{Network, GENESIS_PREVIOUS_BLOCK_HASH},
+    parameters::GENESIS_PREVIOUS_BLOCK_HASH,
     serialization::{SerializationError, ZcashDeserializeInto, ZcashSerialize},
-    LedgerState,
 };
 
 use super::super::{
     arbitrary::{allow_all_transparent_coinbase_spends, PREVOUTS_CHAIN_HEIGHT},
-    serialize::MAX_BLOCK_BYTES,
     *,
 };
 

zebra-chain/src/orchard/action.rs

@@ -1,4 +1,4 @@
-use std::{convert::TryFrom, io};
+use std::io;
 
 use halo2::pasta::pallas;
 use reddsa::orchard::SpendAuth;

zebra-chain/src/orchard/arbitrary.rs

@@ -7,7 +7,7 @@ use group::{
 use halo2::pasta::pallas;
 use reddsa::{orchard::SpendAuth, Signature, SigningKey, VerificationKey, VerificationKeyBytes};
 
-use proptest::{arbitrary::any, array, collection::vec, prelude::*};
+use proptest::{array, collection::vec, prelude::*};
 
 use super::{
     keys::*, note, tree, Action, AuthorizedAction, Flags, NoteCommitment, ValueCommitment,

zebra-chain/src/orchard/note/arbitrary.rs

@@ -1,4 +1,4 @@
-use proptest::{arbitrary::any, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 use super::*;
 

zebra-chain/src/orchard/shielded_data.rs

@@ -8,7 +8,7 @@ use std::{
 
 use byteorder::{ReadBytesExt, WriteBytesExt};
 use halo2::pasta::pallas;
-use reddsa::{self, orchard::Binding, orchard::SpendAuth, Signature};
+use reddsa::{orchard::Binding, orchard::SpendAuth, Signature};
 
 use crate::{
     amount::{Amount, NegativeAllowed},

zebra-chain/src/orchard/tree.rs

@@ -19,7 +19,7 @@ use std::{
 };
 
 use bitvec::prelude::*;
-use bridgetree::{self, NonEmptyFrontier};
+use bridgetree::NonEmptyFrontier;
 use halo2::pasta::{group::ff::PrimeField, pallas};
 use hex::ToHex;
 use incrementalmerkletree::Hashable;

zebra-chain/src/primitives/proofs/bctv14.rs

@@ -53,7 +53,7 @@ impl ZcashDeserialize for Bctv14Proof {
 }
 
 #[cfg(any(test, feature = "proptest-impl"))]
-use proptest::{arbitrary::Arbitrary, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 #[cfg(any(test, feature = "proptest-impl"))]
 impl Arbitrary for Bctv14Proof {

zebra-chain/src/primitives/proofs/groth16.rs

@@ -65,7 +65,7 @@ impl ZcashDeserialize for Groth16Proof {
 }
 
 #[cfg(any(test, feature = "proptest-impl"))]
-use proptest::{arbitrary::Arbitrary, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 #[cfg(any(test, feature = "proptest-impl"))]
 impl Arbitrary for Groth16Proof {

zebra-chain/src/primitives/proofs/halo2.rs

@@ -36,7 +36,7 @@ impl ZcashDeserialize for Halo2Proof {
     }
 }
 #[cfg(any(test, feature = "proptest-impl"))]
-use proptest::{arbitrary::Arbitrary, prelude::*};
+use proptest::prelude::*;
 
 #[cfg(any(test, feature = "proptest-impl"))]
 impl Arbitrary for Halo2Proof {

zebra-chain/src/primitives/zcash_history.rs

@@ -6,7 +6,7 @@
 
 mod tests;
 
-use std::{collections::BTreeMap, convert::TryInto, io, sync::Arc};
+use std::{collections::BTreeMap, io, sync::Arc};
 
 use serde_big_array::BigArray;
 pub use zcash_history::{V1, V2};

zebra-chain/src/sapling/arbitrary.rs

@@ -5,7 +5,7 @@ use jubjub::{AffinePoint, ExtendedPoint};
 use rand::SeedableRng;
 use rand_chacha::ChaChaRng;
 
-use proptest::{arbitrary::any, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 use crate::primitives::Groth16Proof;
 

zebra-chain/src/sapling/commitment.rs

@@ -1,9 +1,6 @@
 //! Note and value commitments.
 
-use std::{
+use std::{fmt, io};
-    convert::{TryFrom, TryInto},
-    fmt, io,
-};
 
 use bitvec::prelude::*;
 use jubjub::ExtendedPoint;

zebra-chain/src/sapling/keys.rs

@@ -16,7 +16,7 @@ use rand_core::{CryptoRng, RngCore};
 
 use crate::{
     error::{AddressError, RandError},
-    primitives::redjubjub::{self, SpendAuth},
+    primitives::redjubjub::SpendAuth,
     serialization::{
         serde_helpers, ReadZcashExt, SerializationError, ZcashDeserialize, ZcashSerialize,
     },

zebra-chain/src/sapling/note/arbitrary.rs

@@ -1,4 +1,4 @@
-use proptest::{arbitrary::any, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 use super::*;
 

zebra-chain/src/sapling/spend.rs

@@ -3,14 +3,11 @@
 //! Zebra uses a generic spend type for `V4` and `V5` transactions.
 //! The anchor change is handled using the `AnchorVariant` type trait.
 
-use std::{convert::TryInto, fmt, io};
+use std::{fmt, io};
 
 use crate::{
     block::MAX_BLOCK_BYTES,
-    primitives::{
+    primitives::{redjubjub::SpendAuth, Groth16Proof},
-        redjubjub::{self, SpendAuth},
-        Groth16Proof,
-    },
     serialization::{
         ReadZcashExt, SerializationError, TrustedPreallocate, WriteZcashExt, ZcashDeserialize,
         ZcashDeserializeInto, ZcashSerialize,

zebra-chain/src/sapling/tests/prop.rs

@@ -8,7 +8,6 @@ use crate::{
     serialization::{ZcashDeserializeInto, ZcashSerialize},
     transaction::{LockTime, Transaction},
 };
-use std::convert::TryInto;
 
 proptest! {
     /// Serialize and deserialize `Spend<PerSpendAnchor>`

zebra-chain/src/sapling/tree.rs

@@ -19,7 +19,7 @@ use std::{
 };
 
 use bitvec::prelude::*;
-use bridgetree::{self, NonEmptyFrontier};
+use bridgetree::NonEmptyFrontier;
 use hex::ToHex;
 use incrementalmerkletree::{frontier::Frontier, Hashable};
 

zebra-chain/src/serialization/arbitrary.rs

@@ -1,9 +1,7 @@
 //! Arbitrary data generation for serialization proptests
 
-use std::convert::TryInto;
-
 use chrono::{DateTime, TimeZone, Utc};
-use proptest::{arbitrary::any, prelude::*};
+use proptest::prelude::*;
 
 use super::{
     CompactSizeMessage, DateTime32, TrustedPreallocate, ZcashSerialize, MAX_PROTOCOL_MESSAGE_LEN,

zebra-chain/src/serialization/compact_size.rs

@@ -5,8 +5,6 @@
 //! - [`CompactSizeMessage`] for sizes that must be less than the network message limit, and
 //! - [`CompactSize64`] for flags, arbitrary counts, and sizes that span multiple blocks.
 
-use std::convert::{TryFrom, TryInto};
-
 use byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt};
 
 use crate::serialization::{

zebra-chain/src/serialization/constraint.rs

@@ -1,9 +1,6 @@
 //! Serialization constraint helpers.
 
-use std::{
+use std::ops::Deref;
-    convert::{TryFrom, TryInto},
-    ops::Deref,
-};
 
 use crate::serialization::SerializationError;
 

zebra-chain/src/serialization/tests/preallocate.rs

@@ -2,7 +2,7 @@
 
 use proptest::{collection::size_range, prelude::*};
 
-use std::{convert::TryInto, matches};
+use std::matches;
 
 use crate::serialization::{
     arbitrary::max_allocation_is_big_enough, zcash_deserialize::MAX_U8_ALLOCATION,

zebra-chain/src/sprout/arbitrary.rs

@@ -1,4 +1,4 @@
-use proptest::{arbitrary::any, array, prelude::*};
+use proptest::{array, prelude::*};
 
 use crate::{
     amount::{Amount, NonNegative},

zebra-chain/src/sprout/note/arbitrary.rs

@@ -1,4 +1,4 @@
-use proptest::{arbitrary::any, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 impl Arbitrary for super::EncryptedNote {
     type Parameters = ();

zebra-chain/src/tests/vectors.rs

@@ -30,7 +30,9 @@ impl Network {
         }
     }
 
+    /// Returns blocks indexed by height in a [`BTreeMap`].
     ///
+    /// Returns Mainnet blocks if `self` is set to Mainnet, and Testnet blocks otherwise.
     pub fn block_map(&self) -> BTreeMap<u32, &'static [u8]> {
         if self.is_mainnet() {
             zebra_test::vectors::MAINNET_BLOCKS.clone()

zebra-chain/src/transaction/arbitrary.rs

@@ -1,17 +1,9 @@
 //! Arbitrary data generation for transaction proptests
 
-use std::{
+use std::{cmp::max, collections::HashMap, ops::Neg, sync::Arc};
-    cmp::max,
-    collections::HashMap,
-    convert::{TryFrom, TryInto},
-    ops::Neg,
-    sync::Arc,
-};
 
 use chrono::{TimeZone, Utc};
-use proptest::{
+use proptest::{array, collection::vec, option, prelude::*, test_runner::TestRunner};
-    arbitrary::any, array, collection::vec, option, prelude::*, test_runner::TestRunner,
-};
 use reddsa::{orchard::Binding, Signature};
 
 use crate::{

zebra-chain/src/transaction/hash.rs

@@ -28,11 +28,7 @@
 //!
 //! [1]: crate::transaction::UnminedTx
 
-use std::{
+use std::{fmt, sync::Arc};
-    convert::{TryFrom, TryInto},
-    fmt,
-    sync::Arc,
-};
 
 #[cfg(any(test, feature = "proptest-impl"))]
 use proptest_derive::Arbitrary;

zebra-chain/src/transaction/memo.rs

@@ -1,4 +1,4 @@
-use std::{cmp, convert::TryFrom, fmt};
+use std::{cmp, fmt};
 
 /// A 512-byte (plaintext) memo associated with a note, as described in
 /// [protocol specification §5.5][ps].

zebra-chain/src/transaction/serialize.rs

@@ -1,10 +1,10 @@
 //! Contains impls of `ZcashSerialize`, `ZcashDeserialize` for all of the
 //! transaction types, so that all of the serialization logic is in one place.
 
-use std::{borrow::Borrow, convert::TryInto, io, sync::Arc};
+use std::{borrow::Borrow, io, sync::Arc};
 
 use byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt};
-use halo2::pasta::{group::ff::PrimeField, pallas};
+use halo2::pasta::group::ff::PrimeField;
 use hex::FromHex;
 use reddsa::{orchard::Binding, orchard::SpendAuth, Signature};
 
@@ -12,13 +12,12 @@ use crate::{
     amount,
     block::MAX_BLOCK_BYTES,
     parameters::{OVERWINTER_VERSION_GROUP_ID, SAPLING_VERSION_GROUP_ID, TX_V5_VERSION_GROUP_ID},
-    primitives::{Groth16Proof, Halo2Proof, ZkSnarkProof},
+    primitives::{Halo2Proof, ZkSnarkProof},
     serialization::{
         zcash_deserialize_external_count, zcash_serialize_empty_list,
         zcash_serialize_external_count, AtLeastOne, ReadZcashExt, SerializationError,
         TrustedPreallocate, ZcashDeserialize, ZcashDeserializeInto, ZcashSerialize,
     },
-    sprout,
 };
 
 use super::*;

zebra-chain/src/transaction/tests/vectors.rs

@@ -5,11 +5,10 @@ use color_eyre::eyre::Result;
 use lazy_static::lazy_static;
 
 use crate::{
-    amount::Amount,
     block::{Block, Height, MAX_BLOCK_BYTES},
-    parameters::{Network, NetworkUpgrade},
+    parameters::Network,
     serialization::{SerializationError, ZcashDeserialize, ZcashDeserializeInto, ZcashSerialize},
-    transaction::{hash::WtxId, sighash::SigHasher, txid::TxIdBuilder, Transaction},
+    transaction::{sighash::SigHasher, txid::TxIdBuilder},
     transparent::Script,
 };
 

zebra-chain/src/transaction/txid.rs

@@ -1,6 +1,6 @@
 //! Transaction ID computation. Contains code for generating the Transaction ID
 //! from the transaction.
-use std::{convert::TryInto, io};
+use std::io;
 
 use super::{Hash, Transaction};
 use crate::serialization::{sha256d, ZcashSerialize};

zebra-chain/src/transparent/address.rs

@@ -2,10 +2,6 @@
 
 use std::{fmt, io};
 
-use ripemd::{Digest, Ripemd160};
-use secp256k1::PublicKey;
-use sha2::Sha256;
-
 use crate::{
     parameters::NetworkKind,
     serialization::{SerializationError, ZcashDeserialize, ZcashSerialize},
@@ -154,29 +150,6 @@ impl ZcashDeserialize for Address {
     }
 }
 
-trait ToAddressWithNetwork {
-    /// Convert `self` to an `Address`, given the current `network`.
-    fn to_address(&self, network: NetworkKind) -> Address;
-}
-
-impl ToAddressWithNetwork for Script {
-    fn to_address(&self, network_kind: NetworkKind) -> Address {
-        Address::PayToScriptHash {
-            network_kind,
-            script_hash: Address::hash_payload(self.as_raw_bytes()),
-        }
-    }
-}
-
-impl ToAddressWithNetwork for PublicKey {
-    fn to_address(&self, network_kind: NetworkKind) -> Address {
-        Address::PayToPublicKeyHash {
-            network_kind,
-            pub_key_hash: Address::hash_payload(&self.serialize()[..]),
-        }
-    }
-}
-
 impl Address {
     /// Create an address for the given public key hash and network.
     pub fn from_pub_key_hash(network_kind: NetworkKind, pub_key_hash: [u8; 20]) -> Self {
@@ -219,21 +192,6 @@ impl Address {
         }
     }
 
-    /// A hash of a transparent address payload, as used in
-    /// transparent pay-to-script-hash and pay-to-publickey-hash
-    /// addresses.
-    ///
-    /// The resulting hash in both of these cases is always exactly 20
-    /// bytes.
-    /// <https://en.bitcoin.it/Base58Check_encoding#Encoding_a_Bitcoin_address>
-    fn hash_payload(bytes: &[u8]) -> [u8; 20] {
-        let sha_hash = Sha256::digest(bytes);
-        let ripe_hash = Ripemd160::digest(sha_hash);
-        let mut payload = [0u8; 20];
-        payload[..].copy_from_slice(&ripe_hash[..]);
-        payload
-    }
-
     /// Given a transparent address (P2SH or a P2PKH), create a script that can be used in a coinbase
     /// transaction output.
     pub fn create_script_from_address(&self) -> Script {
@@ -264,11 +222,53 @@ impl Address {
 
 #[cfg(test)]
 mod tests {
-
+    use ripemd::{Digest, Ripemd160};
     use secp256k1::PublicKey;
+    use sha2::Sha256;
 
     use super::*;
 
+    trait ToAddressWithNetwork {
+        /// Convert `self` to an `Address`, given the current `network`.
+        fn to_address(&self, network: NetworkKind) -> Address;
+    }
+
+    impl ToAddressWithNetwork for Script {
+        fn to_address(&self, network_kind: NetworkKind) -> Address {
+            Address::PayToScriptHash {
+                network_kind,
+                script_hash: Address::hash_payload(self.as_raw_bytes()),
+            }
+        }
+    }
+
+    impl ToAddressWithNetwork for PublicKey {
+        fn to_address(&self, network_kind: NetworkKind) -> Address {
+            Address::PayToPublicKeyHash {
+                network_kind,
+                pub_key_hash: Address::hash_payload(&self.serialize()[..]),
+            }
+        }
+    }
+
+    impl Address {
+        /// A hash of a transparent address payload, as used in
+        /// transparent pay-to-script-hash and pay-to-publickey-hash
+        /// addresses.
+        ///
+        /// The resulting hash in both of these cases is always exactly 20
+        /// bytes.
+        /// <https://en.bitcoin.it/Base58Check_encoding#Encoding_a_Bitcoin_address>
+        #[allow(dead_code)]
+        fn hash_payload(bytes: &[u8]) -> [u8; 20] {
+            let sha_hash = Sha256::digest(bytes);
+            let ripe_hash = Ripemd160::digest(sha_hash);
+            let mut payload = [0u8; 20];
+            payload[..].copy_from_slice(&ripe_hash[..]);
+            payload
+        }
+    }
+
     #[test]
     fn pubkey_mainnet() {
         let _init_guard = zebra_test::init();

zebra-chain/src/transparent/arbitrary.rs

@@ -1,4 +1,4 @@
-use proptest::{arbitrary::any, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 use crate::{block, parameters::NetworkKind, LedgerState};
 

zebra-chain/src/transparent/script.rs

@@ -95,7 +95,6 @@ mod proptests {
     use proptest::prelude::*;
 
     use super::*;
-    use crate::serialization::{ZcashDeserialize, ZcashSerialize};
 
     proptest! {
         #[test]

zebra-chain/src/transparent/utxo.rs

@@ -1,6 +1,6 @@
 //! Unspent transparent output data structures and functions.
 
-use std::{collections::HashMap, convert::TryInto};
+use std::collections::HashMap;
 
 use crate::{
     block::{self, Block, Height},

zebra-chain/src/value_balance.rs

@@ -6,7 +6,7 @@ use crate::{
     transparent,
 };
 
-use std::{borrow::Borrow, collections::HashMap, convert::TryInto};
+use std::{borrow::Borrow, collections::HashMap};
 
 #[cfg(any(test, feature = "proptest-impl"))]
 use crate::{amount::MAX_MONEY, transaction::Transaction};

zebra-chain/src/work/arbitrary.rs

@@ -1,6 +1,6 @@
 use super::*;
 
-use proptest::{arbitrary::Arbitrary, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 impl Arbitrary for equihash::Solution {
     type Parameters = ();

zebra-chain/src/work/difficulty/arbitrary.rs

@@ -1,8 +1,6 @@
 use super::*;
 
-use crate::block;
+use proptest::{collection::vec, prelude::*};
-
-use proptest::{arbitrary::Arbitrary, collection::vec, prelude::*};
 
 impl Arbitrary for CompactDifficulty {
     type Parameters = ();

zebra-chain/src/work/difficulty/tests/prop.rs

@@ -1,8 +1,4 @@
-use proptest::{arbitrary::any, prelude::*};
+use proptest::prelude::*;
-
-use std::cmp::Ordering;
-
-use crate::block;
 
 use super::super::*;
 

zebra-chain/src/work/tests/prop.rs

@@ -2,7 +2,7 @@
 
 use std::{env, sync::Arc};
 
-use proptest::{arbitrary::any, prelude::*, test_runner::Config};
+use proptest::{prelude::*, test_runner::Config};
 
 use crate::{
     block::{self, Block},

zebra-chain/src/work/tests/vectors.rs

@@ -1,5 +1,3 @@
-use std::convert::TryInto;
-
 use crate::{
     block::{Block, MAX_BLOCK_BYTES},
     serialization::{CompactSizeMessage, ZcashDeserialize, ZcashDeserializeInto, ZcashSerialize},

zebra-consensus/src/block/subsidy/general.rs

@@ -2,7 +2,7 @@
 //!
 //! [7.8]: https://zips.z.cash/protocol/protocol.pdf#subsidies
 
-use std::{collections::HashSet, convert::TryFrom};
+use std::collections::HashSet;
 
 use zebra_chain::{
     amount::{Amount, Error, NonNegative},

zebra-consensus/src/block/tests.rs

@@ -1,22 +1,18 @@
 //! Tests for block verification
 
-use std::sync::Arc;
-
-use chrono::Utc;
 use color_eyre::eyre::{eyre, Report};
 use once_cell::sync::Lazy;
 use tower::{buffer::Buffer, util::BoxService};
 
 use zebra_chain::{
-    amount::{Amount, MAX_MONEY},
+    amount::MAX_MONEY,
     block::{
-        self,
         tests::generate::{
             large_multi_transaction_block, large_single_transaction_block_many_inputs,
         },
         Block, Height,
     },
-    parameters::{Network, NetworkUpgrade},
+    parameters::NetworkUpgrade,
     serialization::{ZcashDeserialize, ZcashDeserializeInto},
     transaction::{arbitrary::transaction_to_fake_v5, LockTime, Transaction},
     work::difficulty::{ParameterDifficulty as _, INVALID_COMPACT_DIFFICULTY},

zebra-consensus/src/checkpoint/list/tests.rs

@@ -5,8 +5,8 @@ use std::sync::Arc;
 use num_integer::div_ceil;
 
 use zebra_chain::{
-    block::{self, Block, HeightDiff, MAX_BLOCK_BYTES},
+    block::{Block, HeightDiff, MAX_BLOCK_BYTES},
-    parameters::{Network, Network::*},
+    parameters::Network::*,
     serialization::ZcashDeserialize,
 };
 use zebra_node_services::constants::{MAX_CHECKPOINT_BYTE_COUNT, MAX_CHECKPOINT_HEIGHT_GAP};

zebra-consensus/src/checkpoint/tests.rs

@@ -1,14 +1,10 @@
 //! Tests for checkpoint-based block verification
 
-use std::{cmp::min, mem::drop, time::Duration};
+use std::{cmp::min, time::Duration};
 
 use color_eyre::eyre::{eyre, Report};
-use futures::{
+use futures::stream::{FuturesUnordered, StreamExt};
-    future::TryFutureExt,
-    stream::{FuturesUnordered, StreamExt},
-};
 use tokio::time::timeout;
-use tower::{Service, ServiceExt};
 use tracing_futures::Instrument;
 
 use zebra_chain::{parameters::Network::*, serialization::ZcashDeserialize};

zebra-consensus/src/primitives/ed25519.rs

@@ -15,7 +15,7 @@ use tokio::sync::watch;
 use tower::{util::ServiceFn, Service};
 use tower_batch_control::{Batch, BatchControl};
 use tower_fallback::Fallback;
-use zebra_chain::primitives::ed25519::{batch, *};
+use zebra_chain::primitives::ed25519::*;
 
 use crate::BoxError;
 

zebra-consensus/src/primitives/ed25519/tests.rs

@@ -5,7 +5,6 @@ use std::time::Duration;
 use color_eyre::eyre::{eyre, Report, Result};
 use futures::stream::{FuturesOrdered, StreamExt};
 use tower::ServiceExt;
-use tower_batch_control::Batch;
 
 use crate::primitives::ed25519::*;
 

zebra-consensus/src/primitives/groth16/vectors.rs

@@ -1,5 +1,3 @@
-use std::convert::TryFrom;
-
 use crate::groth16::h_sig;
 
 #[test]

zebra-consensus/src/primitives/redjubjub.rs

@@ -16,7 +16,7 @@ use tower::{util::ServiceFn, Service};
 use tower_batch_control::{Batch, BatchControl};
 use tower_fallback::Fallback;
 
-use zebra_chain::primitives::redjubjub::{batch, *};
+use zebra_chain::primitives::redjubjub::*;
 
 use crate::BoxError;
 

zebra-consensus/src/primitives/redjubjub/tests.rs

@@ -7,7 +7,6 @@ use std::time::Duration;
 use color_eyre::eyre::{eyre, Result};
 use futures::stream::{FuturesUnordered, StreamExt};
 use tower::ServiceExt;
-use tower_batch_control::Batch;
 
 async fn sign_and_verify<V>(mut verifier: V, n: usize) -> Result<(), V::Error>
 where

zebra-consensus/src/primitives/redpallas/tests.rs

@@ -7,7 +7,6 @@ use std::time::Duration;
 use color_eyre::eyre::{eyre, Result};
 use futures::stream::{FuturesUnordered, StreamExt};
 use tower::ServiceExt;
-use tower_batch_control::Batch;
 
 use zebra_chain::primitives::reddsa::{
     orchard::{Binding, SpendAuth},

zebra-consensus/src/router/tests.rs

@@ -4,18 +4,15 @@ use std::{sync::Arc, time::Duration};
 
 use color_eyre::eyre::Report;
 use once_cell::sync::Lazy;
-use tower::{layer::Layer, timeout::TimeoutLayer, Service};
+use tower::{layer::Layer, timeout::TimeoutLayer};
 
 use zebra_chain::{
-    block::{self, Block},
+    block::Block,
-    parameters::Network,
     serialization::{ZcashDeserialize, ZcashDeserializeInto},
 };
 use zebra_state as zs;
 use zebra_test::transcript::{ExpectedTranscriptError, Transcript};
 
-use crate::Config;
-
 use super::*;
 
 /// The timeout we apply to each verify future during testing.

zebra-consensus/src/transaction.rs

@@ -3,7 +3,6 @@
 use std::{
     collections::HashMap,
     future::Future,
-    iter::FromIterator,
     pin::Pin,
     sync::Arc,
     task::{Context, Poll},

zebra-network/src/address_book.rs

@@ -4,7 +4,6 @@
 use std::{
     cmp::Reverse,
     collections::HashMap,
-    iter::Extend,
     net::{IpAddr, SocketAddr},
     sync::{Arc, Mutex},
     time::Instant,

zebra-network/src/config.rs

@@ -5,7 +5,6 @@ use std::{
     ffi::OsString,
     io::{self, ErrorKind},
     net::{IpAddr, SocketAddr},
-    string::String,
     time::Duration,
 };
 

zebra-network/src/meta_addr.rs

@@ -1,7 +1,7 @@
 //! An address-with-metadata type used in Bitcoin networking.
 
 use std::{
-    cmp::{max, Ord, Ordering},
+    cmp::{max, Ordering},
     time::Instant,
 };
 

zebra-network/src/meta_addr/arbitrary.rs

@@ -2,7 +2,7 @@
 
 use std::net::IpAddr;
 
-use proptest::{arbitrary::any, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 use zebra_chain::{parameters::Network::*, serialization::DateTime32};
 

zebra-network/src/peer/connection.rs

@@ -9,11 +9,7 @@
 
 use std::{borrow::Cow, collections::HashSet, fmt, pin::Pin, sync::Arc, time::Instant};
 
-use futures::{
+use futures::{future::Either, prelude::*};
-    future::{self, Either},
-    prelude::*,
-    stream::Stream,
-};
 use rand::{seq::SliceRandom, thread_rng, Rng};
 use tokio::time::{sleep, Sleep};
 use tower::{Service, ServiceExt};

zebra-network/src/peer/connector.rs

@@ -1,7 +1,6 @@
 //! Wrapper around handshake logic that also opens a TCP connection.
 
 use std::{
-    future::Future,
     pin::Pin,
     task::{Context, Poll},
 };

zebra-network/src/peer_set/set.rs

@@ -106,7 +106,7 @@ use std::{
 
 use futures::{
     channel::{mpsc, oneshot},
-    future::{Future, FutureExt, TryFutureExt},
+    future::{FutureExt, TryFutureExt},
     prelude::*,
     stream::FuturesUnordered,
     task::noop_waker,

zebra-network/src/protocol/external/arbitrary.rs

@@ -2,7 +2,7 @@
 
 use std::net::SocketAddr;
 
-use proptest::{arbitrary::any, arbitrary::Arbitrary, collection::vec, prelude::*};
+use proptest::{collection::vec, prelude::*};
 
 use zebra_chain::{block, transaction};
 

zebra-network/src/protocol/external/tests/prop.rs

@@ -1,7 +1,5 @@
 //! Randomised property tests for Zebra's Zcash network protocol types.
 
-use std::convert::TryInto;
-
 use bytes::BytesMut;
 use proptest::{collection::vec, prelude::*};
 use tokio_util::codec::{Decoder, Encoder};

zebra-network/src/protocol/external/tests/vectors.rs

@@ -1,6 +1,6 @@
 //! Fixed test vectors for external protocol messages.
 
-use std::{convert::TryInto, io::Write};
+use std::io::Write;
 
 use byteorder::{LittleEndian, WriteBytesExt};
 

zebra-rpc/src/methods.rs

@@ -6,7 +6,7 @@
 //! Some parts of the `zcashd` RPC documentation are outdated.
 //! So this implementation follows the `zcashd` server and `lightwalletd` client implementations.
 
-use std::{collections::HashSet, default::Default, fmt::Debug, sync::Arc};
+use std::{collections::HashSet, fmt::Debug, sync::Arc};
 
 use chrono::Utc;
 use futures::{stream::FuturesOrdered, FutureExt, StreamExt, TryFutureExt};

zebra-rpc/src/methods/get_block_template_rpcs.rs

@@ -7,7 +7,7 @@ use jsonrpc_core::{self, BoxFuture, Error, ErrorCode, Result};
 use jsonrpc_derive::rpc;
 use tower::{Service, ServiceExt};
 
-use zcash_address::{self, unified::Encoding, TryFromAddress};
+use zcash_address::{unified::Encoding, TryFromAddress};
 
 use zebra_chain::{
     amount::Amount,

zebra-rpc/src/methods/get_block_template_rpcs/types/long_poll.rs

@@ -227,9 +227,8 @@ fn update_checksum(checksum: &mut u32, item: [u8; 32]) {
     }
 }
 
-impl ToString for LongPollId {
+impl std::fmt::Display for LongPollId {
-    /// Exact conversion from LongPollId to a string.
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-    fn to_string(&self) -> String {
         let LongPollId {
             tip_height,
             tip_hash_checksum,
@@ -240,7 +239,8 @@ impl ToString for LongPollId {
 
         // We can't do this using `serde`, because it names each field,
         // but we want a single string containing all the fields.
-        format!(
+        write!(
+            f,
             // Height as decimal, padded with zeroes to the width of Height::MAX
             // Checksums as hex, padded with zeroes to the width of u32::MAX
             // Timestamp as decimal, padded with zeroes to the width of u32::MAX

zebra-rpc/src/methods/tests/snapshot.rs

@@ -5,7 +5,7 @@
 //! cargo insta test --review -p zebra-rpc --lib -- test_rpc_response_data
 //! ```
 
-use std::{collections::BTreeMap, sync::Arc};
+use std::collections::BTreeMap;
 
 use insta::dynamic_redaction;
 use tower::buffer::Buffer;

zebra-rpc/src/methods/tests/vectors.rs

@@ -1,8 +1,7 @@
 //! Fixed test vectors for RPC methods.
 
-use std::{ops::RangeInclusive, sync::Arc};
+use std::ops::RangeInclusive;
 
-use jsonrpc_core::ErrorCode;
 use tower::buffer::Buffer;
 
 use zebra_chain::{
@@ -11,8 +10,7 @@ use zebra_chain::{
     chain_tip::{mock::MockChainTip, NoChainTip},
     parameters::Network::*,
     serialization::{ZcashDeserializeInto, ZcashSerialize},
-    transaction::{UnminedTx, UnminedTxId},
+    transaction::UnminedTxId,
-    transparent,
 };
 use zebra_node_services::BoxError;
 

zebra-rpc/src/server.rs

@@ -13,7 +13,7 @@ use jsonrpc_core::{Compatibility, MetaIoHandler};
 use jsonrpc_http_server::{CloseHandle, ServerBuilder};
 use tokio::task::JoinHandle;
 use tower::Service;
-use tracing::{Instrument, *};
+use tracing::*;
 
 use zebra_chain::{
     block, chain_sync_status::ChainSyncStatus, chain_tip::ChainTip, parameters::Network,

zebra-script/src/lib.rs

@@ -277,7 +277,6 @@ impl Drop for CachedFfiTransaction {
 #[cfg(test)]
 mod tests {
     use hex::FromHex;
-    use std::convert::TryInto;
     use std::sync::Arc;
     use zebra_chain::{
         parameters::{ConsensusBranchId, NetworkUpgrade::*},

zebra-state/src/service/check/difficulty.rs

@@ -5,7 +5,7 @@
 //!  * the Testnet minimum difficulty adjustment from ZIPs 205 and 208, and
 //!  * `median-time-past`.
 
-use std::{cmp::max, cmp::min, convert::TryInto};
+use std::{cmp::max, cmp::min};
 
 use chrono::{DateTime, Duration, Utc};
 

zebra-state/src/service/check/tests/nullifier.rs

@@ -1,6 +1,6 @@
 //! Randomised property tests for nullifier contextual validation
 
-use std::{convert::TryInto, env, sync::Arc};
+use std::{env, sync::Arc};
 
 use itertools::Itertools;
 use proptest::prelude::*;

zebra-state/src/service/check/tests/vectors.rs

@@ -1,7 +1,5 @@
 //! Fixed test vectors for state contextual validation checks.
 
-use std::sync::Arc;
-
 use zebra_chain::serialization::ZcashDeserializeInto;
 
 use super::super::*;

zebra-state/src/service/finalized_state/disk_format/scan/tests/prop.rs

@@ -1,6 +1,6 @@
 //! Randomised proptests for scanner database formats.
 
-use proptest::{arbitrary::any, prelude::*};
+use proptest::prelude::*;
 
 use crate::{
     service::finalized_state::arbitrary::assert_value_properties, SaplingScannedDatabaseIndex,

zebra-state/src/service/finalized_state/disk_format/tests/prop.rs

@@ -1,6 +1,6 @@
 //! Randomised tests for the finalized disk format.
 
-use proptest::{arbitrary::any, prelude::*};
+use proptest::prelude::*;
 
 use zebra_chain::{
     amount::{Amount, NonNegative},

zebra-state/src/service/non_finalized_state/chain.rs

@@ -636,13 +636,11 @@ impl Chain {
                 .next()
                 .expect("Zebra should never reach the max height in normal operation.");
 
-            if self.sprout_trees_by_height.get(&next_height).is_none() {
+            self.sprout_trees_by_height
-                // TODO: Use `try_insert` once it stabilises.
+                .entry(next_height)
-                self.sprout_trees_by_height.insert(
+                .or_insert_with(|| {
-                    next_height,
+                    highest_removed_tree.expect("There should be a cached removed tree.")
-                    highest_removed_tree.expect("There should be a cached removed tree."),
+                });
-                );
-            }
         }
     }
 
@@ -839,13 +837,11 @@ impl Chain {
                 .next()
                 .expect("Zebra should never reach the max height in normal operation.");
 
-            if self.sapling_trees_by_height.get(&next_height).is_none() {
+            self.sapling_trees_by_height
-                // TODO: Use `try_insert` once it stabilises.
+                .entry(next_height)
-                self.sapling_trees_by_height.insert(
+                .or_insert_with(|| {
-                    next_height,
+                    highest_removed_tree.expect("There should be a cached removed tree.")
-                    highest_removed_tree.expect("There should be a cached removed tree."),
+                });
-                );
-            }
         }
     }
 
@@ -1048,13 +1044,11 @@ impl Chain {
                 .next()
                 .expect("Zebra should never reach the max height in normal operation.");
 
-            if self.orchard_trees_by_height.get(&next_height).is_none() {
+            self.orchard_trees_by_height
-                // TODO: Use `try_insert` once it stabilises.
+                .entry(next_height)
-                self.orchard_trees_by_height.insert(
+                .or_insert_with(|| {
-                    next_height,
+                    highest_removed_tree.expect("There should be a cached removed tree.")
-                    highest_removed_tree.expect("There should be a cached removed tree."),
+                });
-                );
-            }
         }
     }
 

zebra-state/src/service/non_finalized_state/tests/prop.rs

@@ -10,7 +10,7 @@ use zebra_chain::{
     fmt::DisplayToDebug,
     history_tree::{HistoryTree, NonEmptyHistoryTree},
     parameters::NetworkUpgrade::*,
-    parameters::{Network, *},
+    parameters::*,
     value_balance::ValueBalance,
     LedgerState,
 };
@@ -611,15 +611,15 @@ fn different_blocks_different_chains() -> Result<()> {
 
                 // blocks, heights, hashes
                 chain1.blocks = chain2.blocks.clone();
-                chain1.height_by_hash = chain2.height_by_hash.clone();
+                chain1.height_by_hash.clone_from(&chain2.height_by_hash);
-                chain1.tx_loc_by_hash = chain2.tx_loc_by_hash.clone();
+                chain1.tx_loc_by_hash.clone_from(&chain2.tx_loc_by_hash);
 
                 // transparent UTXOs
-                chain1.created_utxos = chain2.created_utxos.clone();
+                chain1.created_utxos.clone_from(&chain2.created_utxos);
-                chain1.spent_utxos = chain2.spent_utxos.clone();
+                chain1.spent_utxos.clone_from(&chain2.spent_utxos);
 
                 // note commitment trees
-                chain1.sprout_trees_by_anchor = chain2.sprout_trees_by_anchor.clone();
+                chain1.sprout_trees_by_anchor.clone_from(&chain2.sprout_trees_by_anchor);
                 chain1.sprout_trees_by_height = chain2.sprout_trees_by_height.clone();
                 chain1.sapling_trees_by_height = chain2.sapling_trees_by_height.clone();
                 chain1.orchard_trees_by_height = chain2.orchard_trees_by_height.clone();
@@ -640,9 +640,9 @@ fn different_blocks_different_chains() -> Result<()> {
                 chain1.orchard_anchors_by_height = chain2.orchard_anchors_by_height.clone();
 
                 // nullifiers
-                chain1.sprout_nullifiers = chain2.sprout_nullifiers.clone();
+                chain1.sprout_nullifiers.clone_from(&chain2.sprout_nullifiers);
-                chain1.sapling_nullifiers = chain2.sapling_nullifiers.clone();
+                chain1.sapling_nullifiers.clone_from(&chain2.sapling_nullifiers);
-                chain1.orchard_nullifiers = chain2.orchard_nullifiers.clone();
+                chain1.orchard_nullifiers.clone_from(&chain2.orchard_nullifiers);
 
                 // proof of work
                 chain1.partial_cumulative_work = chain2.partial_cumulative_work;

zebra-test/src/mock_service.rs

@@ -966,6 +966,7 @@ impl<Request, Response, Error> ResponseSender<Request, Response, Error> {
 ///
 /// - [`PanicAssertion`]
 /// - [`PropTestAssertion`]
+#[allow(dead_code)]
 trait AssertionType {}
 
 /// Represents normal Rust assertions that panic, like [`assert_eq`].

zebra-test/src/vectors/block.rs

@@ -5,7 +5,7 @@
 use hex::FromHex;
 use lazy_static::lazy_static;
 
-use std::{collections::BTreeMap, convert::TryInto};
+use std::collections::BTreeMap;
 
 trait ReverseCollection {
     /// Return a reversed copy of this collection

zebra-test/tests/transcript.rs

@@ -48,10 +48,6 @@ async fn self_check() {
     assert!(t1.check(t2).await.is_ok());
 }
 
-#[derive(Debug, thiserror::Error)]
-#[error("Error")]
-struct Error;
-
 const TRANSCRIPT_DATA2: [(&str, Result<&str, ExpectedTranscriptError>); 4] = [
     ("req1", Ok("rsp1")),
     ("req2", Ok("rsp2")),

zebrad/src/commands/copy_state.rs

@@ -35,7 +35,7 @@
 
 use std::{cmp::min, path::PathBuf};
 
-use abscissa_core::{config, Command, FrameworkError, Runnable};
+use abscissa_core::{config, Command, FrameworkError};
 use color_eyre::eyre::{eyre, Report};
 use tokio::time::Instant;
 use tower::{Service, ServiceExt};

zebrad/src/commands/start.rs

@@ -78,7 +78,7 @@
 //!
 //! Some of the diagnostic features are optional, and need to be enabled at compile-time.
 
-use abscissa_core::{config, Command, FrameworkError, Runnable};
+use abscissa_core::{config, Command, FrameworkError};
 use color_eyre::eyre::{eyre, Report};
 use futures::FutureExt;
 use tokio::{pin, select, sync::oneshot};

zebrad/src/components/inbound/tests/fake_peer_set.rs

@@ -1,13 +1,6 @@
 //! Inbound service tests with a fake peer set.
 
-use std::{
+use std::{collections::HashSet, iter, net::SocketAddr, str::FromStr, sync::Arc, time::Duration};
-    collections::HashSet,
-    iter::{self, FromIterator},
-    net::SocketAddr,
-    str::FromStr,
-    sync::Arc,
-    time::Duration,
-};
 
 use futures::FutureExt;
 use tokio::{sync::oneshot, task::JoinHandle, time::timeout};

zebrad/src/components/mempool/storage/tests/vectors.rs

@@ -8,11 +8,10 @@ use zebra_chain::{
     amount::Amount,
     block::{Block, Height},
     parameters::Network,
-    transaction::{UnminedTxId, VerifiedUnminedTx},
 };
 
 use crate::components::mempool::{
-    config, storage::tests::unmined_transactions_in_blocks, storage::*, Mempool,
+    storage::tests::unmined_transactions_in_blocks, storage::*, Mempool,
 };
 
 /// Eviction memory time used for tests. Most tests won't care about this

zebrad/src/components/mempool/tests/vector.rs

@@ -1,6 +1,6 @@
 //! Fixed test vectors for the mempool.
 
-use std::{collections::HashSet, sync::Arc};
+use std::sync::Arc;
 
 use color_eyre::Report;
 use tokio::time::{self, timeout};
@@ -15,12 +15,10 @@ use zebra_state::{Config as StateConfig, CHAIN_TIP_UPDATE_WAIT_LIMIT};
 use zebra_test::mock_service::{MockService, PanicAssertion};
 
 use crate::components::{
-    mempool::{self, storage::tests::unmined_transactions_in_blocks, *},
+    mempool::{self, *},
     sync::RecentSyncLengths,
 };
 
-use super::UnboxMempoolError;
-
 /// A [`MockService`] representing the network service.
 type MockPeerSet = MockService<zn::Request, zn::Response, PanicAssertion>;
 

zebrad/src/components/sync/downloads.rs

@@ -2,7 +2,7 @@
 
 use std::{
     collections::HashMap,
-    convert::{self, TryFrom},
+    convert,
     pin::Pin,
     sync::Arc,
     task::{Context, Poll},

zebrad/src/components/tokio.rs

@@ -9,7 +9,7 @@
 
 use std::{future::Future, time::Duration};
 
-use abscissa_core::{Application, Component, FrameworkError, Shutdown};
+use abscissa_core::{Component, FrameworkError, Shutdown};
 use color_eyre::Report;
 use tokio::runtime::Runtime;
 

zebrad/tests/acceptance.rs

@@ -155,7 +155,7 @@ use std::{
 };
 
 use color_eyre::{
-    eyre::{eyre, Result, WrapErr},
+    eyre::{eyre, WrapErr},
     Help,
 };
 use semver::Version;
@@ -480,7 +480,7 @@ fn ephemeral(cache_dir_config: EphemeralConfig, cache_dir_check: EphemeralCheck)
     let ignored_cache_dir = run_dir.path().join("state");
     if cache_dir_config == EphemeralConfig::MisconfiguredCacheDir {
         // Write a configuration that sets both the cache_dir and ephemeral options
-        config.state.cache_dir = ignored_cache_dir.clone();
+        config.state.cache_dir.clone_from(&ignored_cache_dir);
     }
     if cache_dir_check == EphemeralCheck::ExistingDirectory {
         // We set the cache_dir config to a newly created empty temp directory,
@@ -2953,11 +2953,15 @@ fn scan_start_where_left() -> Result<()> {
         config.shielded_scan.sapling_keys_to_scan = keys;
 
         // Add the cache dir to shielded scan, make it the same as the zebrad cache state.
-        config.shielded_scan.db_config_mut().cache_dir = cache_dir.clone();
+        config
+            .shielded_scan
+            .db_config_mut()
+            .cache_dir
+            .clone_from(&cache_dir);
         config.shielded_scan.db_config_mut().ephemeral = false;
 
         // Add the cache dir to state.
-        config.state.cache_dir = cache_dir.clone();
+        config.state.cache_dir.clone_from(&cache_dir);
         config.state.ephemeral = false;
 
         // Remove the scan directory before starting.

zebrad/tests/common/launch.rs

@@ -13,7 +13,6 @@ use std::{
     time::Duration,
 };
 
-use color_eyre::eyre::Result;
 use tempfile::TempDir;
 
 use zebra_chain::parameters::Network::{self, *};

zebrad/tests/common/lightwalletd.rs

@@ -16,7 +16,7 @@ use tempfile::TempDir;
 use zebra_chain::parameters::Network::{self, *};
 use zebra_test::{
     args,
-    command::{Arguments, TestChild, TestDirExt},
+    command::{Arguments, TestDirExt},
     net::random_known_port,
     prelude::*,
 };

zebrad/tests/common/shielded_scan/scan_task_commands.rs

@@ -69,7 +69,10 @@ pub(crate) async fn run() -> Result<()> {
         .expect("already checked that there is a cached state path");
 
     let mut scan_config = zebra_scan::Config::default();
-    scan_config.db_config_mut().cache_dir = zebrad_state_path.clone();
+    scan_config
+        .db_config_mut()
+        .cache_dir
+        .clone_from(&zebrad_state_path);
 
     // Logs the network as zebrad would as part of the metadata when starting up.
     // This is currently needed for the 'Check startup logs' step in CI to pass.

zebrad/tests/common/sync.rs

@@ -7,7 +7,6 @@
 
 use std::{path::PathBuf, time::Duration};
 
-use color_eyre::eyre::Result;
 use tempfile::TempDir;
 
 use zebra_chain::{block::Height, parameters::Network};