zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

change(docs): Document how to get external PRs to merge (#6252) 

* Document how to get external PRs to merge

* Fix typos

Co-authored-by: Marek <mail@marek.onl>

---------

Co-authored-by: Marek <mail@marek.onl>
This commit is contained in:
teor 2023-03-01 21:52:48 +10:00 committed by GitHub
parent f06e744de2
commit dde63d27e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
book/src/dev/continuous-integration.md
View File

@ -38,7 +38,19 @@ Some PRs don't use Mergify:
We use workflow conditions to skip some checks on PRs, Mergify, or the `main` branch. We use workflow conditions to skip some checks on PRs, Mergify, or the `main` branch.
For example, some workflow changes skip Rust code checks. For example, some workflow changes skip Rust code checks.
## Manually Using Google Cloud ### Pull Requests from Forked Repositories
GitHub doesn't allow PRs from forked repositories to have access to our repository secret keys, even after we approve their CI.
This means that Google Cloud CI fails on these PRs.
Unril we [fix this CI bug](https://github.com/ZcashFoundation/zebra/issues/4529), we can merge external PRs by:
1. Reviewing the code to make sure it won't give our secret keys to anyone
2. Pushing a copy of the branch to the Zebra repository
3. Opening a PR using that branch
4. Closing the original PR with a note that it will be merged (this is reauired by Mergify)
5. Asking another Zebra developer to approve the new PR
## Manual Testing Using Google Cloud
Some Zebra developers have access to the Zcash Foundation's Google Cloud instance, which also runs our automatic CI. Some Zebra developers have access to the Zcash Foundation's Google Cloud instance, which also runs our automatic CI.