zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(release): do not hardcode the name of our images (#6710) 

* fix(release): do not hardcode the name of our images

Our main image in DockerHub is called `zebra` not `zebrad`.

This hardcoded value is also causing the mining image to also be called `zebra` instead of `zebrad-mining-rpcs-testnet`

* fix(release): use same naming convention for `.experimental`

* chore: fix comment
This commit is contained in:
Gustavo Valverde 2023-05-29 19:58:57 -04:00 committed by GitHub
parent 432774c4e4
commit edc13e336c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/build-docker-image.yml vendored
View File

@ -89,7 +89,7 @@ jobs:
# list of Docker images to use as base name for tags # list of Docker images to use as base name for tags
images: | images: |
us-docker.pkg.dev/${{ vars.GCP_PROJECT }}/zebra/${{ inputs.image_name }} us-docker.pkg.dev/${{ vars.GCP_PROJECT }}/zebra/${{ inputs.image_name }}
zfnd/zebra,enable=${{ github.event_name == 'release' && !github.event.release.prerelease }} zfnd/${{ inputs.image_name }},enable=${{ github.event_name == 'release' && !github.event.release.prerelease }}
# appends inputs.tag_suffix to image tags/names # appends inputs.tag_suffix to image tags/names
flavor: | flavor: |
suffix=${{ inputs.tag_suffix }} suffix=${{ inputs.tag_suffix }}

8
.github/workflows/release-binaries.yml vendored
View File

@ -18,14 +18,14 @@ jobs:
# Each time this workflow is executed, a build will be triggered to create a new image # Each time this workflow is executed, a build will be triggered to create a new image
# with the corresponding tags using information from git # with the corresponding tags using information from git
# The image will be named `zebrad:<semver>` # The image will be named `zebra:<semver>`
build: build:
name: Build Release Docker name: Build Release Docker
uses: ./.github/workflows/build-docker-image.yml uses: ./.github/workflows/build-docker-image.yml
with: with:
dockerfile_path: ./docker/Dockerfile dockerfile_path: ./docker/Dockerfile
dockerfile_target: runtime dockerfile_target: runtime
image_name: zebrad image_name: zebra
network: Mainnet network: Mainnet
checkpoint_sync: true checkpoint_sync: true
rust_backtrace: '1' rust_backtrace: '1'
@ -34,14 +34,14 @@ jobs:
# This step needs access to Docker Hub secrets to run successfully # This step needs access to Docker Hub secrets to run successfully
secrets: inherit secrets: inherit
# The image will be named `zebrad-mining-rpcs-testnet:<semver>.experimental` # The image will be named `zebra:<semver>.experimental`
build-mining-testnet: build-mining-testnet:
name: Build Release Testnet Mining Docker name: Build Release Testnet Mining Docker
uses: ./.github/workflows/build-docker-image.yml uses: ./.github/workflows/build-docker-image.yml
with: with:
dockerfile_path: ./docker/Dockerfile dockerfile_path: ./docker/Dockerfile
dockerfile_target: runtime dockerfile_target: runtime
image_name: zebrad-mining-rpcs-testnet image_name: zebra
# TODO: change this to `-experimental` when we release Zebra `1.0.0` # TODO: change this to `-experimental` when we release Zebra `1.0.0`
tag_suffix: .experimental tag_suffix: .experimental
network: Testnet network: Testnet