zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Explain how to review version bump PRs (#2138)

This commit is contained in:
teor 2021-05-12 18:42:48 +10:00 committed by GitHub
parent 59b23f5724
commit f8693ee004
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.github/PULL_REQUEST_TEMPLATE/release-checklist.md vendored
View File

@ -76,6 +76,16 @@ fastmod --extensions rs,toml,md --fixed-strings '0.2.0' '0.2.1' tower-batch
We skipped `tower-fallback`, because it hadn't changed since the last tag.
### Reviewing Version Bump Pull Requests
Check for missed changes by going to:
`https://github.com/ZcashFoundation/zebra/tree/<commit-hash>/`
Where `<commit-hash>` is the hash of the last commit in the version bump PR.
If any Zebra or Tower crates have commit messages that are **not** a version bump, we have missed an update.
Also check for crates that depend on crates that have changed. They should get a version bump as well.
## Initial Testing
- [ ] After any changes, test that the `cargo install` command in `README.md` works (use `--path` instead of `--git` locally)