zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update the acceptance test port range (#1812) 

Windows can reserve or use ports up to 53500.

Windows and macOS sequentially allocate ephemeral ports,
starting at 41952.
This commit is contained in:
teor 2021-02-25 09:27:56 +10:00 committed by GitHub
parent 78f162733d
commit fb6acfaff7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
zebrad/tests/acceptance.rs
View File

@ -904,10 +904,21 @@ fn sync_past_sapling_testnet() {
/// times. For example: setting up both ends of a connection, or re-using /// times. For example: setting up both ends of a connection, or re-using
/// the same port multiple times. /// the same port multiple times.
fn random_known_port() -> u16 { fn random_known_port() -> u16 {
// Use the intersection of the IANA ephemeral port range, and the Linux // Use the intersection of the IANA/Windows/macOS ephemeral port range,
// ephemeral port range: // and the Linux ephemeral port range:
// https://en.wikipedia.org/wiki/Ephemeral_port#Range // - https://en.wikipedia.org/wiki/Ephemeral_port#Range
rand::thread_rng().gen_range(49152, 60999) // excluding ports less than 53500, to avoid:
// - typical Hyper-V reservations up to 52000:
// - https://github.com/googlevr/gvr-unity-sdk/issues/1002
// - https://github.com/docker/for-win/issues/3171
// - the MOM-Clear port 51515
// - https://docs.microsoft.com/en-us/troubleshoot/windows-server/networking/service-overview-and-network-port-requirements
// - the LDAP Kerberos byte-swapped reservation 53249
// - https://docs.microsoft.com/en-us/troubleshoot/windows-server/identity/ldap-kerberos-server-reset-tcp-sessions
// - macOS and Windows sequential ephemeral port allocations,
// starting from 49152:
// - https://dataplane.org/ephemeralports.html
rand::thread_rng().gen_range(53500, 60999)
} }
/// Returns the "magic" port number that tells the operating system to /// Returns the "magic" port number that tells the operating system to