Commit Graph

4894 Commits

Author SHA1 Message Date
arya2 c0fa9e80c9 gets right child subtree roots from ommers 2023-08-31 22:30:12 -04:00
teor 7641f1b2c6 Use error-level logs for database format checks 2023-09-01 12:17:50 +10:00
teor a442d60f99 Fix an off-by-one error with the final subtree check 2023-09-01 12:17:27 +10:00
teor 821f925da6 Add a subtree format check when there is no upgrade 2023-09-01 12:04:24 +10:00
arya2 f622de01fb updates subtree state validity check 2023-09-01 11:52:10 +10:00
teor d295765648 Refactor subtree upgrade to remove duplicate inverted loop conditions 2023-09-01 11:46:51 +10:00
teor 9dbb24a4fe Move a log to the correct location 2023-09-01 11:38:22 +10:00
teor e2735882f7 Clarify subtree index docs 2023-09-01 11:38:09 +10:00
teor 8fc706bc7c Orchard is faster, decrease log interval 2023-09-01 11:34:19 +10:00
arya2 b366fd3195 Adds a state validity check for subtrees upgrade 2023-09-01 11:34:19 +10:00
teor dee2862ea6 Log subtree progress about once every two minutes 2023-09-01 11:34:19 +10:00
teor 307f831315 If a format change is cancelled, don't mark the database as upgraded or do format checks 2023-09-01 11:34:19 +10:00
teor a024e07e7a Log when each subtree is added 2023-09-01 11:34:19 +10:00
teor 96183d97f8 Fix API compatibility when Arcs are removed 2023-09-01 11:34:19 +10:00
teor b110ddee6b Simplify subtree API and avoid exposing Address 2023-09-01 11:34:19 +10:00
teor 8e2b284114 Fix subtree completion condition and add asserts 2023-09-01 11:34:19 +10:00
teor 63728dad26 Use common note commitment list code 2023-09-01 11:34:19 +10:00
teor cdb1e62a61 Use separate subtree writing functions 2023-09-01 11:34:19 +10:00
teor 8c244a0e2e Simplify prev_tree unwrap to avoid an (impossible?) concurrency bug 2023-09-01 11:34:19 +10:00
teor 08624143f6 Clarify some comments and error messages 2023-09-01 11:34:19 +10:00
teor ac7fb850a3 Fix a confusing 'upgrade complete' log 2023-09-01 11:34:19 +10:00
teor 6950ad6c6c Bump the database format version to 25.2.0 2023-09-01 11:34:19 +10:00
teor fbadf4c430 Run the subtree upgrade on startup 2023-09-01 11:34:19 +10:00
teor da5851f76b Use mpsc::Receiver<CancelFormatChange> in the subtree upgrade 2023-09-01 11:34:19 +10:00
teor cf05e626e9 Fix a dead code warning by re-using existing methods 2023-09-01 11:34:19 +10:00
teor d01096ce61 Simplify subtree APIs to avoid exposing frontiers 2023-09-01 11:34:19 +10:00
teor dcb5d473e3 Copy the tree API changes from the original branch 2023-09-01 11:34:19 +10:00
teor 38c90d5206 Copy the database write changes in shielded.rs from the original branch 2023-09-01 11:34:19 +10:00
teor ec684a4abf Copy the add_subtrees upgrade from the original branch 2023-09-01 11:34:19 +10:00
teor 735330618e
cleanup(state): Update some outdated comments in the state & rpcs (#7434)
* Add a module cleanup TODO

* Fix an unrelated comment

* Update the comments about the bincode legacy format
2023-08-31 16:25:11 +00:00
teor 349af4d575
Fix testnet checkpoint job height regex (#7433) 2023-08-31 16:24:42 +00:00
dependabot[bot] c5ea437ebd
build(deps): bump actions/checkout from 3.5.3 to 3.6.0 (#7425)
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.5.3...v3.6.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-31 13:59:49 +00:00
dependabot[bot] e7a322d640
build(deps): bump tj-actions/changed-files from 38.0.0 to 38.1.3 (#7426)
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 38.0.0 to 38.1.3.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](https://github.com/tj-actions/changed-files/compare/v38.0.0...v38.1.3)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-31 01:08:30 +00:00
Alfredo Garcia e567ab812d
change(deps): Run `cargo update` (#7429)
* cargo update

* update rustls duplicated dependency version

* replace deprecated function
2023-08-31 00:49:01 +00:00
Alfredo Garcia 40c35e2729
update checkpoints (#7428) 2023-08-31 00:48:38 +00:00
Alfredo Garcia 38caaafc02
change(docs): update docs for new lightwalletd version used in Zebra (#7427)
* upgrade docs for new lightwalletd repo zebra is using now

* Update book/src/user/lightwalletd.md

Co-authored-by: Marek <mail@marek.onl>

---------

Co-authored-by: Marek <mail@marek.onl>
2023-08-30 22:30:20 +00:00
teor 5888a4e5d6
cleanup(clippy): Fix a clippy lint and deny.toml entry after recent changes (#7419)
* Remove unmatched-skip-root in deny.toml

* Ignore unused variable when getblocktemplate-rpcs is disabled

---------

Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
2023-08-30 17:26:49 +00:00
Pili Guerra a857d1c48c
Remove custom blank template and enable blank issues (#7420) 2023-08-30 11:02:18 +00:00
dependabot[bot] 05c9aac111
build(deps): bump the log group with 1 update (#7398)
Bumps the log group with 1 update: [sentry](https://github.com/getsentry/sentry-rust).

- [Release notes](https://github.com/getsentry/sentry-rust/releases)
- [Changelog](https://github.com/getsentry/sentry-rust/blob/master/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-rust/compare/0.31.5...0.31.6)

---
updated-dependencies:
- dependency-name: sentry
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: log
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
2023-08-30 01:34:42 +00:00
dependabot[bot] c1915f1d7b
build(deps): bump the app group with 1 update (#7399)
Bumps the app group with 1 update: [clap](https://github.com/clap-rs/clap).

- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/clap-rs/clap/compare/v4.3.23...clap_complete-v4.4.0)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: app
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
2023-08-30 01:34:01 +00:00
Marek c403efdfc3
add(docs): Mention the tree deduplication in CHANGELOG.md (#7414)
* Mention the tree deduplication in `CHANGELOG.md`

* Use an alternative formulation
2023-08-30 01:33:31 +00:00
dependabot[bot] a2b5e4b3be
build(deps): bump the test group with 1 update (#7401)
Bumps the test group with 1 update: [proptest-derive](https://github.com/proptest-rs/proptest).

- [Release notes](https://github.com/proptest-rs/proptest/releases)
- [Changelog](https://github.com/proptest-rs/proptest/blob/0.4.0/CHANGELOG.md)
- [Commits](https://github.com/proptest-rs/proptest/compare/proptest-derive-0.3.0...0.4.0)

---
updated-dependencies:
- dependency-name: proptest-derive
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: test
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
2023-08-30 01:32:50 +00:00
Gustavo Valverde 7f28ac9dd5
fix(ci): allow to set docs build as a required test (#7413)
* fix(ci): allow to set docs build as a required test

* build(docs): add problem matcher to docs
2023-08-30 01:32:14 +00:00
dependabot[bot] 6ec670e45a
build(deps): bump the async group with 2 updates (#7397)
Bumps the async group with 2 updates: [reqwest](https://github.com/seanmonstar/reqwest) and [tokio-test](https://github.com/tokio-rs/tokio).


Updates `reqwest` from 0.11.19 to 0.11.20
- [Release notes](https://github.com/seanmonstar/reqwest/releases)
- [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/seanmonstar/reqwest/compare/v0.11.19...v0.11.20)

Updates `tokio-test` from 0.4.2 to 0.4.3
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-test-0.4.2...tokio-test-0.4.3)

---
updated-dependencies:
- dependency-name: reqwest
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: async
- dependency-name: tokio-test
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: async
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-29 10:08:25 +00:00
Gustavo Valverde ff60260464
fix(build): reintroduce `RUST_LOG` info (#7404)
Not having the default `info` level causes some tests to not output the needed logs to debug information.
2023-08-29 07:45:26 +00:00
Arya 2b81d845ea
fix(panic): Log a warning instead of panicking for unused mining configs (#7290)
* Logs warning for unused mining config

* add conditional serialization of the mining section

* rustfmt

* Simplify mining::Config argument passing

* Simplify mining config argument passing in start.rs

---------

Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
Co-authored-by: teor <teor@riseup.net>
2023-08-29 07:44:59 +00:00
dependabot[bot] e58000f07f
build(deps): bump the formats group with 2 updates (#7400)
Bumps the formats group with 2 updates: [serde](https://github.com/serde-rs/serde) and [regex](https://github.com/rust-lang/regex).


Updates `serde` from 1.0.185 to 1.0.188
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.185...v1.0.188)

Updates `regex` from 1.9.3 to 1.9.4
- [Release notes](https://github.com/rust-lang/regex/releases)
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rust-lang/regex/compare/1.9.3...1.9.4)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: formats
- dependency-name: regex
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: formats
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: teor <teor@riseup.net>
2023-08-29 04:01:15 +00:00
Marek 2ea994a19e
fix(state): Fix the deduplication of note commitment trees (#7379)
* Log errors and panic if duplicate trees are found after the de-duplicate upgrade

* Always check for duplicates, even if the state is already marked as upgraded

* Minor doc fixes

* Document ranges for `zs_delete_range`

* Revert the comment for `sapling_tree`

* Rearrange tree methods & fix their docs

* Bump DATABASE_FORMAT_PATCH_VERSION from 0 to 1

* Remove the manual tree deletion at early heights

* Add `skip_while` to `zs_range_iter`

* Refactor the tree deduplication

* Add comments to the pruning

* Turn warnings into panics

* Remove redundant checks

These checks are superseded by `check_for_duplicate_trees`

* Remove an edge case that ignored the last tree

* Suggestion for Fix the deduplication of note commitment trees (#7391)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

---------

Co-authored-by: teor <teor@riseup.net>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-08-28 22:59:07 +00:00
Alfredo Garcia 3ca4597c2c
fix redundant doc links (#7402) 2023-08-28 20:11:23 +00:00
teor c116cff5f0
fix(db): use the correct state version for databases without a state version file (#7385)
* If there's an existing database with no version file, give it version 25.0.0

* Creating the RocksDB database makes a temporary change to the default database version
2023-08-28 17:01:01 +00:00