ef978756cb
Bump hex from 0.4.0 to 0.4.1
...
Bumps [hex](https://github.com/KokaKiwi/rust-hex ) from 0.4.0 to 0.4.1.
- [Release notes](https://github.com/KokaKiwi/rust-hex/releases )
- [Commits](https://github.com/KokaKiwi/rust-hex/compare/v0.4...v0.4.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 12:25:20 -05:00
befdb46dc3
Clean some warnings in the Bitcoin codec.
...
This doesn't clean the warnings about unused items in the builder, since
those are unused for a reason (the implementation that should use them
is missing).
2020-02-10 09:03:56 -08:00
2082672b3c
Remove Response::Error.
...
Error handling is already handled by Result; we don't need an "inner"
error variant duplicating the outer one.
2020-02-10 09:03:56 -08:00
29f901add3
Rename Response::Ok to Response::Nil.
...
This is a better name because it signals "no data in response" rather
than "Ok", which is semantically mixed with `Ok/Err` of `Result`.
2020-02-10 09:03:56 -08:00
5929e05e52
Remove `PushPeers` and ignore unsolicited `addr` messages.
...
PushPeers is more complicated to thread into the rest of our
architecture (we would need to establish a data path connecting our
service handling inbound requests to the network layer's auto-crawler),
and since we crawl the network automatically anyways, we don't actually
need to accept them in order to get updated address information.
The only possible problem with this approach is that zcashd refuses to
answer multiple address requests from the same connection, ostensibly
for fingerprinting prevention (although it's totally happy to give
exactly the same information, as long as you hang up and reconnect
first, lol). It's unclear how this will interact with our design -- on
the one hand, it could mean that we don't get new addr information when
we ask, but on the other hand, we may have enough churn in our
connection pool that this isn't a problem anyways.
2020-02-10 09:03:56 -08:00
2c0f48b587
Refactor connection logic and try a block request.
...
Attempting to implement requests for block data revealed a problem with
the previous connection logic. Block data is requested by sending a
`getdata` message with hashes of the requested blocks; the peer responds
with a sequence of `block` messages with the blocks themselves.
However, this wasn't possible to handle with the previous connection
logic, which could only convert a single Bitcoin message into a
Response. Instead, we factor out the message handling logic into a
Handler, which can statefully accumulate arbitrary data into a Response
and signal completion. This is still pretty ugly but it does work.
As a side effect, the HeartbeatNonceMismatch error is removed; because
the Handler now tries to process messages until it comes to a Response,
it just ignores mismatched nonces (and will eventually time out).
The previous Mempool and Transaction requests were removed but could be
re-added in a different form later. Also, the `Get` prefixes are
removed from `Request` to tidy the name.
2020-02-10 09:03:56 -08:00
3c6fda8e0b
Make the BlockHeaderHash conversions work on borrows.
2020-02-10 09:03:56 -08:00
5f6bf188ff
Derive Hash for BlockHeaderHash.
...
This allows using BlockHeaderHashes in HashSets, HashMaps, etc.
2020-02-10 09:03:56 -08:00
ebf60b8840
Make BlockHeader fields public.
2020-02-10 09:03:56 -08:00
824f206dbe
Add several Debug impls for existing types
...
Resolves #237
2020-02-07 21:30:48 -08:00
866acde6e8
Add BLOCK_MAINNET_415000_BYTES test vector and a test to deserialize it
...
And println! it, for human eyeballs checking.
Resolves #218
Also changes the header constant to use _BYTES.
2020-02-07 13:42:21 -08:00
d6c2b7ac32
Bump futures from 0.3.3 to 0.3.4
...
Bumps [futures](https://github.com/rust-lang/futures-rs ) from 0.3.3 to 0.3.4.
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.3...0.3.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-07 10:28:32 -06:00
0392d8fa5d
Bump byteorder from 1.3.2 to 1.3.4
...
Bumps [byteorder](https://github.com/BurntSushi/byteorder ) from 1.3.2 to 1.3.4.
- [Release notes](https://github.com/BurntSushi/byteorder/releases )
- [Changelog](https://github.com/BurntSushi/byteorder/blob/master/CHANGELOG.md )
- [Commits](https://github.com/BurntSushi/byteorder/compare/1.3.2...1.3.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-07 10:24:49 -06:00
972d16518f
Make ZcashSerialize infallible mod its Writer.
...
Closes #158 .
As discussed on the issue, this makes it possible to safely serialize
data into hashes, and encourages serializable data to make illegal
states unrepresentable.
2020-02-05 19:48:43 -05:00
b0f61c4dd2
Remove outdated comment (we use tokio codecs now)
2020-02-05 19:44:35 -05:00
ab94acf7da
fmt
2020-02-05 19:44:35 -05:00
eeb4a2470b
Remove version fields from Block, Tx messages.
...
These are included in the Block, Transaction objects themselves, so the
previous code ended up trying to deserialize two version fields per
object.
Closes #226 .
2020-02-05 19:44:35 -05:00
51c744b1ae
Update network version number.
2020-02-05 14:06:35 -08:00
9273f83761
Remove tracing-subscriber.
...
We don't need to handle the subscriber directly since we upstreamed this
functionality into Abscissa.
2020-02-05 14:05:46 -08:00
8d58dd804f
Note that tracing causes clippy false positives
...
Thanks @hawkw for pointing this out.
2020-02-05 12:42:32 -08:00
f04f4f0b98
Apply clippy fixes
2020-02-05 12:42:32 -08:00
a0d0d297d9
Try clippy in CI
2020-02-05 12:42:32 -08:00
979cf7ac6d
Bump indexmap from 1.3.1 to 1.3.2
...
Bumps [indexmap](https://github.com/bluss/indexmap ) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/bluss/indexmap/releases )
- [Commits](https://github.com/bluss/indexmap/compare/1.3.1...1.3.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-05 14:14:51 -05:00
e2e63f9b9d
Bump futures from 0.3.1 to 0.3.3
...
Bumps [futures](https://github.com/rust-lang/futures-rs ) from 0.3.1 to 0.3.3.
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.1...0.3.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-04 21:14:26 -08:00
b24f53f4a1
Add From impls for InventoryHash
2020-02-04 17:48:36 -08:00
b860461644
Update test block header hash
2020-02-04 18:04:53 -05:00
6dedb7e101
Write and read the equihash solution compactsize on (de)serialize
2020-02-04 18:04:53 -05:00
a79969b38f
Add comment around sha256d_flush test
2020-02-04 18:04:53 -05:00
4fcb66ad3b
Read and write the block header version, which is fixed at 4
2020-02-04 18:04:53 -05:00
7ebb5ccd41
Add a simple test to check that our mainnet blockheader test vector deserializes without error
2020-02-04 18:04:53 -05:00
9257d838bd
Use Result::expect() in test (de)serializations
2020-02-04 18:04:53 -05:00
9b6a9d8e86
Remove debugging variable assignments
2020-02-04 18:04:53 -05:00
d12db25acb
Cleanup
2020-02-04 18:04:53 -05:00
54628d889e
Add proptests-regressions/block/tests.txt
2020-02-04 18:04:53 -05:00
36e9bb162f
Move block type tests and proptest support impls to block::tests
2020-02-04 18:04:53 -05:00
6508540a92
Remove derive(Arbitrary) on BlockHeader
2020-02-04 18:04:53 -05:00
26469952b0
Update .gitignore
2020-02-04 18:04:53 -05:00
b758a8f753
Extend blockheaderhash unit test to check a single (de)serialization case roundtrip
2020-02-04 18:04:53 -05:00
dab99ba861
Impl Zcash(De)Serialization for Block
2020-02-04 18:04:53 -05:00
f5c135ee1b
Use updated EquihashSolution in BlockHeader
2020-02-04 18:04:53 -05:00
4d7bd3e2d7
derive(Copy) on SaplingNoteTreeRootHash
2020-02-04 18:04:53 -05:00
0f4d3e4a6d
derive(Arbitrary) on MerkleTreeRootHash
2020-02-04 18:04:53 -05:00
d5800e168c
Add a roundtrip (de)serialization proptest for EquihashSolution
2020-02-04 18:04:53 -05:00
c2bb6c15f8
Implement a bunch of traits for EquihashSolution
2020-02-04 18:04:53 -05:00
e82cf0f5a8
Add BlockHeaderHash (de)serialization roundtrip proptest
2020-02-04 18:04:53 -05:00
69164a6943
Add test for BlockHeaderHash::from(BlockHeader)
2020-02-04 18:04:53 -05:00
29e1be2442
Impl Zcash(De)Serialize for BlockHeader
2020-02-04 18:04:53 -05:00
e9d1f91d67
Make MerkleTreeRootHash wrapped array public
2020-02-04 18:04:53 -05:00
3ea4a6a9ab
Move transaction test vectors around
...
Resolves #210
2020-02-04 18:04:53 -05:00
6d3d4c4f64
s/GetData/NotFound/ in read_notfound
2020-02-04 18:04:53 -05:00
dependabot-preview[bot]
Henry de Valence
Deirdre Connolly