Commit Graph

2116 Commits

Author SHA1 Message Date
Francisco 4cf5a8b25a fix: avoid configuring the phy mbsfn from the rrc, when phy is not fully initialized 2021-06-14 15:55:10 +01:00
Francisco f55e1c5a73 fix,srsenb: start stack before the radio to avoid stack methods to be called when stack is not fully initialized 2021-06-14 15:55:10 +01:00
Francisco e8983b88f0 refactor: use enb_cc_idx instead of ue_cc_idx in mac::ue 2021-06-14 13:18:47 +01:00
Xavier Arteaga 63de691351 SRSENB: Added sleep command description 2021-06-14 09:21:29 +02:00
Xavier Arteaga 4bfe092a24 Added multi-command line in srsenb 2021-06-14 09:21:29 +02:00
Francisco 99960c72fa bugfix,srsenb: extend rrc mobility unit test for intraenb handover 2021-06-10 09:46:01 +01:00
Francisco 69b7a7eb19 bugfix,srsenb: the lcids beloging to SRB1 and SRB2 were not being reactivated correctly during intra-eNB handover 2021-06-10 09:46:01 +01:00
Francisco a0ba2d576d remove unused return variable 2021-06-09 11:12:06 +01:00
Francisco 048d487921 bugfix,gtpu: send end marker via the forwarding tunnel, when the source enb receives ue ctxt release command. Improve GTPU unit testing 2021-06-09 11:12:06 +01:00
Francisco 8cbbebdea2 bugfix,scheduler: make sure UL harq pending data is cleared up when the last retx falls in a measurement gap 2021-06-09 10:52:43 +01:00
Francisco 51c9fc514d refactor,sched: fix log lines related with meas gap collisions 2021-06-09 10:52:43 +01:00
Pedro Alvarez 163976f050 Fix releasing on on RRC and not on S1AP on integrity failure. 2021-06-08 18:52:22 +01:00
Pedro Alvarez a53b321ab8 Release UE upon reception of integrity error. 2021-06-08 18:52:22 +01:00
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check
failures.
2021-06-08 18:52:22 +01:00
Francisco 5c7ea6f6df bugfix,srsenb,rrc: remove redundant calls to setup PDCP/RLC bearer state during reestablishment 2021-06-08 16:21:57 +01:00
Francisco fd3901e4a2 bugfix,srsenb,rrc: delete old context right away after sending Reestablishment msg.
Following ReestablishmentRequests should use the most recent rnti as old context.
2021-06-08 16:21:57 +01:00
Andre Puschmann f65faba756 sched_harq: fix uninitialized values in HARQ
detected with Valgrind memcheck
2021-06-05 11:04:33 +02:00
Francisco 35cea3d104 enb,optimization: consider mac::ue object in rnti pool memory block size 2021-06-04 21:29:13 +01:00
Francisco 7e77da6a15 mac,optimization: use rnti memory pool to create mac::ue objects 2021-06-04 21:29:13 +01:00
Francisco fd1d73666c bugfix,srsenb,mac: avoid sanity check for UL PDU length if CRC=KO 2021-06-04 20:03:38 +01:00
Francisco 76004a3054 enb,mac,refactor: mac::ue now uses byte_buffer_pool for UL PDUs 2021-06-04 20:03:38 +01:00
Francisco 9e2a7d4592 bugfix,tpc: only cap PUSCH TPC when PHR is negative. I also extended TPC unit test 2021-06-04 17:39:51 +01:00
Francisco bdc4362475 bugfix,tpc: place a cap on TPC due to PHR only when TPC is positive 2021-06-04 17:39:51 +01:00
Francisco 7badfb1c88 bugfix: avoid multiple TPC=0 for a single PHR<0 2021-06-04 17:39:51 +01:00
Francisco e2c37ad513 bugfix: missing early return in TPC derivation 2021-06-04 17:39:51 +01:00
Francisco 75eebd6b5d bugfix,gtpu: close forwarding tunnel during reestablishment due to handover failure 2021-06-04 14:59:12 +01:00
Francisco 597f993706 sched,improvement: filter out Msg3 UL SNR estimates from the TPC control loop 2021-06-04 13:45:10 +01:00
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
2021-06-04 13:23:54 +02:00
Xavier Arteaga 090022568e DCI NCCE find considers L and NCCE 2021-06-04 11:13:23 +02:00
Andre Puschmann aaffdeb326 rrc,rlc: add method to signal protocol failure to RRC
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.

In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
2021-06-03 21:11:47 +02:00
Andre Puschmann 107f6334dd compile: fix compilation on 32bit systems that require -latomic 2021-06-03 20:45:02 +02:00
Andre Puschmann 80a89ec4bf enb,mac: protect concurrent access to ue_db from different threads
race condition between PHY worker(s) and Stack thread when
accessing ue_db member. RWlock needs to be hold.

partly fixes #2932
2021-06-03 20:43:37 +02:00
faluco 3df72cb6ab Move out a free call in a RT thread when doing lots of rachs. 2021-06-03 20:41:04 +02:00
Francisco ceaef3523f sched,feature: Enable setting the target PHR below which the maximum UL grant size starts decreasing 2021-06-03 15:33:38 +01:00
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 2021-06-03 15:33:38 +01:00
Francisco f7aef3ffc1 sched,bugfix: fix nof_retx update when UL HARQs are resumed 2021-06-02 20:21:32 +01:00
Ismael Gomez 5cef780789 Radio-link KO notification. Measgap fix 2021-06-02 12:37:36 +02:00
Francisco 92e272ce3e limit minimum UL grant size to accommodate both BSR and RLC headers 2021-06-02 12:37:36 +02:00
Francisco 3b61df4b64 test,sched: update TPC test to reflect changes in SNR estimatioN 2021-06-02 10:08:34 +01:00
Francisco 89406b07d6 make eNB UL SNR initial value an exponential average alpha configurable 2021-06-02 10:08:34 +01:00
Francisco 2a2c56391c sched,refactor: Improve DL/UL grant log lines in the scheduler to print CFI as well 2021-06-02 10:08:34 +01:00
Francisco dda52afe61 move rrc unit tests to rrc/ folder 2021-06-02 10:05:49 +01:00
Francisco 47494a668d rrc,bugfix: fix reestablishment crash due to pointer invalidation 2021-06-02 10:05:30 +01:00
Francisco 3f75538660 rrc,feature: Use t301 to set time that the enb waits for the UE RRCConnectionSetupComplete or ReestablishmentComplete 2021-06-02 10:05:30 +01:00
Francisco 0349949cce bugfix, handover: disable inactivity timer during s1 handover in target enb 2021-06-02 10:05:30 +01:00
Francisco 19af55b63d bugfix, handover: Avoid sending UEContextReleaseRequest from Target eNB during S1 Handover due to UL KOs 2021-06-02 10:05:30 +01:00
Andre Puschmann 2c975732dc metrics_stdout: fix race detected by TSAN 2021-06-01 22:44:12 +02:00
Pedro Alvarez c23034e1a7 Make sure the S1AP state is reset after sending a successful/unsuccessful message 2021-06-01 19:16:16 +01:00
Pedro Alvarez 18e2149d68 Sending Initial Context Setup Response after RRC reconfiguration. 2021-06-01 19:16:16 +01:00
Xavier Arteaga 50b7d3937f Added RNTI in SRSENB PDCCH log line 2021-06-01 15:04:24 +02:00
Xavier Arteaga 6de34524e2 Fix SRSENB PHY log line 2021-06-01 08:27:03 +02:00
Xavier Arteaga ce3c808a16 Reviewed SRSENB PHY unused variables and log messages 2021-06-01 08:27:03 +02:00
Francisco f80c591127 sched,bugfix: fix scheduler CA test 2021-05-31 23:59:46 +01:00
Francisco 2cdda3b6db sched,enhancement: allow PUSCH allocations when PHICH falls in measurement Gap by resuming UL HARQ 2021-05-31 23:59:46 +01:00
Andre Puschmann fcba67ca84 enb,rrc: fix logging text 2021-05-28 18:12:16 +02:00
Andre Puschmann 8322887135 enb,rrc: increase RRC PDU queue size to 128 2021-05-28 18:12:16 +02:00
Francisco a8790abd7e fix centos7 tuple compilation issue 2021-05-28 17:21:10 +02:00
Francisco 200006c4b7 bugfix,scheduler: avoid offset to increase decrease unboundedly when mcs is equal to 0 or max_mcs 2021-05-28 17:21:10 +02:00
Francisco 0dafe4dd58 fix coderate derivation in PDCCH based on aggregation level 2021-05-28 17:20:08 +02:00
Francisco a587d20252 allow specification of subset of valid measurement gap offsets in rr.conf 2021-05-28 17:19:30 +02:00
Francisco 0996e50dce bugfix, s1ap: allow source enb to release old UE ctxt in case a connectionRequest arrives with repeated m-TMSI 2021-05-28 17:18:41 +02:00
Francisco 52247a46e5 rrc,refactor - change log level for paging try lock 2021-05-28 12:29:36 +02:00
Francisco 692bd193d5 rrc,improvements - use single subframe-indexed struct to access pending PCCH. The scheduler now doesnt lock checking for pending paging 2021-05-28 12:29:36 +02:00
Francisco 957ca453e9 bugfix,rrc: change mechanism to delete old paging messages to avoid deleting messages not yet sent 2021-05-28 12:29:36 +02:00
Andre Puschmann 66770a57e3 enb_phy_test: fix concurrent access between PHY worker and Stack
PHY and Stack are using a normal std::queue to communicate with each
other. Concurrent access among the threads needs to be protected.
2021-05-26 14:25:38 +02:00
Francisco fe0dc77c03 bugfix, s1ap: fix uninitialized variable access in s1ap_test 2021-05-26 11:35:32 +02:00
Francisco 297a2394b8 bugfix, s1ap: fix failing s1ap_test 2021-05-26 11:35:32 +02:00
Francisco 7076dbfef8 feature, scheduler: Add configuration parameter to set minimum TTI interval between TPCs 2021-05-25 21:51:10 +02:00
Francisco 4627ae9802 bugfix, scheduler: effectively disable adaptive mcs when target bler is unspecified 2021-05-25 21:51:10 +02:00
Francisco c75777c618 bugfix, sched: avoid compilation issue due to uninitialized variable access 2021-05-25 21:50:56 +02:00
Francisco 329cf02cd0 bugfix, sched: ensure max_coderate is respected in scheduler 2021-05-25 21:50:56 +02:00
Francisco a8cccd7a10 bugfix, sched: fix aggregation level derivation to avoid L > 3 2021-05-25 21:50:56 +02:00
Francisco dedd9c09a7 feature, scheduler: Add abitility to set minimum aggregation level in PDCCH, and disable adaptive aggregation level based on target BLER 2021-05-25 21:50:56 +02:00
Francisco fb4a363abd fix formatting errors in scheduler 2021-05-24 19:33:27 +02:00
Francisco 1f1665bab7 improve adaptive offset adjustment log lines 2021-05-24 19:33:27 +02:00
Francisco c5029fc266 feature - implement adaptive link adaptation in DL and UL 2021-05-24 19:33:27 +02:00
Francisco 8811b7c9a7 fix handling of CRNTI CE in the RRC. The scheduler should not allocate more grants for the new rnti after this point. 2021-05-24 19:33:16 +02:00
Francisco 59513c0eed fix bearer reactivation in case the RRC session is recovered after max KO 2021-05-24 19:33:16 +02:00
Andre Puschmann fbb151af2d enb,rrc: fix bearer re-activation after max KO
this patch makes sure that if RBs have been deactivated after
max KO on either the DL or the UL, they are reactivated if either
of them is working again.

UL/DL are always activated together, even if just one of them
recovers. The KO counter (or timer), however, is not stopped implicitly.
2021-05-24 19:33:16 +02:00
Francisco 59db527481 fix reestablishment reject logging level 2021-05-24 19:33:16 +02:00
Francisco a17e3b71e7 set minimum snr under which the UL SNR estimate is not updated 2021-05-24 17:25:07 +02:00
Francisco 8df6ed07c6 sched small fixes - use 0.930 instead of 0.932 for max coderate. Allow computing mcs/tbs based on max coderate directly. Other small fixes 2021-05-24 17:25:07 +02:00
Francisco 41bc7e4810 avoid letting repeated s1ap::user_release calls to deem the user as in zombie state. Use timer instead to auto-remove user from s1ap if no response from mme arrives 2021-05-24 17:24:31 +02:00
Francisco e07ef0aa18 avoid releasing ues doing s1 handover before TS1relocoverall expiry 2021-05-24 17:24:31 +02:00
Francisco b093576634 avoid sending UEContextReleaseRequest from Source eNB during S1 Handover. 2021-05-24 17:24:31 +02:00
Francisco f2a56c9139 simplification of multiqueue design.
- the consumer does multi-staged waiting:
  1. spins first across all queues in a RR fashion
  2. each queue access is done with a try_lock.
  3. if the try_lock fails, it increases the number of spins needed
  2. if no queue had data, the consumer sleeps for 100 usec.
- no differentiation between queues, in terms of notification features
2021-05-24 17:24:12 +02:00
Francisco 2d6a878826 change interface to create multiqueue queues 2021-05-24 17:24:12 +02:00
Francisco f705735093 optimization - only allow some multiqueue queues to notify the multiqueue consumer of the arrival of tasks 2021-05-24 17:24:12 +02:00
Ismael Gomez 8414b2c2c9 Define iszero in csv_stdout 2021-05-22 16:59:27 +02:00
Ismael Gomez 5a2a435710 Improve srsENB output metrics 2021-05-22 16:59:27 +02:00
yagoda 9501283c1c fixing support for extended Cyclic Prefix
small cosmetic fixes of CP code
2021-05-20 18:16:15 +02:00
yagoda f90f6f0c7e adding MAC 0 padding support 2021-05-20 10:26:50 +02:00
Francisco 52ef23f40e fix sched benchmark test 2021-05-19 13:11:39 +01:00
Francisco a83c0ebe3b increase starting CFI when subframe contains control allocations (e.g. SIB or RAR) when cell bandwidth <= 5 MHz 2021-05-19 13:11:39 +01:00
Francisco 0a1ae0e4ad redesign and fix enb rrc message logs 2021-05-19 12:42:41 +01:00
Francisco 8d30c88330 bugfix - avoid calling rlf release timer handler concurrently 2021-05-19 12:17:40 +01:00
Francisco f0f99c1e4f update sched benchmark, created unit test to cover rbg search algorithms, improved algorithms to search for empty rbgs 2021-05-19 11:43:39 +01:00
Francisco 22f1f2d56c move ngap files into their own folders 2021-05-17 15:32:57 +01:00
Francisco 1488606156 refactor - create s1ap dedicated folder 2021-05-17 15:32:57 +01:00
Francisco 0e0835a805 move scheduler rbg/prb/cce mask and interval types and associated helper functions to a separate file 2021-05-17 14:30:23 +01:00
Francisco 7c0649bc24 delete erab if gtpu tunnel creation failed 2021-05-17 15:17:27 +02:00
Francisco c6d543efdf fix conversions of drb id to erab id in srsenb 2021-05-17 15:17:27 +02:00
Andre Puschmann 167200f5cd rrc_bearer_cfg: replace fixed E-RAB to DRB mapping
also make sure we don't assign LCIDs beyond the possible
number.

possible fix for https://github.com/srsran/srsRAN/issues/658

Co-authored-by: herlesupreeth <herlesupreeth@gmail.com>
Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
2021-05-17 15:17:27 +02:00
Francisco fa34aaa16e ensure the DL mask count is reduced enough to fit required bytes 2021-05-14 19:58:03 +01:00
Francisco 4d3ff0d139 implementation of basic search for optimal rbgmask for subband CQI 2021-05-14 19:58:03 +01:00
Francisco f8b6eae2bf use of min DL cqi across all PRBS to compute required DL PRBs 2021-05-14 19:58:03 +01:00
Francisco 8564996eaf fix sched_dl_cqi method to compute cqi-optimal rbgmask 2021-05-14 19:58:03 +01:00
Francisco 485c6ee129 subband CQI feature - add K parameter in sched_interface::ue_cfg_t and update it from RRC 2021-05-14 19:58:03 +01:00
Francisco 84ad6dd8ee Integrated new sched_dl_cqi class in sched_ue_cell
- extend sched_dl_cqi interface to allow getting tti when cqi was last updated
- extend sched_dl_cqi to quickly get average cqi across the whole bandwidth
2021-05-14 19:58:03 +01:00
Francisco 16d05ff042 Remove time exponential averaging of DL cqi
- renaming: sched_cqi -> sched_dl_cqi
- testing: add unit test for sched_dl_cqi wideband cqi mode.
- feature: remove time exponential averaging of dl cqi
2021-05-14 19:58:03 +01:00
Francisco 28c24a89ef sched subband cqi - create method to get cqi-optimal RBG mask 2021-05-14 19:58:03 +01:00
Francisco eeb8ad6571 sched,feature - creation of sched_cqi class to manage the update of CQI in a subband CQI setting 2021-05-14 19:58:03 +01:00
Francisco f25dbea4de fix PCCH assembly in srsenb rrc 2021-05-14 19:57:52 +01:00
Xavier Arteaga af2f37d8ca SRSENB: CFI protection for all CC and fix test 2021-05-13 07:56:08 +02:00
Francisco 96ab16f1c7 s1ap fix - release old rnti (instead of new one) when a new rnti with the same tmsi is found. Furthermore, we now make sure to warn log if the enb is unable to release the old rnti 2021-05-12 18:55:10 +01:00
Francisco 6ed617f429 s1ap, bugfix - check if MME-UE-S1AP-ID has been yet assigned before sending UL NAS Transport. If it hasn't log error and abort. 2021-05-12 16:20:44 +01:00
Francisco 32228389a9 fix latest static analysis warnings in rrc paging 2021-05-11 21:14:47 +01:00
Francisco bfdb0332db remove undefined methods from rrc_ue 2021-05-11 16:54:14 +01:00
Francisco 46cfdaf9e5 Handle case when old rnti gets removed during RRC reestablishment
This is achieved via:
- keep restarting the inactivity timer whenever a ReestablishmentRequest is received
- in case the RRC ReestablishmentComplete is very late and the old rnti was removed anyway,
  abort RRC reestablishment procedure and release new rnti
2021-05-11 16:54:14 +01:00
Andre Puschmann b2825d1280 mac_controller: after maxRetx disable ALL UE bearers
the reasoning here is that the only way to recover
from the maxRetx event is the UE attempting a reestablishment.

No further traffic, neither control nor data is scheduled
until then.
2021-05-10 18:43:37 +02:00
Andre Puschmann b61be7878a enb,rrc: split RLF counter and timer handling for DL/UL/RLC
this patch splits the counter and timer handling for PHY DL, PHY UL,
and RLC errors and makes sure that, for example, a successful DL
does not cancel the UL RLF timer, and vice versa.

They all use the same timeout value which is user-configurable.
2021-05-10 18:43:37 +02:00
David Rupprecht f9c0009d23 Remove setup erabs function 2021-05-10 17:54:38 +02:00
Francisco 0d800eb8f6 stack, multiqueue - bugfix for multiqueue destruction, and addition of unit test 2021-05-10 15:27:21 +01:00
Francisco ef9d1b8c13 stack optimization - reduction of contention in multiqueue class
With the new design, each queue created in the multiqueue object has its own mutex.
Pushing tasks to separate queues will, therefore, not cause contention.
There will be, however, still contention between the popping thread and the pushing threads.
2021-05-10 15:27:21 +01:00
Francisco b54bb35343 use rnti_map_t in scheduler 2021-05-07 10:58:04 +01:00
Francisco 6b84754ede fix rrc and gtpu bearer rnti update during reestablishment. The rnti of UE's rrc_bearer_handler was not being updated 2021-05-07 10:58:04 +01:00
Francisco 1677abce8d create typedef for circular map of rntis. check return of gtpu ue creation 2021-05-07 10:58:04 +01:00
Francisco 9464f36714 make eNB UE release timer after RLF detection configurable 2021-05-07 09:51:59 +01:00
Ismael Gomez 0b91598e36 Move mlockall() to main() in srsUE and srsENB 2021-05-06 23:03:57 +02:00
Francisco 46bd8845ba fix gtpu bearer removal during handover 2021-05-06 18:10:31 +01:00
Francisco 7c2e841eb4 gtpu bugfix - call gtpu rem bearer when erab is removed 2021-05-06 18:10:31 +01:00
Francisco c5396155ad set default gtpu tunnel close timeout to infinity 2021-05-06 18:07:20 +01:00
Francisco 15484e9472 rrc - make t304 configurable via rr.conf 2021-05-06 18:07:20 +01:00
Francisco c6b9c12ba2 gtpu, feature - added the ability to configure gtpu indirect tunnel timeout value. This parameter is useful in the case that the end marker is not received 2021-05-06 18:07:20 +01:00
Francisco b619a2b649 application of new cache allocator to deques in scheduler 2021-05-06 18:06:10 +01:00
David Rupprecht c117b563c9 Initial commit for ngap in enb 2021-05-05 13:54:57 +02:00
David Rupprecht 3284143b39 Capture false encoded messages before sending 2021-05-04 21:38:06 +02:00
Francisco 7bee75e126 update description of srsenb --expert.nof_prealloc_ues config parameter, and added a comment in header file explaining the use of such parameter. 2021-05-04 17:52:47 +01:00
Francisco 5818488b27 change enb max_nof_ues config parameter to nof_prealloc_ues 2021-05-04 17:52:47 +01:00
Francisco 9739a9de5f add missing srsenb expert parameter to enb.conf.example 2021-05-04 17:52:47 +01:00
Francisco 04ded030ea srsenb,bugfix - avoid logging error message when UE sends CRNTI MAC CE for old rnti whose context has already been erased. 2021-05-03 21:43:48 +01:00
Francisco d175bb281b avoid error logging during handover if EIA0 has been chosen 2021-05-03 17:58:24 +01:00
Francisco 051530177e feature - support eia0 during S1 Handover 2021-05-03 17:58:24 +01:00
Francisco a43dd68d57 update comment, explaining the reasoning behind setting a lower bound for allocated UL grants 2021-05-03 17:43:41 +01:00
Francisco f7016633d2 sched, fix - avoid tpc commands when target pusch and pucch snr are not specified 2021-05-03 17:43:41 +01:00
Francisco c69631462b sched, fix - limit UL cqi update to PUSCH SNR reports 2021-05-03 17:43:41 +01:00
Francisco d3c51fdad4 limit minimum UL grant size to accommodate both BSR and RLC headers 2021-05-03 17:43:41 +01:00
Francisco cde61a5796 rrc paging - reduce the space taken by paging manager class
Paging messages can only be transmitted in a subset of subframes - {0, 4, 5, 9}
I avoid now creating objects for the subframes that are not part of this subset
2021-05-03 15:58:21 +01:00
Francisco b014cbfe0f rrc paging - removal of redundant mutexes in paging manager class. Now mutexes are indexed by subframe index instead of paging buffer index 2021-05-03 15:58:21 +01:00
Francisco 8487c10956 removal of unused variables 2021-05-03 15:58:21 +01:00
Francisco 01eace2631 rrc paging mechanism improvements
- moved paging record handling to separate class
- parallel access to pending pcch messages by phy workers based on TTI and without common lock
- asn1 pcch message packing now takes place in stack thread, to avoid real-time issues
2021-05-03 15:58:21 +01:00
Andre Puschmann 598594c51a all: bunch of pass by const& changes suggested by LGTM 2021-04-29 10:00:09 +02:00
Francisco 70d6e4d9b3 mac, fix - Verify that mac::ue also exists in the scheduler before attempting to retrieve its metrics 2021-04-28 00:02:06 +01:00
Francisco 6e7d992552 remove UE on S1AP Release Request if MME S1AP UE ID hasn't been assigned yet 2021-04-27 19:14:25 +01:00
Xavier Arteaga 6045998909 enb_phy_test uses default rr configuration 2021-04-27 16:55:51 +02:00
Francisco Paisana d39183419c
Separate TPC PUSCH and PUCCH target SINR (#2740)
* separate target pusch and pucch sinr configurations in tpc class and rr.conf
2021-04-27 10:12:40 +01:00
Francisco 86dac9c823 several coverity high and medium impact fixes 2021-04-27 10:11:03 +01:00
Andre Puschmann 20575d3eec phy,enb: only initialize NR workers if needed
the NR support in the eNB isn't finished yet but loading
all DL objects even for 4G only isn't required. So only
even attempt to load them if a NR cell is configured.
2021-04-26 09:43:58 +02:00
Andre Puschmann ff53d2b8b8 all: set of trivial changes reported by LGTM
mainly fixmes, unused/empty code, etc.
2021-04-25 21:03:53 +02:00
AlaiaL d88760f099 Fixes coverity 366620 2021-04-23 21:22:06 +02:00
AlaiaL beaa1b3e24 Fixes coverity 369569 2021-04-23 21:22:06 +02:00
AlaiaL 82788ca094 Fixed issues from coverity:
- 370233
- 370234
- 370239
- 370240
- 370241
- 370242
- 370243
- 370295
2021-04-23 21:22:06 +02:00
herlesupreeth 0f06ec0d9c Add feature to provide custom GTP-U (S1) address to be advertised inside S1AP messages
This feature is useful in scenarios where eNB is behind a NAT and EPC on public cloud
Since eNB's GTP-U can only bind to IP address visible in it's host (usually a private IP beind a NAT), it advertises the same to UE in S1AP message
resulting in traffic from EPC to eNB (DL traffic) not able to reach eNB. This commit solves this issue by providing a means to advertise a different IP address than the one GTP-U UDP socket is bound to.
This IP is usually advertised in InitialContextSetupResponse and E-RABSetupResponse.

In order to make use of this feature, use the following parameter in enb.conf

Example:

gtp_advertise_addr = 213.61.141.82
2021-04-23 20:31:36 +02:00
faluco cd1c6732f7 Remove the creation of strings when preparing the contents of a log entry in sched_helpers. 2021-04-22 12:38:14 +02:00
Francisco ff3fc0826b asn1 fixes and improvements
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
2021-04-22 10:21:08 +01:00
Francisco 42e7fc656b s1ap fix - send S1AP UEContextRelease when the UE does a new RRC connection setup with the same TMSI 2021-04-21 16:49:36 +01:00
faluco 69726bc939 Remove two allocs in the prio queues in sched_time_pf. 2021-04-21 15:05:48 +02:00
faluco 7df308c756 Remove two mallocs in the stack:
1) Extend the small buffer to 64bytes for the move_callback class.
2) Replace a std::map for a fixed size circular map in sched_time_pf.
2021-04-21 15:05:48 +02:00
Xavier Arteaga 407903e0d6 SRSUE: refactor carrier setting for accepting a dynamic carrier configuration 2021-04-20 21:50:10 +02:00
Xavier Arteaga 1a4de831e9 Ammended eNb PHY tests 2021-04-20 19:12:46 +01:00
Francisco d1b336101f revert enb phy tests. Check that when nof_carriers==6 the phy fails to start and reports an error. 2021-04-20 19:12:46 +01:00
Francisco 6137e4569b fix srsran_assert definition when asserts are disabled 2021-04-20 14:01:05 +01:00
Francisco 3b78bf3730 bugfix - fix memcheck warnings. move instructions with side effects outside of asserts 2021-04-20 14:01:05 +01:00
David Rupprecht a064e85c54 rename common lte header 2021-04-19 22:23:59 +02:00
David Rupprecht 81ad72b0ff Refactor srb and drb handling 2021-04-19 22:23:59 +02:00
David Rupprecht 6b41ae7e8b Updated PDCP config struct for rat type 2021-04-19 22:23:59 +02:00
Francisco 8ed8b94ca5 in search for contiguous prb interval, skip already scanned prbs 2021-04-19 13:31:20 +01:00
Francisco 22024ac35d implemented bounded_bitset::find_lowest(...) for both reverse and non-reverse bit ordering. Applied this method to UL scheduling search for PRB intervals 2021-04-19 13:31:20 +01:00
David Rupprecht f42d4dbc28 Refactored carrier config 2021-04-19 12:13:37 +02:00
Francisco 52bf973981 s1ap - set cause to transport when gtpu fails to allocate TEID 2021-04-17 13:06:19 +01:00
Francisco 791b8d24ce fix regression in scell activation during intraenb handover 2021-04-16 12:17:41 +01:00
Ismael Gomez 77b11b82ac
Release UE if no activity in DRB (#2658)
* Count user activity with DRB only and SRBs for initial procedures. Add counter to release user after max KO in UL.
2021-04-15 19:13:01 +02:00
Francisco 4838cd2f5e implement cell measurement bandwidth feature 2021-04-15 17:48:18 +01:00
Francisco 14d32db92f implement Handover direct forwarding path availability configuration feature 2021-04-15 17:48:18 +01:00
Francisco 4b9e59e8cf fix some s1ap msg causes 2021-04-15 17:48:18 +01:00
Francisco b8fa1d1b61 fix rrc mobility test 2021-04-15 09:45:31 +01:00
Francisco 66988ffd32 s1ap - simplified erab setup procedure. Handle correctly the failure to setup causes 2021-04-15 09:45:31 +01:00
Francisco f401683960 s1ap - simplified erab modify procedure 2021-04-15 09:45:31 +01:00
Francisco 76978f0d14 s1ap - simplified erab release procedure 2021-04-15 09:45:31 +01:00
Francisco c5fc543516 s1ap - handling of ts1 reloc overall timer. 2021-04-15 09:45:31 +01:00
Xavier Arteaga 7823bfc28c Fix append NR to loggers for NR components 2021-04-14 08:16:44 +02:00
Francisco c2a99a8112 handover - support for handover cancellation causes, check for E-RAB QoS requirements, cancellation of handover if E-RABs are not supported in the target eNB 2021-04-13 21:23:13 +01:00
Francisco f79e0fade8 handover - set handover required cause to handover desirable for radio reason 2021-04-13 21:23:13 +01:00
Francisco 6d401bc79f handover - check if UE integrity and encryption algorithms are supported in the target eNB, and report handover failure if not. 2021-04-13 21:23:13 +01:00
faluco 9b634218be Pre allocate some vectors members in the scheduler. 2021-04-13 21:22:44 +01:00
Francisco 77bd500312 handover - implement and test S1 Handover fail path for the case of invalid QoS config in HO Request message 2021-04-13 09:30:40 +01:00
Francisco d2c404b166 handover - setup s1ap cause in case of handover failure at the target enb 2021-04-13 09:30:40 +01:00
Francisco 49bd895e29 s1ap - handle invalid or repeated erab ids in s1ap erab release command 2021-04-12 22:07:26 +01:00
Francisco 7842e3bff3 s1ap - add unit test to check correct handling of invalid E-RAB ids in modification request. Fix s1ap in order for the test to pass 2021-04-12 22:07:26 +01:00
Francisco 985846e3bd s1ap - set multiple erab ids cause in replay when s1ap erab modify request has repeated ids. 2021-04-12 22:07:26 +01:00
Francisco bc16c46ffc detect and handle repeated ERAB IDs in S1AP ERAB Modify Request message 2021-04-12 22:07:26 +01:00
Andre Puschmann c9da21c9bb mac_nr: add error handling when unpacking SCH MAC PDU
* only handle PDU if unpacking was successfull
* add TC unpacking with malformed PDU
2021-04-12 18:26:31 +02:00
Francisco 685c971dc2 fix recursive call to get rb name 2021-04-12 13:21:43 +01:00
Francisco f7a8b8bf94 separate drb srb ids into separate enum types 2021-04-12 13:21:43 +01:00
Francisco 3a23546c56 fix pdcp_nr.cc compilation 2021-04-12 13:21:43 +01:00
Francisco 21718af3b6 avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type 2021-04-12 13:21:43 +01:00
Francisco 99b4595b69 fix enb phy test by limiting the number of carriers to 5 2021-04-09 15:38:07 +01:00
Francisco d142d7b6a5 update test helpers for enb, so that the rrc tests pass 2021-04-09 12:54:22 +01:00
Francisco ac7cc3c42d change enb ue softbuffer initial allocation size 2021-04-09 12:54:22 +01:00
Francisco 75e9700de0 rlc - usage of memory pool to allocate RLC bearers 2021-04-09 12:54:22 +01:00
Francisco 8fe27a72d0 enb - decreased default enb.conf mac.max_nof_ues to 8 to avoid large memory pool preallocations 2021-04-09 12:54:22 +01:00
Francisco 71f1f1b556 enb - log warning when rnti-specific memory block is full 2021-04-09 12:54:22 +01:00
Francisco a890a22ccd enb - rnti memory pool now fallbacks to new/delete if rnti-specific memory block is full 2021-04-09 12:54:22 +01:00
Francisco 344bdf3165 allocation of UE rlc and pdcp classes in the ue dedicated memory pool 2021-04-09 12:54:22 +01:00
Francisco 60d5c6df7b implementation of memory pool with individual memory blocks per UE that get accessed via their rnti 2021-04-09 12:54:22 +01:00
Francisco 9b7060a098 check ptr value before dereferencing 2021-04-08 21:44:42 +01:00
Ismael Gomez c4069b58af Call HARQ new tti only for the current PID 2021-04-08 20:24:21 +02:00
Andre Puschmann cbe7980d7d enb,mac_controller: apply new MAC config with disabled DRB
fix regression in RRC that updated the local MAC config to
disable DRB scheduling after maxRetx, but didn't actually apply the config
2021-04-08 18:19:55 +02:00
Francisco bb9601c13b gtpu - fix gptu manager members destruction order 2021-04-07 22:26:42 +01:00
Francisco b7d4a72ea1 adt - fix circular map clear() and erase(it) functions 2021-04-07 22:26:42 +01:00
Francisco 643c73acee gtpu - fix removal of gtpu tunnels when rnti is released 2021-04-07 22:26:42 +01:00
Andre Puschmann 7459a65a8e enb,rrc_ue: remove unused variable 2021-04-07 22:19:08 +02:00
Francisco d02cc51e33 use mutex or atomic in running flag to signal the interruption of a thread 2021-04-07 16:11:31 +01:00
Xavier Arteaga 49731ab5a1 Initial NR-DCI refactor
Added NR DCI 1_1 size

Several DCI NR fixes
2021-04-07 16:57:12 +02:00
Francisco cdf72248f3 Reimplement batch-based background object/memory pool
Main changes:
- addition of pool utilities
- The node size/alignment and batch allocation threshold are now runtime arguments
- object pool and memory pool are not anymore based on the same class.
  The object pool cannot use intrusive free list because it would overwrite the object
  memory
2021-04-07 12:02:22 +01:00
Francisco fbeb87c53e remove unused parameters from mac::ue 2021-04-07 12:02:22 +01:00
Francisco b004c2024d integration of object pool in mac::ue for allocation of softbuffers. Definition of common object pool interface class 2021-04-07 12:02:22 +01:00
Francisco 460d7a8f4f fix memory pool test - placed the pool state into a shared_ptr so that the callbacks still have a valid handle when the pool is destroyed 2021-04-07 12:02:22 +01:00
Francisco ec3cd9ffea adt - added background object pool test, and fix existing bugs related to the creation of pools with objects that are too small to be used in free lists 2021-04-07 12:02:22 +01:00
Francisco d1c5b000dc adt - creation of pre-initialized object pool, that leverages the background memory pool allocator 2021-04-07 12:02:22 +01:00
Francisco eb9814837a fix gtpu test valgrind warning 2021-04-02 17:40:50 +01:00
Francisco a79ca92020 refactor type storage and pool tests 2021-04-02 17:40:50 +01:00
Francisco 046633674a refactor - removal of stack-gtpu interface, and use of socket manager interface instead 2021-04-02 11:42:50 +01:00
Francisco c24e382c19 Refactor of socket manager class
- use of inheritance to simplify testing
- removal of global network manager
- pass of custon socket manager to s1ap and gtpu ctors
- overhauled the registration of socket fd,callback in socket manager
2021-04-02 11:42:50 +01:00
Francisco 4aac7ac238 use global rx multisocket handler, and remove stack-s1ap interface 2021-04-02 11:42:50 +01:00
Francisco 39de2efa69 multisocket handler - use blocking socket remove method 2021-04-02 11:42:50 +01:00
Francisco bf96d897ee network utils refactor - renaming of socket handle to unique socket and cleanup of its methods 2021-04-02 11:42:50 +01:00
Francisco aed5c51010 fix bug in cc_used_buffers_map in request_pdu(...) 2021-04-02 11:41:08 +01:00
Francisco 8fda69a3dd refactor mac::ue cc_used_buffers_map class to use new circular_map container 2021-04-02 11:41:08 +01:00
Pedro Alvarez 696de22a28 Change default maximum number of KOs to 100 2021-04-01 13:21:43 +01:00
Pedro Alvarez b2b7d8f617 Set rlf_timer timeout once. Make activity timer expiry also stops rlf_timer 2021-04-01 13:21:43 +01:00
Pedro Alvarez e1a852d4b8 Split split RLF timer and Inactivity timer 2021-04-01 13:21:43 +01:00
Pedro Alvarez 47135cb75b Changed counting of KOs to RRC 2021-04-01 13:21:43 +01:00
Pedro Alvarez 8194b5ec73 Added check for consequetive KOs in MAC. Change set_activity_user to pass activity and max KOs to RRC and trigger RLF timeout. 2021-04-01 13:21:43 +01:00
Francisco ec72b310d7 fix mme ue s1ap id initialization 2021-04-01 10:24:34 +01:00
Francisco 23ae9967cf replaced present+value for optional field in s1ap mme_ue_s1ap_id context field 2021-04-01 10:24:34 +01:00
Francisco b8f220258d s1ap - extend s1ap unit test to verify result of passing an invalid mme s1ap ue id 2021-04-01 10:24:34 +01:00
Francisco c3482b45e1 s1ap - handle erroneous enb/mme s1ap ue id in received s1ap messages from the MME 2021-04-01 10:24:34 +01:00
Francisco cc369aca1f sched - handle the case when the CRC is missing and max retx is reached 2021-03-31 20:52:02 +01:00
faluco 67530687e9 Restore RRC release result variable after logging the event. 2021-03-31 19:37:49 +02:00