Commit Graph

4929 Commits

Author SHA1 Message Date
dvdgrgrtt 3fad800ef6 Fix various typos and minor issues
Some typos in the comments/error messages.
A couple of minor bugs (should not have any impact in the performance).
2022-01-28 08:15:36 +01:00
dvdgrgrtt 1390eeea88 sch_nr: Fix CRC-related bug
CRC failure was not reported correctly when the TB consists of a single
block.
2022-01-28 08:15:36 +01:00
Andre Puschmann c3596cc684 ue_nas_interfaces.h: set default APN type to ipv4 2022-01-27 12:49:13 +01:00
Robert Falkenberg cceae68958 zmq: extend test to 4 trx, w/wo decimation 2022-01-27 09:56:42 +01:00
Robert Falkenberg b4bbbc902a zmq: fix scaling of samples when decimation is applied 2022-01-27 09:56:42 +01:00
Xavier Arteaga fbf178e958 Decrease PBCH-DMRS threshold to pass test 2022-01-26 22:29:50 +01:00
dvdgrgrtt cac62e01e0 Improve coding style 2022-01-26 17:05:36 +01:00
dvdgrgrtt 2df371fdd6 Provide PRACH NR performance test 2022-01-26 17:05:36 +01:00
Xavier Arteaga e3f8b75652 SSB search uses correlation power to normalise 2022-01-26 12:43:09 +01:00
Xavier Arteaga 569f5c1a6f Protect input buffer SSB demodulation in search/find and skip PBCH decoding if PBCH DMRS correlation does not reach threshold 2022-01-26 12:42:31 +01:00
Xavier Arteaga aea7a11e53 Fix SKIQ compilation with gcc-11 2022-01-26 12:42:31 +01:00
Carlo Galiotto d5859fb60b rrc-nr: remove comments/dead code
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-26 10:47:26 +01:00
Carlo Galiotto fe6500bd55 rrc: copy PUCCH cnf from RRCSetup to PHY structs
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-26 10:47:26 +01:00
Carlo Galiotto 362abfe3c9 rrc-nr: add conversion for pucch_cfg
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-26 10:47:26 +01:00
Carlo Galiotto a53e7c9673 TMP WIP
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-26 10:47:26 +01:00
Carlo Galiotto 49e01584ac rrc-nr: fix rebase issue
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-26 10:47:26 +01:00
Francisco Paisana 378e14826e rrc,nr: fix conversion of csi meas cfg to phy cfg flat struct 2022-01-26 10:47:26 +01:00
Xavier Arteaga 256bba0fd3 Handle NAN in NR PBCH reception and add unit test case 2022-01-25 16:08:41 +01:00
Bedran Karakoc 70084cf9cc Added unit test for K_gnb derivation 2022-01-25 14:24:58 +01:00
Bedran Karakoc efa13290a9 ue,rrc_nr,nas_5g: Introduce NR AS Key derivation and update context handling in 5G NAS 2022-01-25 14:24:58 +01:00
Bedran Karakoc a8eaf1cdd8 ue,nas_5g: Add get_k_amf() helper function and security context flag 2022-01-25 14:24:58 +01:00
Andre Puschmann 44a00feccb pdcp_entity_base: fix log typo 2022-01-24 21:07:22 +01:00
Xavier Arteaga a9591f1d45 Avoid poping queue if empty 2022-01-24 10:09:17 +01:00
Fabian Eckermann 12cc7cb4d7 Add support for RRC redirect. 2022-01-21 09:46:56 +01:00
Francisco 52106be3d5 sched,nr: remove phy cfg types from sched_nr_cell_cfg_t 2022-01-20 10:54:00 +00:00
Francisco b25814de27 sched,nr: fix failing sched test due to misconfiguration 2022-01-20 10:54:00 +00:00
Francisco 7ef206e15b sched,rrc,nr: remove need to pass sched ue cfg object to rrc during ra procedure 2022-01-20 10:54:00 +00:00
Francisco 7f200ac7f7 sched,nr: pass asn1 TDD configuration to scheduler as defined in ORAN 2022-01-20 10:54:00 +00:00
Xavier Arteaga 66f6c11561 Fix concurrent issues in dummy radio used in nr_phy_test 2022-01-19 18:33:39 +01:00
Xavier Arteaga 8a7a4a588d Fix concurrent access to decimator busy flag 2022-01-19 18:33:39 +01:00
Andre Puschmann aaceb029eb rlc_am_lte: fix wrong fmt string 2022-01-19 12:26:18 +01:00
dvdgrgrtt c9beba6f36 Use srsran_convert_dB_to_power
Instead of computing power using the power function.
2022-01-19 11:13:28 +01:00
dvdgrgrtt 3ffefe5ba7 Use copyright as file header 2022-01-19 11:13:28 +01:00
dvdgrgrtt a69fb1d50f ch_awgn: Improve API
The API of functions srsran_ch_awgn_X was causing confusion between
noise variance and standard deviation. Also, in the complex-valued case,
the noise variance did not take into account the fact that the signal is
two-dimensional.

All uses of these functions are modified accordingly.
2022-01-19 11:13:28 +01:00
Andre Puschmann 92a13294b2 rrc_nr_utils: set RAT for PDCP config for SRB to NR 2022-01-18 18:20:04 +01:00
Andre Puschmann 99c2d16c1b ue_nr_interface: include SRB ARFCN in cell search result 2022-01-18 18:20:04 +01:00
Andre Puschmann ee8d334aaa phy,nr: logging fix for PDCCH 2022-01-18 18:07:21 +01:00
Andre Puschmann 02cdc66302 security: fix k_gnb* derivation for 5G
add FC code for gNB KDF and fix ARFCN encoding (can be more than 2 bytes)
2022-01-18 18:07:21 +01:00
Pedro Alvarez 9bd368e0a9 lib,rlc: changed back status and header logging helpers to log directly. Make sure RB name is automatically logged. 2022-01-18 11:53:37 +00:00
Pedro Alvarez 00a60dbb97 lib,rlc: removed duplicate rb_name in logs of rlc_am_base and rlc_tm 2022-01-18 11:53:37 +00:00
Pedro Alvarez 87607a4ea7 lib,rlc: changed RLC UM NR to use new logging macros 2022-01-18 11:53:37 +00:00
Pedro Alvarez b53da22eb1 lib,rlc: changed return of string helper functions from char* to std::string to avoid UB 2022-01-18 11:53:37 +00:00
Pedro Alvarez b46c5423f0 lib,rlc: make sure TM rb name is initialized. changed rlc_um_lte to use new logging macros 2022-01-18 11:53:37 +00:00
Pedro Alvarez e157806db2 lib,rlc_am_lte: removed RB_NAME macro. changed status and data pdu logging helpers to return C strings. Using new logging macros to make sure that RB name is included when logging status and amd pdus. 2022-01-18 11:53:37 +00:00
Pedro Alvarez 0f4b64f13f lib,rlc: added macros for hex logging that automatically add the rb_name. changed logging to use new macros in multiple places. 2022-01-18 11:53:37 +00:00
Pedro Alvarez b687072815 lib,rlc: added rb_name and logger to rlc_common. Added macros to help making sure bearer name is always included to the log to rlc_common.h. Started using said macros in TM, UM and AM entities. 2022-01-18 11:53:37 +00:00
Alejandro Leal 74d847efe9 Removed unneeded libraries in the test as srsran_phy already includes
srsran_phy_common
2022-01-17 15:43:20 +01:00
Francisco 3c25b6cb24 asn1: remove presence flag for lists and octet strings, as the size of the latter implicitly tell if the asn1 field is present 2022-01-17 11:58:00 +00:00
Xavier Arteaga 65255ecb4e Unpack MIB to update MIB 2022-01-17 10:55:38 +01:00
Xavier Arteaga c88774a3f4 Fix UE SYNC NR CFO feedback and periodicity 2022-01-17 10:55:38 +01:00
Xavier Arteaga 8694cc63ec Added SSB configuration conversion to string 2022-01-17 10:55:38 +01:00
faluco 634db621e4 Fix compiler error due to a bug in clang9. 2022-01-16 22:17:14 +01:00
sauka d5040540fb use NR type1 RIV function helper 2022-01-14 10:40:18 +01:00
sauka 9b24867bc4 set SCH configuration only for non SI-RNTI case. Fix formatting 2022-01-14 10:40:18 +01:00
sauka 870c3ab8c5 update TV, enable ue_dl_nr_file_test for c-rnti case
Cell:
nr_arfcn=368500 ul_nr_arfcn=349500 pci=500 mode=FDD rat=nr n_rb_dl=52 n_rb_ul=52 dl_mu=0 ul_mu=0 ssb_mu=0 ssb_arfcn=368410 ssb_prb=13:21 k_ssb=6 coreset0_prb=1:48 coreset0_idx=6

coreset1:
11:49:15.018 [PHY] DL 0001 01 0100   718.1 PDCCH: ss_id=1 cce_index=0 al=4 dci=1_0
	rb_alloc=0x5f
	time_domain_rsc=0
	vrb_to_prb_map=0
	mcs=10
	ndi=1
	rv_idx=0
	harq_process=0
	dai=0
	tpc_command=1
	pucch_rsc=0
	harq_feedback_timing=3
	dci_len=39
11:49:15.018 [PHY] DL 0001 01 0100   718.1 PDSCH: harq=0 prb=1:48 symb=1:13 k1=4 CW0: tb_len=960 mod=4 rv_idx=0 cr=0.33 retx=0
        0000:  43 03 bd c0 05 00 59 09  47 7e 29 e5 43 3d b6 2b  C.....Y.G~).C=.+
        0010:  e3 ed a1 43 3a 53 f2 23  d4 8b 23 a0 c9 5d ec 23  ...C:S.#..#..].#
        0020:  47 80 2b 64 0d f6 2a 11  bc 76 ed 0c 72 6a 7e c5  G.+d..*..v..rj~.
        0030:  4c 14 80 56 86 69 bf 27  60 9d 0b fd 23 22 4b d1  L..V.i.'`...#"K.
        0040:  45 a4 01 b0 50 f7 02 e2  3a ac 16 b3 b3 b8 e0 09  E...P...:.......
        ...
        0380:  f2 fa 54 f3 4e 3f 14 54  38 73 ab 4e bb d7 41 76  ..T.N?.T8s.N..Av
        0390:  47 19 31 b0 86 fb 7f 9f  1d 93 91 69 66 b8 ae 91  G.1........if...
        03a0:  8f 1e 4b 03 9e 7d 03 ae  93 77 a8 81 0a 8f 44 8b  ..K..}...w....D.
        03b0:  87 cf 76 59 11 1f 31 7d  aa 01 e3 9c 26 07 33 57  ..vY..1}....&.3W
2022-01-14 10:40:18 +01:00
sauka b9fb65e301 extend ue_dl_nr_filetest to specify PDSCH allocation in time-domain, add option to enable interleaved pdcch 2022-01-14 10:40:18 +01:00
Ismael Gomez e1313cce74 sidekiq: update cur_rx_gain_db inside card sub-module 2022-01-14 10:19:08 +01:00
Ismael Gomez fd2eef132d sidekiq: configure RFIC rx_gain with user values instead of using calibrated rx_gain offsets 2022-01-14 10:19:08 +01:00
Ismael Gomez dcd94649ef enb,parser: add option to set a default tx gain per cell 2022-01-13 17:25:39 +01:00
faluco 1ec8e8a94e Raise C++ version to 14 and fix ill-formed code that is considered by this new standard. 2022-01-13 13:35:58 +00:00
Xavier Arteaga a19d68710c Fix successful related typos 2022-01-12 16:37:37 +01:00
Xavier Arteaga 2c7287e4d4 Fix successful related typos 2022-01-12 10:27:33 +01:00
Xavier Arteaga db19941985 Minor changes on UE SA PHY 2022-01-12 10:27:33 +01:00
Xavier Arteaga c494a84738 Fix ue_sync_nr_test 2022-01-12 10:27:33 +01:00
Xavier Arteaga 5e8e4b90c1 Fix memory access in SSB search and measure 2022-01-12 10:27:33 +01:00
Xavier Arteaga 5760080b27 Fix multiple nr_phy_test tests 2022-01-12 10:27:33 +01:00
Xavier Arteaga d6ee282796 Created dummy radio and moved UE dummy PHY into real UE SA PHY 2022-01-12 10:27:33 +01:00
Xavier Arteaga 3b396c8a9a Implement and test initial SFN synchronization for UE standalone mode 2022-01-12 10:27:33 +01:00
Xavier Arteaga 9e4e75bfda Parametrize UE SYNC NR test 2022-01-12 10:27:33 +01:00
Xavier Arteaga 5b744bb6c5 Increase SSB detection frequency range 2022-01-12 10:27:33 +01:00
Xavier Arteaga d4fd4c8350 Fix deadlock 2022-01-12 10:27:33 +01:00
Xavier Arteaga a5130673f6 More cell search development 2022-01-12 10:27:33 +01:00
Francisco b616207ef0 asn1: remove extra copy and template instantiation in unpacking of IE Containers 2022-01-11 22:59:38 +00:00
Francisco f7efee9884 asn1: use typedefs for amf_ue_ngap_id, ran_ue_ngap_id, mme_ue_s1ap_id and enb_ue_s1ap_id and changed interface to access s1ap and ngap protocol_ies 2022-01-11 22:59:38 +00:00
Francisco 26f173e582 asn1: use template to generate ngap/s1ap elementary procedure option and reduce code duplication 2022-01-11 22:59:38 +00:00
Francisco Paisana d5f5df3e7b asn1: place common asn1 type for empty ie object sets in asn1_utils.h 2022-01-11 22:59:38 +00:00
Francisco Paisana ec1ed9d4a5 asn1: fix json generation for s1ap/ngap and improve ie protocol field interface 2022-01-11 22:59:38 +00:00
Francisco Paisana 61e225d762 asn1: move setup_release_c from rrc_nr_asn1 to asn1_utils and improved interface 2022-01-11 22:59:38 +00:00
Francisco Paisana e2b8a80f87 asn1: move all ie protocol container types to asn1_tuils to be reused in different layers 2022-01-11 22:59:38 +00:00
Francisco Paisana 2d2a5bee03 asn1: update procotol_ie_single_container interface to use -> operator instead of .value to access container content 2022-01-11 22:59:38 +00:00
Francisco Paisana 6b181e7a94 asn1: move protocol_ie_single_container_s to asn1_utils, so it can be used by ngap, s1ap, and other layers 2022-01-11 22:59:38 +00:00
Francisco Paisana c8f7976014 asn1: use byte buffer pool for temporary variable length field generation instead of stack array 2022-01-11 22:59:38 +00:00
yagoda 615ae98a9d fixing regression bug - adding bsr_callback to mrb 2022-01-11 09:58:41 +01:00
Pedro Alvarez b0581ae5ae lib,rlc_am_nr: removed ugly hack to get last element of list. Renamed current_sdu to sdu_under_segmentation. 2022-01-10 23:25:44 +00:00
Pedro Alvarez e9a47ef7b1 lib,rlc_am_nr: added assert to make sure we never write over nof_bytes 2022-01-10 23:25:44 +00:00
Pedro Alvarez 33735852a4 lib,rlc_am_nr: remove unecessary ternary operator. 2022-01-10 23:25:44 +00:00
Pedro Alvarez bd8c7f7c57 lib,rlc_am_nr: added max_hdr and min_hdr variables, that are configured based on SN length. Replaced magic numbers with said variables. 2022-01-10 23:25:44 +00:00
Pedro Alvarez 19268281c8 lib,rlc_am_nr: reduced logging level of some messages to debug. 2022-01-10 23:25:44 +00:00
Pedro Alvarez 5532c514ba lib,rlc_am_nr: added logging macros to make sure that the RB name is allways logged. 2022-01-10 23:25:44 +00:00
Pedro Alvarez f60259afb9 lib,rlc_am_nr: fixed multiple typos and deleted useless comments 2022-01-10 23:25:44 +00:00
Pedro Alvarez 9e6b852834 lib,rlc_am_nr: Added handle_full_sdu() and handle_segment_sdu() functions. Reduced duplicate code in handling SDU segments. 2022-01-10 23:25:44 +00:00
Pedro Alvarez 8afea13d9a lib,rlc_am_nr: added initial logic to support receiving PDU segments. 2022-01-10 23:25:44 +00:00
Pedro Alvarez aae1d9ad10 lib,rlc_am_nr: changed rlc_amd_nr_tx_sdu to use std::list to store
segment infomation. Segment infomation incluses, SO and payload length.
2022-01-10 23:25:44 +00:00
Pedro Alvarez 76c33c78a9 lib,rlc_am_nr: starting to add test for segmentation. Starting to add functions for creating new segments and segment continuation. 2022-01-10 23:25:44 +00:00
Pedro Alvarez f544cc7f7e lib,rlc_am_nr: fixed issue introduced with the changes of the header packing. 2022-01-10 23:25:44 +00:00
Pedro Alvarez 40fab8fdb4 lib,rlc_am_nr: starting to add segmentation test 2022-01-10 23:25:44 +00:00
Pedro Alvarez 3e5b064a08 lib,rlc_am_nr: starting to add build_sdu_segment() function.
Also adding write_header function that receives as argument uint8_t* so
we can write the header straight to the payload.
2022-01-10 23:25:44 +00:00
Pedro Alvarez 72ba7503e5 lib,rlc_am_nr: make max tx queue size configurable. 2022-01-10 23:25:44 +00:00
Xavier Arteaga 6c4c1ea155 NR UE PHY: interfaced fix wideband CQI reporting in nr_phy_test 2022-01-10 18:50:53 +01:00
Carlo Galiotto d7e4018adf sched: remove unused function
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-06 20:32:20 +01:00
Carlo Galiotto b359c7b728 sched,nr: add comments and rename variables
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-06 20:32:20 +01:00
Carlo Galiotto 0f92869156 rrc,sched: add csi-MeasConfig setup in RRC
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-06 20:32:20 +01:00
Carlo Galiotto 9be9bd659e sched,nr: add CQI to SE and SE to MCS mapping ...
for scheduler + add CQi reporting from PHY to scheduler

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-06 20:32:20 +01:00
Carlo Galiotto 2040a88bf9 sched: add comments + rename variable
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-06 20:32:20 +01:00
Carlo Galiotto cd32f1385a sched,test: add test for CQI->MCS mapping fnc
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-06 20:32:20 +01:00
Carlo Galiotto a7255cfac6 sched: add fnc to map CQI to MCS
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2022-01-06 20:32:20 +01:00
Francisco Paisana 40138c7125 changed namespace of asn1 ngap from 'ngap_nr' to simply 'ngap' 2022-01-05 18:26:05 +01:00
Ismael Gomez 2d31e11144 ue,lte: update rx_gain_offset more frequently. Avoid calling UHD driver when getting rx_gain 2021-12-22 22:41:24 +01:00
Ismael Gomez 70d6e596f7 nr: add RAR ue_dl_nr_file test 2021-12-22 17:15:49 +01:00
Merlin Chlosta c967b688ff emergency handler for NAS PCAP to close file
Previously NAS PCAP wasn't closed/fflushed on
unclean exit, resulting in missing or corrupted PCAP.
2021-12-22 17:13:21 +01:00
Matan Perelman 0dff58613f srsUE: Add option to filter N_id_1 / SSS to configuration 2021-12-22 17:13:21 +01:00
Matan Perelman 5302f1b23c Sync: Fix incorrect log line 2021-12-22 17:13:21 +01:00
Robert Falkenberg 767d5390f9 benchmark_radio: don't join plot_thread if not requested 2021-12-20 10:15:32 +01:00
Fabian Eckermann 94c2967486 Return correct iterator value. 2021-12-17 17:30:25 +01:00
Francisco e8f6c723b6 refactor: isolate rrc interfaces for pdcp, rlc and s1ap into separate files. This will avoid importing lte asn1 symbols to srsgnb code 2021-12-15 23:25:26 +00:00
Francisco 632f2dbddd nr,gnb,sched: changed pdsch_allocator interface and extended its respective unit tests 2021-12-15 13:20:38 +00:00
joaquim-SRS 213769fa3d Fix stringop overflow error 2021-12-14 20:37:28 +01:00
Fabian Eckermann 6252d94ef4 Change NSA RRC reconfiguration interface to prepare for SA. 2021-12-14 18:00:49 +01:00
Fabian Eckermann 93210d9bb3 Add unit tests for new functions. 2021-12-14 18:00:49 +01:00
Fabian Eckermann affdacd9b4 Add decoding of sib1. 2021-12-14 18:00:49 +01:00
Fabian Eckermann 361054da12 Clarify error message. 2021-12-14 18:00:49 +01:00
Andre Puschmann 04d3e516af awgn_channel_test: fix memleak 2021-12-10 09:48:27 +01:00
Francisco c3d682bba8 nr,gnb,sched: cache ue phy dci_cfg to avoid computing it at every slot 2021-12-09 14:26:19 +00:00
Andre Puschmann fee0351dd3 Revert "Modify PUSCH power normalization"
This reverts commit a4b86e5a0a
which causes low UL throughput against Amarisoft (max MCS not achieved over RF).
See issue #3723.

We need to investigate this again and revert the revert.
2021-12-09 12:58:28 +01:00
Pedro Alvarez 57fc2470ad lib,rlc_am_lte: added some debug logging to t-PollRetranmission expiry and re-arming. 2021-12-09 11:30:59 +00:00
Pedro Alvarez ee4bf85209 lib,rlc_am_lte: check segment's polling requirements after updating the RETX queue. This makes sure that if the RETX and TX queues are empty after the last segment, polling is requested and the t-PollRetransmission is restarted 2021-12-09 11:30:59 +00:00
Pedro Alvarez 17d2eb0ea7 lib,rlc_am_lte: added unit test for t-pollRetransmssion re-arming when ACK/NACK is received. 2021-12-09 11:30:59 +00:00
Pedro Alvarez b425316936 lib,rlc_am_nr: fixed tx_mod_base_nr(). Added unit test for inside_tx_window(). 2021-12-07 16:46:26 +00:00
Pedro Alvarez ab8577ff43 lib,rlc_am_nr: switched back to unsigned rx_mod_base. Removed if that is always true. 2021-12-07 16:46:26 +00:00
Pedro Alvarez 3d5682b180 lib,rlc_am_nr: added unit tests to check inside_rx_window helper 2021-12-07 16:46:26 +00:00
Pedro Alvarez fea7828d3e lib,rlc_am_nr: added struct to hold state variables. This is consistent
with TX and makes it easier to make getter/setters.
2021-12-07 16:46:26 +00:00
Pedro Alvarez bca9ef2454 lib,rlc_am_nr: made mod_nr configurable 2021-12-07 16:46:26 +00:00
Pedro Alvarez 665aea599c lib,rlc_am_nr: made sure that the return of rx_mod_base and tx_mod_base is signed by changing from a macro to an class method. 2021-12-07 16:46:26 +00:00
Pedro Alvarez 4b69af7ca2 lib,rlc_am_nr: possible fix for ubuntu 16.04 compilation warning 2021-12-07 16:46:26 +00:00
Francisco 9a4a5345c4 nr,gnb,sched: improve sched sanity checks, and improve bwp_pdcch_allocator api 2021-12-07 12:30:39 +00:00
Ismael Gomez 9f1a1c297c
Merge pull request #3710 from softwareradiosystems/feature_nr_sa_igm
Initial version of UE NR SA
2021-12-03 19:54:20 +01:00
Ismael Gomez 3c929ed24c ue,sa: Sends PRACH and receives RAR, then Msg4, resolves contention resolution and pushes ConnectionSetup to RRC 2021-12-01 22:36:10 +01:00
Francisco 11b4a572a0 nr,gnb,rrc&ngap: implementation of NGAP UE Context Release Request and RRC Release for the case RRC_CONNECTED->RRC_IDLE 2021-12-01 18:54:33 +00:00
AlaiaL c2fd340cd4
build: building srsran_rf as shared library too
* Created shared library for srsran_rf
* Using an object to build static and shared library.
* Remove the instalation of the srsran_rf library
* Renaming library to srsran_rf_shared so the name becames clearer
2021-12-01 17:37:10 +01:00
Andre Puschmann 118a2a3bc2 awgn_channel_test: disable strict check for Gaussianity
this seems to cause issues with some platforms/compilers.
needs to be dissable until proper RNG is in place
2021-12-01 14:39:36 +01:00
Andre Puschmann f30059004b gtpu: remove warning when GTPU_EXT_HEADER_PDU_SESSION_CONTAINER is received 2021-12-01 14:25:17 +01:00
Ismael Gomez 46f4be458a ue,sa: can sync and receive pbch successfully 2021-12-01 10:18:27 +01:00
Ismael Gomez 219bae4fd3 srsue,sa: dummy rrc_nr to initiate dummy cell_select and phy_cfg 2021-11-30 14:45:26 +01:00
Ismael Gomez c71ab70b83 Completed basic sync module with bypass camping. Removed ue_phy_nr and ue_phy_lte base classes 2021-11-30 14:45:26 +01:00
Ismael Gomez 6947f87bcb Add minimum NR SA logic in parent PHY class 2021-11-30 14:45:26 +01:00
Ismael Gomez fb897d2998 Refactor PHY interfaces to remove difference between SA and NSA PHY 2021-11-30 14:45:26 +01:00
Ismael Gomez 58ab8086ff Added multi gNb simulation and RF 2021-11-30 14:45:26 +01:00
Xavier Arteaga f5446422bc UE NR SA interface expects PBCH message instead of spare fields 2021-11-30 14:45:26 +01:00
Xavier Arteaga fb17e3326f More development in UE NR SA cell search 2021-11-30 14:45:26 +01:00
Xavier Arteaga b1bcc1a8c0 Initial UE NR SA PHY classes 2021-11-30 14:45:26 +01:00
dvdgrgrtt 864cb14eec Fix some clang-tidy warnings 2021-11-29 15:25:34 +01:00
dvdgrgrtt 7752feb3c2 Fix typos 2021-11-29 15:25:34 +01:00
dvdgrgrtt a4b86e5a0a Modify PUSCH power normalization
The PUSCH signal was normalized to fix the maximum amplitude instead of
the transmitted power.
2021-11-29 15:25:34 +01:00
dvdgrgrtt 7d8c519865 Restore proper file mode
The file had been mistakenly given executable permissions.
2021-11-29 15:25:34 +01:00
dvdgrgrtt f95c654aba Minor change
Forgot to check for unsuccessful malloc.
2021-11-29 15:25:34 +01:00
dvdgrgrtt 32c4da8db0 Fix typos 2021-11-29 15:25:34 +01:00
dvdgrgrtt 081428aab8 Check for Gaussianity in AWGN unit test
Implements the Anderson-Darling test to check whether noise samples are
drawn from a Gaussian distribution.
2021-11-29 15:25:34 +01:00
dvdgrgrtt bae6f13c89 Introduce function srsran_vec_sc_sum_fff
This function adds a float scalar to all elements of a float vector.
2021-11-29 15:25:34 +01:00
Francisco b27c184d2f nr,gnb,stack: add bearer manager to gNB stack to correctly map between eps bearer ids and lcids 2021-11-26 20:33:47 +00:00
Pedro Alvarez 194fb4fabf lib,rlc_am_nr: stop status prohibit timer when a polling bit is received. 2021-11-26 16:25:53 +00:00
Pedro Alvarez a038c74cc0 Only run the status prohibit timer, if it has been set before. 2021-11-26 16:25:53 +00:00
Francisco 71c0d69461 nr,gnb,phy: fix dci padding for the case of common search space type1 2021-11-26 12:34:41 +00:00
Pedro Alvarez f9a2850d74 gnb,ngap: Added interface so the NGAP can pass a NAS message to the RRC
upon starting the RRC Security Mode command. This allows the gNB to
pass this message only after the SM procedure is complete.

Also made sure that the RRC notifies the NGAP upon the end of the
reconfiguration procedure, to make sure that the NGAP sends the UE
context setup response.
2021-11-25 19:03:30 +00:00
Pedro Alvarez 942c75ae80 gnb,rrc_nr: move location of creation of nr srb PDCP configs to rrc_nr_utils.cc 2021-11-25 19:03:30 +00:00
Pedro Alvarez 14170bbba2 lib,rrc_nr: made separate function to create default PDCP SRB configs 2021-11-25 19:03:30 +00:00
Pedro Alvarez 3296ee679c lib,pdcp_entity_lte: removed check for having SRBs only for 5bits SNlen. This was required for re-using the entity in NR. 2021-11-25 17:45:05 +00:00
Pedro Alvarez c69b221293 gnb,rrc_nr: move location of creation of nr srb PDCP configs to rrc_nr_utils.cc 2021-11-25 17:45:05 +00:00
Pedro Alvarez 9b622b3bff lib,rrc_nr: made separate function to create default PDCP SRB configs 2021-11-25 17:45:05 +00:00
Francisco 3bd77befd3 nr,gnb,asn1: update asn1 rrc nr unit test 2021-11-25 16:49:50 +00:00
Francisco 6df8b6bb9e nr,gnb,sched: account for CORESET RB offset in the DCI RB indexing in case of common search spaces 2021-11-25 15:14:18 +00:00
Pedro Alvarez 90ed04afd1 Fix unitialized header warning on rlc_amd_tx_pdu for ARM. 2021-11-24 21:23:23 +00:00
Andre Puschmann f959c8c14a rlc_tm: remove warning when PDU can't be read
MAC will call read_pdu() until RLC doesn't have any more data to send.
don't log a warning in this case.
2021-11-24 12:10:17 +01:00
Andre Puschmann 8ddc344cdb gnb,mac: rework DL MAC PDU packing and add ConRes handling
* store Msg3 when UL-CCCH is received
* add ConRes CE in DL-SCH when indicated by scheduler
* remove fixed LCID for packing SDUs
2021-11-24 12:10:17 +01:00
Andre Puschmann 059a747081 mac_sch_pdu_nr: fix pretty-priting of CCCH 2021-11-24 12:10:17 +01:00
Andre Puschmann 97997b6d0b buffer_pool: add helper to build byte_buffer from raw payload+len 2021-11-24 12:10:17 +01:00
Pedro Alvarez dface7e4af lib,rlc_am_nr: make sure header is initialized. 2021-11-23 20:29:02 +00:00
Pedro Alvarez 2fad9ded01 Make sure that the pcap is started before NGAP init, so that the NGSetupRequest is caught 2021-11-23 17:12:53 +00:00
Pedro Alvarez 5e22e42762 Added option to save NGAP pcaps. 2021-11-23 17:12:53 +00:00
Francisco ffc1ea5c86 nr,gnb,phy: decoupled gnb and enb phy config structs by moving them to separate files 2021-11-23 10:56:38 +00:00
Pedro Alvarez 7460a9db69 lib,rlc_am_nr: check whether we exced nof_bytes in retx. changed build_retx_pdu API to receive unique_byte_buffer by ref. 2021-11-22 17:42:52 +00:00
Pedro Alvarez 1ca9804d84 lib,rlc_am_nr: make sure the return of make_byte_buffer() is checked 2021-11-22 17:42:52 +00:00
Pedro Alvarez e3b95ef131 lib,rlc_am_nr: remove unused structure 2021-11-22 17:42:52 +00:00
Pedro Alvarez 47340f37a2 lib,rlc_am_nr: fix TS version in comments 2021-11-22 17:42:52 +00:00
Pedro Alvarez b497d773ce lib,rlc_am_nr: Fixed some metrics calculation. Added more precise metrics checking to unit tests 2021-11-22 17:42:52 +00:00
Pedro Alvarez 5eaa56e6ba lib,rlc_am_nr: fix processing of ACKs 2021-11-22 17:42:52 +00:00
Pedro Alvarez b794593469 lib,rlc_am_nr: added processing of ACKs from status report 2021-11-22 17:42:52 +00:00
Pedro Alvarez ec93cc7238 rlc_am_nr: added logic to retx NACK'ed PDU. 2021-11-22 17:42:52 +00:00
Pedro Alvarez 473a45aae0 rlc_am_nr: fix buffer status calculation for retxs 2021-11-22 17:42:52 +00:00
Pedro Alvarez 63657ddfe6 Moved retx queue to rlc_am_data_structs, to enable it being re-used in RLC AM NR 2021-11-22 17:42:52 +00:00
Pedro Alvarez 4e1c713c14 rlc_am_nr: Enabled sending NACKs on status PDUs
- Added some logic to only poll when PDU_WITHOUT_POLL > PollPDU
  - Fixed initalization of t-Reassembly
  - Fixed a bug in the packing of the status buffer.
Nacks now work for a single lost PDU.
2021-11-22 17:42:52 +00:00
Pedro Alvarez 25492de6b7 Stating to add PollPDU 2021-11-22 17:42:52 +00:00
Pedro Alvarez a8453d644a Make sure t-reassembly triggers the status report 2021-11-22 17:42:52 +00:00
Pedro Alvarez 4c02407d3e Change the update of rx_next and rx_highest_status. 2021-11-22 17:42:52 +00:00
Pedro Alvarez 3f000f0472 Adding t_reassembly to RLC AM NR 2021-11-22 17:42:52 +00:00
Pedro Alvarez f09020e57f Adding unit test for lost SDUs. Fixing way rx_next and rx_status_highest are updated. 2021-11-22 17:42:52 +00:00
Francisco cc89b1607f nr,gnb,rrc: fix RRC setup to avoid configuring the SRB1 twice 2021-11-22 17:06:26 +00:00
Andre Puschmann afd417c96e mac_pdu_nr_test: add TC for MAC CON RES CE 2021-11-22 15:16:12 +01:00
Andre Puschmann 062cba5bd5 mac_sch_pdu_nr: add support for contention resolution CE 2021-11-22 15:16:12 +01:00
Andre Puschmann 4dcbc70131 mac,packing: move test code to source folder 2021-11-22 15:16:12 +01:00
Pedro Alvarez c0d2e8c11d gNB NR security context:
- changed variables to use nia/nea instead of eia/eea.
  - make rrc_nr_cfg a ref
  - Changed NR ciphering/integrity algo enums to their own enum
2021-11-19 18:24:03 +00:00
Pedro Alvarez 37f8dba4ac Make sure rlc_am_nr_header_t is initialized. 2021-11-19 16:05:03 +00:00
Andre Puschmann 85f7313f83 mac_pdu_nr_test: add TC for UL-SCH PDU with CCCH 48bits 2021-11-18 21:02:32 +01:00
Fabian Eckermann 8bac4eceda Add ue MAC procedures for PDCCH orders. 2021-11-18 14:56:31 +01:00
Fabian Eckermann f228491e1d Add test for pdcch order (un)packing. 2021-11-18 14:56:31 +01:00
Fabian Eckermann d0c07fc86e Add packing of dci format 1A for pdcch orders. 2021-11-18 14:56:31 +01:00
Francisco b35584ae70 nr,gnb,rrc: add code to add/mod/release bearers during rrc setup and reconfiguration 2021-11-17 18:07:41 +00:00
Pedro Alvarez c4f7e95e58 lib,rlc_am_nr: Make sure BSR callback is called 2021-11-17 10:50:35 +00:00
Pedro Alvarez ca13b6f3c4 Remove duplicate calculation of status report bytes 2021-11-17 10:50:35 +00:00
Pedro Alvarez 9e4631ee24 Added NR specific config struct for RLC AM. Added status prohibit timer. 2021-11-17 10:50:35 +00:00
Pedro Alvarez 5e8ab48c25 Wrote some logic to write SDU to PDCP 2021-11-17 10:50:35 +00:00
Pedro Alvarez 78d5ed1bc8 Fix get buffer state when status report is required 2021-11-17 10:50:35 +00:00
Pedro Alvarez a1c57eb473 Made sure that we don't try to read from empty queue. Modified some logging. 2021-11-17 10:50:35 +00:00
Pedro Alvarez 8ff545c423 Added RLC AM NR config structure. Added helpers to create RLC AM NR configs. Made it possible to create RLC AM NR entites in rlc.cc 2021-11-17 10:50:35 +00:00
Pedro Alvarez 1f8d0ab557 Fix generation of status report. 2021-11-17 10:50:35 +00:00
Pedro Alvarez 8ae4d379aa RLC AM NR: Added some logging functions to better debug the state and the received headers. Added initial handling of data pdu. Updating rx_next and rx_status_highest now. 2021-11-17 10:50:35 +00:00
Pedro Alvarez 2d29e4005c Starting to generate RLC NR status report.
Starting to check if status pdu generation is correct.
2021-11-17 10:50:35 +00:00
Pedro Alvarez be9bb344a4 Starting to add handle_data_pdu to RLC NR entity. 2021-11-17 10:50:35 +00:00
Pedro Alvarez 7121152cff Added basic functionality for read_pdu to RLC AM NR entity. 2021-11-17 10:50:35 +00:00
Pedro Alvarez 4196abafee Added get_buffer_status to RLC AM NR entity 2021-11-17 10:50:35 +00:00
Ismael Gomez ebeb46b230 nr,pdcch_dmrs: take into account offset_rb in DMRS mapping 2021-11-17 10:28:31 +01:00
Francisco a58420a530 nr,gnb,rrc: implement basic NR RRC bearer addition and reconf message sending 2021-11-16 19:32:53 +00:00
Francisco 0c733f7ea3 nr,ngap: use const_byte_spans instead of unique_byte_buffers in ngap interface to avoid intermediate copies 2021-11-16 19:32:53 +00:00
Francisco e8beb2ef81 nr,rrc: redesign fetching of asn1 obj ids for comparison and addmod/rem to asn1 lists 2021-11-16 19:04:51 +00:00
Francisco 3b3630d444 nr,gnb,rrc: remove redundant code, and update rrc_nr_test to use default rrc nr cfg generator 2021-11-16 17:17:53 +01:00
Francisco f705445f21 nr,gnb,rrc: use rrc_nr_cfg to generate sib1 and mib 2021-11-16 17:17:53 +01:00
faluco 453a7760b3 Port misc SSN changes to dev. 2021-11-16 14:46:51 +01:00
Andre Puschmann 0ee82ed0f6 ue_dl_nr_file_test: add option to select ue specific search space
* add option to select search space: ue and common1
* print coreset info
2021-11-16 12:57:20 +01:00
Andre Puschmann b7f9dd5d75 phy_common_nr: add helper method to print coreset info to string 2021-11-16 12:57:20 +01:00
Francisco 5a3e99fb58 nr,gnb,rrc: fix missing return for mib generation 2021-11-16 00:12:36 +00:00
Francisco 25a8ea53d3 nr,gnb,sched: pass mib config to scheduler so it is used during SSB allocation 2021-11-16 00:12:36 +00:00
Francisco fec97689a2 rrc,nr,gnb: refactored rrc nr cfg default and derived param generation to be mostly independent of parser 2021-11-16 00:12:36 +00:00
Francisco f2a5f00bb3 nr,gnb: fix abs freq ssb arfcn derivation 2021-11-15 15:47:31 +01:00
Francisco 0b8a6970f0 nr,gnb,rrc: fix ssb frequency derivation when coreset0 is active 2021-11-15 15:47:31 +01:00
Francisco 92c4e6e2d0 nr,gnb: account for CORESET#0 RB offset (See 38.213, table 13-1) in computation of SSB center frequency 2021-11-15 15:47:31 +01:00
Ismael Gomez 4836e90b2c Move place to apply reference_point_k_rb to dmrs 2021-11-15 09:50:39 +01:00
Andre Puschmann 883ddef4a6 ue_dl_nr_file_test: fix compilation on gcc 4.8 2021-11-15 09:50:39 +01:00
Andre Puschmann 66871b1e8e ue_dl_nr_file_test: disable failing file tests temporarily
they will be enabled again as soon as the decoding issues are solved
2021-11-15 09:50:39 +01:00
Ismael Gomez 798e9b7a5e ue_dl: reference point for DMRS varies for SIB 2021-11-15 09:50:39 +01:00
Ismael Gomez e7c2cea032 Fix data conversion parse in ue_dl_nr_file_test 2021-11-15 09:50:39 +01:00
Andre Puschmann 9c6f9f5949 dci_nr: print coreset0_bw when DCI is scrambled with SI-RNTI 2021-11-15 09:50:39 +01:00
Andre Puschmann d5a00fcdad dci_nr_test: add test for DCI 1_0 with SI-RNTI 2021-11-15 09:50:39 +01:00
Andre Puschmann 573b2f657a ssb_file_test: make duplex and SSB SCS configurable, add new unit test for FDD+15kHz SCS 2021-11-15 09:50:39 +01:00
Andre Puschmann dd34f5b274 ue_dl_nr_file_test: fix coreset0 bandwidth when decoding SI-RNTI 2021-11-15 09:50:39 +01:00
Andre Puschmann 972e080e48 ue_dl_nr_file_test: update SSB/SIB TV
update capture and make sure its rv=0

// Cell 0x01: nr_arfcn=368500 ul_nr_arfcn=349500 pci=500 mode=FDD rat=nr n_rb_dl=52 n_rb_ul=52 dl_mu=0 ul_mu=0 ssb_mu=0 ssb_arfcn=368410 ssb_prb=13:21 k_ssb=6 coreset0_prb=1:48 coreset0_idx=6
20:43:31.997 [PHY] DL    - 01 ffff   784.0 PDSCH: harq=si prb=1:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=0 cr=0.44
        0000:  74 81 01 70 10 40 04 02  00 00 c8 00 24 68 a0 38  t..p.@......$h.8
        0010:  05 01 00 40 1a 00 00 06  6c 6d 92 21 f3 70 40 20  ...@....lm.!.p@
        0020:  00 00 80 80 00 41 06 80  a0 90 9c 20 08 55 19 40  .....A..... .U.@
        0030:  00 00 33 a1 c6 d9 22 40  10 00 1e b8 94 63 c0 09  ..3..."@.....c..
        0040:  28 c4 1b 8a 36 e1 5b 1c  3a 01 3c 5b 46 14 00 00  (...6.[.:.<[F...
        0050:  00 00 00 00                                       ....
20:43:31.997 [PHY] DL    - 01 ffff   784.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
	rb_alloc=0x120
	time_domain_rsc=0
	vrb_to_prb_map=0
	mcs=6
	rv_idx=0
	si_indicator=0
	dci_len=39
2021-11-15 09:50:39 +01:00
Andre Puschmann 7a64163aa4 ue_dl_nr_file_test: enable coreset0_idx=6 file test 2021-11-15 09:50:39 +01:00
Andre Puschmann 16b5f4c3db ue_dl_nr_file_test: add further IQ capture with coreset0_idx=6
Cell 0x01: nr_arfcn=368500 ul_nr_arfcn=349500 pci=500 mode=FDD rat=nr n_rb_dl=52 n_rb_ul=52 dl_mu=0 ul_mu=0 ssb_mu=0 ssb_arfcn=368410 ssb_prb=13:21 k_ssb=6 coreset0_prb=1:48 coreset0_idx=6
12:58:46.197 [PHY] DL    - 01 ffff   556.0 PDSCH: harq=si prb=1:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=2 cr=0.44
        0000:  74 81 01 70 10 40 04 02  00 00 c8 00 24 68 a0 38  t..p.@......$h.8
        0010:  05 01 00 40 1a 00 00 06  6c 6d 92 21 f3 70 40 20  ...@....lm.!.p@
        0020:  00 00 80 80 00 41 06 80  a0 90 9c 20 08 55 19 40  .....A..... .U.@
        0030:  00 00 33 a1 c6 d9 22 40  10 00 1e b8 94 63 c0 09  ..3..."@.....c..
        0040:  28 c4 1b 8a 36 e1 5b 1c  3a 01 3c 5b 46 14 00 00  (...6.[.:.<[F...
        0050:  00 00 00 00                                       ....
12:58:46.197 [PHY] DL    - 01 ffff   556.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
	rb_alloc=0x120
	time_domain_rsc=0
	vrb_to_prb_map=0
	mcs=6
	rv_idx=2
	si_indicator=0
	dci_len=39
2021-11-15 09:50:39 +01:00
Andre Puschmann d2fc11fbec ue_dl_nr_file_test: add missing parameter to existing file tests 2021-11-15 09:50:39 +01:00
Andre Puschmann 830cbcde08 ue_dl_nr_file_test: add all zero PDSCH check and let test fail in this case 2021-11-15 09:50:39 +01:00
Andre Puschmann 77269c055d ue_dl_nr_file_test: expose ARFCN for center and SSB and use it to derive RB offset 2021-11-15 09:50:39 +01:00
Andre Puschmann 1684c56ca0 phy: add two IQ dumps with coreset0 and coreset1
coreset0:
15:03:16.697 [PHY] DL    - 01 ffff    86.0 PDSCH: harq=si prb=2:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=1 cr=0.44
        0000:  74 81 01 70 10 40 04 02  00 00 c8 00 24 68 a0 38  t..p.@......$h.8
        0010:  05 01 02 60 24 00 00 06  6c 6d 92 21 f3 70 40 20  ...`$...lm.!.p@
        0020:  00 00 80 80 00 41 06 80  a0 90 9c 20 4c 29 21 00  .....A..... L)!.
        0030:  00 00 33 a1 c6 d9 22 40  10 00 1e b8 94 63 c0 09  ..3..."@.....c..
        0040:  28 c4 1b 8a 36 fd 5b 1c  3a 00 bc 5b 46 14 00 00  (...6.[.:..[F...
        0050:  00 00 00 00                                       ....
15:03:16.697 [PHY] DL    - 01 ffff    86.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
	rb_alloc=0x120
	time_domain_rsc=0
	vrb_to_prb_map=0
	mcs=6
	rv_idx=1
	si_indicator=0
	dci_len=39

coreset1:

15:03:16.693 [PHY] DL 0001 01 0100    85.6 PDCCH: ss_id=1 cce_index=0 al=4 dci=1_0
	rb_alloc=0x5f
	time_domain_rsc=0
	vrb_to_prb_map=0
	mcs=6
	ndi=1
	rv_idx=0
	harq_process=0
	dai=0
	tpc_command=1
	pucch_rsc=0
	harq_feedback_timing=3
	dci_len=39
15:03:16.693 [PHY] DL 0001 01 0100    85.6 PDSCH: harq=0 prb=2:48 symb=1:13 k1=4 CW0: tb_len=624 mod=2 rv_idx=0 cr=0.44 retx=0
        0000:  43 02 6d 40 00 80 00 00  d6 5b 77 92 be 29 a1 5c  C.m@.....[w..).\
        0010:  9d d9 a3 42 64 bf d7 c0  cc 20 a6 4f b3 5e f5 06  ...Bd.... .O.^..
        0020:  5f fc 03 02 83 ca e9 ee  04 e7 1a 1d 00 3f 9c 01  _............?..
        0030:  ec 1c 32 bb 6b 0f e2 e9  dc 7c f6 84 41 b2 2b e8  ..2.k....|..A.+.
        0040:  10 f0 23 2c 91 f1 5d c7  6f b5 6e ac b6 fb c2 e6  ..#,..].o.n.....
        0050:  32 2d b2 8b 07 36 11 f3  81 78 5d ff 1a 85 8d 6c  2-...6...x]....l
        0060:  18 ce ca 52 1f 81 0f 78  c6 1a ab b5 e8 71 50 34  ...R...x.....qP4
2021-11-15 09:50:39 +01:00
Andre Puschmann 8c99d7a3bd ue_dl_nr_file_test: use common helper function to derive coreset0 params 2021-11-15 09:50:39 +01:00
Andre Puschmann 279d82aa31 ue_dl_nr: debug to print PDCCH received symbols 2021-11-15 09:50:39 +01:00
Andre Puschmann 36a287edd8 ue_dl_nr_file_test: expose various coreset and search space related parameters 2021-11-15 09:50:39 +01:00
Andre Puschmann f708635a5d rrc_nr_cfg: set default PLMN for NR cell to 00101 2021-11-15 09:50:39 +01:00
Andre Puschmann 779bfcf791 phy_common: fix symbol size derivation for NR-only cells
make sure that 52 PRB cell with LTE rates gives 15.36e6 as sample rate
2021-11-15 09:50:39 +01:00
Andre Puschmann 853d870c52 rlc_um_nr: fix SN wrap-around in a few places 2021-11-14 16:25:09 +01:00
Andre Puschmann 813adb9567 rlc_um_nr: reduce verbosity in info mode
this will only print the most relevant messages in info mode.
also streamlines some messages with RLC AM entity.
2021-11-14 16:25:09 +01:00
Andre Puschmann 1bec07a64a rlc_um_nr: fix starting/stopping of reassemble timer 2021-11-14 16:25:09 +01:00
Andre Puschmann b3c7eeedd3 rlc_um_nr_test: add extra check to verify reassembly timer isn't running 2021-11-14 16:25:09 +01:00
Andre Puschmann 4187be3ff9 Revert "Revert "rlc_um_nr: reimplement update of RX_Next_Reassembly""
This reverts commit 296758e4ab.
2021-11-14 16:25:09 +01:00
Andre Puschmann 7141fda69c Revert "rlc_um_nr_test: disable test9 until low TCP UL rates are understood/fixed"
This reverts commit e491aef74e.
2021-11-14 16:25:09 +01:00
Pedro Alvarez f99d6bc224 lib,rlc: changed get_bearer() to get_lcid(). 2021-11-12 22:41:37 +00:00
Pedro Alvarez 3b150e26cb rlc_am_nr: Changed header_t to HeaderType typename in RLC data structs.
Fix issue in clear_pdcp_sdu()
2021-11-12 22:41:37 +00:00
Pedro Alvarez 123ac16653 rlc_am_nr: fixed issue with pointers from rx entity to tx entity 2021-11-12 22:41:37 +00:00
Pedro Alvarez f99e841421 Changed using a rlc_am_lte and rlc_am_nr entity, to a single rlc_am entity. 2021-11-12 22:41:37 +00:00
Pedro Alvarez eefedcfccd rlc_am_nr: renamed rlc_am_base to just rlc_am 2021-11-12 22:41:37 +00:00
Pedro Alvarez aef87d5366 rlc_am_nr: Change rlc_am_base to use unique_ptr to hold rx/tx entities 2021-11-12 22:41:37 +00:00
Pedro Alvarez 779eda98bd Temporarly silence unused variable warnings. 2021-11-12 22:41:37 +00:00
Pedro Alvarez e780eb5ab0 Fixed missing TM and RLC AM NR in mem_pool 2021-11-12 22:41:37 +00:00
Pedro Alvarez debb4a0c6b Refactored RLC AM segment pool for re-use in both LTE and NR
Moved RLC AMD PDU definitions from rlc_am_lte.h to rlc_common.h to make them re-usable in both RLC LTE and RLC NR
2021-11-12 22:41:37 +00:00
Pedro Alvarez 54be15e7a6 Moved write pdu to rlc_am_base::rlc_am_base_rx 2021-11-12 22:41:37 +00:00
Pedro Alvarez 476f9e1156 Changed logger initialization in RLC AM entities 2021-11-12 22:41:37 +00:00
Pedro Alvarez 022c51493b Refactored RLC AM NR/LTE Rx and Tx entities to use a rlc_am_base_rx/tx class.
This was done to make it easier to share entity specific code between LTE and NR.
This removes the previously used templates.
2021-11-12 22:41:37 +00:00
Pedro Alvarez b15f63f32f Added an RLC AM base class to avoid code duplication in the RLC AM NR entity.
This class is based on a template that receives as argument the
rlc_am_*_tx/rx entities, so that those are different for LTE and NR.

Moved code from rlc_am_lte/nr entities so that they use the new base class.
2021-11-12 22:41:37 +00:00
Pedro Alvarez e65bcd7147 Changed default max S1 Setup retries to infinity 2021-11-12 15:09:39 +00:00
Pedro Alvarez e5a83474cc Added max_s1_setup retries option to S1AP 2021-11-12 15:09:39 +00:00
Pedro Alvarez 930e3699d0 Added max_s1_retries parameter 2021-11-12 15:09:39 +00:00
Francisco 83c1fb65d7 nr,gnb,rrc: add rrc nr message handler and send functions to establish an SA RRC connection 2021-11-12 14:46:44 +00:00
Robert Falkenberg 02f261c0a9 rf: build srsran_rf as static library
For Ubuntu 18.04: Linking the static srsran_rf to libuhd
also requires to link Boost's "system" library.

Newer systems do not require this special handling.
2021-11-12 15:33:58 +01:00
Andre Puschmann 085d561f65 skiq: allow running without root permissions
do what the comment says, when thread can't be created with privelages,
try to create it without them.
2021-11-12 15:33:36 +01:00
Francisco 16753a006a nr,gnb,rrc: add test logger delimiter; handle rrc setup complete 2021-11-11 10:55:35 +00:00
Ismael Gomez 360f718a5e Add PHY resource allocation calculation for SIB common 0 search space 2021-11-08 14:36:45 +00:00
Francisco 9734f2e393 adt: fix optional_vector ctor, and add emplace method 2021-11-05 16:13:09 +00:00
Andre Puschmann 0967cda042 gnb,stack: move gNB components into own folder
* move RRC, MAC, NGAP, SDAP into gnb folder
* move testing code below respective layers
2021-11-05 15:26:06 +01:00
Andre Puschmann 951fea5f61 bearer_manager,rlc: reduce log level of message to warning level
relevant for the UE when it receives 2nd reconfiguration it could
be that the bearers are added again. in this case the handling is fine
and everything will work as expected. No reason to log error.
2021-11-05 15:26:06 +01:00
Francisco 5f3afffd05 nr,gnb: implementation of sib and mib asn1 generation functions 2021-11-04 18:05:14 +00:00
Francisco 96fd3aae3c nr,gnb: small gnb interface refactors and fix of byte buffer operator= 2021-11-04 18:05:14 +00:00
Pedro Alvarez 2a5d21164f Adding RLC AM NR unit tests 2021-11-04 16:12:07 +00:00
Pedro Alvarez d528d8af4c Added initial skeleton for RLC AM NR entity 2021-11-04 16:12:07 +00:00
Pedro Alvarez 2bb249bf09 Moved RLC AM LTE and NR packing functions to their own file. 2021-11-04 16:12:07 +00:00
Pedro Alvarez f93d428e49 Moved RLC AM data structures to their own file 2021-11-04 16:12:07 +00:00
Francisco 7e7f7b4c01 nr: fix failing unit tests 2021-11-04 15:24:57 +00:00
Ismael Gomez fa600ebda1 update sampling rate calculation from prb for nr 2021-11-04 15:24:57 +00:00
Francisco dab6e8bdcd nr,gnb: updates in parsing and phy files to allow the splitting of NR and LTE stacks 2021-11-04 15:24:57 +00:00
Andre Puschmann 1ead159f3f backward: make signalhandler object static
having the sh a normal stack variable made the backtrace disappear
in some runs.
2021-11-04 14:53:41 +01:00
Andre Puschmann b44372faae crash_handler: write backtrace to stderr instead of backtrace file
the backtrace file is hard to collect in some environment but the stdout
and stderr is usually captured by default.
2021-11-04 14:53:41 +01:00
Francisco 8d719db43d nr,gnb,mac: implement zero-copy get_dl_sched/get_ul_sched NR scheduler interface 2021-11-03 21:21:45 +01:00
Carlo Galiotto ba50bbfb76 rlc,rrc,nr: remove rb_type from rlc_um_config
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
Carlo Galiotto 9c2099f680 rrc,rlc,nr: fix RB label in RLC-NR for UE logs + ..
add rb_type in rlc_um_config

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
Carlo Galiotto d95c31d2de rlc,rrc,nr: fix rlc bearer string diplayed in logs
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
faluco 90d21f8426 Fix invalid log line formatting. 2021-11-03 16:51:33 +01:00
Andre Puschmann 0bf2674d22 bearer_manager: reduce log level for clean/delete operations
this was causing errors in logs that aren't severe. the operations
are called when removing a UE regardless whether a bearer has been
created or not
2021-11-03 16:20:16 +01:00
Francisco f6e1ecdaf3 nr,gnb,mac: remove redundant checks and unused lcid enum constants 2021-11-03 13:31:16 +00:00
Francisco c615df9d1d nr,gnb,mac: prioritize CRNTI CE handling over remaining SDUs and CEs in gNB mac receiver 2021-11-03 13:31:16 +00:00
Francisco 4286ab81d9 nr,gnb,mac: fix const-correctness of some methods of class srsran::mac_sch_pdu_nr 2021-11-03 13:31:16 +00:00
faluco 74456bf3d2 Whitelist a reported deadlock involving read lock. 2021-10-29 12:45:47 +02:00
Francisco dfc2ea0a3e nr,gnb,pdcp: extend the use of local rb_name member to pdcp nr 2021-10-28 21:21:46 +01:00
Francisco c64be663d2 nr,gnb,pdcp: store the PDCP RB name in base class for easier use 2021-10-28 21:21:46 +01:00
Francisco 3c18e7c1f3 lte,enb,pdcp: fix addition of DRB logging in PDCP 2021-10-28 21:21:46 +01:00
Francisco 5b8d4c39af pdcp,lte: fix drb/srb id logging to account for dynamic mapping 2021-10-28 21:21:46 +01:00
Andre Puschmann e491aef74e rlc_um_nr_test: disable test9 until low TCP UL rates are understood/fixed 2021-10-28 19:09:35 +02:00
Andre Puschmann 296758e4ab Revert "rlc_um_nr: reimplement update of RX_Next_Reassembly"
This reverts commit 5b025cfbf8.
2021-10-28 19:09:35 +02:00
Andre Puschmann 229b1eef21 radio,test: fix Coverity warning about dead code
add default in switch instead of using the the END state directly
that is checked before entering the switch. Coverity correctly
reports this as dead code.
2021-10-28 17:25:21 +02:00
Ismael Gomez 8a53a9d35c ssb_decode_test: Fix stack overflow pbch_msg buffer 2021-10-28 16:13:02 +02:00
Andre Puschmann 6d0aafcf69 rlc_um_nr: fix has_missing_byte_segment() routine
return true if rx_window contains segment of this SN
2021-10-27 19:50:35 +02:00
Andre Puschmann 5b025cfbf8 rlc_um_nr: reimplement update of RX_Next_Reassembly 2021-10-27 19:50:35 +02:00
Andre Puschmann 2366dc286d rlc_um_nr: improve logging 2021-10-27 19:50:35 +02:00
Andre Puschmann 85e478d8ad rlc_um_nr_test: add TC to reproduce reassembly issue
* add TC to reproduce reassembly issue that causes low TCP throughput
* fix PCAP writing
* fix other testcase to wait for t_reassembly to expire
2021-10-27 19:50:35 +02:00
Alejandro Leal Conejos ca7a377878 Fixes coverity 262740 2021-10-27 19:47:45 +02:00
Alejandro Leal Conejos 4bd8b6f2de Fixes coverity 359677 2021-10-27 19:47:45 +02:00
Bedran Karakoc a14cc451d0 Addition NGAP cleanup 2021-10-27 19:37:49 +02:00
Andre Puschmann 7f6801cb1e ue_sync: fix 32bit compilation
fix printf format string on 32bit arches like ARMv7

FAILED: lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o
/usr/bin/gcc -DASSERTS_ENABLED -DENABLE_TIMEPROF -DENABLE_TTCN3 -DHAVE_BACKWARD -DHAVE_MBEDTLS -DHAVE_PCSC -I/usr/include/PCSC -I/usr/include/SoapySDR -Ilib/include -I../lib/include -Wno-unused-but-set-variable -Wall -Wno-comment -Wno-write-strings -Wno-unused-result -Wformat -Wmissing-field-initializers -Wtype-limits -std=c99 -fno-strict-aliasing -D_GNU_SOURCE -O3 -fno-trapping-math -fno-math-errno -DBUILD_TYPE_RELEASE -DIS_ARM -DHAVE_NEON -mfloat-abi=hard -mfpu=neon -fvisibility=hidden -fdiagnostics-color=always -Werror --param large-function-growth=1600 -O3 -DNDEBUG -fPIC -MD -MT lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o -MF lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o.d -o lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o   -c ../lib/src/phy/ue/ue_sync.c
In file included from ../lib/include/srsran/srsran.h:31,
                 from ../lib/src/phy/ue/ue_sync.c:13:
../lib/src/phy/ue/ue_sync.c: In function ‘srsran_ue_sync_set_tti_from_timestamp’:
../lib/include/srsran/phy/utils/debug.h:59:23: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=]
       fprintf(stdout, "[DEBUG]: " _fmt "\n", ##__VA_ARGS__);                                                           \
                       ^~~~~~~~~~~
../lib/src/phy/ue/ue_sync.c:1044:3: note: in expansion of macro ‘DEBUG’
   DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
   ^~~~~
../lib/src/phy/ue/ue_sync.c:1044:41: note: format string is defined here
   DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
                                       ~~^
                                       %llu
cc1: all warnings being treated as errors
2021-10-27 18:03:03 +02:00
joaquim-SRS 00b82bc772 Fix more issues in PHY lib
Fix variable shadowing issues in chest_test
Fix mutex unlock position in dft_fftw.c
CID 371598 Out of bounds access, in ssb_decode_test.c
2021-10-27 18:02:00 +02:00
joaquim-SRS 9b74e3429c Fix more Coverity issues in the PHY lib
CID 369560 Missing unlock, in dft_fftw.c
CID 363710 Logically dead code, in resampler.c
CID 55097 Result is not floating point, in chest_test_dl.c
CID 351020 Result is not floating point, in chest_nbiot_test_dl.c
2021-10-27 18:02:00 +02:00
Nils Fürste b036da07de Extend ASN1 utils function from_number() 2021-10-27 17:53:28 +02:00
Fabian Eckermann 0007473c7a Initialize variable. 2021-10-27 17:39:51 +02:00
Fabian Eckermann f539851128 Fix possible out-of-bounds-read. 2021-10-27 17:39:51 +02:00
Fabian Eckermann 1b2d77a49d Fix possible out-of-bounds-read. 2021-10-27 17:39:51 +02:00
Fabian Eckermann 8753ea1be5 Fix coverty defects. 2021-10-27 17:39:51 +02:00
Carlo Galiotto 9c74dda039 rrc,nr: add msg5 and inactivity timers to RRC-NR
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-26 23:18:17 +02:00
faluco edf0926a2f Batch of LGTM fixes. 2021-10-26 21:49:17 +02:00
Francisco 529e2bdf55 nr,rlc: call bsr update callback in RLC UM NR 2021-10-26 21:44:59 +02:00
Francisco 7ad1ad800e lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB 2021-10-26 21:44:59 +02:00
Ismael Gomez d972fb368c
Some LGTM fixes (#3564)
* Fix LGTM issues

* ue: add logging to switch on function

* Fix new LGTM issues
2021-10-26 21:15:36 +02:00
Joaquim 93649429dd
WIP: Fix Coverity issues in PHY lib (#3507)
Fix several Coverity issues

This commit adrresses the following code issues found by Coverity:

CID 339785 Division by zero, in fading_channel_test.c
CID 355272 Division by zero, in awgn_channel_test.c
CID 355277 NULL ptr dereference, in awgn_channel_test.c
CID 359663 NULL ptr dereference, in delay_channel_test.c
CID 369544 NULL ptr dereference, in chest_dl_nbiot.c
CID 373326 Resource Leak, in dft_fftw.c
CID 373329 Resource Leak, in dft_fftw.c
CID 372878 Division by zero, in sliv_test.c
CID 372871 Division by zero, in dmrs_pdcch.c
CID 370622 Negative loop bound, in csr_rs.c
CID 370624 Negative loop bound, in csr_rs.c
CID 370626 Negative loop bound, in csr_rs.c
CID's 369568, 369594 NULL ptr dereference, in ch_awgn.c
CID 369540 Logically dead code, in refsignal_dl.c
CID 369608 Logically dead code, in refsignal_ul.c
CIDs 366291, 366296, 366297 Out-of-bounds access, in zc_sequence.c
CID 372209 Division by zero, in cqi.c
CID 370992 Uninitialized pointer read, in pdcch_test.c
CID 373334 Integer overflow, in ue_sync.h
CID 370993, 370995 Undefined division, in pdcch_test.c
CID 370994 Undefined division, in ssb_decode_test.c
CIDs 353368 353364 353365 359673 353366 353367
Explicit null dereferenced, in psss_file_test.c
CID 371865 Unchecked return value, in rf_uhd_imp.cc
CID 363810 Undefined division, in ldpc_rm_chain_test.c
CID 372209, 372211, 372213, 372216 Undefined modulo, in cqi.c
CID 339834 Array compared against 0, in chest_dl.c
CID 369589 Out of bounds access, in dmrs_pucch.c
CID 371681 Out of bounds access, in ue_sync_nr_test.c
CIDs 370761, 370825 Copy-paste error, in ssb.c
CID 369599 out of bounds read, in dmrs_pdcch_test.c
CID 363795 out of bounds read, in ldpc_dec_c_avx2_flood.c
CID 363805 out of bounds read, in ldpc_dec_c_avx2long_flood.c
CID 363821 out of bounds read, in ldpc_dec_c_flood.c
2021-10-26 19:59:45 +02:00
faluco dc31fb05a3 Fix ODR issue detected by ASAN in arch for the srsran_verbose global variable. 2021-10-26 16:56:11 +02:00
faluco fa8e8ddf1f Fix an ODR issue detected by ASAN in arch, where the global variable handler_registered was defined multiple times. 2021-10-26 16:56:11 +02:00
yagoda 5d6b48311e fixing a few regression bugs in embms 2021-10-26 15:35:18 +02:00
Andre Puschmann 497e183487 rf_zmq_imp: disable Tx baseband scaling
until the correct gain settings are documented and potential
mis-configuration are handled. It seems that the default
Tx/rx gains values are not working with this function.
2021-10-26 14:56:44 +02:00
Andre Puschmann e2d26b5a8c rlc_um_nr: log PDU without SN if full SDU is transmitted
PDUs that contain full SDUs don't have SNs, so the log should be
without it
2021-10-26 13:32:48 +02:00
Andre Puschmann 3eb1862ab9 gnb_interface: reduce MAX_GRANTS to 4
see #3530 for detailed discussion. This change saves some CPU cycles it seems
2021-10-25 21:52:03 +02:00
Fabian Eckermann 32a1646536
nr,gnb,rrc: Derive RRC parameters from config.
* Derive RRC parameters from config.
* nr,gnb,rrc: hard code prach config index to 8 to avoid expiring RA proc window.
2021-10-25 20:54:32 +02:00
faluco 5ff6b2eaa9 Fix data race in ZMQ where nsamples and running variables could be read concurrently. 2021-10-25 20:30:57 +02:00
Xavier Arteaga 322f57a952
Initial real-time Tx gain setting (#2976)
* Make filename const in filesink

* Sine generation returns the next phase

* Avoid malloc/free in radio class

* Implement Tx gain in ZMQ

* Initial ratio RT gain test

* UHD: use timed Tx gain commands to align changes to subframes

* Minor improvement in test_radio_rt_gain

* Fix compilation

* Check RF gain thread id before joining

* Remove redundant zero initialization.

Co-authored-by: Fabian Eckermann <fabian@srs.io>
2021-10-25 10:54:17 +02:00
Xavier Arteaga ebab12403f
Asynchronous NR PHY configuration (#3527)
* Fix a race condition when accessing the NR PHY cfg by the RRC and phy workers.
Rework how the phy cfg is handled, now workers have their own copy that gets updated after a reconfig moving it out of the state class.

* Default initialize sf_len member in sf_worker for consistency.

* Asynchronous NR PHY configuration

* Fix compilation

* Corrected method override and fix unitialised value

* Added carrier equal comparison to avoid aligment byte padding comparison

Co-authored-by: faluco <borja.ferrer@softwareradiosystems.com>
2021-10-25 10:51:02 +02:00
faluco 0ada9a01ec Whitelist TSAN issue in srsenb::mac::sr_detected. 2021-10-23 21:26:00 +02:00
faluco a1b2f3915d Whitelist lock order inversion tsan issue in srsenb::rlc::rb_is_um. 2021-10-23 21:26:00 +02:00
Andre Puschmann 8294724aad gnb_interface: reduce MAX_GRANTS to 4
this significantly reduces data copies when providing the PHY
with scheduler results.
2021-10-23 21:09:26 +02:00
Xavier Arteaga 95bf85b3d3 Reduced maximum number of CSI reports 2021-10-23 17:23:08 +02:00
Pedro Alvarez fbcffb84bd Check if RLC is suspended before transmiting PDCP SDU.
This was done to avoid integrity issues, when the UE's RRC erroneously sent
measurement reports while the re-establishment was already in progress.

As errously sending PDCP PDUs on DRBs can cause issues as well, this was
disabled too.
2021-10-22 17:27:32 +01:00