Maximilian Krüger
|
bd6ff44ced
|
add comments
|
2018-01-08 14:16:33 +01:00 |
|
Maximilian Krüger
|
21bb9a6adc
|
add docstring
|
2018-01-08 14:15:41 +01:00 |
|
Maximilian Krüger
|
e71c9c53c9
|
withdraw_relay.rs: improve docstring
|
2018-01-08 14:14:39 +01:00 |
|
Maximilian Krüger
|
3d76ce0309
|
withdraw_relay.rs: improve var name and comments
|
2018-01-08 14:12:55 +01:00 |
|
Maximilian Krüger
|
b8246bfe4b
|
deploy.rs: hardcode estimatedGasCostOfWithdraw for now
|
2018-01-08 14:10:33 +01:00 |
|
Maximilian Krüger
|
4b408fa023
|
add compiled contract .abi and .bin
|
2018-01-08 14:09:22 +01:00 |
|
Maximilian Krüger
|
5b98a06873
|
withdraw_relay.rs: add some docstrings
|
2018-01-08 11:43:55 +01:00 |
|
Maximilian Krüger
|
7c9e0bb268
|
bridge.sol: constant -> view
|
2018-01-08 11:42:48 +01:00 |
|
Maximilian Krüger
|
cff04ba033
|
bridge.sol: messageValueSufficientToCoverRelay -> isMessageValueSufficientToCoverRelay
|
2018-01-08 11:42:33 +01:00 |
|
Maximilian Krüger
|
def974e0e3
|
WithdrawRelayState::Fetch -> WithdrawRelayState::FetchMessagesSignatures
|
2018-01-08 11:18:26 +01:00 |
|
Maximilian Krüger
|
1ca0439057
|
bridge.sol: reuse functions to reduce logic duplication
|
2018-01-05 16:31:46 +01:00 |
|
Maximilian Krüger
|
ea9f25003a
|
bridge.sol: add HomeBridge.messageValueSufficientToCoverRelay()
|
2018-01-05 16:31:23 +01:00 |
|
Maximilian Krüger
|
c7fcfe76f0
|
bridge.sol: add HomeBridge.getWithdrawRelayCost()
|
2018-01-05 16:31:07 +01:00 |
|
Maximilian Krüger
|
5b8f6d7bfd
|
bridge.sol: extract functions that read values from message so they can be tested/reused
and withdraw stays more focused
|
2018-01-05 16:05:13 +01:00 |
|
Maximilian Krüger
|
d66f51839c
|
add test: should revert withdraw if value <= estimatedWeiCostOfWithdraw
|
2018-01-05 15:12:06 +01:00 |
|
Maximilian Krüger
|
3fccc2ad7f
|
tests: add comment explaining gas price
|
2018-01-05 15:01:20 +01:00 |
|
Maximilian Krüger
|
5bfa568833
|
tests: remove console.log statements for debugging on travis
|
2018-01-05 15:00:59 +01:00 |
|
Maximilian Krüger
|
4ebe2a8e54
|
fix travis: remove assertion which fails during coverage testing
since coverage testing inserts instructions which increase the gas cost
|
2018-01-05 14:27:47 +01:00 |
|
Maximilian Krüger
|
44d559c043
|
fix new solium rule security/no-assign-params
|
2018-01-05 14:07:20 +01:00 |
|
Maximilian Krüger
|
0b12c2cc98
|
truffle: bump everything to newest version
|
2018-01-05 14:04:20 +01:00 |
|
Maximilian Krüger
|
49981435fb
|
travis fix: fetch gas price dynamically
|
2018-01-05 13:51:25 +01:00 |
|
Maximilian Krüger
|
b2bf3b6dfe
|
use long argument when setting port on ganache-cli
|
2018-01-05 13:39:07 +01:00 |
|
Maximilian Krüger
|
a900fcffd4
|
fix travis: explicitely setting gas price to lower value
|
2018-01-05 13:19:49 +01:00 |
|
Maximilian Krüger
|
6a64f4c6dc
|
trying more things to debug why tests only fail on travis
|
2018-01-05 13:11:50 +01:00 |
|
Maximilian Krüger
|
609c8065a4
|
debugging test which only fails on travis
|
2018-01-04 19:05:40 +01:00 |
|
Maximilian Krüger
|
434b845319
|
force truffle gasPrice to make it consistent since it seems different on travis
|
2018-01-04 19:00:36 +01:00 |
|
Maximilian Krüger
|
a28fa13f87
|
add test that recipient pays for relay
|
2018-01-04 18:49:54 +01:00 |
|
Maximilian Krüger
|
4834e25e97
|
tests: helpers: add getBalances helper
|
2018-01-04 18:49:32 +01:00 |
|
Maximilian Krüger
|
03aacc8f16
|
truffle tests: use camelcase consistently for variable names
|
2018-01-04 18:17:14 +01:00 |
|
Maximilian Krüger
|
a7910aa5cd
|
change ganache port to 8547 so it doesn't clash with vanilla parity rpc port
|
2018-01-04 17:38:47 +01:00 |
|
Maximilian Krüger
|
ee49dc5c3b
|
tools/estimate_gas_costs.sh: improve wording
|
2018-01-04 16:27:49 +01:00 |
|
Maximilian Krüger
|
109c8e35b3
|
add tools/estimate_gas_costs.sh
|
2018-01-04 16:26:05 +01:00 |
|
Maximilian Krüger
|
178b2de87b
|
bridge.sol: charge recipient for withdraw relay cost and ignore too low values
|
2018-01-04 15:42:36 +01:00 |
|
Maximilian Krüger
|
f86400a810
|
bridge.sol: pragma solidity ^0.4.17;
|
2018-01-04 15:42:21 +01:00 |
|
Maximilian Krüger
|
cce5b09fac
|
bridge.sol: fix setting of estimatedGasCostOfWithdraw in constructor
|
2018-01-04 15:30:10 +01:00 |
|
Maximilian Krüger
|
cd5a3e5889
|
bridge.sol: fix solium errors
|
2018-01-04 15:29:54 +01:00 |
|
Maximilian Krüger
|
66bc676891
|
make tests pass again after introducing `estimatedGasCostOfWithdraw`
|
2018-01-04 15:15:32 +01:00 |
|
Maximilian Krüger
|
6a859f004f
|
bridge.sol: improve linebreak of comment
|
2018-01-04 15:15:02 +01:00 |
|
Maximilian Krüger
|
ada27d9819
|
bridge.sol: introduce storage var estimatedGasCostOfWithdraw
|
2018-01-04 15:14:34 +01:00 |
|
Maximilian Krüger
|
0df75a5ae2
|
bridge.sol: add to comment
|
2018-01-04 14:14:29 +01:00 |
|
Maximilian Krüger
|
21390fa2f2
|
bridge.sol: consistency: make ForeignBridge constructor more readable
|
2018-01-04 14:12:03 +01:00 |
|
Maximilian Krüger
|
ba04292c02
|
bridge.sol: make HomeBridge constructor more readable
|
2018-01-04 13:59:02 +01:00 |
|
Maximilian Krüger
|
e38967fd94
|
readme: update test instructions
|
2018-01-04 13:56:09 +01:00 |
|
snd
|
7e6d443fba
|
Merge pull request #71 from paritytech/issue-59-solium
[pleasereview] introduce solium and solve all linter/compiler errors/warnings (#59)
|
2017-12-18 16:15:34 +01:00 |
|
Maximilian Krüger
|
6cec01f8f0
|
bridge.sol: mark pure functions as pure to get to 0 solc compiliation warnings
|
2017-12-15 11:25:53 +01:00 |
|
Maximilian Krüger
|
31a17f2644
|
add .soliumignore: without it solium complains
|
2017-12-15 11:01:44 +01:00 |
|
Maximilian Krüger
|
d090b1d403
|
add .soliumrc.json. without it solium exits
|
2017-12-15 11:01:15 +01:00 |
|
Maximilian Krüger
|
b270bb240b
|
run solium on CI
|
2017-12-14 18:34:34 +01:00 |
|
Maximilian Krüger
|
71571b895d
|
update yarn.lock
|
2017-12-14 18:33:31 +01:00 |
|
Maximilian Krüger
|
f1e3dc05ea
|
package.json: add solium
|
2017-12-14 18:33:16 +01:00 |