Commit Graph

375 Commits

Author SHA1 Message Date
Maximilian Krüger 4c63d4469e test/home: reduce homeGasPrice everywhere to keep coverage test from failing 2018-02-12 17:55:07 +01:00
Maximilian Krüger 71fed91200 test/home: trying lower gas price in to not fail when computing coverage 2018-02-12 17:39:56 +01:00
Maximilian Krüger e667321760 truffle tests fail on travis only :/ trying something 2018-02-12 17:17:05 +01:00
Maximilian Krüger a3740a5672 test/foreign: add missing variable homeGasPrice 2018-02-12 16:39:59 +01:00
Maximilian Krüger 5b446b48a3 remove `use` of symbols that no longer exist 2018-02-12 16:35:36 +01:00
Maximilian Krüger 3cc6b29438 tests/tests/withdraw_confirm.rs: refactor: replace opaque data strings by something easily modifiable (json, ethabi use) 2018-02-12 16:15:19 +01:00
Maximilian Krüger 8ab895664a integration-tests: set home_gas_price to 0 to make it pass for now 2018-02-12 15:35:06 +01:00
Maximilian Krüger c887668eda remove tests for withdraw confirm payloads
- they test against raw hex strings
  - hard to modify
  - if we me it easier to modify by using ethabi to assemble data
    the tests essentially become useless
- logic should already be covered by both integration test and RPC tests
2018-02-12 15:24:23 +01:00
Maximilian Krüger 4a3b4ba1f0 remove test for function that doesn't exist anymore 2018-02-12 15:23:41 +01:00
Maximilian Krüger d7928c22cc tests/tests/withdraw_relay.rs: refactor: replace opaque data strings by something easily modifiable (json, ethabi use) 2018-02-12 15:09:38 +01:00
Maximilian Krüger be18c96d31 remove conversion (web3 -> ethabi) that is no longer needed (ethereum-types) 2018-02-12 14:58:14 +01:00
Maximilian Krüger 87c57c9963 extract code dealing with signatures into module 2018-02-12 14:57:57 +01:00
Maximilian Krüger b28944511c message_to_mainnet.rs: fix from_bytes (respect little endian) 2018-02-12 14:55:02 +01:00
Maximilian Krüger ed060ae85b message_to_mainnet.rs: remove to_hex, add to_payload 2018-02-12 14:54:46 +01:00
Maximilian Krüger 78c6cf4472 bridge/src/helpers.rs: no longer needed 2018-02-12 14:51:16 +01:00
Maximilian Krüger 465e2d88e8 update Cargo.lock 2018-02-12 14:51:02 +01:00
Maximilian Krüger 999a4a7a7e use ethereum_types 0.2 everywhere 2018-02-12 14:50:44 +01:00
Maximilian Krüger 42993089f5 adapt to ethabi version bump 2018-02-12 10:11:39 +01:00
Maximilian Krüger 9df576739b tests/Cargo.toml: add more required deps 2018-02-09 09:44:55 +01:00
Maximilian Krüger b3760ec322 tests/src/lib.rs: change order of assertions to see most meaningful failure first 2018-02-09 09:44:55 +01:00
Maximilian Krüger e3bbe9eda3 truffle test for message: should extract homeGasPrice 2018-02-09 09:44:55 +01:00
Maximilian Krüger 88a117a5ba fix test helpers.createMessage: allow setting of homeGasPrice 2018-02-09 09:44:55 +01:00
Maximilian Krüger 467c5dc2f2 remove contract code that dealt with removed ignoring of insufficient value withdraws 2018-02-09 09:44:55 +01:00
Maximilian Krüger 5000043930 extract code dealing with Withdraw message
remove ignoring of messages with insufficient value
because no longer needed.

use user specified gas price on withdraw.
2018-02-09 09:44:55 +01:00
Maximilian Krüger 793029974d tests/tests/log_stream.rs: &str -> json! 2018-02-09 09:41:46 +01:00
Maximilian Krüger b16644578f tests/tests/deposit_relay.rs: &str -> json! 2018-02-09 09:41:46 +01:00
Maximilian Krüger ef2a4bca42 make rpc stream tests more readable/modifiable by using json! instead of strings 2018-02-09 09:41:46 +01:00
Maximilian Krüger c0d87f19c0 magic numbers -> constants 2018-02-09 09:41:46 +01:00
Maximilian Krüger f2e29764c2 make existing truffle tests run again after 112 2018-02-09 09:41:46 +01:00
Maximilian Krüger 8f1f8cae3e adapt integration tests to #112 2018-02-09 09:41:46 +01:00
Maximilian Krüger 41543ca40e user explicitely specifies homeGasPrice on withdraw. resolves #112 2018-02-09 09:41:45 +01:00
Maximilian Krüger 36c0859d78 bridge.sol: move withdraw sig verify from modifier into function
more explicit, easier to test in isolation
2018-02-09 09:39:08 +01:00
Maximilian Krüger f7587409f9 bridge.sol: improve param names 2018-02-09 09:39:08 +01:00
Maximilian Krüger c7ef6bfd65 bridge.sol: improve docstring of withdraw 2018-02-09 09:39:08 +01:00
snd 68c9949804
Merge pull request #115 from paritytech/bump_ethabi
bump ethabi and ethereum-types to latest versions
2018-02-08 08:39:40 +01:00
debris 0a02e461b9 bump dependencies 2018-02-07 17:23:49 +01:00
debris f0dcb70cf3 remove redundant conversions between types 2018-02-07 14:58:50 +01:00
debris 5e90f850fd updated web3 to latest version and resolved build issues 2018-02-07 14:50:49 +01:00
debris cc2c3fea9b bump ethabi and ethereum-types to latest versions 2018-02-06 22:57:06 +01:00
Björn Wagner 88a17e3d71
Update README.md 2018-01-31 17:18:44 +01:00
snd 232e437f86
Merge pull request #110 from GriffGreen/patch-1
Fixed some typos and made a section more coherent
2018-01-30 17:34:39 +01:00
snd 93ecddb401
Merge pull request #108 from gitter-badger/gitter-badge
Add a Gitter chat badge to README.md
2018-01-30 17:33:37 +01:00
Griff Green 90068a8ae4
Fixed some typos and made a section more coherent 2018-01-30 20:45:32 +07:00
Björn Wagner 2acd8b0697
Update README.md 2018-01-30 13:29:41 +01:00
The Gitter Badger dc999eaa9a Add Gitter badge 2018-01-30 11:36:22 +00:00
snd 16ced48292
Merge pull request #86 from paritytech/snd-issue85-erc20
#85 (ERC20 for ForeignBridge) and more
2018-01-29 11:58:57 +01:00
Maximilian Krüger d94e5cb322 README.md: wording 2018-01-29 09:28:07 +01:00
Maximilian Krüger 6dc9ec827c README.md: update build and run instructions 2018-01-26 13:47:53 +01:00
Maximilian Krüger ddc54802dd bridge.sol: check for overflow in transferFrom 2018-01-26 12:05:37 +01:00
Maximilian Krüger 1daa7bb6ad README.md: wording 2018-01-26 10:01:44 +01:00