Alexander Kolotov
|
ee633d18a2
|
rolled back a workaround from HomeBridge contract after removing little-endian encoding for integers in withdraw_confirm's message
|
2018-02-25 00:24:00 +03:00 |
Alexander Kolotov
|
57bce4579a
|
fixes #23
|
2018-02-25 00:21:23 +03:00 |
Alexander Kolotov
|
2f2af35440
|
fixed missed semicolon
|
2018-02-24 07:34:45 +03:00 |
Alexander Kolotov
|
5e1b7f43f7
|
example of ERC20 token to work with current version of ForeignBridge contract
|
2018-02-23 04:26:48 +03:00 |
Alexander Kolotov
|
0714eb70c8
|
quick and dirty fix to allow performing withdraw. A separate issue will be created
|
2018-02-23 04:25:45 +03:00 |
Alexander Kolotov
|
ca64cf3b6a
|
merge from master branch
|
2018-02-16 02:13:46 +03:00 |
snd
|
396198781d
|
Merge pull request #114 from paritytech/snd-issue-112
fix #112 - users were able to burn value during withdraw
|
2018-02-15 14:48:00 +01:00 |
Maximilian Krüger
|
586afe8773
|
bridge.sol: uint -> uint256: more explicit, clear.
seen in many other solidity projects with high code quality
|
2018-02-15 14:27:07 +01:00 |
Maximilian Krüger
|
033a923432
|
make ForeignBridge.submitSignature a bit easier to understand
|
2018-02-15 14:22:20 +01:00 |
Maximilian Krüger
|
9753db7326
|
cli/Cargo.toml: bump `env_logger` to `0.4`
|
2018-02-15 13:13:59 +01:00 |
Maximilian Krüger
|
0246119518
|
remove panics. improve error handling for signature.
resolves grumble:
https://github.com/paritytech/parity-bridge/pull/114#discussion_r168406741
|
2018-02-15 12:49:12 +01:00 |
Maximilian Krüger
|
4226a045cd
|
README.md: add missing word
|
2018-02-15 12:07:36 +01:00 |
Maximilian Krüger
|
763e065b67
|
update readme
|
2018-02-15 11:49:47 +01:00 |
Maximilian Krüger
|
f437a2f2de
|
README.md: mention homeGasPrice
|
2018-02-15 11:38:57 +01:00 |
Maximilian Krüger
|
6f13eb4b05
|
shorten error handling
resolve grumble:
https://github.com/paritytech/parity-bridge/pull/114#discussion_r168433291
|
2018-02-15 11:33:59 +01:00 |
Maximilian Krüger
|
ca7f758587
|
remove unnecessary `.clone()`
resolves grumble:
https://github.com/paritytech/parity-bridge/pull/114#discussion_r168406837
|
2018-02-15 11:18:26 +01:00 |
Maximilian Krüger
|
189d5b2331
|
remove redundant conversions
resolves grumbles:
https://github.com/paritytech/parity-bridge/pull/114#discussion_r168407959
https://github.com/paritytech/parity-bridge/pull/114#discussion_r168408026
|
2018-02-15 11:17:42 +01:00 |
Maximilian Krüger
|
55192e9830
|
proper error handling instead of expect
|
2018-02-14 12:13:49 +01:00 |
Maximilian Krüger
|
53e02f4430
|
add docstrings
|
2018-02-14 12:13:40 +01:00 |
Maximilian Krüger
|
107141e0b7
|
remove unused imports
|
2018-02-14 12:13:11 +01:00 |
Maximilian Krüger
|
d7feac802f
|
verifySignatures -> hasEnoughValidSignatures and make it return bool
|
2018-02-13 17:18:24 +01:00 |
Maximilian Krüger
|
59d354bde0
|
test: withdraw should succeed if gas price != requested gas price but sender is receiver
|
2018-02-13 16:51:24 +01:00 |
Maximilian Krüger
|
845ab3359c
|
fix syntax error
|
2018-02-13 16:38:28 +01:00 |
Maximilian Krüger
|
22e9b5d695
|
add test that fails when gas price != requested gas price
|
2018-02-13 16:13:58 +01:00 |
Maximilian Krüger
|
0de0384509
|
fix test that submitting signature with too short msg fails
|
2018-02-13 16:09:57 +01:00 |
Maximilian Krüger
|
50e63db3cd
|
improve truffle tests for ForeignBridge.transferToHome
|
2018-02-13 15:48:10 +01:00 |
Maximilian Krüger
|
85a2e10fcb
|
remove redundance require. signatures of wrong length don't pass the address recovery above
|
2018-02-13 15:47:17 +01:00 |
Maximilian Krüger
|
4e56c9ec65
|
require value to be greater estimated wei cost for relay
|
2018-02-13 15:46:51 +01:00 |
Maximilian Krüger
|
61bb0b3ffa
|
fix truffle tests that failed because of wrong number of args
|
2018-02-13 15:11:24 +01:00 |
Maximilian Krüger
|
52652cb9fc
|
add truffle test: should fail to transfer more than balance home
|
2018-02-13 14:44:55 +01:00 |
Maximilian Krüger
|
2165513fdd
|
tests for Helpers.verifySignatures
|
2018-02-13 14:26:11 +01:00 |
Maximilian Krüger
|
c97785862b
|
remove unused function param
|
2018-02-13 14:25:54 +01:00 |
Maximilian Krüger
|
bd20896deb
|
use `accounts` in more truffle tests
|
2018-02-13 14:25:43 +01:00 |
Maximilian Krüger
|
76c85e6f84
|
bridge.sol: add HelpersTest.verifySignatures
|
2018-02-13 14:25:11 +01:00 |
Maximilian Krüger
|
a1dc3bcb05
|
bridge.sol: improve docstring for verifySignatures
|
2018-02-13 14:25:00 +01:00 |
Maximilian Krüger
|
edd691672a
|
fix broken truffle tests that passed because error handling was broken
|
2018-02-13 11:01:05 +01:00 |
Maximilian Krüger
|
ff9f7bb7f6
|
fix error handling in truffle tests
only catch/ignore such errors that we want to happen.
propagate all other errors correctly and don't ignore them.
|
2018-02-13 11:00:09 +01:00 |
Maximilian Krüger
|
49c7a11fdf
|
tests: fix indentation
|
2018-02-13 10:57:07 +01:00 |
Maximilian Krüger
|
d9090d9cde
|
add ignoreExpectedError to test helpers
|
2018-02-13 10:29:21 +01:00 |
Maximilian Krüger
|
d42f4b9590
|
Cargo.lock: use newest cargo which doesn't add `root`
addresses https://github.com/paritytech/parity-bridge/pull/114#discussion_r167784460
|
2018-02-13 09:23:48 +01:00 |
Maximilian Krüger
|
12eea5053f
|
quickcheck test that MessageToMainnet roundtrips from/to bytes and payload
|
2018-02-12 19:32:09 +01:00 |
Maximilian Krüger
|
1de9a53d1e
|
slightly simplify test for signature roundtrips
|
2018-02-12 19:31:46 +01:00 |
Maximilian Krüger
|
dfb7fef654
|
bridge/src/signature.rs: 100% test coverage with quickcheck
|
2018-02-12 19:14:57 +01:00 |
Maximilian Krüger
|
4c63d4469e
|
test/home: reduce homeGasPrice everywhere to keep coverage test from failing
|
2018-02-12 17:55:07 +01:00 |
Maximilian Krüger
|
71fed91200
|
test/home: trying lower gas price in to not fail when computing coverage
|
2018-02-12 17:39:56 +01:00 |
Maximilian Krüger
|
e667321760
|
truffle tests fail on travis only :/ trying something
|
2018-02-12 17:17:05 +01:00 |
Maximilian Krüger
|
a3740a5672
|
test/foreign: add missing variable homeGasPrice
|
2018-02-12 16:39:59 +01:00 |
Maximilian Krüger
|
5b446b48a3
|
remove `use` of symbols that no longer exist
|
2018-02-12 16:35:36 +01:00 |
Maximilian Krüger
|
3cc6b29438
|
tests/tests/withdraw_confirm.rs: refactor: replace opaque data strings by something easily modifiable (json, ethabi use)
|
2018-02-12 16:15:19 +01:00 |
Maximilian Krüger
|
8ab895664a
|
integration-tests: set home_gas_price to 0 to make it pass for now
|
2018-02-12 15:35:06 +01:00 |