236115917d
Merge pull request #290 from zcash/v1-layouter
...
V1 layouter
2021-06-12 18:14:54 +01:00
eae5049ba2
Merge pull request #291 from zcash/circuitlayout-builder
...
dev: CircuitLayout builder
2021-06-11 23:50:08 +01:00
d04b532368
Merge pull request #292 from zcash/expression-square
...
plonk::circuit.rs: Add Expression::square() method.
2021-06-12 06:49:36 +08:00
c907ca5410
plonk::circuit.rs: Add Expression::square() method.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-06-11 12:31:27 +08:00
faac7b798b
dev: Render Selectors in a darker shade of blue
...
The regions are now rendered uniformly the same colour, by removing the
background bleed-through (which was more complex now that the fixed
columns are rendered in two colours).
2021-06-10 00:06:20 +01:00
49e18b2647
dev: Render labels last (so they are always the top layer)
2021-06-10 00:05:49 +01:00
53c43e85b2
Fix clippy lints
2021-06-08 12:40:16 +01:00
d4984ebf53
dev: Enable CircuitLayout labels to be hidden
2021-06-08 12:26:37 +01:00
52be437509
dev: Add CircuitLayout viewport controls
2021-06-08 12:26:37 +01:00
3e82c7b232
dev: Move halo2::dev::circuit_layout to halo2::dev::CircuitLayout::render
...
This makes it easier to add configuration to the renderer.
2021-06-08 12:13:18 +01:00
7cca91331b
Implement improved strategy for the V1 layouter
...
This layouter improves on the single-pass strategy in two ways:
- Regions are layed out with a "first fit" strategy (using the algorithm
described in https://github.com/zcash/halo2/issues/93 ) instead of a
"last fit" strategy. This enables gaps in the circuit to be filled.
- Regions are sorted by their "advice area" (columns * rows), and are
then layed out biggest-first. This takes advantage of the regularity
of circuits, and that the advice columns have the most contention. It
also leads to larger gaps between early layed-out regions that are more
easily filled by subsequent smaller regions.
2021-06-08 11:35:41 +01:00
a94d4a9c01
Implement V1 layouter
...
The V1 layouter is a dual-pass layouter, that has visibility into the
entire `Circuit::synthesize` step.
This first commit implements the same strategy as `SingleChipLayouter`,
behaving as if it were a single-pass layouter.
2021-06-07 15:13:41 +01:00
b00a0df392
Move SingleChipLayouter into a submodule
...
It is a single-pass layouter, but we won't rename it for now.
2021-06-07 14:52:25 +01:00
d8e4f24df4
Merge pull request #287 from zcash/remove-selector-rotations
...
Remove rotations from Selectors
2021-06-05 23:36:37 +01:00
879509491f
Merge pull request #286 from zcash/constraint-annotations
...
Enable annotating individual constraints within gates
2021-06-05 23:36:28 +01:00
53ac47fcec
Merge pull request #289 from zcash/ci-book-fix
...
CI: Build book with latest mdbook
2021-06-05 11:38:02 +01:00
1dff93a8ad
dev: Update documentation for constraint_name
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-06-04 23:12:55 +01:00
5bf9390d23
Merge pull request #285 from zcash/dev-gate-constraints
...
dev: MockProver fixes and improvements
2021-06-04 23:11:49 +01:00
a388726ce9
CI: Build book with latest mdbook
...
`mdbook-katex` is installed from crates.io, and if it doesn't use the
same version of `mdbook` it can cause build issues.
2021-06-04 22:41:25 +01:00
0d8b3bab38
Remove rotations from Selectors
...
Enabling selectors to be used in gates at non-zero rotations leads to
confusing gates, and inhibits our ability to create visualizations of
circuits. In most cases, a gate can be rearranged so that the selectors
have no rotation; in cases where cross-gate selector optimisations are
required, these can still be implemented using fixed columns.
2021-06-04 16:18:51 +01:00
483c872cbe
dev: Clarify gate name documentation
2021-06-04 15:18:52 +01:00
876587c818
Panic in ConstraintSystem::create_gate if it would contain no constraints
...
We use iterators to allow a gate to contain more than one constraint, but
it is a programming error for a gate to not contain any constraints.
2021-06-04 12:59:57 +01:00
6cf73391e8
Enable annotating individual constraints within gates
...
The closure passed to `ConstraintSystem::create_gate` can now return:
- Tuples of `(&'static str, Expression<F>)`
- Anything implementing `IntoIterator` (e.g. `Some(Expression<F>)`)
2021-06-04 03:49:21 +01:00
ff2a500e9a
dev: impl fmt::Display for VerifyFailure
2021-06-04 03:46:08 +01:00
47061ade3d
dev: Report indices of unsatisfied constraints
...
Now that gates may contain multiple constraints, we need to inform
developers about which specific constraints are failing within gates.
2021-06-04 03:46:08 +01:00
e01fb15018
dev: Fix bug in cell assignment checker
...
The simple example was broken because it uses an instance column in a
gate. MockProver now assumes all instance cells are assigned to, since
this happens outside the circuit and outside its purview.
2021-06-04 02:56:35 +01:00
32cdcfa66f
Merge pull request #284 from zcash/doc-batch-invert-zero
...
Document that batch inversion in arithmetic.rs leaves zero as zero
2021-06-04 01:15:50 +01:00
e426fddd5e
Update arithmetic.rs
2021-06-04 00:17:05 +01:00
3ff44d31a8
Merge pull request #283 from zcash/pasta-curves-0.1
...
`pasta_curves 0.1`
2021-06-01 17:18:09 -06:00
c86b24f496
pasta_curves 0.1
2021-06-02 00:03:50 +01:00
8b94e3ad64
Bump MSRV to 1.51.0
2021-06-02 00:03:06 +01:00
0448584333
Merge pull request #278 from zcash/144-proof-encoding
...
book: Document encoding of proofs
2021-06-01 17:26:47 +01:00
7379e96a70
book: Use M for number-of-circuit-instances in proof encoding
2021-06-01 17:26:00 +01:00
256055c656
Merge pull request #279 from zcash/derive-eq
...
plonk::circuit : Derive Eq for Permutation
2021-06-01 17:20:05 +01:00
684efbd6c1
plonk::circuit : Derive Eq for Permutation
2021-06-01 17:19:06 +01:00
aac310c763
Merge pull request #274 from zcash/dev-check-cells-for-active-gates
...
MockProver: Check that cells for active gates are assigned to
2021-06-01 17:15:12 +01:00
ea3d59756b
Merge pull request #273 from zcash/multiple-polys-per-gate
...
Allow multiple polynomial constraints per gate
2021-06-01 17:14:53 +01:00
845bf724ff
Merge pull request #272 from zcash/configure-api-changes
...
`Circuit` API changes
2021-06-01 17:14:39 +01:00
9a7f331f1b
book: Document k constant in proof encodings
2021-06-01 14:05:33 +01:00
4b362669e4
book: Document encoding of proofs
...
Closes zcash/halo2#144 .
2021-05-28 02:21:58 +01:00
081e353681
book: Move implementation notes about proofs into a subsection
2021-05-28 01:13:20 +01:00
e4072e78ce
Merge pull request #234 from zcash/book-point-addition
...
[book] Point addition and compression background
2021-05-27 22:37:06 +01:00
36cd8633e2
book: Adjustments to point addition and compression sections
2021-05-27 18:43:24 +01:00
15c79bcd89
Merge pull request #260 from zcash/book-chip-refactor
...
[book] Remove core/chip abstraction
2021-05-27 18:23:25 +01:00
6dd3d1831b
MockProver: Check that cells for active gates are assigned to
2021-05-27 18:10:23 +01:00
78ca7d38ba
Merge pull request #276 from zcash/horners-rule
...
Use Horner's rule in `eval_polynomial()`
2021-05-27 10:53:35 -06:00
5fc0e2a449
Cargo fmt
2021-05-28 00:40:39 +08:00
ea1af2c9c8
Use Horner's rule in eval_polynomial()
2021-05-28 00:32:18 +08:00
32896917d0
Add a failing test showing an undetected missed assignment
2021-05-27 15:02:01 +01:00
0f0dd8a26c
Allow multiple polynomial constraints per gate
...
This enables a gate such as ECC complete addition to define its
constraints in terms of a common set of queried columns.
2021-05-27 15:01:46 +01:00
str4d
ying tong
Daira Hopwood
ebfull