Jack Grigg
7dae8698b6
MockProver: Poison unusable advice cells
...
Circuit developers need to use selectors (or equivalent) to prevent their
custom gates from being active on unusable rows. By marking the advice
cells in these rows as "poisoned" and tracking this through expressions,
we can provide a better error message to developers that indicates the
missing selector issue.
Closes zcash/halo2#329 .
2021-07-15 22:12:50 +01:00
ebfull
4a9e329ded
Merge pull request #316 from zcash/zk-changes-again
...
Final ZK changes
2021-07-14 16:19:06 -06:00
Sean Bowe
070beafa53
Address minor review comments.
2021-07-14 15:19:26 -06:00
Sean Bowe
1f75dc25ee
Make plonk_api test exercise multiple permutation sets.
2021-07-14 10:24:31 -06:00
Sean Bowe
0a3ae6f1eb
Add clarifying comment.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-14 10:17:44 -06:00
Sean Bowe
bbe06ac61e
Add clarifying comment.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-14 10:08:49 -06:00
Sean Bowe
af01af8fa5
Remove unnecessary collect.
2021-07-14 10:07:30 -06:00
Sean Bowe
11a1fc7d4a
Fix stale comment
2021-07-14 09:48:56 -06:00
Sean Bowe
ef01b9310a
Fix examples broken by verifier API changes.
2021-07-14 09:47:53 -06:00
Sean Bowe
99a0e675f1
Minor changes to comments.
2021-07-14 09:46:29 -06:00
Sean Bowe
b4bd4ada9a
Clarify barycentric weight doc comment.
2021-07-14 09:19:56 -06:00
ebfull
29fc0a781a
Simplify `l_i_range` using `rotate_omega`.
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-14 09:07:21 -06:00
ebfull
dfe716dbc1
Describe `l_i_range` implementation in doc comment
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-14 09:05:40 -06:00
Sean Bowe
74f3e1c6d9
Fix omitted notation to explicitly designate l_last and l_blind as polynomials.
2021-07-13 16:30:52 -06:00
Sean Bowe
4cd0bffc8e
Collapse random_{poly,blind} fields back into Committed in other structures.
2021-07-13 16:19:44 -06:00
Sean Bowe
8caafc0abf
Change n to u in sanity check.
2021-07-13 16:12:21 -06:00
Sean Bowe
dd41cfa022
fix clippy lint
2021-07-13 16:02:41 -06:00
Sean Bowe
d0950c6d4c
Add explanation of lookup table degree nuances.
2021-07-13 16:02:27 -06:00
Sean Bowe
0dc4447ad8
Change verification API to allow the caller to supply instances as slices of scalars rather than commitments.
2021-07-13 12:08:16 -06:00
Sean Bowe
f532b7e973
Return error if supplied instance slice is too large.
2021-07-13 11:44:58 -06:00
Sean Bowe
c05ceab04d
Switch 5 to 3 in benchmark.
2021-07-13 09:15:30 -06:00
Sean Bowe
9155cd174b
Introduce `set_minimum_degree` to avoid performance regression in benchmark.
2021-07-12 15:28:16 -06:00
Daira Hopwood
20c347b269
Merge pull request #320 from daira/book-zk-changes
...
[Book] Zero knowledge changes (and misc cleanups)
2021-07-12 20:35:20 +01:00
Daira Hopwood
103c93391d
Clarify the statement about the δ^i being distinct quadratic non-residues.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 17:24:21 +01:00
Daira Hopwood
8ac20608e4
Merge branch 'kw-halo-book' into book-zk-changes
...
Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:32:36 +01:00
Daira Hopwood
06ff90ba95
Rename UPA to PLONKish.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:12:58 +01:00
Daira Hopwood
0a39457780
Merge pull request #319 from zcash/book-fixes
...
Book fixes
2021-07-12 02:06:14 +01:00
Daira Hopwood
6a11c2b97e
Update the circuit commitments section for the changes to the permutation argument.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:03:41 +01:00
Daira Hopwood
1b3241d757
Clarify product argument and add a diagram.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:03:41 +01:00
Daira Hopwood
fedcc1960d
Permutation argument cosmetics.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
69ca38d2b1
Update permutation argument for zero knowledge changes in #316 .
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
25b42a531d
Follow https://github.com/zcash/halo2/pull/316 and https://github.com/zcash/orchard/issues/143
...
in using 1 - Z(X) instead of Z(X) - 1.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
0dbf7cf4af
Match the order of q_last and q_blind in the implementation.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
5deb3fcd72
Lookup argument cosmetics.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
55c48007c9
Update lookup argument for zero knowledge changes in #316 .
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Sean Bowe
d8df7a12d5
Fix clippy lint on beta.
2021-07-10 08:52:30 -06:00
Sean Bowe
cc84e9bf52
Additional documentation suggestions from @str4d.
2021-07-10 08:47:57 -06:00
Sean Bowe
50768bff20
Add comment explaining the extra caution in minimum_rows().
2021-07-10 08:43:01 -06:00
Sean Bowe
9023161988
Add bounds check to Assignment::query_instance impls.
2021-07-10 08:25:00 -06:00
Sean Bowe
c4e2554654
Incorporate documentation improvements suggested by @str4d.
2021-07-10 08:20:34 -06:00
Sean Bowe
3942d4e2e8
(examples) Specify row when calling expose_public in simple-example.
2021-07-10 08:13:24 -06:00
Sean Bowe
1be7bf1df0
Address review comments from @daira.
2021-07-10 08:12:08 -06:00
Sean Bowe
20653acc39
Document `permutation::Argument::required_degree`.
2021-07-10 07:52:42 -06:00
str4d
66e4b0ee7f
Merge pull request #321 from zcash/ci-book-rustdoc
...
book: Render latest rustdoc in book subdir
2021-07-09 20:20:14 +01:00
Jack Grigg
4eb464e49d
book: Render latest rustdoc in book subdir
2021-07-09 20:12:40 +01:00
Jack Grigg
5fe6323a8d
book: Add note about efficient FFTs for Pallas and Vesta
2021-07-09 19:53:41 +01:00
Sean Bowe
fc946d99bf
Use Option in sanity-check rather than a random value.
2021-07-09 12:47:36 -06:00
Sean Bowe
9e6277ef6b
Make `usable_rows` temporary to avoid duplicative code.
2021-07-09 12:45:51 -06:00
Sean Bowe
326cae153e
Fix minor typos in comments.
2021-07-09 12:44:27 -06:00
Sean Bowe
90be1c29ab
Fix bug in sanity check during lookup argument witness creation.
2021-07-09 12:41:52 -06:00